165812 2016-12-13 11:50:48 -0800 std::expected: fix rvalue forwarding issues 2016-12-13 14:28:28 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 163919 1 jfbastien jfbastien benjamin cdumez cmarcelo commit-queue dbates jfbastien oldest_to_newest 1259476 0 jfbastien 2016-12-13 11:50:48 -0800 I ran into a few forwarding issues while using std::expected in #163919. 1259477 1 297031 jfbastien 2016-12-13 11:52:43 -0800 Created attachment 297031 patch 1259481 2 297031 mark.lam 2016-12-13 11:59:52 -0800 Comment on attachment 297031 patch LGTM. 1259539 3 297031 commit-queue 2016-12-13 14:28:23 -0800 Comment on attachment 297031 patch Clearing flags on attachment: 297031 Committed r209778: <http://trac.webkit.org/changeset/209778> 1259540 4 commit-queue 2016-12-13 14:28:28 -0800 All reviewed patches have been landed. Closing bug. 297031 2016-12-13 11:52:43 -0800 2016-12-13 14:28:23 -0800 patch 0001-std-expected-forwarding.patch text/plain 3656 jfbastien RnJvbSA5NWI1OTZkZmQ5NTY2NmExNDM0ODM1YTVjMjVlYWZlNWRkYmIwNjZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBUdWUsIDEzIERlYyAyMDE2IDExOjUxOjA3IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gc3RkOjpl eHBlY3RlZCBmb3J3YXJkaW5nCgotLS0KIFNvdXJjZS9XVEYvQ2hhbmdlTG9nICAgICAgfCAxMiAr KysrKysrKysrKysKIFNvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmggfCAgOSArKysrKysrLS0KIDIg ZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDVh MzRmYTEuLjdmZDU0MjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMTItMTMgIEpGIEJhc3Rp ZW4gIDxqZmJhc3RpZW5AYXBwbGUuY29tPgorCisgICAgICAgIHN0ZDo6ZXhwZWN0ZWQ6IGZpeCBy dmFsdWUgZm9yd2FyZGluZyBpc3N1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2NTgxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogd3RmL0V4cGVjdGVkLmg6CisgICAgICAgIChXVEY6OlVuZXhwZWN0 ZWRUeXBlOjpVbmV4cGVjdGVkVHlwZSk6CisgICAgICAgIChXVEY6OkV4cGVjdGVkRGV0YWlsOjpC YXNlOjpCYXNlKToKKyAgICAgICAgKFdURjo6RXhwZWN0ZWQ6OkV4cGVjdGVkKToKKwogMjAxNi0x Mi0xMyAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIwOTcyNS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL0V4cGVjdGVkLmggYi9Tb3VyY2UvV1RGL3d0Zi9FeHBlY3RlZC5oCmluZGV4IDM0MmU2ODYu LmJjMDAzYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL0V4cGVjdGVkLmgKKysrIGIvU291 cmNlL1dURi93dGYvRXhwZWN0ZWQuaApAQCAtNDUsNyArNDUsNyBAQCBjbGFzcyBVbmV4cGVjdGVk VHlwZSB7CiBwdWJsaWM6CiAgICAgVW5leHBlY3RlZFR5cGUoKSA9IGRlbGV0ZTsKICAgICBjb25z dGV4cHIgZXhwbGljaXQgVW5leHBlY3RlZFR5cGUoY29uc3QgRSYgZSkgOiB2YWwoZSkgeyB9Ci0g ICAgY29uc3RleHByIGV4cGxpY2l0IFVuZXhwZWN0ZWRUeXBlKEUmJiBlKSA6IHZhbChXVEZNb3Zl KGUpKSB7IH0KKyAgICBjb25zdGV4cHIgZXhwbGljaXQgVW5leHBlY3RlZFR5cGUoRSYmIGUpIDog dmFsKHN0ZDo6Zm9yd2FyZDxFPihlKSkgeyB9CiAgICAgY29uc3RleHByIGNvbnN0IEUmIHZhbHVl KCkgY29uc3QgeyByZXR1cm4gdmFsOyB9CiAgICAgUkVMQVhFRF9DT05TVEVYUFIgRSYgdmFsdWUo KSB7IHJldHVybiB2YWw7IH0KIApAQCAtMTA0LDcgKzEwNCw5IEBAIHVuaW9uIFN0b3JhZ2Ugewog ICAgIGNvbnN0ZXhwciBTdG9yYWdlKFZhbHVlVGFnVHlwZSkgOiB2YWwoKSB7IH0KICAgICBjb25z dGV4cHIgU3RvcmFnZShFcnJvclRhZ1R5cGUpIDogZXJyKCkgeyB9CiAgICAgY29uc3RleHByIFN0 b3JhZ2UoVmFsdWVUYWdUeXBlLCBjb25zdCBWYWx1ZVR5cGUmIHZhbCkgOiB2YWwodmFsKSB7IH0K KyAgICBjb25zdGV4cHIgU3RvcmFnZShWYWx1ZVRhZ1R5cGUsIFZhbHVlVHlwZSYmIHZhbCkgOiB2 YWwoc3RkOjpmb3J3YXJkPFZhbHVlVHlwZT4odmFsKSkgeyB9CiAgICAgY29uc3RleHByIFN0b3Jh Z2UoRXJyb3JUYWdUeXBlLCBjb25zdCBFcnJvclR5cGUmIGVycikgOiBlcnIoZXJyKSB7IH0KKyAg ICBjb25zdGV4cHIgU3RvcmFnZShFcnJvclRhZ1R5cGUsIEVycm9yVHlwZSYmIGVycikgOiBlcnIo c3RkOjpmb3J3YXJkPEVycm9yVHlwZT4oZXJyKSkgeyB9CiAgICAgflN0b3JhZ2UoKSB7IH0KIH07 CiAKQEAgLTEzMSw2ICsxMzMsNyBAQCB1bmlvbiBTdG9yYWdlPHZvaWQsIEU+IHsKICAgICBjb25z dGV4cHIgU3RvcmFnZShWYWx1ZVRhZ1R5cGUpIDogZHVtbXkoKSB7IH0KICAgICBjb25zdGV4cHIg U3RvcmFnZShFcnJvclRhZ1R5cGUpIDogZXJyKCkgeyB9CiAgICAgY29uc3RleHByIFN0b3JhZ2Uo RXJyb3JUYWdUeXBlLCBjb25zdCBFcnJvclR5cGUmIGVycikgOiBlcnIoZXJyKSB7IH0KKyAgICBj b25zdGV4cHIgU3RvcmFnZShFcnJvclRhZ1R5cGUsIEVycm9yVHlwZSYmIGVycikgOiBlcnIoc3Rk Ojpmb3J3YXJkPEVycm9yVHlwZT4oZXJyKSkgeyB9CiAgICAgflN0b3JhZ2UoKSB7IH0KIH07CiAK QEAgLTE1OCw3ICsxNjEsOSBAQCBzdHJ1Y3QgQmFzZSB7CiAgICAgY29uc3RleHByIEJhc2UoVmFs dWVUYWdUeXBlIHRhZykgOiBzKHRhZyksIGhhcyh0cnVlKSB7IH0KICAgICBjb25zdGV4cHIgQmFz ZShFcnJvclRhZ1R5cGUgdGFnKSA6IHModGFnKSwgaGFzKGZhbHNlKSB7IH0KICAgICBjb25zdGV4 cHIgQmFzZShWYWx1ZVRhZ1R5cGUgdGFnLCBjb25zdCBWYWx1ZVR5cGUmIHZhbCkgOiBzKHRhZywg dmFsKSwgaGFzKHRydWUpIHsgfQorICAgIGNvbnN0ZXhwciBCYXNlKFZhbHVlVGFnVHlwZSB0YWcs IFZhbHVlVHlwZSYmIHZhbCkgOiBzKHRhZywgc3RkOjpmb3J3YXJkPFZhbHVlVHlwZT4odmFsKSks IGhhcyh0cnVlKSB7IH0KICAgICBjb25zdGV4cHIgQmFzZShFcnJvclRhZ1R5cGUgdGFnLCBjb25z dCBFcnJvclR5cGUmIGVycikgOiBzKHRhZywgZXJyKSwgaGFzKGZhbHNlKSB7IH0KKyAgICBjb25z dGV4cHIgQmFzZShFcnJvclRhZ1R5cGUgdGFnLCBFcnJvclR5cGUmJiBlcnIpIDogcyh0YWcsIHN0 ZDo6Zm9yd2FyZDxFcnJvclR5cGU+KGVycikpLCBoYXMoZmFsc2UpIHsgfQogICAgIEJhc2UoY29u c3QgQmFzZSYgbykKICAgICAgICAgOiBoYXMoby5oYXMpCiAgICAgewpAQCAtMjU0LDcgKzI1OSw3 IEBAIHB1YmxpYzoKICAgICBFeHBlY3RlZChjb25zdCBFeHBlY3RlZCYpID0gZGVmYXVsdDsKICAg ICBFeHBlY3RlZChFeHBlY3RlZCYmKSA9IGRlZmF1bHQ7CiAgICAgY29uc3RleHByIEV4cGVjdGVk KGNvbnN0IFZhbHVlVHlwZSYgZSkgOiBiYXNlKEV4cGVjdGVkRGV0YWlsOjpWYWx1ZVRhZywgZSkg eyB9Ci0gICAgY29uc3RleHByIEV4cGVjdGVkKFZhbHVlVHlwZSYmIGUpIDogYmFzZShFeHBlY3Rl ZERldGFpbDo6VmFsdWVUYWcsIFdURk1vdmUoZSkpIHsgfQorICAgIGNvbnN0ZXhwciBFeHBlY3Rl ZChWYWx1ZVR5cGUmJiBlKSA6IGJhc2UoRXhwZWN0ZWREZXRhaWw6OlZhbHVlVGFnLCBzdGQ6OmZv cndhcmQ8VmFsdWVUeXBlPihlKSkgeyB9CiAgICAgLy8gdGVtcGxhdGUgPGNsYXNzLi4uIEFyZ3M+ IGNvbnN0ZXhwciBleHBsaWNpdCBFeHBlY3RlZChpbl9wbGFjZV90LCBBcmdzJiYuLi4pOwogICAg IC8vIHRlbXBsYXRlIDxjbGFzcyBVLCBjbGFzcy4uLiBBcmdzPiBjb25zdGV4cHIgZXhwbGljaXQg RXhwZWN0ZWQoaW5fcGxhY2VfdCwgc3RkOjppbml0aWFsaXplcl9saXN0PFU+LCBBcmdzJiYuLi4p OwogICAgIGNvbnN0ZXhwciBFeHBlY3RlZChVbmV4cGVjdGVkVHlwZTxFcnJvclR5cGU+IGNvbnN0 JiB1KSA6IGJhc2UoRXhwZWN0ZWREZXRhaWw6OkVycm9yVGFnLCB1LnZhbHVlKCkpIHsgfQotLSAK Mi4xMC4xCgo=