165797 2016-12-13 08:09:47 -0800 REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs 2017-01-03 00:16:09 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned annulen bugs-noreply cgarcia mrobinson oldest_to_newest 1259398 0 mcatanzaro 2016-12-13 08:09:47 -0800 Source/WebKit is distributed in tarballs. In particular, there are a bunch of files under Source/WebKit/Storage. This isn't right, we shouldn't have Source/WebKit at all. 1263298 1 cgarcia 2017-01-02 06:32:43 -0800 I think I messed it up in r173753 by adding a new rulset in the middle of the directory source ruleset. I have to admit I don't completely understand the manifest format. The thing is that we have this: directory Source/WebInspectorUI/UserInterface/Images/gtk # Most of the files in Source/WebKit are not necessary to build GTK+ and # the directory includes lots of images, so we're a bit more picky here. exclude Source/WebKit/.* That directory rule is adding a new ruleset, it should added after all the exclude, because the default is to include. 1263299 2 297896 cgarcia 2017-01-02 06:39:53 -0800 Created attachment 297896 Patch 1263407 3 cgarcia 2017-01-03 00:16:09 -0800 Committed r210233: <http://trac.webkit.org/changeset/210233> 297896 2017-01-02 06:39:53 -0800 2017-01-02 08:10:33 -0800 Patch wk-no-webkit-dist.diff text/plain 2012 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiZjgy NDc3OWQ4YS4uZDU1NmE3MGUzM2YgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxNy0wMS0wMiAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTcz NzUzKTogW0dUS10gU291cmNlL1dlYktpdCBpcyBkaXN0cmlidXRlZCBpbiB0YXJiYWxscworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1Nzk3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSBkaXJlY3Rv cnkgcnVsZXNldCBhZnRlciBhbGwgZXhjbHVkZSBydWxlcyBvZiBTb3VyY2UgcnVsc2V0LgorCisg ICAgICAgICogZ3RrL21hbmlmZXN0LnR4dC5pbjoKKwogMjAxNy0wMS0wMiAgQ2hyaXMgRmxlaXph Y2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBFeHBvc2UgYmxvY2sgcXVv dGUgbGV2ZWwgdG8gaU9TIEFQSQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL21hbmlmZXN0LnR4dC5p biBiL1Rvb2xzL2d0ay9tYW5pZmVzdC50eHQuaW4KaW5kZXggYzQ1YTliZWFiNDQuLmIwNDRlOTM2 NjIwIDEwMDY0NAotLS0gYS9Ub29scy9ndGsvbWFuaWZlc3QudHh0LmluCisrKyBiL1Rvb2xzL2d0 ay9tYW5pZmVzdC50eHQuaW4KQEAgLTUxLDYgKzUxLDcgQEAgZXhjbHVkZSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9hdWRpby9yZXNvdXJjZXMKIGV4Y2x1ZGUgU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy90ZXN0CiBleGNsdWRlIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9EZWZh dWx0VGhlbWUKIGV4Y2x1ZGUgU291cmNlL1dlYkNvcmUvUmVzb3VyY2VzCitleGNsdWRlIFNvdXJj ZS9XZWJLaXQvLioKIGV4Y2x1ZGUgU291cmNlL2NtYWtlL0VGTEhlbHBlcnMuY21ha2UkCiBleGNs dWRlIFNvdXJjZS9jbWFrZS9PcHRpb25zV2luQ2Fpcm8uY21ha2UkCiBleGNsdWRlIFNvdXJjZS9j bWFrZS9PcHRpb25zV2luZG93cy5jbWFrZSQKQEAgLTYwLDE3ICs2MSwxMyBAQCBleGNsdWRlIFNv dXJjZS9jbWFrZS9lZmxzeW1ib2xzLmZpbHRlciQKIGV4Y2x1ZGUgU291cmNlL1dlYkluc3BlY3Rv clVJL1Rvb2xzCiBleGNsdWRlIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0lt YWdlcwogCi1kaXJlY3RvcnkgU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvSW1h Z2VzL2d0awotCi0jIE1vc3Qgb2YgdGhlIGZpbGVzIGluIFNvdXJjZS9XZWJLaXQgYXJlIG5vdCBu ZWNlc3NhcnkgdG8gYnVpbGQgR1RLKyBhbmQKLSMgdGhlIGRpcmVjdG9yeSBpbmNsdWRlcyBsb3Rz IG9mIGltYWdlcywgc28gd2UncmUgYSBiaXQgbW9yZSBwaWNreSBoZXJlLgotZXhjbHVkZSBTb3Vy Y2UvV2ViS2l0Ly4qCiBleGNsdWRlIFNvdXJjZS9XZWJLaXQyL1Jlc291cmNlcwogZXhjbHVkZSBT b3VyY2UvV2ViS2l0Mi9ndGsvTkVXUyQKIAogIyBXZSBkbyB3YW50IHRvIGluY2x1ZGUgdGhlIE5F V1MsIGJ1dCB3ZSB3YW50IGl0IHRvIGJlIGluIHRoZSByb290IG9mIHRoZSBhcmNoaXZlLgogZmls ZSBTb3VyY2UvV2ViS2l0Mi9ndGsvTkVXUyBORVdTCiAKK2RpcmVjdG9yeSBTb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9JbWFnZXMvZ3RrCiBmaWxlIFNvdXJjZS9XZWJDb3JlL0Vu Z2xpc2gubHByb2ovbWVkaWFDb250cm9sc0xvY2FsaXplZFN0cmluZ3MuanMgU291cmNlL1dlYkNv cmUvRW5nbGlzaC5scHJvai9tZWRpYUNvbnRyb2xzTG9jYWxpemVkU3RyaW5ncy5qcwogZmlsZSBT b3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJp bmdzLmpzIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2Fs aXplZFN0cmluZ3MuanMKIAo=