165775 2016-12-12 14:34:52 -0800 Infinite recursion when viewport is set to the size of the content but the content overflows the viewport. 2016-12-12 16:36:06 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan commit-queue mitz simon.fraser oldest_to_newest 1259207 0 zalan 2016-12-12 14:34:52 -0800 We should handle such cases like we do with m_setNeedsLayoutWasDeferred. 1259209 1 zalan 2016-12-12 14:35:10 -0800 rdar://problem/29366628 1259233 2 296957 zalan 2016-12-12 15:27:05 -0800 Created attachment 296957 Patch 1259242 3 296957 simon.fraser 2016-12-12 15:48:59 -0800 Comment on attachment 296957 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296957&action=review > Source/WebCore/page/FrameView.cpp:2662 > + // FIXME: Merge this logic with m_setNeedsLayoutWasDeferred and find a more appropriate File a bug for this. 1259247 4 296962 zalan 2016-12-12 15:57:51 -0800 Created attachment 296962 Patch 1259257 5 296962 commit-queue 2016-12-12 16:36:02 -0800 Comment on attachment 296962 Patch Clearing flags on attachment: 296962 Committed r209745: <http://trac.webkit.org/changeset/209745> 1259258 6 commit-queue 2016-12-12 16:36:06 -0800 All reviewed patches have been landed. Closing bug. 296957 2016-12-12 15:27:05 -0800 2016-12-12 15:57:48 -0800 Patch bug-165775-20161212152618.patch text/plain 2602 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5Mjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzkxZGU5ZmM5YjQ2ODg1 YjdjZWUxMTMzNmVhNTlkMTNmZDM2MDljNC4uM2U2YjQ0ZmJlZmZhMWY0MDI2NWQzNTQ1MTlmNjU2 ZTJiN2U3NDFkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTEyLTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW5maW5pdGUgcmVjdXJzaW9u IHdoZW4gdmlld3BvcnQgaXMgc2V0IHRvIHRoZSBzaXplIG9mIHRoZSBjb250ZW50IGJ1dCB0aGUg Y29udGVudCBvdmVyZmxvd3MgdGhlIHZpZXdwb3J0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1Nzc1CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI5 MzY2NjI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW4gY2VydGFpbiBjYXNlcyB3aGVuIHRoZSB2aWV3cG9ydCBpcyBzaXplZCB0byBhY2NvbW9kYXRl IHRoZSBjb250ZW50IGFuZAorICAgICAgICB0aGUgY29udGVudCBhbHdheXMgb3ZlcmZsb3dzIHRo ZSB2aWV3cG9ydCwgd2UgbWlnaHQgZW5kIHVwIGluIHJlY3Vyc2l2ZSBGcmFtZVZpZXc6OmxheW91 dCBjYWxscy4KKyAgICAgICAgVGhpcyBpcyBzcGVjaWZpYyB0byBjb250ZW50IHdpdGggdmlld3Bv cnQgdW5pdHMsIGJlY2F1c2Ugd2UgYWx3YXlzIGludmFsaWRhdGUgZWxlbWVudHMgd2l0aCB2dy92 aCB1bml0cyBvbgorICAgICAgICB2aWV3cG9ydCBzaXplIGNoYW5nZS4gSG93ZXZlciBpZiB0aGlz IHZpZXdwb3J0IHNpemUgY2hhbmdlIGlzIGluIHJlc3BvbnNlIHRvIGNvbnRlbnQgc2l6ZSBjaGFu Z2UgKGxheW91dCksIAorICAgICAgICBpbnZhbGlkYXRpbmcgZWxlbWVudHMgY291bGQgdHJpZ2dl ciBzeW5jaHJvbm91cyBsYXlvdXQsIHdoaWxlIHdlIGFyZSBzdGlsbCBpbnNpZGUgdGhpcyBjdXJy ZW50IGxheW91dC4KKyAgICAgICAgVGhpcyBpcyB2ZXJ5IHNpbWlsYXIgdG8gdGhlIG1fc2V0TmVl ZHNMYXlvdXRXYXNEZWZlcnJlZCBjYXNlIGFuZCB0aGV5IHNob3VsZCBldmVudHVhbGx5IGJlIG1l cmdlZC4KKyAgICAgICAgSXQgYWxzbyBtZWFucyB0aGF0IHdlIG1pZ2h0IGJlIGJlaGluZCBieSBv bmUgbGF5b3V0IG9uIGVsZW1lbnRzIHdpdGggdncvdmggdW5pdHMgKGZpeGVkIGxheW91dCBvbmx5 IHRob3VnaCkuCisKKyAgICAgICAgQ3VycmVudGx5IG5vdCB0ZXN0YWJsZS4KKworICAgICAgICAq IHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6YXZhaWxh YmxlQ29udGVudFNpemVDaGFuZ2VkKToKKwogMjAxNi0xMi0wMiAgQW50b2luZSBRdWludCAgPGdy YW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFtNb2Rlcm4gTWVkaWEgQ29udHJvbHNdIEFkZCBy ZXdpbmQgYW5kIGZhc3QtZm9yd2FyZCBzdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAK aW5kZXggNTkwOTZkZGNjZGI4M2FkOTNkM2Y4ZjFjMDVhZWVjNGQ2OTk3MjJjMy4uMzE1NWI5MTJh NGFkYzFjZGE3NmM1NmQ5MzM1NGFmYjRlYzI4OTJkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcApAQCAtMjY1OCw4ICsyNjU4LDEzIEBAIGJvb2wgRnJhbWVWaWV3OjpyZW5kZXJlZENoYXJh Y3RlcnNFeGNlZWQodW5zaWduZWQgdGhyZXNob2xkKQogCiB2b2lkIEZyYW1lVmlldzo6YXZhaWxh YmxlQ29udGVudFNpemVDaGFuZ2VkKEF2YWlsYWJsZVNpemVDaGFuZ2VSZWFzb24gcmVhc29uKQog ewotICAgIGlmIChEb2N1bWVudCogZG9jdW1lbnQgPSBmcmFtZSgpLmRvY3VtZW50KCkpCi0gICAg ICAgIGRvY3VtZW50LT51cGRhdGVWaWV3cG9ydFVuaXRzT25SZXNpemUoKTsKKyAgICBpZiAoRG9j dW1lbnQqIGRvY3VtZW50ID0gZnJhbWUoKS5kb2N1bWVudCgpKSB7CisgICAgICAgIC8vIEZJWE1F OiBNZXJnZSB0aGlzIGxvZ2ljIHdpdGggbV9zZXROZWVkc0xheW91dFdhc0RlZmVycmVkIGFuZCBm aW5kIGEgbW9yZSBhcHByb3ByaWF0ZQorICAgICAgICAvLyB3YXkgb2YgaGFuZGxpbmcgcG90ZW50 aWFsIHJlY3Vyc2l2ZSBsYXlvdXRzIHdoZW4gdGhlIHZpZXdwb3J0IGlzIHJlc2l6ZWQgdG8gYWNj b21vZGF0ZQorICAgICAgICAvLyB0aGUgY29udGVudCBidXQgdGhlIGNvbnRlbnQgYWx3YXlzIG92 ZXJmbG93cyB0aGUgdmlld3BvcnQuCisgICAgICAgIGlmICghKGxheW91dFBoYXNlKCkgPT0gSW5W aWV3U2l6ZUFkanVzdCAmJiB1c2VGaXhlZExheW91dCgpKSkKKyAgICAgICAgICAgIGRvY3VtZW50 LT51cGRhdGVWaWV3cG9ydFVuaXRzT25SZXNpemUoKTsKKyAgICB9CiAKICAgICB1cGRhdGVMYXlv dXRWaWV3cG9ydCgpOwogICAgIHNldE5lZWRzTGF5b3V0KCk7Cg== 296962 2016-12-12 15:57:51 -0800 2016-12-12 16:36:02 -0800 Patch bug-165775-20161212155704.patch text/plain 2625 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5Mjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzkxZGU5ZmM5YjQ2ODg1 YjdjZWUxMTMzNmVhNTlkMTNmZDM2MDljNC4uMTI4M2YzN2E0NDJiOTVlYjFjNWY0OWE4NTc0OWI1 Y2YzMjcxNGE1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTEyLTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW5maW5pdGUgcmVjdXJzaW9u IHdoZW4gdmlld3BvcnQgaXMgc2V0IHRvIHRoZSBzaXplIG9mIHRoZSBjb250ZW50IGJ1dCB0aGUg Y29udGVudCBvdmVyZmxvd3MgdGhlIHZpZXdwb3J0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1Nzc1CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzI5 MzY2NjI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIElu IGNlcnRhaW4gY2FzZXMgd2hlbiB0aGUgdmlld3BvcnQgaXMgc2l6ZWQgdG8gYWNjb21vZGF0ZSB0 aGUgY29udGVudCBhbmQKKyAgICAgICAgdGhlIGNvbnRlbnQgYWx3YXlzIG92ZXJmbG93cyB0aGUg dmlld3BvcnQsIHdlIG1pZ2h0IGVuZCB1cCBpbiByZWN1cnNpdmUgRnJhbWVWaWV3OjpsYXlvdXQg Y2FsbHMuCisgICAgICAgIFRoaXMgaXMgc3BlY2lmaWMgdG8gY29udGVudCB3aXRoIHZpZXdwb3J0 IHVuaXRzLCBiZWNhdXNlIHdlIGFsd2F5cyBpbnZhbGlkYXRlIGVsZW1lbnRzIHdpdGggdncvdmgg dW5pdHMgb24KKyAgICAgICAgdmlld3BvcnQgc2l6ZSBjaGFuZ2UuIEhvd2V2ZXIgaWYgdGhpcyB2 aWV3cG9ydCBzaXplIGNoYW5nZSBpcyBpbiByZXNwb25zZSB0byBjb250ZW50IHNpemUgY2hhbmdl IChsYXlvdXQpLCAKKyAgICAgICAgaW52YWxpZGF0aW5nIGVsZW1lbnRzIGNvdWxkIHRyaWdnZXIg c3luY2hyb25vdXMgbGF5b3V0LCB3aGlsZSB3ZSBhcmUgc3RpbGwgaW5zaWRlIHRoaXMgY3VycmVu dCBsYXlvdXQuCisgICAgICAgIFRoaXMgaXMgdmVyeSBzaW1pbGFyIHRvIHRoZSBtX3NldE5lZWRz TGF5b3V0V2FzRGVmZXJyZWQgY2FzZSBhbmQgdGhleSBzaG91bGQgZXZlbnR1YWxseSBiZSBtZXJn ZWQuCisgICAgICAgIEl0IGFsc28gbWVhbnMgdGhhdCB3ZSBtaWdodCBiZSBiZWhpbmQgYnkgb25l IGxheW91dCBvbiBlbGVtZW50cyB3aXRoIHZ3L3ZoIHVuaXRzIChmaXhlZCBsYXlvdXQgb25seSB0 aG91Z2gpLgorCisgICAgICAgIEN1cnJlbnRseSBub3QgdGVzdGFibGUuCisKKyAgICAgICAgKiBw YWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmF2YWlsYWJs ZUNvbnRlbnRTaXplQ2hhbmdlZCk6CisKIDIwMTYtMTItMDIgIEFudG9pbmUgUXVpbnQgIDxncmFv dXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBbTW9kZXJuIE1lZGlhIENvbnRyb2xzXSBBZGQgcmV3 aW5kIGFuZCBmYXN0LWZvcndhcmQgc3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmlu ZGV4IDU5MDk2ZGRjY2RiODNhZDkzZDNmOGYxYzA1YWVlYzRkNjk5NzIyYzMuLjE5ZTBkYmVhNjk0 YTIwYjJhMmE0MmU3NmFhNmI1NWEyNjYwNTM4MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5j cHAKQEAgLTI2NTgsOCArMjY1OCwxMyBAQCBib29sIEZyYW1lVmlldzo6cmVuZGVyZWRDaGFyYWN0 ZXJzRXhjZWVkKHVuc2lnbmVkIHRocmVzaG9sZCkKIAogdm9pZCBGcmFtZVZpZXc6OmF2YWlsYWJs ZUNvbnRlbnRTaXplQ2hhbmdlZChBdmFpbGFibGVTaXplQ2hhbmdlUmVhc29uIHJlYXNvbikKIHsK LSAgICBpZiAoRG9jdW1lbnQqIGRvY3VtZW50ID0gZnJhbWUoKS5kb2N1bWVudCgpKQotICAgICAg ICBkb2N1bWVudC0+dXBkYXRlVmlld3BvcnRVbml0c09uUmVzaXplKCk7CisgICAgaWYgKERvY3Vt ZW50KiBkb2N1bWVudCA9IGZyYW1lKCkuZG9jdW1lbnQoKSkgeworICAgICAgICAvLyBGSVhNRTog TWVyZ2UgdGhpcyBsb2dpYyB3aXRoIG1fc2V0TmVlZHNMYXlvdXRXYXNEZWZlcnJlZCBhbmQgZmlu ZCBhIG1vcmUgYXBwcm9wcmlhdGUKKyAgICAgICAgLy8gd2F5IG9mIGhhbmRsaW5nIHBvdGVudGlh bCByZWN1cnNpdmUgbGF5b3V0cyB3aGVuIHRoZSB2aWV3cG9ydCBpcyByZXNpemVkIHRvIGFjY29t b2RhdGUKKyAgICAgICAgLy8gdGhlIGNvbnRlbnQgYnV0IHRoZSBjb250ZW50IGFsd2F5cyBvdmVy Zmxvd3MgdGhlIHZpZXdwb3J0LiBTZWUgd2Via2l0Lm9yZy9iLzE2NTc4MS4KKyAgICAgICAgaWYg KCEobGF5b3V0UGhhc2UoKSA9PSBJblZpZXdTaXplQWRqdXN0ICYmIHVzZUZpeGVkTGF5b3V0KCkp KQorICAgICAgICAgICAgZG9jdW1lbnQtPnVwZGF0ZVZpZXdwb3J0VW5pdHNPblJlc2l6ZSgpOwor ICAgIH0KIAogICAgIHVwZGF0ZUxheW91dFZpZXdwb3J0KCk7CiAgICAgc2V0TmVlZHNMYXlvdXQo KTsK