165771 2016-12-12 13:10:59 -0800 [CSS Parser] MediaQueryParser should use Ref and not RefPtr 2023-05-02 13:14:44 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 hyatt hyatt barraclough commit-queue ntim oldest_to_newest 1259174 0 hyatt 2016-12-12 13:10:59 -0800 [CSS Parser] MediaQueryParser should use Ref and not RefPtr 1259175 1 296946 hyatt 2016-12-12 13:11:58 -0800 Created attachment 296946 Patch 1259176 2 commit-queue 2016-12-12 13:13:49 -0800 Attachment 296946 did not pass style-queue: ERROR: Source/WebCore/css/parser/MediaQueryParser.h:92: 'parseInternal' is incorrectly named. It should be named 'protector' or 'protectedCSSParserTokenRange'. [readability/naming/protected] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1259190 3 hyatt 2016-12-12 13:50:35 -0800 Fixed in r209726. 1259665 4 barraclough 2016-12-14 00:26:01 -0800 Rolled out in r209794 due to memory regression in r209726. 1952469 5 ntim 2023-05-02 13:14:44 -0700 The media query code has since been rewritten 296946 2016-12-12 13:11:58 -0800 2016-12-12 13:17:53 -0800 Patch bug-165771-20161212151110.patch text/plain 6328 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTcyMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE2LTEyLTEyICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFtDU1MgUGFyc2VyXSBNZWRpYVF1ZXJ5 UGFyc2VyIHNob3VsZCB1c2UgUmVmIGFuZCBub3QgUmVmUHRyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU3NzEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGNzcy9NZWRpYUxpc3QuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TWVkaWFRdWVyeVNldDo6Y3JlYXRlKToKKyAgICAgICAgKiBjc3MvcGFyc2Vy L0NTU1BhcnNlckltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VySW1wbDo6Y29u c3VtZUltcG9ydFJ1bGUpOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VySW1wbDo6Y29uc3Vt ZU1lZGlhUnVsZSk6CisgICAgICAgICogY3NzL3BhcnNlci9NZWRpYVF1ZXJ5UGFyc2VyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUXVlcnlQYXJzZXI6OnBhcnNlTWVkaWFRdWVyeVNldCk6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVF1ZXJ5UGFyc2VyOjpwYXJzZU1lZGlhQ29uZGl0aW9u KToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUXVlcnlQYXJzZXI6OnBhcnNlSW50ZXJuYWwpOgor ICAgICAgICAqIGNzcy9wYXJzZXIvTWVkaWFRdWVyeVBhcnNlci5oOgorCiAyMDE2LTEyLTEyICBa YWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgVGhlIENTUyAnY29sdW1u cycgcHJvcGVydHkgd2hlbiBzZXQgb24gdGhlIDxib2R5PiBlbGVtZW50IG1ha2VzIHNob3J0IGNv bHVtbnMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYUxpc3QuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9NZWRpYUxpc3QuY3BwCShyZXZpc2lvbiAyMDk3MTcpCisr KyBTb3VyY2UvV2ViQ29yZS9jc3MvTWVkaWFMaXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzAs NyArNzAsNyBAQCBSZWY8TWVkaWFRdWVyeVNldD4gTWVkaWFRdWVyeVNldDo6Y3JlYXRlCiAgICAg aWYgKG1lZGlhU3RyaW5nLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIE1lZGlhUXVlcnlTZXQ6 OmNyZWF0ZSgpOwogICAgIAotICAgIHJldHVybiBNZWRpYVF1ZXJ5UGFyc2VyOjpwYXJzZU1lZGlh UXVlcnlTZXQobWVkaWFTdHJpbmcpLnJlbGVhc2VOb25OdWxsKCk7CisgICAgcmV0dXJuIE1lZGlh UXVlcnlQYXJzZXI6OnBhcnNlTWVkaWFRdWVyeVNldChtZWRpYVN0cmluZyk7CiB9CiAKIE1lZGlh UXVlcnlTZXQ6Ok1lZGlhUXVlcnlTZXQoKQpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL3BhcnNl ci9DU1NQYXJzZXJJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvcGFy c2VyL0NTU1BhcnNlckltcGwuY3BwCShyZXZpc2lvbiAyMDk3MTgpCisrKyBTb3VyY2UvV2ViQ29y ZS9jc3MvcGFyc2VyL0NTU1BhcnNlckltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MTksNyAr NTE5LDcgQEAgUmVmUHRyPFN0eWxlUnVsZUltcG9ydD4gQ1NTUGFyc2VySW1wbDo6YwogICAgICAg ICBtX29ic2VydmVyV3JhcHBlci0+b2JzZXJ2ZXIoKS5lbmRSdWxlQm9keShlbmRPZmZzZXQpOwog ICAgIH0KIAotICAgIHJldHVybiBTdHlsZVJ1bGVJbXBvcnQ6OmNyZWF0ZSh1cmksIE1lZGlhUXVl cnlQYXJzZXI6OnBhcnNlTWVkaWFRdWVyeVNldChwcmVsdWRlKS5yZWxlYXNlTm9uTnVsbCgpKTsK KyAgICByZXR1cm4gU3R5bGVSdWxlSW1wb3J0OjpjcmVhdGUodXJpLCBNZWRpYVF1ZXJ5UGFyc2Vy OjpwYXJzZU1lZGlhUXVlcnlTZXQocHJlbHVkZSkpOwogfQogCiBSZWZQdHI8U3R5bGVSdWxlTmFt ZXNwYWNlPiBDU1NQYXJzZXJJbXBsOjpjb25zdW1lTmFtZXNwYWNlUnVsZShDU1NQYXJzZXJUb2tl blJhbmdlIHByZWx1ZGUpCkBAIC01MzgsNyArNTM4LDcgQEAgUmVmUHRyPFN0eWxlUnVsZU5hbWVz cGFjZT4gQ1NTUGFyc2VySW1wbAogUmVmUHRyPFN0eWxlUnVsZU1lZGlhPiBDU1NQYXJzZXJJbXBs Ojpjb25zdW1lTWVkaWFSdWxlKENTU1BhcnNlclRva2VuUmFuZ2UgcHJlbHVkZSwgQ1NTUGFyc2Vy VG9rZW5SYW5nZSBibG9jaykKIHsKICAgICBpZiAobV9kZWZlcnJlZFBhcnNlcikKLSAgICAgICAg cmV0dXJuIFN0eWxlUnVsZU1lZGlhOjpjcmVhdGUoTWVkaWFRdWVyeVBhcnNlcjo6cGFyc2VNZWRp YVF1ZXJ5U2V0KHByZWx1ZGUpLnJlbGVhc2VOb25OdWxsKCksICBzdGQ6Om1ha2VfdW5pcXVlPERl ZmVycmVkU3R5bGVHcm91cFJ1bGVMaXN0PihibG9jaywgKm1fZGVmZXJyZWRQYXJzZXIpKTsKKyAg ICAgICAgcmV0dXJuIFN0eWxlUnVsZU1lZGlhOjpjcmVhdGUoTWVkaWFRdWVyeVBhcnNlcjo6cGFy c2VNZWRpYVF1ZXJ5U2V0KHByZWx1ZGUpLCBzdGQ6Om1ha2VfdW5pcXVlPERlZmVycmVkU3R5bGVH cm91cFJ1bGVMaXN0PihibG9jaywgKm1fZGVmZXJyZWRQYXJzZXIpKTsKIAogICAgIFZlY3RvcjxS ZWZQdHI8U3R5bGVSdWxlQmFzZT4+IHJ1bGVzOwogCkBAIC01NTUsNyArNTU1LDcgQEAgUmVmUHRy PFN0eWxlUnVsZU1lZGlhPiBDU1NQYXJzZXJJbXBsOjpjbwogICAgIGlmIChtX29ic2VydmVyV3Jh cHBlcikKICAgICAgICAgbV9vYnNlcnZlcldyYXBwZXItPm9ic2VydmVyKCkuZW5kUnVsZUJvZHko bV9vYnNlcnZlcldyYXBwZXItPmVuZE9mZnNldChibG9jaykpOwogCi0gICAgcmV0dXJuIFN0eWxl UnVsZU1lZGlhOjpjcmVhdGUoTWVkaWFRdWVyeVBhcnNlcjo6cGFyc2VNZWRpYVF1ZXJ5U2V0KHBy ZWx1ZGUpLnJlbGVhc2VOb25OdWxsKCksIHJ1bGVzKTsKKyAgICByZXR1cm4gU3R5bGVSdWxlTWVk aWE6OmNyZWF0ZShNZWRpYVF1ZXJ5UGFyc2VyOjpwYXJzZU1lZGlhUXVlcnlTZXQocHJlbHVkZSks IHJ1bGVzKTsKIH0KIAogUmVmUHRyPFN0eWxlUnVsZVN1cHBvcnRzPiBDU1NQYXJzZXJJbXBsOjpj b25zdW1lU3VwcG9ydHNSdWxlKENTU1BhcnNlclRva2VuUmFuZ2UgcHJlbHVkZSwgQ1NTUGFyc2Vy VG9rZW5SYW5nZSBibG9jaykKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvTWVkaWFR dWVyeVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9N ZWRpYVF1ZXJ5UGFyc2VyLmNwcAkocmV2aXNpb24gMjA5NzE3KQorKysgU291cmNlL1dlYkNvcmUv Y3NzL3BhcnNlci9NZWRpYVF1ZXJ5UGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzYsMTcg KzM2LDE3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotUmVmUHRyPE1lZGlhUXVlcnlTZXQ+ IE1lZGlhUXVlcnlQYXJzZXI6OnBhcnNlTWVkaWFRdWVyeVNldChjb25zdCBTdHJpbmcmIHF1ZXJ5 U3RyaW5nKQorUmVmPE1lZGlhUXVlcnlTZXQ+IE1lZGlhUXVlcnlQYXJzZXI6OnBhcnNlTWVkaWFR dWVyeVNldChjb25zdCBTdHJpbmcmIHF1ZXJ5U3RyaW5nKQogewogICAgIHJldHVybiBwYXJzZU1l ZGlhUXVlcnlTZXQoQ1NTVG9rZW5pemVyKHF1ZXJ5U3RyaW5nKS50b2tlblJhbmdlKCkpOwogfQog Ci1SZWZQdHI8TWVkaWFRdWVyeVNldD4gTWVkaWFRdWVyeVBhcnNlcjo6cGFyc2VNZWRpYVF1ZXJ5 U2V0KENTU1BhcnNlclRva2VuUmFuZ2UgcmFuZ2UpCitSZWY8TWVkaWFRdWVyeVNldD4gTWVkaWFR dWVyeVBhcnNlcjo6cGFyc2VNZWRpYVF1ZXJ5U2V0KENTU1BhcnNlclRva2VuUmFuZ2UgcmFuZ2Up CiB7CiAgICAgcmV0dXJuIE1lZGlhUXVlcnlQYXJzZXIoTWVkaWFRdWVyeVNldFBhcnNlcikucGFy c2VJbnRlcm5hbChyYW5nZSk7CiB9CiAKLVJlZlB0cjxNZWRpYVF1ZXJ5U2V0PiBNZWRpYVF1ZXJ5 UGFyc2VyOjpwYXJzZU1lZGlhQ29uZGl0aW9uKENTU1BhcnNlclRva2VuUmFuZ2UgcmFuZ2UpCitS ZWY8TWVkaWFRdWVyeVNldD4gTWVkaWFRdWVyeVBhcnNlcjo6cGFyc2VNZWRpYUNvbmRpdGlvbihD U1NQYXJzZXJUb2tlblJhbmdlIHJhbmdlKQogewogICAgIHJldHVybiBNZWRpYVF1ZXJ5UGFyc2Vy KE1lZGlhQ29uZGl0aW9uUGFyc2VyKS5wYXJzZUludGVybmFsKHJhbmdlKTsKIH0KQEAgLTI0Niw3 ICsyNDYsNyBAQCB2b2lkIE1lZGlhUXVlcnlQYXJzZXI6OnByb2Nlc3NUb2tlbihjb25zCiB9CiAK IC8vIFRoZSBzdGF0ZSBtYWNoaW5lIGxvb3AKLVJlZlB0cjxNZWRpYVF1ZXJ5U2V0PiBNZWRpYVF1 ZXJ5UGFyc2VyOjpwYXJzZUludGVybmFsKENTU1BhcnNlclRva2VuUmFuZ2UgcmFuZ2UpCitSZWY8 TWVkaWFRdWVyeVNldD4gTWVkaWFRdWVyeVBhcnNlcjo6cGFyc2VJbnRlcm5hbChDU1NQYXJzZXJU b2tlblJhbmdlIHJhbmdlKQogewogICAgIHdoaWxlICghcmFuZ2UuYXRFbmQoKSkKICAgICAgICAg cHJvY2Vzc1Rva2VuKHJhbmdlLmNvbnN1bWUoKSk7CkBAIC0yNjEsNyArMjYxLDcgQEAgUmVmUHRy PE1lZGlhUXVlcnlTZXQ+IE1lZGlhUXVlcnlQYXJzZXI6OgogICAgIH0gZWxzZSBpZiAobV9tZWRp YVF1ZXJ5RGF0YS5jdXJyZW50TWVkaWFRdWVyeUNoYW5nZWQoKSkKICAgICAgICAgY29tbWl0TWVk aWFRdWVyeSgpOwogCi0gICAgcmV0dXJuIG1fcXVlcnlTZXQ7CisgICAgcmV0dXJuIFdURk1vdmUo bV9xdWVyeVNldCk7CiB9CiAKIE1lZGlhUXVlcnlEYXRhOjpNZWRpYVF1ZXJ5RGF0YSgpCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL01lZGlhUXVlcnlQYXJzZXIuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL01lZGlhUXVlcnlQYXJzZXIuaAkocmV2aXNp b24gMjA5NzE3KQorKysgU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9NZWRpYVF1ZXJ5UGFyc2Vy LmgJKHdvcmtpbmcgY29weSkKQEAgLTc2LDkgKzc2LDkgQEAgcHJpdmF0ZToKIGNsYXNzIE1lZGlh UXVlcnlQYXJzZXIgewogICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKE1lZGlhUXVlcnlQYXJzZXIp OwogcHVibGljOgotICAgIHN0YXRpYyBSZWZQdHI8TWVkaWFRdWVyeVNldD4gcGFyc2VNZWRpYVF1 ZXJ5U2V0KGNvbnN0IFN0cmluZyYpOwotICAgIHN0YXRpYyBSZWZQdHI8TWVkaWFRdWVyeVNldD4g cGFyc2VNZWRpYVF1ZXJ5U2V0KENTU1BhcnNlclRva2VuUmFuZ2UpOwotICAgIHN0YXRpYyBSZWZQ dHI8TWVkaWFRdWVyeVNldD4gcGFyc2VNZWRpYUNvbmRpdGlvbihDU1NQYXJzZXJUb2tlblJhbmdl KTsKKyAgICBzdGF0aWMgUmVmPE1lZGlhUXVlcnlTZXQ+IHBhcnNlTWVkaWFRdWVyeVNldChjb25z dCBTdHJpbmcmKTsKKyAgICBzdGF0aWMgUmVmPE1lZGlhUXVlcnlTZXQ+IHBhcnNlTWVkaWFRdWVy eVNldChDU1NQYXJzZXJUb2tlblJhbmdlKTsKKyAgICBzdGF0aWMgUmVmPE1lZGlhUXVlcnlTZXQ+ IHBhcnNlTWVkaWFDb25kaXRpb24oQ1NTUGFyc2VyVG9rZW5SYW5nZSk7CiAKIHByaXZhdGU6CiAg ICAgZW51bSBQYXJzZXJUeXBlIHsKQEAgLTg5LDcgKzg5LDcgQEAgcHJpdmF0ZToKICAgICBNZWRp YVF1ZXJ5UGFyc2VyKFBhcnNlclR5cGUpOwogICAgIHZpcnR1YWwgfk1lZGlhUXVlcnlQYXJzZXIo KTsKIAotICAgIFJlZlB0cjxNZWRpYVF1ZXJ5U2V0PiBwYXJzZUludGVybmFsKENTU1BhcnNlclRv a2VuUmFuZ2UpOworICAgIFJlZjxNZWRpYVF1ZXJ5U2V0PiBwYXJzZUludGVybmFsKENTU1BhcnNl clRva2VuUmFuZ2UpOwogCiAgICAgdm9pZCBwcm9jZXNzVG9rZW4oY29uc3QgQ1NTUGFyc2VyVG9r ZW4mKTsKIApAQCAtMTE2LDcgKzExNiw3IEBAIHByaXZhdGU6CiAgICAgU3RhdGUgbV9zdGF0ZTsK ICAgICBQYXJzZXJUeXBlIG1fcGFyc2VyVHlwZTsKICAgICBNZWRpYVF1ZXJ5RGF0YSBtX21lZGlh UXVlcnlEYXRhOwotICAgIFJlZlB0cjxNZWRpYVF1ZXJ5U2V0PiBtX3F1ZXJ5U2V0OworICAgIFJl ZjxNZWRpYVF1ZXJ5U2V0PiBtX3F1ZXJ5U2V0OwogICAgIE1lZGlhUXVlcnlCbG9ja1dhdGNoZXIg bV9ibG9ja1dhdGNoZXI7CiAKICAgICBjb25zdCBzdGF0aWMgU3RhdGUgUmVhZFJlc3RyaWN0b3I7 Cg==