165722 2016-12-10 00:09:44 -0800 Replace isUnclosedNode by isClosedShadowHidden 2016-12-10 02:19:35 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez commit-queue dbates esprehn+autocc kangil.han kling koivisto oldest_to_newest 1258622 0 rniwa 2016-12-10 00:09:44 -0800 The DOM Specification recently replaced the concept of “unclosed” by “closed-shadow-hidden” (negated). https://dom.spec.whatwg.org/#concept-closed-shadow-hidden https://github.com/whatwg/dom/pull/306 The new name is pretty horrible but there’s still a value in matching the spec terminology so do that. 1258623 1 296786 rniwa 2016-12-10 00:13:59 -0800 Created attachment 296786 Refactors the code 1258661 2 296786 koivisto 2016-12-10 02:07:37 -0800 Comment on attachment 296786 Refactors the code View in context: https://bugs.webkit.org/attachment.cgi?id=296786&action=review > Source/WebCore/dom/Node.cpp:1078 > +static bool isClosedShadowHiddenUsingSpecDefinition(const Node& A, const Node& B) "Specification" 1258663 3 296786 commit-queue 2016-12-10 02:19:30 -0800 Comment on attachment 296786 Refactors the code Clearing flags on attachment: 296786 Committed r209661: <http://trac.webkit.org/changeset/209661> 1258664 4 commit-queue 2016-12-10 02:19:35 -0800 All reviewed patches have been landed. Closing bug. 296786 2016-12-10 00:13:59 -0800 2016-12-10 02:19:30 -0800 Refactors the code fix165722.patch text/plain 5745 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTY1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE2LTEyLTEwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlcGxhY2UgaXNVbmNsb3NlZE5v ZGUgYnkgaXNDbG9zZWRTaGFkb3dIaWRkZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2NTcyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlcGxhY2VkIE5vZGU6OmlzVW5jbG9zZWROb2RlIGJ5IE5vZGU6 OmlzQ2xvc2VkU2hhZG93SGlkZGVuIGFuZCBuZWdhdGVkIHRoZSBzZW1hbnRpY3MgYXMgZG9uZSBp biB0aGUgc3BlYzoKKyAgICAgICAgaHR0cHM6Ly9kb20uc3BlYy53aGF0d2cub3JnLyNjb25jZXB0 LWNsb3NlZC1zaGFkb3ctaGlkZGVuCisgICAgICAgIGh0dHBzOi8vZ2l0aHViLmNvbS93aGF0d2cv ZG9tL3B1bGwvMzA2CisKKyAgICAgICAgQWxzbyBhZGRlZCBhIHZlcnNpb24gd2hpY2ggZm9sbG93 cyB0aGUgc3BlYyB0ZXh0IGZvciBhIGRlYnVnIGFzc2VydGlvbi4KKworICAgICAgICBObyBuZXcg dGVzdHMgc2luY2UgdGhpcyBoYXMgbm8gYmVoYXZpb3JhbCBjaGFuZ2UuCisKKyAgICAgICAgKiBk b20vRXZlbnRDb250ZXh0Lmg6CisgICAgICAgIChXZWJDb3JlOjpFdmVudENvbnRleHQ6OmlzVW5y ZWFjaGFibGVOb2RlKToKKyAgICAgICAgKiBkb20vRXZlbnRQYXRoLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkV2ZW50UGF0aDo6Y29tcHV0ZVBhdGhVbmNsb3NlZFRvVGFyZ2V0KToKKyAgICAgICAg KFdlYkNvcmU6OlJlbGF0ZWROb2RlUmV0YXJnZXRlcjo6Y2hlY2tDb25zaXN0ZW5jeSk6CisgICAg ICAgICogZG9tL05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNDbG9zZWRTaGFkb3dIaWRk ZW5Vc2luZ1NwZWNEZWZpbml0aW9uKTogQWRkZWQgdG8gYXNzZXJ0IG91ciBpbXBsZW1lbnRhdGlv biBtYXRjaGVzIHRoZSBzcGVjIHRleHQuCisgICAgICAgIChXZWJDb3JlOjpOb2RlOjppc0Nsb3Nl ZFNoYWRvd0hpZGRlbik6IFJlbmFtZWQgZnJvbSBOb2RlOjppc1VuY2xvc2VkTm9kZSBhbmQgbmVn YXRlZCB0aGUgcmV0dXJuIHZhbHVlLgorICAgICAgICAqIGRvbS9Ob2RlLmg6CisKIDIwMTYtMTIt MDkgIFJvbWFpbiBCZWxsZXNzb3J0ICA8cm9tYWluLmJlbGxlc3NvcnRAY3JmLmNhbm9uLmZyPgog CiAgICAgICAgIFtSZWFkYWJsZSBTdHJlYW1zIEFQSV0gSW1wbGVtZW50IFJlYWRhYmxlQnl0ZVN0 cmVhbUNvbnRyb2xsZXIgZGVzaXJlZFNpemUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9FdmVu dENvbnRleHQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRDb250ZXh0 LmgJKHJldmlzaW9uIDIwOTY0NykKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9FdmVudENvbnRleHQu aAkod29ya2luZyBjb3B5KQpAQCAtMTMyLDcgKzEzMiw3IEBACiBpbmxpbmUgYm9vbCBFdmVudENv bnRleHQ6OmlzVW5yZWFjaGFibGVOb2RlKEV2ZW50VGFyZ2V0KiB0YXJnZXQpIGNvbnN0CiB7CiAg ICAgLy8gRklYTUU6IENoZWNrcyBhbHNvIGZvciBTVkcgZWxlbWVudHMuCi0gICAgcmV0dXJuIHRh cmdldCAmJiB0YXJnZXQtPnRvTm9kZSgpICYmICF0YXJnZXQtPnRvTm9kZSgpLT5pc1NWR0VsZW1l bnQoKSAmJiAhbV9ub2RlLT5pc1VuY2xvc2VkTm9kZSgqdGFyZ2V0LT50b05vZGUoKSk7CisgICAg cmV0dXJuIHRhcmdldCAmJiB0YXJnZXQtPnRvTm9kZSgpICYmICF0YXJnZXQtPnRvTm9kZSgpLT5p c1NWR0VsZW1lbnQoKSAmJiBtX25vZGUtPmlzQ2xvc2VkU2hhZG93SGlkZGVuKCp0YXJnZXQtPnRv Tm9kZSgpKTsKIH0KICNlbmRpZgogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRQYXRo LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRXZlbnRQYXRoLmNwcAkocmV2 aXNpb24gMjA5NjQ3KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50UGF0aC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI2OSw3ICsyNjksNyBAQAogCiAgICAgZm9yIChhdXRvJiBjb250ZXh0IDog bV9wYXRoKSB7CiAgICAgICAgIGlmIChOb2RlKiBub2RlSW5QYXRoID0gY29udGV4dC0+Y3VycmVu dFRhcmdldCgpLT50b05vZGUoKSkgewotICAgICAgICAgICAgaWYgKHRhcmdldE5vZGUtPmlzVW5j bG9zZWROb2RlKCpub2RlSW5QYXRoKSkKKyAgICAgICAgICAgIGlmICghdGFyZ2V0Tm9kZS0+aXND bG9zZWRTaGFkb3dIaWRkZW4oKm5vZGVJblBhdGgpKQogICAgICAgICAgICAgICAgIHBhdGguYXBw ZW5kKGNvbnRleHQtPmN1cnJlbnRUYXJnZXQoKSk7CiAgICAgICAgIH0gZWxzZQogICAgICAgICAg ICAgcGF0aC5hcHBlbmQoY29udGV4dC0+Y3VycmVudFRhcmdldCgpKTsKQEAgLTQwMCw3ICs0MDAs NyBAQAogewogICAgIGlmICghbV9yZXRhcmdldGVkUmVsYXRlZE5vZGUpCiAgICAgICAgIHJldHVy bjsKLSAgICBBU1NFUlQoY3VycmVudFRhcmdldC5pc1VuY2xvc2VkTm9kZSgqbV9yZXRhcmdldGVk UmVsYXRlZE5vZGUpKTsKKyAgICBBU1NFUlQoIWN1cnJlbnRUYXJnZXQuaXNDbG9zZWRTaGFkb3dI aWRkZW4oKm1fcmV0YXJnZXRlZFJlbGF0ZWROb2RlKSk7CiAgICAgQVNTRVJUKG1fcmV0YXJnZXRl ZFJlbGF0ZWROb2RlID09ICZjdXJyZW50VGFyZ2V0LnRyZWVTY29wZSgpLnJldGFyZ2V0VG9TY29w ZShtX3JlbGF0ZWROb2RlKSk7CiB9CiAjZW5kaWYKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9O b2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAJKHJldmlz aW9uIDIwOTY0NykKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTA3Myw4ICsxMDczLDE4IEBACiAgICAgcmV0dXJuIGlzPFNoYWRvd1Jvb3Q+KHJvb3Qp ID8gZG93bmNhc3Q8U2hhZG93Um9vdD4oJnJvb3QpIDogbnVsbHB0cjsKIH0KIAorI2lmICFBU1NF UlRfRElTQUJMRUQKKy8vIGh0dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9yZy8jY29uY2VwdC1jbG9z ZWQtc2hhZG93LWhpZGRlbgorc3RhdGljIGJvb2wgaXNDbG9zZWRTaGFkb3dIaWRkZW5Vc2luZ1Nw ZWNEZWZpbml0aW9uKGNvbnN0IE5vZGUmIEEsIGNvbnN0IE5vZGUmIEIpCit7CisgICAgcmV0dXJu IEEuaXNJblNoYWRvd1RyZWUoKQorICAgICAgICAmJiAhQS5yb290Tm9kZSgpLmNvbnRhaW5zSW5j bHVkaW5nU2hhZG93RE9NKCZCKQorICAgICAgICAmJiAoQS5jb250YWluaW5nU2hhZG93Um9vdCgp LT5tb2RlKCkgIT0gU2hhZG93Um9vdE1vZGU6Ok9wZW4gfHwgaXNDbG9zZWRTaGFkb3dIaWRkZW5V c2luZ1NwZWNEZWZpbml0aW9uKCpBLnNoYWRvd0hvc3QoKSwgQikpOworfQorI2VuZGlmCisKIC8v IGh0dHA6Ly93M2MuZ2l0aHViLmlvL3dlYmNvbXBvbmVudHMvc3BlYy9zaGFkb3cvI2Rmbi11bmNs b3NlZC1ub2RlCi1ib29sIE5vZGU6OmlzVW5jbG9zZWROb2RlKGNvbnN0IE5vZGUmIG90aGVyTm9k ZSkgY29uc3QKK2Jvb2wgTm9kZTo6aXNDbG9zZWRTaGFkb3dIaWRkZW4oY29uc3QgTm9kZSYgb3Ro ZXJOb2RlKSBjb25zdAogewogICAgIC8vIFVzZSBWZWN0b3IgaW5zdGVhZCBvZiBIYXNoU2V0IHNp bmNlIHdlIGV4cGVjdCB0aGUgbnVtYmVyIG9mIGFuY2VzdG9yIHRyZWUgc2NvcGVzIHRvIGJlIHNt YWxsLgogICAgIFZlY3RvcjxUcmVlU2NvcGUqLCA4PiBhbmNlc3RvclNjb3Blc09mVGhpc05vZGU7 CkBAIC0xMDg0LDggKzEwOTQsMTAgQEAKIAogICAgIGZvciAoYXV0byogdHJlZVNjb3BlVGhhdENh bkFjY2Vzc090aGVyTm9kZSA9ICZvdGhlck5vZGUudHJlZVNjb3BlKCk7IHRyZWVTY29wZVRoYXRD YW5BY2Nlc3NPdGhlck5vZGU7IHRyZWVTY29wZVRoYXRDYW5BY2Nlc3NPdGhlck5vZGUgPSB0cmVl U2NvcGVUaGF0Q2FuQWNjZXNzT3RoZXJOb2RlLT5wYXJlbnRUcmVlU2NvcGUoKSkgewogICAgICAg ICBmb3IgKGF1dG8qIHNjb3BlIDogYW5jZXN0b3JTY29wZXNPZlRoaXNOb2RlKSB7Ci0gICAgICAg ICAgICBpZiAoc2NvcGUgPT0gdHJlZVNjb3BlVGhhdENhbkFjY2Vzc090aGVyTm9kZSkKLSAgICAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsgLy8gdHJlZVNjb3BlVGhhdENhbkFjY2Vzc090aGVyTm9k ZSBpcyBhIHNoYWRvdy1pbmNsdWRpbmcgaW5jbHVzaXZlIGFuY2VzdG9yIG9mIHRoaXMgbm9kZS4K KyAgICAgICAgICAgIGlmIChzY29wZSA9PSB0cmVlU2NvcGVUaGF0Q2FuQWNjZXNzT3RoZXJOb2Rl KSB7CisgICAgICAgICAgICAgICAgQVNTRVJUKCFpc0Nsb3NlZFNoYWRvd0hpZGRlblVzaW5nU3Bl Y0RlZmluaXRpb24ob3RoZXJOb2RlLCAqdGhpcykpOworICAgICAgICAgICAgICAgIHJldHVybiBm YWxzZTsgLy8gdHJlZVNjb3BlVGhhdENhbkFjY2Vzc090aGVyTm9kZSBpcyBhIHNoYWRvdy1pbmNs dWRpbmcgaW5jbHVzaXZlIGFuY2VzdG9yIG9mIHRoaXMgbm9kZS4KKyAgICAgICAgICAgIH0KICAg ICAgICAgfQogICAgICAgICBhdXRvJiByb290ID0gdHJlZVNjb3BlVGhhdENhbkFjY2Vzc090aGVy Tm9kZS0+cm9vdE5vZGUoKTsKICAgICAgICAgaWYgKGlzPFNoYWRvd1Jvb3Q+KHJvb3QpICYmIGRv d25jYXN0PFNoYWRvd1Jvb3Q+KHJvb3QpLm1vZGUoKSAhPSBTaGFkb3dSb290TW9kZTo6T3BlbikK QEAgLTEwOTIsNyArMTEwNCw4IEBACiAgICAgICAgICAgICBicmVhazsKICAgICB9CiAKLSAgICBy ZXR1cm4gZmFsc2U7CisgICAgQVNTRVJUKGlzQ2xvc2VkU2hhZG93SGlkZGVuVXNpbmdTcGVjRGVm aW5pdGlvbihvdGhlck5vZGUsICp0aGlzKSk7CisgICAgcmV0dXJuIHRydWU7CiB9CiAKIHN0YXRp YyBpbmxpbmUgU2hhZG93Um9vdCogcGFyZW50U2hhZG93Um9vdChjb25zdCBOb2RlJiBub2RlKQpJ bmRleDogU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5oCShyZXZpc2lvbiAyMDk2NDcpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20v Tm9kZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNDEsNyArMjQxLDcgQEAKICAgICBXRUJDT1JFX0VY UE9SVCBOb2RlKiBkZXByZWNhdGVkU2hhZG93QW5jZXN0b3JOb2RlKCkgY29uc3Q7CiAgICAgU2hh ZG93Um9vdCogY29udGFpbmluZ1NoYWRvd1Jvb3QoKSBjb25zdDsKICAgICBTaGFkb3dSb290KiBz aGFkb3dSb290KCkgY29uc3Q7Ci0gICAgYm9vbCBpc1VuY2xvc2VkTm9kZShjb25zdCBOb2RlJikg Y29uc3Q7CisgICAgYm9vbCBpc0Nsb3NlZFNoYWRvd0hpZGRlbihjb25zdCBOb2RlJikgY29uc3Q7 CiAKICAgICBIVE1MU2xvdEVsZW1lbnQqIGFzc2lnbmVkU2xvdCgpIGNvbnN0OwogICAgIEhUTUxT bG90RWxlbWVudCogYXNzaWduZWRTbG90Rm9yQmluZGluZ3MoKSBjb25zdDsK