165709 2016-12-09 18:35:54 -0800 Add reflected nonce attribute to HTML Link element IDL 2016-12-09 18:54:27 -0800 1 1 1 Unclassified WebKit DOM WebKit Local Build All All RESOLVED FIXED WebExposed P2 Normal --- 1 dbates dbates cdumez commit-queue esprehn+autocc gyuyoung.kim kondapallykalyan oldest_to_newest 1258514 0 dbates 2016-12-09 18:35:54 -0800 We should add the reflected nonce attribute to the HTML Link element IDL definition so as to match the HTML standard: <https://html.spec.whatwg.org/multipage/semantics.html#the-link-element> (9 December 2016). 1258516 1 296762 dbates 2016-12-09 18:37:24 -0800 Created attachment 296762 Patch and layout test 1258522 2 296762 rniwa 2016-12-09 18:43:28 -0800 Comment on attachment 296762 Patch and layout test View in context: https://bugs.webkit.org/attachment.cgi?id=296762&action=review > LayoutTests/fast/dom/nonce-attribute-reflection.html:10 > +var e; Can we not use a single letter variable like e? 1258527 3 dbates 2016-12-09 18:50:16 -0800 (In reply to comment #2) > Comment on attachment 296762 [details] > Patch and layout test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296762&action=review > > > LayoutTests/fast/dom/nonce-attribute-reflection.html:10 > > +var e; > > Can we not use a single letter variable like e? Will substitute element for e before landing. For completeness, I chose to use "e" as the name of the global variable so as to focus the attention of the reader on the commands being used to generate the DOM element and set nonce attribute as opposed to the name of the global used solely to string all these commands together so as to make use of shouldBeEqualToString(). 1258530 4 dbates 2016-12-09 18:54:15 -0800 Committed r209644: <http://trac.webkit.org/changeset/209644> 296762 2016-12-09 18:37:24 -0800 2016-12-09 18:43:28 -0800 Patch and layout test bug-165709-20161209183641.patch text/plain 3972 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5NjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmY4ZDIzY2YwZWQ3ZDBj YTVkODU0MGY4Y2JiYTE3ZmIxYTVjOTdhZi4uNDdkODRkNTQ1MzRmZThjNjYzYTUzMjE0MjUxMjhh ZTMxMWNiOTJiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTEyLTA5ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBBZGQgcmVmbGVjdGVkIG5v bmNlIGF0dHJpYnV0ZSB0byBIVE1MIExpbmsgZWxlbWVudCBJREwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTcwOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0aGUgcmVmbGVjdGVkIG5vbmNlIGF0 dHJpYnV0ZSB0byB0aGUgSFRNTCBMaW5rIGVsZW1lbnQgSURMIGRlZmluaXRpb24KKyAgICAgICAg YXMgcGVyIHRoZSBIVE1MIHN0YW5kYXJkIDxodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211 bHRpcGFnZS9zZW1hbnRpY3MuaHRtbCN0aGUtbGluay1lbGVtZW50PiAoOSBEZWNlbWJlciAyMDE2 KS4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9ub25jZS1hdHRyaWJ1dGUtcmVmbGVjdGlvbi5o dG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxMaW5rRWxlbWVudC5pZGw6CisKKzIwMTYtMTItMDkg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCiAgICAgICAgIFJlbW92ZSBRdWlj a0xvb2sgc2NoZW1lIGZyb20gdGhlIGxpc3Qgb2Ygc2VjdXJlIHNjaGVtZXMKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTY5OQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxMaW5rRWxlbWVudC5pZGwKaW5kZXggN2FlMjFiMGYwZTM0NzJiYTg0ZDI4OGQy MzhkNzA0MmFjYzBiOTA3OS4uOTJmYmY5ODE4Y2QzMGUwMTg5YTU1ZjM5OTNiZjY3NzYxNTNmOGJk OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuaWRsCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmlkbApAQCAtNDAsNSArNDAs NyBAQAogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBTdHlsZVNoZWV0IHNoZWV0OwogCiAgICAgW1B1 dEZvcndhcmRzPXZhbHVlXSByZWFkb25seSBhdHRyaWJ1dGUgRE9NVG9rZW5MaXN0IHJlbExpc3Q7 CisKKyAgICBbUmVmbGVjdF0gYXR0cmlidXRlIERPTVN0cmluZyBub25jZTsKIH07CiAKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCBkYWJkNTQ2YTFiYjBkNzdjZTRlZWMxYjU1MjgwZWU3OWU1ZTBkNTVmLi5mMGZkYTJlYjU4MDc3 NzRkZmY5ZWJiZTAzMGIyOWQ5ZTE0YWQ5Yzk0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYt MTItMDkgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBy ZWZsZWN0ZWQgbm9uY2UgYXR0cmlidXRlIHRvIEhUTUwgTGluayBlbGVtZW50IElETAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NzA5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB0byBl bnN1cmUgdGhhdCB3ZSByZWZsZWN0IHRoZSBub25jZSBhdHRyaWJ1dGUgZm9yIHRoZSBIVE1MIGxp bmssIHN0eWxlLAorICAgICAgICBhbmQgc2NyaXB0IGVsZW1lbnRzLgorCisgICAgICAgICogZmFz dC9kb20vbm9uY2UtYXR0cmlidXRlLXJlZmxlY3Rpb24tZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2RvbS9ub25jZS1hdHRyaWJ1dGUtcmVmbGVjdGlvbi5odG1sOiBBZGRlZC4K KwogMjAxNi0xMi0wOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAg IFtDb2NvYV0gVmFsaWRhdGlvbiBtZXNzYWdlIGZvciByZXF1aXJlZCBjaGVja2JveCBkb2VzbuKA mXQgY29uZm9ybSB0aGUgdGhlIEFwcGxlIFN0eWxlIEd1aWRlCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9ub25jZS1hdHRyaWJ1dGUtcmVmbGVjdGlvbi1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9ub25jZS1hdHRyaWJ1dGUtcmVmbGVjdGlvbi1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uMjZjOTgyNmEyMDdjZThmMjhhMzVjNTRiOWNhNDIyMDE1Zjc1YTg1NQot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL25vbmNlLWF0dHJpYnV0ZS1y ZWZsZWN0aW9uLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEyIEBACitUZXN0cyB0aGF0IHRoZSBu b25jZSBhdHRyaWJ1dGUgZm9yIEhUTUwgbGluaywgc3R5bGUsIGFuZCBzY3JpcHQgZWxlbWVudHMg aXMgcmVmbGVjdGVkLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBB U1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBlID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgibGluayIpOyBlLnNldEF0dHJpYnV0ZSgibm9uY2UiLCAi ZHVtbXkiKTsgZS5ub25jZSBpcyAiZHVtbXkiCitQQVNTIGUgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCJzdHlsZSIpOyBlLnNldEF0dHJpYnV0ZSgibm9uY2UiLCAiZHVtbXkiKTsgZS5ub25jZSBp cyAiZHVtbXkiCitQQVNTIGUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzY3JpcHQiKTsgZS5z ZXRBdHRyaWJ1dGUoIm5vbmNlIiwgImR1bW15Iik7IGUubm9uY2UgaXMgImR1bW15IgorUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2Zhc3QvZG9tL25vbmNlLWF0dHJpYnV0ZS1yZWZsZWN0aW9uLmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9ub25jZS1hdHRyaWJ1dGUtcmVmbGVjdGlvbi5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjU5MGZkNjc5ZDRjZDhiZGY4NGE4YWE3ODMxNjBlMjc0MzMzNTEwMWUKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9ub25jZS1hdHRyaWJ1dGUtcmVmbGVjdGlv bi5odG1sCkBAIC0wLDAgKzEsMTcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4K KzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor PC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3RzIHRoYXQgdGhlIG5v bmNlIGF0dHJpYnV0ZSBmb3IgSFRNTCBsaW5rLCBzdHlsZSwgYW5kIHNjcmlwdCBlbGVtZW50cyBp cyByZWZsZWN0ZWQuIik7CisKK3ZhciBlOwordmFyIHRhZ05hbWVzVG9UZXN0ID0gWyJsaW5rIiwg InN0eWxlIiwgInNjcmlwdCJdOworZm9yIChsZXQgdGFnTmFtZSBvZiB0YWdOYW1lc1RvVGVzdCkK KyAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmcoYGUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCIk e3RhZ05hbWV9Iik7IGUuc2V0QXR0cmlidXRlKCJub25jZSIsICJkdW1teSIpOyBlLm5vbmNlYCwg ImR1bW15Iik7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVz dC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K