165698 2016-12-09 16:18:37 -0800 [GTK] Web Inspector: Add NavigationItemCodeCoverage.svg icon 2016-12-12 17:05:53 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 nvasilyev nvasilyev agomez bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1258440 0 nvasilyev 2016-12-09 16:18:37 -0800 NavigationItemCodeCoverage.svg is missing for GTK. https://github.com/WebKit/webkit/blob/master/Source/WebInspectorUI/UserInterface/Images/NavigationItemCodeCoverage.svg 1258956 1 296891 nvasilyev 2016-12-11 20:10:00 -0800 Created attachment 296891 Patch 1258957 2 296892 nvasilyev 2016-12-11 20:12:55 -0800 Created attachment 296892 [Image] Code Coverage Icon 1259261 3 296891 joepeck 2016-12-12 16:42:24 -0800 Comment on attachment 296891 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296891&action=review > Source/WebInspectorUI/UserInterface/Images/gtk/NavigationItemCodeCoverage.svg:5 > + <rect stroke="currentColor" width="12" height="12" x=".49998" y="1.0001" fill="none" stroke-width=".99996" stroke-miterlimit="10" stroke-linejoin="bevel" rx="1.2112" ry="1.2111"/> > + <path fill="none" stroke="currentColor" stroke-width="2.4" d="M9 5.5s0-1.5-2.5-1.5C3 4 3 10 6.5 10c2.5 0 2.5-1.5 2.5-1.5"/> Normally Images/gtk has a single space indentation. But I'll leave it up to you if you want to reduce this. Back to cq? 1259267 4 296967 nvasilyev 2016-12-12 16:48:00 -0800 Created attachment 296967 Patch 1259278 5 296967 commit-queue 2016-12-12 17:05:49 -0800 Comment on attachment 296967 Patch Clearing flags on attachment: 296967 Committed r209748: <http://trac.webkit.org/changeset/209748> 1259279 6 commit-queue 2016-12-12 17:05:53 -0800 All reviewed patches have been landed. Closing bug. 296891 2016-12-11 20:10:00 -0800 2016-12-12 16:48:00 -0800 Patch patch.txt text/plain 1618 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUzYTU5OTIuLmI5N2Y3OTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTEyLTExICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFtHVEtdIFdlYiBJbnNwZWN0b3I6 IEFkZCBOYXZpZ2F0aW9uSXRlbUNvZGVDb3ZlcmFnZS5zdmcgaWNvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1Njk4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0ltYWdlcy9n dGsvTmF2aWdhdGlvbkl0ZW1Db2RlQ292ZXJhZ2Uuc3ZnOiBBZGRlZC4KKyAgICAgICAgTWF0Y2gg aW4gc3R5bGUgdGhlIGV4aXN0aW5nIE5hdmlnYXRpb25JdGVtVHlwZXMuc3ZnIGljb24uCisKIDIw MTYtMTItMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBNb3ZlIE1haW5UYXJnZXQgYW5kIFdvcmtlclRhcmdldCB0byB0aGVp ciBvd24gZmlsZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0ltYWdlcy9ndGsvTmF2aWdhdGlvbkl0ZW1Db2RlQ292ZXJhZ2Uuc3ZnIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvSW1hZ2VzL2d0ay9OYXZpZ2F0aW9uSXRlbUNvZGVD b3ZlcmFnZS5zdmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZDkyOWVmNAot LS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0lt YWdlcy9ndGsvTmF2aWdhdGlvbkl0ZW1Db2RlQ292ZXJhZ2Uuc3ZnCkBAIC0wLDAgKzEsNiBAQAor PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KKzwhLS0gTGljZW5zZWQgdW5k ZXIgdGhlIENyZWF0aXZlIENvbW1vbnMgQXR0cmlidXRpb24tU2hhcmUgQWxpa2UgMy4wIFVuaXRl ZCBTdGF0ZXMgTGljZW5zZSAoaHR0cDovL2NyZWF0aXZlY29tbW9ucy5vcmcvbGljZW5zZXMvYnkt c2EvMy4wLykgLS0+Cis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgaWQ9 InJvb3QiIHZlcnNpb249IjEuMSIgdmlld0JveD0iMCAwIDEzIDE0Ij4KKyAgICA8cmVjdCBzdHJv a2U9ImN1cnJlbnRDb2xvciIgd2lkdGg9IjEyIiBoZWlnaHQ9IjEyIiB4PSIuNDk5OTgiIHk9IjEu MDAwMSIgZmlsbD0ibm9uZSIgc3Ryb2tlLXdpZHRoPSIuOTk5OTYiIHN0cm9rZS1taXRlcmxpbWl0 PSIxMCIgc3Ryb2tlLWxpbmVqb2luPSJiZXZlbCIgcng9IjEuMjExMiIgcnk9IjEuMjExMSIvPgor ICAgIDxwYXRoIGZpbGw9Im5vbmUiIHN0cm9rZT0iY3VycmVudENvbG9yIiBzdHJva2Utd2lkdGg9 IjIuNCIgZD0iTTkgNS41czAtMS41LTIuNS0xLjVDMyA0IDMgMTAgNi41IDEwYzIuNSAwIDIuNS0x LjUgMi41LTEuNSIvPgorPC9zdmc+Cg== 296892 2016-12-11 20:12:55 -0800 2016-12-11 20:12:55 -0800 [Image] Code Coverage Icon gtk-code-coverage-icon.png image/png 2275 nvasilyev iVBORw0KGgoAAAANSUhEUgAAAHQAAABpCAYAAADr0gdiAAAIqklEQVR4nO2dXUxU2R3Af2c+xeFb 18oU/EAkUJu1dYnZGlQWY11NMWnDA3WyFJdkU/rQaHYLL9adUmvidlO7bVJiNmwpjWi1L7JETajU RmUtQdrdZltjp91ucPGhOATYUYaZubcPyFgYQBjvZYbj+SU8eGf4/w/35zn33DNn7l/ouq6jkAZL ohugMBYlVDKUUMlQQiVDCZUMJVQylFDJUEIlQwmVjBmFdnV1LXY7TOdZ+ZtUD5UMm1mBe3t7uXTp Ej6fD7/f/1SxsrOzKSgoYO/evZSUlBjUwoVx1RehrU/jo3sRBkafLpY7DZ7PsXJgi4WyAqsxDXyE KUJPnjxp6BDn9/vp6emhp6eH8vJyDh8+bFjs+VD/foizH0YMizcwCgOjES7fiVC1WeOtCrthsQ0f cltbW029XnV1ddHa2mpa/Om8fTVsqMzpnP0wwttXw4bFM7yHtre3A1BQUMCxY8dwuVyGxA0EAhw5 cgSfz0d7ezvV1dWGxH0SzTcnTvYWt4XfeuykOYUhcUeDOq+cDtE3oNF8M8wbZcaoMFxoMBhE13W8 Xm9Ups/n48aNG9jtCxtaxsbG2LZtG0VFRbhcLrxeLx6Ph2AwaHSzZyXwqPO8V2WcTIA0p+C9Kjtf +VkwmsMITLmGCiHIyMgAYGhoiPr6ekKhUFyxOjo6aG5uJisri4yMDIQw7qQuhOzlc+d9GNL5zxB8 el8nooM7A9zpFp5LBcssv/qkmPFg2ix3ksHBwajMO3fuLOh3CwsLCYVCDA4OkpWVZUbznpqRMZ2T f4rwm1shwlqsoLwM+EGZg/1ftswq1khMF2q1TkzLR0ZGFix09erVpKenR2MkG5/6db5zZpx/D+nA zLb6h+H7F8a5/A8r73zLjtPkM266UE3TAEhPT2fPnj0xr1+5cgW73c6OHTtiXlvoNXcxeTCuU31m nE+G5rcl6+KdCO4uOPp1c/8m01eK8vPzcbvdwISg6T9CCIQQM74GkJOTw7p168xu5oJp6o7MW+Yk Lb1h/vu5SQ16hOk91GKxcOrUKQKBwJTjVVVVMe91uVw0NzdH/61pGqmpqQmbCM1GYFzn1z2xU9Mv psO+IiupTkFvv0bfZxECocdtD2uCvrsae4rM60emC51k+v2oy+WKkexyuQy7bzWTP/5TZ2R86rEN 2YLLrzmnXCN1HRb7/6JanI+Dj+7FrhzVbrXFTHgSMbAooXEwGIg99tXc5DiVydGKJUaSXdKnoITG wYrlscf+cldb/IbMgBIaB8/nxC50NPeECU6b+CbiW0OLNsuViZc2CtIdTJnp/suvU/arsTlvWwDe rXTIcdsiEy6H4OBWG+9cn9olPxuBd3v+fwY8VabNorPF5MmTGnLjpG6blfVZC5sd1ZTYeC7VpAY9 QgmNk+UOQeu3HeTPU+q+QisN5eavTSd8yC0sLMRmm2jG9JWjZGdttqC91vFsfXw2G5mZmQQCAdav Xx89lp+fn6jmxE36MsGbe2zUl1sX/AG3GZgiVNd1hoeHo7sWZqKxsZHOzs7ownskEqGiomLOuMPD w+i6npDFev8Dfc4dBil2QfEqKF41/7b5Hxh/X2O4UKfTSTAYxOv1zrlJbNWqVXg8nnnHDQQCeL1e hBA4nU6jmvtEXLaJfUWvng0Zvkns1bOhaA6jMFzo/v37OX/+PD6fb8aPyIzKsVjUvmjjF9fD9A1o bPqpOZvTal80ToPhs9zq6mp27dpldNgo5eXli7aFE+CNMhtVm83bAlO12WrYFk4w6Rp66NAhSktL pfkqxFsVdvYVW57dr0IAlJSUJOx7KGZQVmB9dPKTd58TqIUF6RDqSWJyoXqoZCihkqGESoYSKhlK qGQooZKhhEqGEioZSqhkKKGSoYRKhq2joyPRbVAYiOqhkiHUhy1yoXqoZCihkqGESoYSKhlKqGQo oZKhhEqGEioZSqhkKKGSoYRKhhIqGUqoZCihkqGESoYSKhlKqGQooZKhhEqGEioZSqhkKKGSoYRK RqIfryrrpuCE1Y1QPVQylFDJUEIlI6FCu7q6pMyVSBI9KZqT/v5+mpqauH379pw1vO12O0VFRdTV 1ZGXlxdXLt99naMXQ/TcjTAemX1O47DqbM210rjPTsGK5KuZldRCGxoaSElJoaKiYs6nWAeDQa5f v05DQwNtbW1x5apsCZLmgNe22lk2xwM3x0Lw/t/DVLYE+evry+LKZSZJLXR0dJS2tja6u7tpaWmJ Vo+YRAiBpml4PB4OHjz4xGfWz4X/ITGCPg/q3BudqHWWlSKiRezqd9lYc2ws7lxmktRCJ+nu7ubm zZsMDAzEvJaTk8OGDRsoLS01LF8wDD/5Q5jW3jCTJepecFv4+TftrF1g8Z3FZkkIXblyJWvXrmXN mjUIIejs7GT37t3RChGZmZmG5vtxZ5jWW1PLYN0a0PCcHufq95zYkvjeYEkIramp4cCBAwBUVlYC YLVaOXfuHAAOh8OwXPcf6JzuCwGCr+VZ+O42K5/44W/3NFJsguExnRVzlPtINEtCKDyWNlmzRQhh qMhJPr6nE9Encrz5sp0vfUHwEgDmFRIwkiQePBTxsGR66HTMqq60KUdgFRO99EeXQzFD7uvlVjXk LiVWLBd4tthpvRXmg36ND373uBTzmkxB47LkPmVLbsjVdZ3s7Gw0zbya1z/cbaOmxDbl5LzgtnDa 40jqGS4swR66c+dOcnNz2bhxo2k5nDZofNlG/UvWGRcWkpmkFpqWlkZtbS3bt2+PLv253W7cbjcA Z86cASaW/q5du0ZaWlrcubJTYPsvx/jGJisp9tnNPQzpdHwcITsl7lSmktRCT5w4QVNTExcuXCAc Ds/6PpvNRnFxMXV1dXHn+n2Nk6MXQzT/OcJYZPb3LbNCSa6Fxn3JWWEpqYXm5eVx/PjxRclVsELQ 9orx97WLTaKf9af2FBlMks/ZFAtFCZUMJVQylFDJ+B/lXJhqMm0/fgAAAABJRU5ErkJggg== 296967 2016-12-12 16:48:00 -0800 2016-12-12 17:05:49 -0800 Patch patch.txt text/plain 1613 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUzYTU5OTIuLjViNzc1OWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTEyLTEyICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFtHVEtdIFdlYiBJbnNwZWN0b3I6 IEFkZCBOYXZpZ2F0aW9uSXRlbUNvZGVDb3ZlcmFnZS5zdmcgaWNvbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1Njk4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgSm9zZXBoIFBlY29yYXJvLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9JbWFnZXMv Z3RrL05hdmlnYXRpb25JdGVtQ29kZUNvdmVyYWdlLnN2ZzogQWRkZWQuCisgICAgICAgIE1hdGNo IGluIHN0eWxlIHRoZSBleGlzdGluZyBOYXZpZ2F0aW9uSXRlbVR5cGVzLnN2ZyBpY29uLgorCiAy MDE2LTEyLTExICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogTW92ZSBNYWluVGFyZ2V0IGFuZCBXb3JrZXJUYXJnZXQgdG8gdGhl aXIgb3duIGZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9JbWFnZXMvZ3RrL05hdmlnYXRpb25JdGVtQ29kZUNvdmVyYWdlLnN2ZyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0ltYWdlcy9ndGsvTmF2aWdhdGlvbkl0ZW1Db2Rl Q292ZXJhZ2Uuc3ZnCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjUxM2JlMzkK LS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9J bWFnZXMvZ3RrL05hdmlnYXRpb25JdGVtQ29kZUNvdmVyYWdlLnN2ZwpAQCAtMCwwICsxLDYgQEAK Kzw/eG1sIHZlcnNpb249IjEuMCIgZW5jb2Rpbmc9IlVURi04Ij8+Cis8IS0tIExpY2Vuc2VkIHVu ZGVyIHRoZSBDcmVhdGl2ZSBDb21tb25zIEF0dHJpYnV0aW9uLVNoYXJlIEFsaWtlIDMuMCBVbml0 ZWQgU3RhdGVzIExpY2Vuc2UgKGh0dHA6Ly9jcmVhdGl2ZWNvbW1vbnMub3JnL2xpY2Vuc2VzL2J5 LXNhLzMuMC8pIC0tPgorPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIGlk PSJyb290IiB2ZXJzaW9uPSIxLjEiIHZpZXdCb3g9IjAgMCAxMyAxNCI+CisgPHJlY3Qgc3Ryb2tl PSJjdXJyZW50Q29sb3IiIHdpZHRoPSIxMiIgaGVpZ2h0PSIxMiIgeD0iLjQ5OTk4IiB5PSIxLjAw MDEiIGZpbGw9Im5vbmUiIHN0cm9rZS13aWR0aD0iLjk5OTk2IiBzdHJva2UtbWl0ZXJsaW1pdD0i MTAiIHN0cm9rZS1saW5lam9pbj0iYmV2ZWwiIHJ4PSIxLjIxMTIiIHJ5PSIxLjIxMTEiLz4KKyA8 cGF0aCBmaWxsPSJub25lIiBzdHJva2U9ImN1cnJlbnRDb2xvciIgc3Ryb2tlLXdpZHRoPSIyLjQi IGQ9Ik05IDUuNXMwLTEuNS0yLjUtMS41QzMgNCAzIDEwIDYuNSAxMGMyLjUgMCAyLjUtMS41IDIu NS0xLjUiLz4KKzwvc3ZnPgo=