165692 2016-12-09 15:15:21 -0800 Don’t expose pointer lock in WebKit1 Objective-C API 2016-12-09 16:28:52 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa andersca jeremyj-wk jonlee oldest_to_newest 1258387 0 rniwa 2016-12-09 15:15:21 -0800 Right now, there’s a if-def’ed code in WebKit1’s Objective-C API. Since we never enabled pointer lock until now, we’re effectively adding pointer lock to objective-C API now. Don’t do that. 1258389 1 296714 rniwa 2016-12-09 15:16:08 -0800 Created attachment 296714 Removes the Objective-C API 1258435 2 rniwa 2016-12-09 16:06:39 -0800 Committed r209637: <http://trac.webkit.org/changeset/209637> 1258457 3 rniwa 2016-12-09 16:28:52 -0800 <rdar://problem/29604589> 296714 2016-12-09 15:16:08 -0800 2016-12-09 15:20:18 -0800 Removes the Objective-C API bug-165692-20161209151531.patch text/plain 2941 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTYzMykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEyLTA5 ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIERvbuKAmXQgZXhw b3NlIHBvaW50ZXIgbG9jayBpbiBXZWJLaXQxIE9iamVjdGl2ZS1DIEFQSQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NjkyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBET00vRE9NRG9jdW1lbnQubW06 CisgICAgICAgICgtW0RPTURvY3VtZW50IHBvaW50ZXJMb2NrRWxlbWVudF0pOiBEZWxldGVkLgor ICAgICAgICAoLVtET01Eb2N1bWVudCBleGl0UG9pbnRlckxvY2tdKTogRGVsZXRlZC4KKyAgICAg ICAgKiBET00vRE9NRWxlbWVudC5tbToKKyAgICAgICAgKC1bRE9NRWxlbWVudCByZXF1ZXN0UG9p bnRlckxvY2tdKTogRGVsZXRlZC4KKyAgICAgICAgKiBET00vRE9NTW91c2VFdmVudC5tbToKKyAg ICAgICAgKC1bRE9NTW91c2VFdmVudCBtb3ZlbWVudFhdKTogRGVsZXRlZC4KKyAgICAgICAgKC1b RE9NTW91c2VFdmVudCBtb3ZlbWVudFldKTogRGVsZXRlZC4KKwogMjAxNi0xMi0wOSAgUnlvc3Vr ZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBkb2N1bWVudC53ZWJraXRGdWxs c2NyZWVuRWxlbWVudCBsZWFrcyBlbGVtZW50cyBpbnNpZGUgYSBzaGFkb3cgdHJlZQpJbmRleDog U291cmNlL1dlYktpdC9tYWMvRE9NL0RPTURvY3VtZW50Lm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvbWFjL0RPTS9ET01Eb2N1bWVudC5tbQkocmV2aXNpb24gMjA5NjI4KQorKysgU291 cmNlL1dlYktpdC9tYWMvRE9NL0RPTURvY3VtZW50Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zNzgs MTYgKzM3OCw2IEBAIC0gKERPTUVsZW1lbnQgKil3ZWJraXRGdWxsc2NyZWVuRWxlbWVudAogCiAj ZW5kaWYKIAotI2lmIEVOQUJMRShQT0lOVEVSX0xPQ0spCi0KLS0gKERPTUVsZW1lbnQgKilwb2lu dGVyTG9ja0VsZW1lbnQKLXsKLSAgICBXZWJDb3JlOjpKU01haW5UaHJlYWROdWxsU3RhdGUgc3Rh dGU7Ci0gICAgcmV0dXJuIGtpdChXVEY6OmdldFB0cihJTVBMLT5wb2ludGVyTG9ja0VsZW1lbnQo KSkpOwotfQotCi0jZW5kaWYKLQogLSAoTlNTdHJpbmcgKil2aXNpYmlsaXR5U3RhdGUKIHsKICAg ICBXZWJDb3JlOjpKU01haW5UaHJlYWROdWxsU3RhdGUgc3RhdGU7CkBAIC03MjUsMTYgKzcxNSw2 IEBAIC0gKHZvaWQpd2Via2l0RXhpdEZ1bGxzY3JlZW4KIAogI2VuZGlmCiAKLSNpZiBFTkFCTEUo UE9JTlRFUl9MT0NLKQotCi0tICh2b2lkKWV4aXRQb2ludGVyTG9jawotewotICAgIFdlYkNvcmU6 OkpTTWFpblRocmVhZE51bGxTdGF0ZSBzdGF0ZTsKLSAgICBJTVBMLT5leGl0UG9pbnRlckxvY2so KTsKLX0KLQotI2VuZGlmCi0KIC0gKERPTUVsZW1lbnQgKilnZXRFbGVtZW50QnlJZDooTlNTdHJp bmcgKillbGVtZW50SWQKIHsKICAgICBXZWJDb3JlOjpKU01haW5UaHJlYWROdWxsU3RhdGUgc3Rh dGU7CkluZGV4OiBTb3VyY2UvV2ViS2l0L21hYy9ET00vRE9NRWxlbWVudC5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9ET00vRE9NRWxlbWVudC5tbQkocmV2aXNpb24gMjA5NjI3 KQorKysgU291cmNlL1dlYktpdC9tYWMvRE9NL0RPTUVsZW1lbnQubW0JKHdvcmtpbmcgY29weSkK QEAgLTQ1MywxNiArNDUzLDYgQEAgLSAodm9pZCl3ZWJraXRSZXF1ZXN0RnVsbHNjcmVlbgogCiAj ZW5kaWYKIAotI2lmIEVOQUJMRShQT0lOVEVSX0xPQ0spCi0KLS0gKHZvaWQpcmVxdWVzdFBvaW50 ZXJMb2NrCi17Ci0gICAgSlNNYWluVGhyZWFkTnVsbFN0YXRlIHN0YXRlOwotICAgIHVud3JhcCgq c2VsZikucmVxdWVzdFBvaW50ZXJMb2NrKCk7Ci19Ci0KLSNlbmRpZgotCiAtICh2b2lkKXJlbW92 ZQogewogICAgIEpTTWFpblRocmVhZE51bGxTdGF0ZSBzdGF0ZTsKSW5kZXg6IFNvdXJjZS9XZWJL aXQvbWFjL0RPTS9ET01Nb3VzZUV2ZW50Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv bWFjL0RPTS9ET01Nb3VzZUV2ZW50Lm1tCShyZXZpc2lvbiAyMDk2MjcpCisrKyBTb3VyY2UvV2Vi S2l0L21hYy9ET00vRE9NTW91c2VFdmVudC5tbQkod29ya2luZyBjb3B5KQpAQCAtMTA0LDIyICsx MDQsNiBAQCAtIChpZCA8RE9NRXZlbnRUYXJnZXQ+KXJlbGF0ZWRUYXJnZXQKICAgICByZXR1cm4g a2l0KFdURjo6Z2V0UHRyKElNUEwtPnJlbGF0ZWRUYXJnZXQoKSkpOwogfQogCi0jaWYgRU5BQkxF KFBPSU5URVJfTE9DSykKLS0gKGludCltb3ZlbWVudFgKLXsKLSAgICBXZWJDb3JlOjpKU01haW5U aHJlYWROdWxsU3RhdGUgc3RhdGU7Ci0gICAgcmV0dXJuIElNUEwtPm1vdmVtZW50WCgpOwotfQot I2VuZGlmCi0KLSNpZiBFTkFCTEUoUE9JTlRFUl9MT0NLKQotLSAoaW50KW1vdmVtZW50WQotewot ICAgIFdlYkNvcmU6OkpTTWFpblRocmVhZE51bGxTdGF0ZSBzdGF0ZTsKLSAgICByZXR1cm4gSU1Q TC0+bW92ZW1lbnRZKCk7Ci19Ci0jZW5kaWYKLQogLSAoaW50KW9mZnNldFgKIHsKICAgICBXZWJD b3JlOjpKU01haW5UaHJlYWROdWxsU3RhdGUgc3RhdGU7Cg==