165648 2016-12-08 20:13:23 -0800 Web Inspector: Frontend should not be resetting TypeProfiler state when switching between ContentViews 2016-12-09 14:44:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1258047 0 joepeck 2016-12-08 20:13:23 -0800 Summary: Frontend should not be resetting TypeProfiler state when switching between ContentViews Right now, every time we switch between two different resources we are sending Runtime.disableTypeProfiler / Runtime.disableControlFlowProfiler (or enable if the feature is on). We should only be toggling the backends when the state changes, not for every single resource. Steps to Reproduce: 1. Inspect this page 2. Select a JavaScript Resource => Runtime commands sent 3. Select another JavaScript Resource => The same Runtime commands are sent 1258049 1 296628 joepeck 2016-12-08 20:21:29 -0800 Created attachment 296628 [PATCH] Proposed Fix 1258326 2 bburg 2016-12-09 14:12:09 -0800 <rdar://problem/29602027> 1258332 3 nvasilyev 2016-12-09 14:18:01 -0800 Looks good! I was planning on doing very similar change in bug 163345: Web Inspector: Disable Type and Code Coverage profilers while timeline is being recorded. 1258333 4 296628 bburg 2016-12-09 14:18:21 -0800 Comment on attachment 296628 [PATCH] Proposed Fix rs=me 1258357 5 296628 commit-queue 2016-12-09 14:44:24 -0800 Comment on attachment 296628 [PATCH] Proposed Fix Clearing flags on attachment: 296628 Committed r209631: <http://trac.webkit.org/changeset/209631> 1258359 6 commit-queue 2016-12-09 14:44:28 -0800 All reviewed patches have been landed. Closing bug. 296628 2016-12-08 20:21:29 -0800 2016-12-09 14:44:24 -0800 [PATCH] Proposed Fix setting-1.patch text/plain 5335 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDE2OGNhMTguLjAyZGRlZTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEyLTA4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRnJvbnRl bmQgc2hvdWxkIG5vdCBiZSByZXNldHRpbmcgVHlwZVByb2ZpbGVyIHN0YXRlIHdoZW4gc3dpdGNo aW5nIGJldHdlZW4gQ29udGVudFZpZXdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjU2NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLmxvYWRlZCk6CisgICAgICAgIFVwZGF0ZSBhbGwgYmFja2VuZHMgd2hlbiB0 aGUgc3RhdGUgY2hhbmdlcy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU291cmNl Q29kZVRleHRFZGl0b3IuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRF ZGl0b3IucHJvdG90eXBlLl9zZXRUeXBlVG9rZW5Bbm5vdGF0b3JFbmFibGVkU3RhdGUpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVUZXh0RWRpdG9yLnByb3RvdHlwZS5zZXQgX2Jh c2ljQmxvY2tBbm5vdGF0b3JFbmFibGVkKToKKyAgICAgICAgTW92ZWQgdGhpcyBjb2RlIHRvIHdo ZW4gdGhlIGdsb2JhbCBTZXR0aW5nICh3aGljaCBhZmZlY3RzIGFsbCBlZGl0b3JzKSBjaGFuZ2Vz LgorCiAyMDE2LTEyLTA3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogU29tZSByZXNvdXJjZXMgZmV0Y2hlZCB2aWEgRmV0Y2gg QVBJIGRvIG5vdCBoYXZlIGRhdGEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCBjNTc1MTlmLi40OWY0ZjQ1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0xNjcsMTAg KzE2NywxMiBAQCBXZWJJbnNwZWN0b3IubG9hZGVkID0gZnVuY3Rpb24oKQogCiAgICAgLy8gQ09N UEFUSUJJTElUWSAoaU9TIDgpOiBQYWdlLmVuYWJsZVR5cGVQcm9maWxlciBkaWQgbm90IGV4aXN0 LgogICAgIHRoaXMuc2hvd0phdmFTY3JpcHRUeXBlSW5mb3JtYXRpb25TZXR0aW5nID0gbmV3IFdl Ykluc3BlY3Rvci5TZXR0aW5nKCJzaG93LWphdmFzY3JpcHQtdHlwZS1pbmZvcm1hdGlvbiIsIGZh bHNlKTsKKyAgICB0aGlzLnNob3dKYXZhU2NyaXB0VHlwZUluZm9ybWF0aW9uU2V0dGluZy5hZGRF dmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5TZXR0aW5nLkV2ZW50LkNoYW5nZWQsIHRoaXMuX3No b3dKYXZhU2NyaXB0VHlwZUluZm9ybWF0aW9uU2V0dGluZ0NoYW5nZWQsIHRoaXMpOwogICAgIGlm ICh0aGlzLnNob3dKYXZhU2NyaXB0VHlwZUluZm9ybWF0aW9uU2V0dGluZy52YWx1ZSAmJiB3aW5k b3cuUnVudGltZUFnZW50ICYmIFJ1bnRpbWVBZ2VudC5lbmFibGVUeXBlUHJvZmlsZXIpCiAgICAg ICAgIFJ1bnRpbWVBZ2VudC5lbmFibGVUeXBlUHJvZmlsZXIoKTsKIAogICAgIHRoaXMuZW5hYmxl Q29udHJvbEZsb3dQcm9maWxlclNldHRpbmcgPSBuZXcgV2ViSW5zcGVjdG9yLlNldHRpbmcoImVu YWJsZS1jb250cm9sLWZsb3ctcHJvZmlsZXIiLCBmYWxzZSk7CisgICAgdGhpcy5lbmFibGVDb250 cm9sRmxvd1Byb2ZpbGVyU2V0dGluZy5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5TZXR0 aW5nLkV2ZW50LkNoYW5nZWQsIHRoaXMuX2VuYWJsZUNvbnRyb2xGbG93UHJvZmlsZXJTZXR0aW5n Q2hhbmdlZCwgdGhpcyk7CiAgICAgaWYgKHRoaXMuZW5hYmxlQ29udHJvbEZsb3dQcm9maWxlclNl dHRpbmcudmFsdWUgJiYgd2luZG93LlJ1bnRpbWVBZ2VudCAmJiBSdW50aW1lQWdlbnQuZW5hYmxl Q29udHJvbEZsb3dQcm9maWxlcikKICAgICAgICAgUnVudGltZUFnZW50LmVuYWJsZUNvbnRyb2xG bG93UHJvZmlsZXIoKTsKIApAQCAtMjA4OSw2ICsyMDkxLDI4IEBAIFdlYkluc3BlY3Rvci5fc2hv d1RhYkF0SW5kZXggPSBmdW5jdGlvbihpLCBldmVudCkKICAgICAgICAgV2ViSW5zcGVjdG9yLnRh YkJhci5zZWxlY3RlZFRhYkJhckl0ZW0gPSBpIC0gMTsKIH07CiAKK1dlYkluc3BlY3Rvci5fc2hv d0phdmFTY3JpcHRUeXBlSW5mb3JtYXRpb25TZXR0aW5nQ2hhbmdlZCA9IGZ1bmN0aW9uKGV2ZW50 KQoreworICAgIGlmICh0aGlzLnNob3dKYXZhU2NyaXB0VHlwZUluZm9ybWF0aW9uU2V0dGluZy52 YWx1ZSkgeworICAgICAgICBmb3IgKGxldCB0YXJnZXQgb2YgV2ViSW5zcGVjdG9yLnRhcmdldHMp CisgICAgICAgICAgICB0YXJnZXQuUnVudGltZUFnZW50LmVuYWJsZVR5cGVQcm9maWxlcigpOwor ICAgIH0gZWxzZSB7CisgICAgICAgIGZvciAobGV0IHRhcmdldCBvZiBXZWJJbnNwZWN0b3IudGFy Z2V0cykKKyAgICAgICAgICAgIHRhcmdldC5SdW50aW1lQWdlbnQuZGlzYWJsZVR5cGVQcm9maWxl cigpOworICAgIH0KK307CisKK1dlYkluc3BlY3Rvci5fZW5hYmxlQ29udHJvbEZsb3dQcm9maWxl clNldHRpbmdDaGFuZ2VkID0gZnVuY3Rpb24oZXZlbnQpCit7CisgICAgaWYgKHRoaXMuZW5hYmxl Q29udHJvbEZsb3dQcm9maWxlclNldHRpbmcudmFsdWUpIHsKKyAgICAgICAgZm9yIChsZXQgdGFy Z2V0IG9mIFdlYkluc3BlY3Rvci50YXJnZXRzKQorICAgICAgICAgICAgdGFyZ2V0LlJ1bnRpbWVB Z2VudC5lbmFibGVDb250cm9sRmxvd1Byb2ZpbGVyKCk7CisgICAgfSBlbHNlIHsKKyAgICAgICAg Zm9yIChsZXQgdGFyZ2V0IG9mIFdlYkluc3BlY3Rvci50YXJnZXRzKQorICAgICAgICAgICAgdGFy Z2V0LlJ1bnRpbWVBZ2VudC5kaXNhYmxlQ29udHJvbEZsb3dQcm9maWxlcigpOworICAgIH0KK307 CisKIFdlYkluc3BlY3Rvci5lbGVtZW50RHJhZ1N0YXJ0ID0gZnVuY3Rpb24oZWxlbWVudCwgZGl2 aWRlckRyYWcsIGVsZW1lbnREcmFnRW5kLCBldmVudCwgY3Vyc29yLCBldmVudFRhcmdldCkKIHsK ICAgICBpZiAoV2ViSW5zcGVjdG9yLl9lbGVtZW50RHJhZ2dpbmdFdmVudExpc3RlbmVyIHx8IFdl Ykluc3BlY3Rvci5fZWxlbWVudEVuZERyYWdnaW5nRXZlbnRMaXN0ZW5lcikKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NvdXJjZUNvZGVUZXh0 RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291 cmNlQ29kZVRleHRFZGl0b3IuanMKaW5kZXggOGI0YTRiMC4uZTRlZGRhNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRF ZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv U291cmNlQ29kZVRleHRFZGl0b3IuanMKQEAgLTIwNjUsMTcgKzIwNjUsMTEgQEAgV2ViSW5zcGVj dG9yLlNvdXJjZUNvZGVUZXh0RWRpdG9yID0gY2xhc3MgU291cmNlQ29kZVRleHRFZGl0b3IgZXh0 ZW5kcyBXZWJJbnNwZWMKICAgICAgICAgaWYgKHNob3VsZEFjdGl2YXRlKSB7CiAgICAgICAgICAg ICBjb25zb2xlLmFzc2VydCh0aGlzLnZpc2libGUsICJBbm5vdGF0b3JzIHNob3VsZCBub3QgYmUg ZW5hYmxlZCBpZiB0aGUgVGV4dEVkaXRvciBpcyBub3QgdmlzaWJsZSIpOwogCi0gICAgICAgICAg ICBmb3IgKGxldCB0YXJnZXQgb2YgV2ViSW5zcGVjdG9yLnRhcmdldHMpCi0gICAgICAgICAgICAg ICAgdGFyZ2V0LlJ1bnRpbWVBZ2VudC5lbmFibGVUeXBlUHJvZmlsZXIoKTsKLQogICAgICAgICAg ICAgdGhpcy5fdHlwZVRva2VuQW5ub3RhdG9yLnJlc2V0KCk7CiAKICAgICAgICAgICAgIGlmICgh dGhpcy5fdHlwZVRva2VuU2Nyb2xsSGFuZGxlcikKICAgICAgICAgICAgICAgICB0aGlzLl9lbmFi bGVTY3JvbGxFdmVudHNGb3JUeXBlVG9rZW5Bbm5vdGF0b3IoKTsKICAgICAgICAgfSBlbHNlIHsK LSAgICAgICAgICAgIGZvciAobGV0IHRhcmdldCBvZiBXZWJJbnNwZWN0b3IudGFyZ2V0cykKLSAg ICAgICAgICAgICAgICB0YXJnZXQuUnVudGltZUFnZW50LmRpc2FibGVUeXBlUHJvZmlsZXIoKTsK LQogICAgICAgICAgICAgdGhpcy5fdHlwZVRva2VuQW5ub3RhdG9yLmNsZWFyKCk7CiAKICAgICAg ICAgICAgIGlmICh0aGlzLl90eXBlVG9rZW5TY3JvbGxIYW5kbGVyKQpAQCAtMjA5NSwxOCArMjA4 OSwxMiBAQCBXZWJJbnNwZWN0b3IuU291cmNlQ29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VD b2RlVGV4dEVkaXRvciBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICBpZiAoc2hvdWxkQWN0aXZh dGUpIHsKICAgICAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KHRoaXMudmlzaWJsZSwgIkFubm90YXRv cnMgc2hvdWxkIG5vdCBiZSBlbmFibGVkIGlmIHRoZSBUZXh0RWRpdG9yIGlzIG5vdCB2aXNpYmxl Iik7CiAKLSAgICAgICAgICAgIGZvciAobGV0IHRhcmdldCBvZiBXZWJJbnNwZWN0b3IudGFyZ2V0 cykKLSAgICAgICAgICAgICAgICB0YXJnZXQuUnVudGltZUFnZW50LmVuYWJsZUNvbnRyb2xGbG93 UHJvZmlsZXIoKTsKLQogICAgICAgICAgICAgY29uc29sZS5hc3NlcnQoIXRoaXMuX2Jhc2ljQmxv Y2tBbm5vdGF0b3IuaXNBY3RpdmUoKSk7CiAgICAgICAgICAgICB0aGlzLl9iYXNpY0Jsb2NrQW5u b3RhdG9yLnJlc2V0KCk7CiAKICAgICAgICAgICAgIGlmICghdGhpcy5fY29udHJvbEZsb3dTY3Jv bGxIYW5kbGVyKQogICAgICAgICAgICAgICAgIHRoaXMuX2VuYWJsZVNjcm9sbEV2ZW50c0ZvckNv bnRyb2xGbG93QW5ub3RhdG9yKCk7CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBmb3Ig KGxldCB0YXJnZXQgb2YgV2ViSW5zcGVjdG9yLnRhcmdldHMpCi0gICAgICAgICAgICAgICAgdGFy Z2V0LlJ1bnRpbWVBZ2VudC5kaXNhYmxlQ29udHJvbEZsb3dQcm9maWxlcigpOwotCiAgICAgICAg ICAgICB0aGlzLl9iYXNpY0Jsb2NrQW5ub3RhdG9yLmNsZWFyKCk7CiAKICAgICAgICAgICAgIGlm ICh0aGlzLl9jb250cm9sRmxvd1Njcm9sbEhhbmRsZXIpCg==