165642 2016-12-08 18:34:33 -0800 FileHandle::printf doesn't build on Windows 2016-12-10 18:16:18 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 krollin krollin commit-queue darin oldest_to_newest 1257996 0 krollin 2016-12-08 18:34:33 -0800 vasprintf doesn't exist on Windows. 1257997 1 296609 krollin 2016-12-08 18:36:30 -0800 Created attachment 296609 Patch 1258015 2 296609 commit-queue 2016-12-08 19:10:30 -0800 Comment on attachment 296609 Patch Clearing flags on attachment: 296609 Committed r209593: <http://trac.webkit.org/changeset/209593> 1258016 3 commit-queue 2016-12-08 19:10:34 -0800 All reviewed patches have been landed. Closing bug. 1258587 4 296609 darin 2016-12-09 21:38:10 -0800 Comment on attachment 296609 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296609&action=review > Source/WebCore/platform/FileHandle.cpp:105 > + // TODO: implement this without relying on vasprintf. > + return false; Looked up how to do it here <http://en.cppreference.com/w/cpp/io/c/vfprintf>: va_list args; va_start(args, format); va_list preflightArgs; va_copy(preflightArgs, args); Vector<char, 1024> buffer { 1 + std::vsnprintf(nullptr, 0, format, preflightArgs) }; va_end(preflightArgs); std::vsnprintf(buffer.data(), buffer.size(), format, args); va_end(args); return write(buffer.data(), strlen(buffer.data())); 1258588 5 darin 2016-12-09 21:38:31 -0800 That version should work fine on other platforms too. 1258803 6 darin 2016-12-10 18:16:18 -0800 I put up a patch with the above code in bug 165740. 296609 2016-12-08 18:36:30 -0800 2016-12-08 19:10:30 -0800 Patch bug-165642-20161208183548.patch text/plain 1631 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjVlMjg5OWNjOTU2M2U0 NWQ2ZTU0YmNhNWI1ZGZjNmY0MWEwMDQ1Ny4uMDI0OTM5MjZlZGU3MTMyYmExMDkxY2I1NTg1ZmNm MzY0YjhiNzQwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEyLTA4ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBGaWxlSGFuZGxlOjpwcmlu dGYgZG9lc24ndCBidWlsZCBvbiBXaW5kb3dzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU2NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBGaXggdGhlIGJ1aWxkIC0tIHZhc3ByaW50ZiBkb2VzIG5vdCBl eGlzdCBvbiBXaW5kb3dzLCBzbyBtYWtlCisgICAgICAgIEZpbGVIYW5kbGU6OnByaW50ZiBhIG5v LW9wIG9uIHRoYXQgcGxhdGZvcm0uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC0tIGFmZmVjdGVk IGZhY2lsaXR5IGlzIGN1cnJlbnRseSBvbmx5IHVzZWQgaW4gdGVzdGluZworICAgICAgICBjb2Rl IGFuZCBpcyBub3QgdXNlciByZWFjaGFibGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9GaWxlSGFu ZGxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZpbGVIYW5kbGU6OnByaW50Zik6CisKIDIwMTYt MTItMDggIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAg ICBBU1NFUlRJT04gRkFJTEVEOiBsb2NhbGUgaW4gV2ViQ29yZTo6bGFzdEh5cGhlbkxvY2F0aW9u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9GaWxlSGFuZGxlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVIYW5kbGUuY3BwCmluZGV4IDQ4MWY0NGU3MDlmZjE2 ZjA1MjJhNDY3ZDU0NjY3NWI5ODkzZmRjMGEuLjJhZjcyNDAwYjg2NjBhODg2YmExZDdiNTk5Zjdk MWU3ODVjMGVlMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVIYW5k bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZpbGVIYW5kbGUuY3BwCkBAIC0x MDAsNiArMTAwLDEwIEBAIGludCBGaWxlSGFuZGxlOjp3cml0ZShjb25zdCB2b2lkKiBkYXRhLCBp bnQgbGVuZ3RoKQogCiBib29sIEZpbGVIYW5kbGU6OnByaW50Zihjb25zdCBjaGFyKiBmb3JtYXQs IC4uLikKIHsKKyNpZiBPUyhXSU5ET1dTKQorICAgIC8vIFRPRE86IGltcGxlbWVudCB0aGlzIHdp dGhvdXQgcmVseWluZyBvbiB2YXNwcmludGYuCisgICAgcmV0dXJuIGZhbHNlOworI2Vsc2UKICAg ICB2YV9saXN0IGFyZ3M7CiAgICAgdmFfc3RhcnQoYXJncywgZm9ybWF0KTsKIApAQCAtMTEyLDYg KzExNiw3IEBAIGJvb2wgRmlsZUhhbmRsZTo6cHJpbnRmKGNvbnN0IGNoYXIqIGZvcm1hdCwgLi4u KQogICAgIHZhX2VuZChhcmdzKTsKIAogICAgIHJldHVybiB3cml0ZVJlc3VsdCA+PSAwOworI2Vu ZGlmCiB9CiAKIHZvaWQgRmlsZUhhbmRsZTo6Y2xvc2UoKQo=