165615 2016-12-08 11:34:25 -0800 Enable JSC restricted options by default in the jsc shell. 2016-12-08 11:44:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren jfbastien keith_miller msaboff saam ysuzuki oldest_to_newest 1257785 0 mark.lam 2016-12-08 11:34:25 -0800 The jsc shell is only used for debugging and development testing. We should allow it to use restricted options like JSC_useDollarVM even for release builds. 1257789 1 296542 mark.lam 2016-12-08 11:37:24 -0800 Created attachment 296542 proposed patch. 1257790 2 296542 keith_miller 2016-12-08 11:40:41 -0800 Comment on attachment 296542 proposed patch. r=me. 1257791 3 mark.lam 2016-12-08 11:44:44 -0800 Thanks for the review. Landed in r209553: <http://trac.webkit.org/r209553>. 296542 2016-12-08 11:37:24 -0800 2016-12-08 11:40:41 -0800 proposed patch. bug-165615.patch text/plain 3270 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5NTUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE2LTEyLTA4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBF bmFibGUgSlNDIHJlc3RyaWN0ZWQgb3B0aW9ucyBieSBkZWZhdWx0IGluIHRoZSBqc2Mgc2hlbGwu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU2MTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUganNj IHNoZWxsIGlzIG9ubHkgdXNlZCBmb3IgZGVidWdnaW5nIGFuZCBkZXZlbG9wbWVudCB0ZXN0aW5n LiAgV2Ugc2hvdWxkCisgICAgICAgIGFsbG93IGl0IHRvIHVzZSByZXN0cmljdGVkIG9wdGlvbnMg bGlrZSBKU0NfdXNlRG9sbGFyVk0gZXZlbiBmb3IgcmVsZWFzZSBidWlsZHMuCisKKyAgICAgICAg KiBqc2MuY3BwOgorICAgICAgICAoanNjbWFpbik6CisgICAgICAgICogcnVudGltZS9PcHRpb25z LmNwcDoKKyAgICAgICAgKEpTQzo6T3B0aW9uczo6ZW5hYmxlUmVzdHJpY3RlZE9wdGlvbnMpOgor ICAgICAgICAoSlNDOjpPcHRpb25zOjppc0F2YWlsYWJsZSk6CisgICAgICAgIChKU0M6OmFsbG93 UmVzdHJpY3RlZE9wdGlvbnMpOiBEZWxldGVkLgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5o OgorCiAyMDE2LTEyLTA4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIwOTQ4OS4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qc2MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2Mu Y3BwCShyZXZpc2lvbiAyMDk0OTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzIxMSw2ICszMjExLDkgQEAgc3RhdGljIGludCBORVZFUl9JTkxJ TkUgcnVuSlNDKFZNKiB2bSwgQwogCiBpbnQganNjbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3Yp CiB7CisgICAgLy8gTmVlZCB0byBvdmVycmlkZSBhbmQgZW5hYmxlIHJlc3RyaWN0ZWQgb3B0aW9u cyBiZWZvcmUgd2Ugc3RhcnQgcGFyc2luZyBvcHRpb25zIGJlbG93LgorICAgIE9wdGlvbnM6OmVu YWJsZVJlc3RyaWN0ZWRPcHRpb25zKHRydWUpOworCiAgICAgLy8gTm90ZSB0aGF0IHRoZSBvcHRp b25zIHBhcnNpbmcgY2FuIGFmZmVjdCBWTSBjcmVhdGlvbiwgYW5kIHRodXMKICAgICAvLyBjb21l cyBmaXJzdC4KICAgICBDb21tYW5kTGluZSBvcHRpb25zKGFyZ2MsIGFyZ3YpOwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAJKHJldmlzaW9uIDIwOTQ5OSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC01NSwxNSArNTUsMTkgQEAKIAogbmFtZXNwYWNlIEpTQyB7CiAKLXN0YXRpYyBib29s IGFsbG93UmVzdHJpY3RlZE9wdGlvbnMoKQoteworbmFtZXNwYWNlIHsKICNpZmRlZiBOREVCVUcK LSAgICByZXR1cm4gZmFsc2U7Citib29sIHJlc3RyaWN0ZWRPcHRpb25zRW5hYmxlZCA9IGZhbHNl OwogI2Vsc2UKLSAgICByZXR1cm4gdHJ1ZTsKK2Jvb2wgcmVzdHJpY3RlZE9wdGlvbnNFbmFibGVk ID0gdHJ1ZTsKICNlbmRpZgogfQogCit2b2lkIE9wdGlvbnM6OmVuYWJsZVJlc3RyaWN0ZWRPcHRp b25zKGJvb2wgZW5hYmxlT3JOb3QpCit7CisgICAgcmVzdHJpY3RlZE9wdGlvbnNFbmFibGVkID0g ZW5hYmxlT3JOb3Q7Cit9CisgICAgCiBzdGF0aWMgYm9vbCBwYXJzZShjb25zdCBjaGFyKiBzdHJp bmcsIGJvb2wmIHZhbHVlKQogewogICAgIGlmICghc3RyY2FzZWNtcChzdHJpbmcsICJ0cnVlIikg fHwgIXN0cmNhc2VjbXAoc3RyaW5nLCAieWVzIikgfHwgIXN0cmNtcChzdHJpbmcsICIxIikpIHsK QEAgLTEyOCw3ICsxMzIsNyBAQCBzdGF0aWMgYm9vbCBwYXJzZShjb25zdCBjaGFyKiBzdHJpbmcs IEdDCiBib29sIE9wdGlvbnM6OmlzQXZhaWxhYmxlKE9wdGlvbnM6OklEIGlkLCBPcHRpb25zOjpB dmFpbGFiaWxpdHkgYXZhaWxhYmlsaXR5KQogewogICAgIGlmIChhdmFpbGFiaWxpdHkgPT0gQXZh aWxhYmlsaXR5OjpSZXN0cmljdGVkKQotICAgICAgICByZXR1cm4gYWxsb3dSZXN0cmljdGVkT3B0 aW9ucygpOworICAgICAgICByZXR1cm4gcmVzdHJpY3RlZE9wdGlvbnNFbmFibGVkOwogICAgIEFT U0VSVChhdmFpbGFiaWxpdHkgPT0gQXZhaWxhYmlsaXR5OjpDb25maWd1cmFibGUpOwogICAgIAog ICAgIFVOVVNFRF9QQVJBTShpZCk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv T3B0aW9ucy5oCShyZXZpc2lvbiAyMDk0OTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTUwNiw2ICs1MDYsOCBAQCBwdWJsaWM6 CiAKICAgICBKU19FWFBPUlRfUFJJVkFURSBzdGF0aWMgdm9pZCBlbnN1cmVPcHRpb25zQXJlQ29o ZXJlbnQoKTsKIAorICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyB2b2lkIGVuYWJsZVJlc3Ry aWN0ZWRPcHRpb25zKGJvb2wgZW5hYmxlT3JOb3QpOworCiAgICAgLy8gRGVjbGFyZSBhY2Nlc3Nv cnMgZm9yIGVhY2ggb3B0aW9uOgogI2RlZmluZSBGT1JfRUFDSF9PUFRJT04odHlwZV8sIG5hbWVf LCBkZWZhdWx0VmFsdWVfLCBhdmFpbGFiaWxpdHlfLCBkZXNjcmlwdGlvbl8pIFwKICAgICBBTFdB WVNfSU5MSU5FIHN0YXRpYyB0eXBlXyYgbmFtZV8oKSB7IHJldHVybiBzX29wdGlvbnNbbmFtZV8j I0lEXS50eXBlXyMjVmFsOyB9IFwK