165603 2016-12-08 08:19:02 -0800 Implement CSS `display: flow-root` (modern clearfix) 2019-05-17 21:29:56 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build All All RESOLVED FIXED https://bugzilla.mozilla.org/show_bug.cgi?id=1322191 https://bugs.chromium.org/p/chromium/issues/detail?id=672508 https://drafts.csswg.org/css-display-3/#valdef-display-flow-root InRadar, WebExposed P2 Enhancement --- 1 mtanalin jh718.park commit-queue darin dino eoconnor gyuyoung.kim jh718.park Justin koivisto m.kurz+webkitbugs murakami simon.fraser webkit-bug-importer webkit.bugzilla webkit zalan oldest_to_newest 1257701 0 mtanalin 2016-12-08 08:19:02 -0800 `display: flow-root` is a modern way to force a block to be a formatting context that floated elements are contained in (aka clearfix). From the spec [1]: > The element generates a block container box, and lays out its contents using flow layout. It always establishes a new block formatting context for its contents. Tab Atkins and Elika Etemad (fantasai) from CSSWG consider the feature stable enough to be implemented [2]. [1] https://drafts.csswg.org/css-display-3/#valdef-display-flow-root [2] https://discourse.wicg.io/t/1835/6 1264823 1 webkit-bug-importer 2017-01-08 10:12:47 -0800 <rdar://problem/29918759> 1536302 2 369909 jh718.park 2019-05-14 16:49:16 -0700 Created attachment 369909 Patch 1536659 3 jh718.park 2019-05-15 16:26:25 -0700 Could you please review this change? 1536667 4 369909 simon.fraser 2019-05-15 16:57:19 -0700 Comment on attachment 369909 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369909&action=review > Source/WebCore/css/StyleResolver.cpp:699 > + case DisplayType::FlowRoot: Is this change sufficient to get the behavior described in the spec? It's unclear to me if this change is complete. 1536801 5 369909 jh718.park 2019-05-16 08:03:42 -0700 Comment on attachment 369909 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369909&action=review >> Source/WebCore/css/StyleResolver.cpp:699 >> + case DisplayType::FlowRoot: > > Is this change sufficient to get the behavior described in the spec? It's unclear to me if this change is complete. The 'flow-root' spec says that if it is specified it creates a new block formatting context. https://www.w3.org/TR/CSS2/visuren.html#normal-flow specifies the condition which when BFC is created, and the conditions are listed in RenderBox::createsNewFormattingContext(). So I added flow-root to the end of the list of the conditions for creating BFC as below. bool RenderBox::createsNewFormattingContext() const { return isInlineBlockOrInlineTable() || isFloatingOrOutOfFlowPositioned() || hasOverflowClip() || isFlexItemIncludingDeprecated() || isTableCell() || isTableCaption() || isFieldset() || isWritingModeRoot() || isDocumentElementRenderer() || isRenderFragmentedFlow() || isRenderFragmentContainer() || isGridItem() || style().specifiesColumns() || style().columnSpan() == ColumnSpan::All || style().display() == DisplayType::FlowRoot; } BFC creation is addressed above, so I think FlowRoot display type works as expected and this change is sufficient. But if I missed something, please let me know:) 1536843 6 simon.fraser 2019-05-16 11:08:11 -0700 Is the WPT enough to test the behavior of flow and flow-root? 1537001 7 369909 zalan 2019-05-16 19:27:53 -0700 Comment on attachment 369909 Patch Unfortunately we can't explicitly say that this block level box should establish a block formatting context, instead the combination of the renderer type (RenderBlock in this case) and its children will imply the type of layout (e.g. inline vs block). ::createsNewFormattingContext() is really mostly used to check against float intruding and avoiding. So while this patch is fine in this context, we really lack some fundamental CSS basics in our codebase. 1537082 8 jh718.park 2019-05-17 04:24:17 -0700 (In reply to Simon Fraser (smfr) from comment #6) > Is the WPT enough to test the behavior of flow and flow-root? Yes, the WPT test includes 5 sub test and I think they are testing the expected behavior for flow-root and flow well. 1537083 9 jh718.park 2019-05-17 04:34:09 -0700 (In reply to zalan from comment #7) > Comment on attachment 369909 [details] > Patch > > Unfortunately we can't explicitly say that this block level box should > establish a block formatting context, instead the combination of the > renderer type (RenderBlock in this case) and its children will imply the > type of layout (e.g. inline vs block). ::createsNewFormattingContext() is > really mostly used to check against float intruding and avoiding. So while > this patch is fine in this context, we really lack some fundamental CSS > basics in our codebase. For supporting more CSS basic things, I will make a bug in jira if needed, or if there are existing bugs, I will check that to try to address it. Thank you for your review Zalan:) 1537179 10 zalan 2019-05-17 11:26:40 -0700 (In reply to Joonghun Park from comment #9) > (In reply to zalan from comment #7) > > Comment on attachment 369909 [details] > > Patch > > > > Unfortunately we can't explicitly say that this block level box should > > establish a block formatting context, instead the combination of the > > renderer type (RenderBlock in this case) and its children will imply the > > type of layout (e.g. inline vs block). ::createsNewFormattingContext() is > > really mostly used to check against float intruding and avoiding. So while > > this patch is fine in this context, we really lack some fundamental CSS > > basics in our codebase. > > For supporting more CSS basic things, I will make a bug in jira if needed, > or if there are existing bugs, I will check that to try to address it. > Thank you for your review Zalan:) No I don't have a bug on this but the LFC code (WebCore/layout) is meant to fix all these visual formatting model fundamentals. 1537373 11 jh718.park 2019-05-17 21:00:41 -0700 (In reply to zalan from comment #10) > (In reply to Joonghun Park from comment #9) > > (In reply to zalan from comment #7) > > > Comment on attachment 369909 [details] > > > Patch > > > > > > Unfortunately we can't explicitly say that this block level box should > > > establish a block formatting context, instead the combination of the > > > renderer type (RenderBlock in this case) and its children will imply the > > > type of layout (e.g. inline vs block). ::createsNewFormattingContext() is > > > really mostly used to check against float intruding and avoiding. So while > > > this patch is fine in this context, we really lack some fundamental CSS > > > basics in our codebase. > > > > For supporting more CSS basic things, I will make a bug in jira if needed, > > or if there are existing bugs, I will check that to try to address it. > > Thank you for your review Zalan:) > No I don't have a bug on this but the LFC code (WebCore/layout) is meant to > fix all these visual formatting model fundamentals. I can see the patches with tag [LFC] in log. I will read that patches and follow up the changes. Thank you:) 1537377 12 369909 commit-queue 2019-05-17 21:29:54 -0700 Comment on attachment 369909 Patch Clearing flags on attachment: 369909 Committed r245494: <https://trac.webkit.org/changeset/245494> 1537378 13 commit-queue 2019-05-17 21:29:56 -0700 All reviewed patches have been landed. Closing bug. 369909 2019-05-14 16:49:16 -0700 2019-05-17 21:29:54 -0700 Patch bug-165603-20190515084915.patch text/plain 10057 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1Mjc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGYzMDAxMWY3MzkyZmIy MTgwN2Y2MWFjYmRhYTVlMDg1ODUzZGY4OS4uNjg0NzljMTE4YTNlMGVhNDU1YjY3NjkxNDE3YjJk NzFkNGNhMTQxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE5LTA1LTE0ICBKb29u Z2h1biBQYXJrICA8cGpoMDcxOEBnbWFpbC5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IENTUyBg ZGlzcGxheTogZmxvdy1yb290YCAobW9kZXJuIGNsZWFyZml4KQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NjAzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgZm9sbG93cyBodHRwczov L2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLWRpc3BsYXktMy8jdmFsZGVmLWRpc3BsYXktZmxvdy1yb290 IGFzIGJlbG93LgorCisgICAgICAgICdkaXNwbGF5OiBmbG93LXJvb3QnIGdlbmVyYXRlcyBhIGJs b2NrIGNvbnRhaW5lciBib3gsIGFuZCBsYXlzIG91dCBpdHMgY29udGVudHMgdXNpbmcgZmxvdyBs YXlvdXQuCisgICAgICAgIEl0IGFsd2F5cyBlc3RhYmxpc2hlcyBhIG5ldyBibG9jayBmb3JtYXR0 aW5nIGNvbnRleHQgZm9yIGl0cyBjb250ZW50cy4KKworICAgICAgICAqIGNzcy9DU1NQcmltaXRp dmVWYWx1ZU1hcHBpbmdzLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmltaXRpdmVWYWx1ZTo6 Q1NTUHJpbWl0aXZlVmFsdWUpOgorICAgICAgICAqIGNzcy9DU1NWYWx1ZUtleXdvcmRzLmluOgor ICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmVxdWl2 YWxlbnRCbG9ja0Rpc3BsYXkpOgorICAgICAgICAqIGNzcy9wYXJzZXIvQ1NTUGFyc2VyRmFzdFBh dGhzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlckZhc3RQYXRoczo6aXNWYWxpZEtl eXdvcmRQcm9wZXJ0eUFuZFZhbHVlKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6Y3JlYXRlc05ld0Zvcm1hdHRpbmdDb250 ZXh0IGNvbnN0KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJFbGVtZW50OjpjcmVhdGVGb3IpOgorICAgICAgICAqIHJlbmRl cmluZy9zdHlsZS9SZW5kZXJTdHlsZUNvbnN0YW50cy5oOgorCiAyMDE5LTA1LTE0ICBKb29uZ2h1 biBQYXJrICA8cGpoMDcxOEBnbWFpbC5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IHBhZ2UtYnJl YWstKiBhbmQgLXdlYmtpdC1jb2x1bW4tYnJlYWstKiBhcyBsZWdhY3ktc2hvcnRoYW5kcy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGVhZmEyMTU1ODUxMjRmYzQ4ODA3MDIyZmUwNTQxZWQz YzJkM2FkN2UuLjhlYzMwZjk1NTg1ZTI5MTllZTc0MjRmYTI0YTZjOWJiYjQxMGZmZTQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA1LTE0ICBKb29uZ2h1 biBQYXJrICA8cGpoMDcxOEBnbWFpbC5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IENTUyBgZGlz cGxheTogZmxvdy1yb290YCAobW9kZXJuIGNsZWFyZml4KQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NjAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgZm9sbG93cyBodHRwczovL2Ry YWZ0cy5jc3N3Zy5vcmcvY3NzLWRpc3BsYXktMy8jdmFsZGVmLWRpc3BsYXktZmxvdy1yb290IGFz IGJlbG93LgorCisgICAgICAgICdkaXNwbGF5OiBmbG93LXJvb3QnIGdlbmVyYXRlcyBhIGJsb2Nr IGNvbnRhaW5lciBib3gsIGFuZCBsYXlzIG91dCBpdHMgY29udGVudHMgdXNpbmcgZmxvdyBsYXlv dXQuCisgICAgICAgIEl0IGFsd2F5cyBlc3RhYmxpc2hlcyBhIG5ldyBibG9jayBmb3JtYXR0aW5n IGNvbnRleHQgZm9yIGl0cyBjb250ZW50cy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvRXh0 ZXJuYWwvQ29kZU1pcnJvci9jc3MuanM6CisKIDIwMTktMDUtMDkgIERldmluIFJvdXNzbyAgPGRy b3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVuY2F1Z2h0IEV4Y2Vw dGlvbjogbnVsbCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICdyZXNvdXJjZS5wYXJlbnRG cmFtZS5zZWN1cml0eU9yaWdpbicpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2 ZVZhbHVlTWFwcGluZ3MuaAppbmRleCBmNjA4Y2ZlMTM3ODIwZDIzNzAwZjBmMDNjN2I1NmQ3OWUx NDdiMDE5Li45ZDEyMGNhNWU4MjNjNWEyYzIwOTIyNTlkMGE4MGRhMDkzYjZkMzUzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgKQEAgLTE0MDks NiArMTQwOSw5IEBAIHRlbXBsYXRlPD4gaW5saW5lIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmlt aXRpdmVWYWx1ZShEaXNwbGF5VHlwZSBlKQogICAgIGNhc2UgRGlzcGxheVR5cGU6OkNvbnRlbnRz OgogICAgICAgICBtX3ZhbHVlLnZhbHVlSUQgPSBDU1NWYWx1ZUNvbnRlbnRzOwogICAgICAgICBi cmVhazsKKyAgICBjYXNlIERpc3BsYXlUeXBlOjpGbG93Um9vdDoKKyAgICAgICAgbV92YWx1ZS52 YWx1ZUlEID0gQ1NTVmFsdWVGbG93Um9vdDsKKyAgICAgICAgYnJlYWs7CiAgICAgfQogfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbiBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUtleXdvcmRzLmluCmluZGV4IDVhZmUzNTZlMGIwM2QyNzM3 OGYxNDZlOGIyN2IyNjNhODlkYWRjODIuLmU5MTkyZDMzMDRiYzgxOWIxZGNmMjEwODBhMjU3ODE4 ZjdiM2ZlYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUtleXdvcmRz LmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUtleXdvcmRzLmluCkBAIC00NTQs NiArNDU0LDcgQEAgaW5saW5lLWZsZXgKIGNvbnRlbnRzCiBncmlkCiBpbmxpbmUtZ3JpZAorZmxv dy1yb290CiAvL25vbmUKIC8vCiAvLyBDU1NfUFJPUF9DVVJTT1I6CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5 bGVSZXNvbHZlci5jcHAKaW5kZXggMmRhNWVjMTE0YzRiOGEzNzEzNDJiNTI1MDM0MDdlMTI3M2Ew OTZiYi4uNGU4MTEzZjVjZGMxOTVlOWM4OTdlZGIyMjIxYmFhOTQwNzdlZjZlZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAtNjk2LDYgKzY5Niw3IEBAIHN0YXRpYyBEaXNw bGF5VHlwZSBlcXVpdmFsZW50QmxvY2tEaXNwbGF5KGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZSwg Y29uc3QgRG9jdW1lCiAgICAgY2FzZSBEaXNwbGF5VHlwZTo6RmxleDoKICAgICBjYXNlIERpc3Bs YXlUeXBlOjpXZWJLaXRGbGV4OgogICAgIGNhc2UgRGlzcGxheVR5cGU6OkdyaWQ6CisgICAgY2Fz ZSBEaXNwbGF5VHlwZTo6Rmxvd1Jvb3Q6CiAgICAgICAgIHJldHVybiBkaXNwbGF5OwogCiAgICAg Y2FzZSBEaXNwbGF5VHlwZTo6TGlzdEl0ZW06CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9j c3MvcGFyc2VyL0NTU1BhcnNlckZhc3RQYXRocy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFy c2VyL0NTU1BhcnNlckZhc3RQYXRocy5jcHAKaW5kZXggYTBhMGUzMTk5MDgyNTA2MGQ5YmJjMTBh OGI3NDgyNTZmMzVkZGIyNC4uYTIwMTc2NTI4ZGExMDk5ZjE5MGMwMmRkOWZkYzk4YjMwOGZhMmNm MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXJGYXN0UGF0 aHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUGFyc2VyRmFzdFBhdGhz LmNwcApAQCAtNTc3LDcgKzU3Nyw3IEBAIGJvb2wgQ1NTUGFyc2VyRmFzdFBhdGhzOjppc1ZhbGlk S2V5d29yZFByb3BlcnR5QW5kVmFsdWUoQ1NTUHJvcGVydHlJRCBwcm9wZXJ0eUlkCiAgICAgICAg IC8vIHRhYmxlLWNvbHVtbi1ncm91cCB8IHRhYmxlLWNvbHVtbiB8IHRhYmxlLWNlbGwgfCB0YWJs ZS1jYXB0aW9uIHwgLXdlYmtpdC1ib3ggfCAtd2Via2l0LWlubGluZS1ib3ggfCBub25lCiAgICAg ICAgIC8vIGZsZXggfCBpbmxpbmUtZmxleCB8IC13ZWJraXQtZmxleCB8IC13ZWJraXQtaW5saW5l LWZsZXggfCBncmlkIHwgaW5saW5lLWdyaWQKICAgICAgICAgcmV0dXJuICh2YWx1ZUlEID49IENT U1ZhbHVlSW5saW5lICYmIHZhbHVlSUQgPD0gQ1NTVmFsdWVDb250ZW50cykgfHwgdmFsdWVJRCA9 PSBDU1NWYWx1ZU5vbmUKLSAgICAgICAgICAgIHx8IHZhbHVlSUQgPT0gQ1NTVmFsdWVHcmlkIHx8 IHZhbHVlSUQgPT0gQ1NTVmFsdWVJbmxpbmVHcmlkOworICAgICAgICAgICAgfHwgdmFsdWVJRCA9 PSBDU1NWYWx1ZUdyaWQgfHwgdmFsdWVJRCA9PSBDU1NWYWx1ZUlubGluZUdyaWQgfHwgdmFsdWVJ RCA9PSBDU1NWYWx1ZUZsb3dSb290OwogICAgIGNhc2UgQ1NTUHJvcGVydHlEb21pbmFudEJhc2Vs aW5lOgogICAgICAgICAvLyBhdXRvIHwgdXNlLXNjcmlwdCB8IG5vLWNoYW5nZSB8IHJlc2V0LXNp emUgfCBpZGVvZ3JhcGhpYyB8CiAgICAgICAgIC8vIGFscGhhYmV0aWMgfCBoYW5naW5nIHwgbWF0 aGVtYXRpY2FsIHwgY2VudHJhbCB8IG1pZGRsZSB8CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCb3guY3BwCmluZGV4IGI2YmI3ZTFkM2NlNmFkMGYxMzhiMWFiYzhmNzZkNzU3MmI5NTY4ZjYu LmRlMmZlMzc0MDg5ZTJjNTgzMTQyYzIyMTI5NzI0ZmJiNDBmZDMyZWEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCkBAIC00NTEwLDcgKzQ1MTAsNyBAQCBib29sIFJlbmRl ckJveDo6Y3JlYXRlc05ld0Zvcm1hdHRpbmdDb250ZXh0KCkgY29uc3QKIHsKICAgICByZXR1cm4g aXNJbmxpbmVCbG9ja09ySW5saW5lVGFibGUoKSB8fCBpc0Zsb2F0aW5nT3JPdXRPZkZsb3dQb3Np dGlvbmVkKCkgfHwgaGFzT3ZlcmZsb3dDbGlwKCkgfHwgaXNGbGV4SXRlbUluY2x1ZGluZ0RlcHJl Y2F0ZWQoKQogICAgICAgICB8fCBpc1RhYmxlQ2VsbCgpIHx8IGlzVGFibGVDYXB0aW9uKCkgfHwg aXNGaWVsZHNldCgpIHx8IGlzV3JpdGluZ01vZGVSb290KCkgfHwgaXNEb2N1bWVudEVsZW1lbnRS ZW5kZXJlcigpIHx8IGlzUmVuZGVyRnJhZ21lbnRlZEZsb3coKSB8fCBpc1JlbmRlckZyYWdtZW50 Q29udGFpbmVyKCkKLSAgICAgICAgfHwgaXNHcmlkSXRlbSgpIHx8IHN0eWxlKCkuc3BlY2lmaWVz Q29sdW1ucygpIHx8IHN0eWxlKCkuY29sdW1uU3BhbigpID09IENvbHVtblNwYW46OkFsbDsKKyAg ICAgICAgfHwgaXNHcmlkSXRlbSgpIHx8IHN0eWxlKCkuc3BlY2lmaWVzQ29sdW1ucygpIHx8IHN0 eWxlKCkuY29sdW1uU3BhbigpID09IENvbHVtblNwYW46OkFsbCB8fCBzdHlsZSgpLmRpc3BsYXko KSA9PSBEaXNwbGF5VHlwZTo6Rmxvd1Jvb3Q7CiB9CiAKIGJvb2wgUmVuZGVyQm94Ojphdm9pZHNG bG9hdHMoKSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3Bw CmluZGV4IDFhNDBmYjI2OGZhMzA1NDA4ZWMzYjVjOWY4YzZhYTIwMThmYjg4YjEuLjZlZTY3YzUy YjlmM2Y2OWRmMGRhODMyMzQ2NTMyY2QzYjBmZmI5NmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKQEAgLTE1OCw2ICsxNTgsNyBAQCBSZW5kZXJQdHI8UmVu ZGVyRWxlbWVudD4gUmVuZGVyRWxlbWVudDo6Y3JlYXRlRm9yKEVsZW1lbnQmIGVsZW1lbnQsIFJl bmRlclN0eWxlJgogICAgICAgICAgICAgcmV0dXJuIGNyZWF0ZVJlbmRlcmVyPFJlbmRlcklubGlu ZT4oZWxlbWVudCwgV1RGTW92ZShzdHlsZSkpOwogICAgICAgICBGQUxMVEhST1VHSDsgLy8gRmll bGRzZXRzIHNob3VsZCBtYWtlIGEgYmxvY2sgZmxvdyBpZiBkaXNwbGF5OmlubGluZSBpcyBzZXQu CiAgICAgY2FzZSBEaXNwbGF5VHlwZTo6QmxvY2s6CisgICAgY2FzZSBEaXNwbGF5VHlwZTo6Rmxv d1Jvb3Q6CiAgICAgY2FzZSBEaXNwbGF5VHlwZTo6SW5saW5lQmxvY2s6CiAgICAgY2FzZSBEaXNw bGF5VHlwZTo6Q29tcGFjdDoKICAgICAgICAgcmV0dXJuIGNyZWF0ZVJlbmRlcmVyPFJlbmRlckJs b2NrRmxvdz4oZWxlbWVudCwgV1RGTW92ZShzdHlsZSkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlQ29uc3RhbnRzLmggYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGVDb25zdGFudHMuaAppbmRleCA2NGUzY2U5 NTQ3ZmRmOTJiOTQ0NDAzM2E0MmIxOGVlNmU1NmY4ZDFiLi42ZDZmZmJlNTkxN2IzZjUyYjA5ZGNm ODJkYmQ0ZWRlNzQxZWNmOGJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3R5bGUvUmVuZGVyU3R5bGVDb25zdGFudHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvc3R5bGUvUmVuZGVyU3R5bGVDb25zdGFudHMuaApAQCAtODc2LDYgKzg3Niw3IEBAIGVudW0g Y2xhc3MgRGlzcGxheVR5cGUgOiB1aW50OF90IHsKICAgICBDb250ZW50cywKICAgICBHcmlkLAog ICAgIElubGluZUdyaWQsCisgICAgRmxvd1Jvb3QsCiAgICAgTm9uZQogfTsKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRXh0ZXJuYWwvQ29kZU1pcnJv ci9jc3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9FeHRlcm5hbC9D b2RlTWlycm9yL2Nzcy5qcwppbmRleCAzZWIyMjUwMGExNmNhM2RjY2VjNTA3MzcyMDlkZjZjODJk MGRlZWNmLi5jNGVlNDQ4NzgzZTUyYjdjMmQ3MTcyYzFiMzdmYWEwZDFjMzg4MDU4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9FeHRlcm5hbC9Db2RlTWly cm9yL2Nzcy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9FeHRl cm5hbC9Db2RlTWlycm9yL2Nzcy5qcwpAQCAtNjE0LDcgKzYxNCw3IEBAIENvZGVNaXJyb3IuZGVm aW5lTW9kZSgiY3NzIiwgZnVuY3Rpb24oY29uZmlnLCBwYXJzZXJDb25maWcpIHsKICAgICAiZXRo aW9waWMtaGFsZWhhbWUtc2lkLWV0IiwgImV0aGlvcGljLWhhbGVoYW1lLXNvLWV0IiwKICAgICAi ZXRoaW9waWMtaGFsZWhhbWUtdGktZXIiLCAiZXRoaW9waWMtaGFsZWhhbWUtdGktZXQiLCAiZXRo aW9waWMtaGFsZWhhbWUtdGlnIiwKICAgICAiZXRoaW9waWMtbnVtZXJpYyIsICJldy1yZXNpemUi LCAiZXhjbHVzaW9uIiwgImV4cGFuZGVkIiwgImV4dGVuZHMiLCAiZXh0cmEtY29uZGVuc2VkIiwK LSAgICAiZXh0cmEtZXhwYW5kZWQiLCAiZmFudGFzeSIsICJmYXN0IiwgImZpbGwiLCAiZml4ZWQi LCAiZmxhdCIsICJmbGV4IiwgImZsZXgtZW5kIiwgImZsZXgtc3RhcnQiLCAiZm9vdG5vdGVzIiwK KyAgICAiZXh0cmEtZXhwYW5kZWQiLCAiZmFudGFzeSIsICJmYXN0IiwgImZpbGwiLCAiZml4ZWQi LCAiZmxhdCIsICJmbGV4IiwgImZsZXgtZW5kIiwgImZsZXgtc3RhcnQiLCAiZmxvdy1yb290Iiwg ImZvb3Rub3RlcyIsCiAgICAgImZvcndhcmRzIiwgImZyb20iLCAiZ2VvbWV0cmljUHJlY2lzaW9u IiwgImdlb3JnaWFuIiwgImdyYXl0ZXh0IiwgImdyaWQiLCAiZ3Jvb3ZlIiwKICAgICAiZ3VqYXJh dGkiLCAiZ3VybXVraGkiLCAiaGFuZCIsICJoYW5ndWwiLCAiaGFuZ3VsLWNvbnNvbmFudCIsICJo YXJkLWxpZ2h0IiwgImhlYnJldyIsCiAgICAgImhlbHAiLCAiaGlkZGVuIiwgImhpZGUiLCAiaGln aGVyIiwgImhpZ2hsaWdodCIsICJoaWdobGlnaHR0ZXh0IiwKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1NjNkZjMzMGY3NDVj MmE5YTE2MDgxNDViNzZiMmM2OGM1Y2Q3Mjg0Li43M2Y2MjM0YTg5M2U4MjU3MzFkOTlkNTAzOGEw NWE0N2E5NTVkNzRhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDUtMTQgIEpvb25naHVu IFBhcmsgIDxwamgwNzE4QGdtYWlsLmNvbT4KKworICAgICAgICBJbXBsZW1lbnQgQ1NTIGBkaXNw bGF5OiBmbG93LXJvb3RgIChtb2Rlcm4gY2xlYXJmaXgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU2MDMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNoYW5nZSBmb2xsb3dzIGh0dHBzOi8vZHJh ZnRzLmNzc3dnLm9yZy9jc3MtZGlzcGxheS0zLyN2YWxkZWYtZGlzcGxheS1mbG93LXJvb3QgYXMg YmVsb3cuCisKKyAgICAgICAgJ2Rpc3BsYXk6IGZsb3ctcm9vdCcgZ2VuZXJhdGVzIGEgYmxvY2sg Y29udGFpbmVyIGJveCwgYW5kIGxheXMgb3V0IGl0cyBjb250ZW50cyB1c2luZyBmbG93IGxheW91 dC4KKyAgICAgICAgSXQgYWx3YXlzIGVzdGFibGlzaGVzIGEgbmV3IGJsb2NrIGZvcm1hdHRpbmcg Y29udGV4dCBmb3IgaXRzIGNvbnRlbnRzLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczoK KwogMjAxOS0wNS0xNCAgSmF2aWVyIEZlcm5hbmRleiAgPGpmZXJuYW5kZXpAaWdhbGlhLmNvbT4K IAogICAgICAgICBJbXBsZW1lbnQgImxpbmUtYnJlYWs6IGFueXdoZXJlIgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlv bnMKaW5kZXggYjE3ZTIyZTNmNzg3NWRjODA0ZjY5NDk0ZmMyOWRiN2FiNTAxNjczYi4uOWY4MmZi ZTlhYWM4MTdiN2QxMzFjZDU5ZTAzMTRjZjEzMjA4YzgzZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBA IC0yMDAyLDcgKzIwMDIsNiBAQCB3ZWJraXQub3JnL2IvMTk3NDMwIGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy10ZXh0L3dvcmQtYnJlYWsvd29yZAogIyMjIFNUQVJUIE9G IGRpc3BsYXk6IGNvbnRlbnRzIGZhaWx1cmVzCiAKIHdlYmtpdC5vcmcvYi8xNTc0NzcgaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWRpc3BsYXkvZGlzcGxheS1jb250ZW50 cy1keW5hbWljLXRhYmxlLTAwMS1pbmxpbmUuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQotd2Vi a2l0Lm9yZy9iLzE1NzQ3NyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mt ZGlzcGxheS9kaXNwbGF5LWZsb3ctcm9vdC0wMDEuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQog CiAjIyMgRU5EIE9GIGRpc3BsYXk6IGNvbnRlbnRzIGZhaWx1cmVzCiAjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCg==