165599 2016-12-08 07:10:57 -0800 [Readable Streams API] Implement ReadableByteStreamController desiredSize 2016-12-12 08:00:23 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 romain.wkt romain.wkt benjamin calvaris commit-queue youennf oldest_to_newest 1257690 0 romain.wkt 2016-12-08 07:10:57 -0800 Implement ReadableByteStreamController desiredSize 1257694 1 296513 romain.wkt 2016-12-08 07:44:59 -0800 Created attachment 296513 Patch 1258152 2 296513 achristensen 2016-12-09 09:44:47 -0800 Comment on attachment 296513 Patch Can desiredSize be set to values other than 1? I think that should be tested, as well as actually getting bytes and showing that the desiredSize is actually used correctly. 1258585 3 296513 darin 2016-12-09 21:30:41 -0800 Comment on attachment 296513 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296513&action=review > LayoutTests/streams/readable-byte-stream-controller-expected.txt:13 > +PASS By default initial value of desiredSize should be 1 This does not seem to be sufficient testing. 1258589 4 296513 commit-queue 2016-12-09 21:56:43 -0800 Comment on attachment 296513 Patch Clearing flags on attachment: 296513 Committed r209649: <http://trac.webkit.org/changeset/209649> 1258590 5 commit-queue 2016-12-09 21:56:47 -0800 All reviewed patches have been landed. Closing bug. 1259034 6 romain.wkt 2016-12-12 08:00:23 -0800 (In reply to comment #2) > Comment on attachment 296513 [details] > Patch > > Can desiredSize be set to values other than 1? I think that should be > tested, as well as actually getting bytes and showing that the desiredSize > is actually used correctly. (In reply to comment #3) > Comment on attachment 296513 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296513&action=review > > > LayoutTests/streams/readable-byte-stream-controller-expected.txt:13 > > +PASS By default initial value of desiredSize should be 1 > > This does not seem to be sufficient testing. For the moment, as the API is not yet fully implemented, desiredSize value cannot change. But my intent is to add more tests addressing desiredSize as other functions are implemented. 296513 2016-12-08 07:44:59 -0800 2016-12-09 21:56:43 -0800 Patch bug-165599-20161208164417.patch text/plain 5792 romain.wkt U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5NTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThkMmU1NzkxNjhmMzRl ZmFmY2ZmM2Q5YTEwY2M5ZDQ1N2NlYmYwMi4uOGE4ODU1YzY4MmExODVkMjI2ZjcyNTE2MDVkYmZi OGFjYTlmYTg1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEyLTA4ICBSb21h aW4gQmVsbGVzc29ydCAgPHJvbWFpbi5iZWxsZXNzb3J0QGNyZi5jYW5vbi5mcj4KKworICAgICAg ICBbUmVhZGFibGUgU3RyZWFtcyBBUEldIEltcGxlbWVudCBSZWFkYWJsZUJ5dGVTdHJlYW1Db250 cm9sbGVyIGRlc2lyZWRTaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjU1OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbXBsZW1lbnRlZCBSZWFkYWJsZUJ5dGVTdHJlYW1Db250cm9sbGVyIGF0dHJp YnV0ZSBkZXNpcmVkU2l6ZS4KKworICAgICAgICBBZGRlZCB0ZXN0IHRvIGNoZWNrIGRlc2lyZWRT aXplIHZhbHVlLgorCisgICAgICAgICogTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlQnl0ZVN0cmVh bUNvbnRyb2xsZXIuanM6CisgICAgICAgIChkZXNpcmVkU2l6ZSk6CisgICAgICAgICogTW9kdWxl cy9zdHJlYW1zL1JlYWRhYmxlQnl0ZVN0cmVhbUludGVybmFscy5qczoKKyAgICAgICAgKHJlYWRh YmxlQnl0ZVN0cmVhbUNvbnRyb2xsZXJHZXREZXNpcmVkU2l6ZSk6CisKIDIwMTYtMTItMDggIEFs ZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXgg Q01ha2UgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMv UmVhZGFibGVCeXRlU3RyZWFtQ29udHJvbGxlci5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv c3RyZWFtcy9SZWFkYWJsZUJ5dGVTdHJlYW1Db250cm9sbGVyLmpzCmluZGV4IGFhZTlhODQ4OTk3 ODE4OGMxOGY1ODcxNDhkYjk1NDAyYzNiYTYzYWUuLmYzZDQ2YzVmZTE0MThlNzhiZWI3MGI3YjQw MGNmOTI2YTZiMzgwZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFt cy9SZWFkYWJsZUJ5dGVTdHJlYW1Db250cm9sbGVyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvc3RyZWFtcy9SZWFkYWJsZUJ5dGVTdHJlYW1Db250cm9sbGVyLmpzCkBAIC03NCw3ICs3 NCw4IEBAIGZ1bmN0aW9uIGRlc2lyZWRTaXplKCkKIHsKICAgICAidXNlIHN0cmljdCI7CiAKLSAg ICAvL0ZJWE1FOiBJbXBsZW1lbnQgYXBwcm9wcmlhdGUgYmVoYXZpb3IuCi0gICAgQHRocm93VHlw ZUVycm9yKCJSZWFkYWJsZUJ5dGVTdHJlYW1Db250cm9sbGVyIGRlc2lyZWRTaXplIGlzIG5vdCBp bXBsZW1lbnRlZCIpOwotfQorICAgIGlmICghQGlzUmVhZGFibGVCeXRlU3RyZWFtQ29udHJvbGxl cih0aGlzKSkKKyAgICAgICAgdGhyb3cgQG1ha2VHZXR0ZXJUeXBlRXJyb3IoIlJlYWRhYmxlQnl0 ZVN0cmVhbUNvbnRyb2xsZXIiLCAiZGVzaXJlZFNpemUiKTsKIAorICAgIHJldHVybiBAcmVhZGFi bGVCeXRlU3RyZWFtQ29udHJvbGxlckdldERlc2lyZWRTaXplKHRoaXMpOworfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlQnl0ZVN0cmVhbUludGVy bmFscy5qcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZUJ5dGVTdHJl YW1JbnRlcm5hbHMuanMKaW5kZXggNDM5MTQ1ZGU4YjkxNDFmMGZkNmEyYTRlYjViZDBjMmUxNTFk OTI2Zi4uZjhkZjk3ZmQ1ODA3OTk1ZThmMjA2MzJjMWY0Njg0ZjY3YzY0MjY5MSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlQnl0ZVN0cmVhbUludGVy bmFscy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVCeXRl U3RyZWFtSW50ZXJuYWxzLmpzCkBAIC0xMjUsMyArMTI1LDEwIEBAIGZ1bmN0aW9uIHJlYWRhYmxl Qnl0ZVN0cmVhbUNvbnRyb2xsZXJDbGVhclBlbmRpbmdQdWxsSW50b3MoY29udHJvbGxlcikKIAog ICAgIC8vIEZJWE1FOiBUbyBiZSBpbXBsZW1lbnRlZCBpbiBjb25qdW5jdGlvbiB3aXRoIFJlYWRh YmxlU3RyZWFtQllPQlJlcXVlc3QuCiB9CisKK2Z1bmN0aW9uIHJlYWRhYmxlQnl0ZVN0cmVhbUNv bnRyb2xsZXJHZXREZXNpcmVkU2l6ZShjb250cm9sbGVyKQoreworICAgInVzZSBzdHJpY3QiOwor CisgICByZXR1cm4gY29udHJvbGxlci5Ac3RyYXRlZ3lIV00gLSBjb250cm9sbGVyLkB0b3RhbFF1 ZXVlZEJ5dGVzOworfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUxMThlNjI0MjRkZWE3YmZkNzEyMWM4YjQ5YzFlMDhhMDAz N2I4MmEuLjdiYTNkN2M2OWI2Y2Y3YTUxMzA2M2E4N2I1MzIyMTgzOTk2MjYxOTkgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxNi0xMi0wOCAgUm9tYWluIEJlbGxlc3NvcnQgIDxyb21haW4uYmVs bGVzc29ydEBjcmYuY2Fub24uZnI+CisKKyAgICAgICAgW1JlYWRhYmxlIFN0cmVhbXMgQVBJXSBJ bXBsZW1lbnQgUmVhZGFibGVCeXRlU3RyZWFtQ29udHJvbGxlciBkZXNpcmVkU2l6ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NTk5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdCB0byBj aGVjayBSZWFkYWJsZUJ5dGVTdHJlYW1Db250cm9sbGVyIGRlc2lyZWRTaXplIHZhbHVlLgorCisg ICAgICAgICogc3RyZWFtcy9yZWFkYWJsZS1ieXRlLXN0cmVhbS1jb250cm9sbGVyLWV4cGVjdGVk LnR4dDogQWRkZWQgZXhwZWN0YXRpb24gZm9yIG5ldyB0ZXN0LgorICAgICAgICAqIHN0cmVhbXMv cmVhZGFibGUtYnl0ZS1zdHJlYW0tY29udHJvbGxlci5qczogQWRkZWQgbmV3IHRlc3QgZm9yIGRl c2lyZWRTaXplLgorCiAyMDE2LTEyLTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyMDk0OTApOiBbaW9zLXNpbXVsYXRvcl0gTGF5b3V0 VGVzdCBmYXN0L3NoYWRvdy1kb20vbWVkaWEtc2hhZG93LW1hbmlwdWxhdGlvbi5odG1sIGlzIGZh aWxpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0cmVhbXMvcmVhZGFibGUtYnl0ZS1zdHJl YW0tY29udHJvbGxlci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlYWRhYmxl LWJ5dGUtc3RyZWFtLWNvbnRyb2xsZXItZXhwZWN0ZWQudHh0CmluZGV4IDJkMDIwNmRmZmMxMGQx NzVlY2JhZDlkOTVmMGUxMzNhZDBmMGNkMjcuLmI4MjAzZDg1MmQzN2U4ZmYzNzBhMDlhNTUwODE3 YjhjNzI0Y2Q5Y2IgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0cmVhbXMvcmVhZGFibGUtYnl0 ZS1zdHJlYW0tY29udHJvbGxlci1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RyZWFt cy9yZWFkYWJsZS1ieXRlLXN0cmVhbS1jb250cm9sbGVyLWV4cGVjdGVkLnR4dApAQCAtMTAsNiAr MTAsNyBAQCBQQVNTIENhbGxpbmcgY2xvc2UoKSBhZnRlciBjYWxsaW5nIGVycm9yKCkgc2hvdWxk IHRocm93IGEgVHlwZUVycm9yCiBQQVNTIENhbGxpbmcgcmVhZCgpIG9uIGEgcmVhZGVyIGFzc29j aWF0ZWQgdG8gYSBjb250cm9sbGVyIHRoYXQgaGFzIGJlZW4gZXJyb3JlZCBzaG91bGQgZmFpbCB3 aXRoIHByb3ZpZGVkIGVycm9yIAogUEFTUyBDYWxsaW5nIHJlYWQoKSBvbiBhIHJlYWRlciBhc3Nv Y2lhdGVkIHRvIGEgY29udHJvbGxlciB0aGF0IGhhcyBiZWVuIGNsb3NlZCBzaG91bGQgbm90IGJl IHJlamVjdGVkIAogRkFJTCBDYWxsaW5nIHJlYWQoKSBhZnRlciBhIGNodW5rIGhhcyBiZWVuIGVu cXVldWVkIHNob3VsZCByZXN1bHQgaW4gb2J0YWluaW5nIHNhaWQgY2h1bmsgUmVhZGFibGVCeXRl U3RyZWFtQ29udHJvbGxlciBlbnF1ZXVlKCkgaXMgbm90IGltcGxlbWVudGVkCitQQVNTIEJ5IGRl ZmF1bHQgaW5pdGlhbCB2YWx1ZSBvZiBkZXNpcmVkU2l6ZSBzaG91bGQgYmUgMSAKIFBBU1MgQ3Jl YXRpbmcgYSBSZWFkYWJsZVN0cmVhbSB3aXRoIGFuIHVuZGVybHlpbmdTb3VyY2Ugd2l0aCB0eXBl IHByb3BlcnR5IHNldCB0byAnYnl0ZXMnIHNob3VsZCBzdWNjZWVkIAogUEFTUyBSZWFkYWJsZUJ5 dGVTdHJlYW1Db250cm9sbGVyIGluc3RhbmNlcyBzaG91bGQgaGF2ZSB0aGUgY29ycmVjdCBsaXN0 IG9mIHByb3BlcnRpZXMgCiBQQVNTIENhbGxpbmcgZXJyb3IoKSB3aXRoIGEgdGhpcyBvYmplY3Qg ZGlmZmVyZW50IGZyb20gUmVhZGFibGVCeXRlU3RyZWFtQ29udHJvbGxlciBzaG91bGQgdGhyb3cg YSBUeXBlRXJyb3IgCkBAIC0yMSw0ICsyMiw1IEBAIFBBU1MgQ2FsbGluZyBjbG9zZSgpIGFmdGVy IGNhbGxpbmcgZXJyb3IoKSBzaG91bGQgdGhyb3cgYSBUeXBlRXJyb3IKIFBBU1MgQ2FsbGluZyBy ZWFkKCkgb24gYSByZWFkZXIgYXNzb2NpYXRlZCB0byBhIGNvbnRyb2xsZXIgdGhhdCBoYXMgYmVl biBlcnJvcmVkIHNob3VsZCBmYWlsIHdpdGggcHJvdmlkZWQgZXJyb3IgCiBQQVNTIENhbGxpbmcg cmVhZCgpIG9uIGEgcmVhZGVyIGFzc29jaWF0ZWQgdG8gYSBjb250cm9sbGVyIHRoYXQgaGFzIGJl ZW4gY2xvc2VkIHNob3VsZCBub3QgYmUgcmVqZWN0ZWQgCiBGQUlMIENhbGxpbmcgcmVhZCgpIGFm dGVyIGEgY2h1bmsgaGFzIGJlZW4gZW5xdWV1ZWQgc2hvdWxkIHJlc3VsdCBpbiBvYnRhaW5pbmcg c2FpZCBjaHVuayBSZWFkYWJsZUJ5dGVTdHJlYW1Db250cm9sbGVyIGVucXVldWUoKSBpcyBub3Qg aW1wbGVtZW50ZWQKK1BBU1MgQnkgZGVmYXVsdCBpbml0aWFsIHZhbHVlIG9mIGRlc2lyZWRTaXpl IHNob3VsZCBiZSAxIAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlYWRhYmxl LWJ5dGUtc3RyZWFtLWNvbnRyb2xsZXIuanMgYi9MYXlvdXRUZXN0cy9zdHJlYW1zL3JlYWRhYmxl LWJ5dGUtc3RyZWFtLWNvbnRyb2xsZXIuanMKaW5kZXggYzBhNDczNDFiMjNlODM1ZjdiNDUxZThj MGM5NmMyMDZjZmRmZDQ2MS4uZTI1MzlmNTc2N2IwY2RmMGVkMzgyMzQxZGM0ZDRlOWU4N2I3MTJm MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3RyZWFtcy9yZWFkYWJsZS1ieXRlLXN0cmVhbS1j b250cm9sbGVyLmpzCisrKyBiL0xheW91dFRlc3RzL3N0cmVhbXMvcmVhZGFibGUtYnl0ZS1zdHJl YW0tY29udHJvbGxlci5qcwpAQCAtMjE3LDQgKzIxNywxNyBAQCB0ZXN0NC5zdGVwKGZ1bmN0aW9u KCkgewogICAgICk7CiB9KTsKIAordGVzdChmdW5jdGlvbigpIHsKKyAgICBsZXQgY29udHJvbGxl cjsKKworICAgIGNvbnN0IHJzID0gbmV3IFJlYWRhYmxlU3RyZWFtKHsKKyAgICAgICAgc3RhcnQ6 IGZ1bmN0aW9uKGMpIHsKKyAgICAgICAgICAgIGNvbnRyb2xsZXIgPSBjOworICAgICAgICB9LAor ICAgICAgICB0eXBlOiAiYnl0ZXMiCisgICAgfSk7CisKKyAgICBhc3NlcnRfZXF1YWxzKGNvbnRy b2xsZXIuZGVzaXJlZFNpemUsIDEsICJieSBkZWZhdWx0IGluaXRpYWwgdmFsdWUgb2YgZGVzaXJl ZFNpemUgc2hvdWxkIGJlIDEiKTsKK30sICJCeSBkZWZhdWx0IGluaXRpYWwgdmFsdWUgb2YgZGVz aXJlZFNpemUgc2hvdWxkIGJlIDEiKTsKKwogZG9uZSgpOwo=