165573 2016-12-07 17:28:17 -0800 Renamed SourceCode members to match their accessor names 2016-12-07 17:32:10 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1257494 0 ggaren 2016-12-07 17:28:17 -0800 Renamed SourceCode members to match their accessor names 1257495 1 296450 ggaren 2016-12-07 17:30:00 -0800 Created attachment 296450 Patch 1257497 2 296450 keith_miller 2016-12-07 17:31:33 -0800 Comment on attachment 296450 Patch r=me. 1257498 3 ggaren 2016-12-07 17:32:10 -0800 Committed r209505: <http://trac.webkit.org/changeset/209505> 296450 2016-12-07 17:30:00 -0800 2016-12-07 17:31:33 -0800 Patch bug-165573-20161207172920.patch text/plain 3887 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5NTA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE2LTEyLTA3ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgUmVuYW1lZCBTb3VyY2VDb2RlIG1lbWJlcnMgdG8gbWF0Y2ggdGhlaXIgYWNjZXNzb3IgbmFt ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTU3 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHN0YXJ0 Q2hhciA9PiBzdGFydE9mZnNldAorICAgICAgICBlbmRDaGFyID0+IGVuZE9mZnNldAorCisgICAg ICAgICogcGFyc2VyL1VubGlua2VkU291cmNlQ29kZS5oOgorICAgICAgICAoSlNDOjpVbmxpbmtl ZFNvdXJjZUNvZGU6OlVubGlua2VkU291cmNlQ29kZSk6CisgICAgICAgIChKU0M6OlVubGlua2Vk U291cmNlQ29kZTo6dmlldyk6CisgICAgICAgIChKU0M6OlVubGlua2VkU291cmNlQ29kZTo6c3Rh cnRPZmZzZXQpOgorICAgICAgICAoSlNDOjpVbmxpbmtlZFNvdXJjZUNvZGU6OmVuZE9mZnNldCk6 CisgICAgICAgIChKU0M6OlVubGlua2VkU291cmNlQ29kZTo6bGVuZ3RoKToKKwogMjAxNi0xMi0w NyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg bW9yZSBtaXNzaW5nIHRyaXZpYWwgd2FzbSBvcHMuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcGFyc2VyL1VubGlua2VkU291cmNlQ29kZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3BhcnNlci9VbmxpbmtlZFNvdXJjZUNvZGUuY3BwCShyZXZpc2lvbiAyMDk1 MDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1VubGlua2VkU291cmNlQ29kZS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2LDcgQEAgQ1N0cmluZyBVbmxpbmtlZFNvdXJj ZUNvZGU6OnRvVVRGOCgpIGNvbgogICAgIGlmICghbV9wcm92aWRlcikKICAgICAgICAgcmV0dXJu IENTdHJpbmcoIiIsIDApOwogICAgIAotICAgIHJldHVybiBtX3Byb3ZpZGVyLT5zb3VyY2UoKS5z dWJzdHJpbmcobV9zdGFydENoYXIsIG1fZW5kQ2hhciAtIG1fc3RhcnRDaGFyKS51dGY4KCk7Cisg ICAgcmV0dXJuIG1fcHJvdmlkZXItPnNvdXJjZSgpLnN1YnN0cmluZyhtX3N0YXJ0T2Zmc2V0LCBt X2VuZE9mZnNldCAtIG1fc3RhcnRPZmZzZXQpLnV0ZjgoKTsKIH0KIAogfSAvLyBuYW1lc3BhY2Ug SlNDCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1VubGlua2VkU291cmNlQ29k ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvVW5saW5rZWRT b3VyY2VDb2RlLmgJKHJldmlzaW9uIDIwOTUwMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9w YXJzZXIvVW5saW5rZWRTb3VyY2VDb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTM3LDggKzM3LDgg QEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgcHVibGljOgogICAgICAgICBVbmxpbmtlZFNvdXJjZUNv ZGUoKQogICAgICAgICAgICAgOiBtX3Byb3ZpZGVyKDApCi0gICAgICAgICAgICAsIG1fc3RhcnRD aGFyKDApCi0gICAgICAgICAgICAsIG1fZW5kQ2hhcigwKQorICAgICAgICAgICAgLCBtX3N0YXJ0 T2Zmc2V0KDApCisgICAgICAgICAgICAsIG1fZW5kT2Zmc2V0KDApCiAgICAgICAgIHsKICAgICAg ICAgfQogCkBAIC00OSwyMiArNDksMjIgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICAgICAgVW5s aW5rZWRTb3VyY2VDb2RlKFBhc3NSZWZQdHI8U291cmNlUHJvdmlkZXI+IHByb3ZpZGVyKQogICAg ICAgICAgICAgOiBtX3Byb3ZpZGVyKHByb3ZpZGVyKQotICAgICAgICAgICAgLCBtX3N0YXJ0Q2hh cigwKQotICAgICAgICAgICAgLCBtX2VuZENoYXIobV9wcm92aWRlci0+c291cmNlKCkubGVuZ3Ro KCkpCisgICAgICAgICAgICAsIG1fc3RhcnRPZmZzZXQoMCkKKyAgICAgICAgICAgICwgbV9lbmRP ZmZzZXQobV9wcm92aWRlci0+c291cmNlKCkubGVuZ3RoKCkpCiAgICAgICAgIHsKICAgICAgICAg fQogCiAgICAgICAgIFVubGlua2VkU291cmNlQ29kZShQYXNzUmVmUHRyPFNvdXJjZVByb3ZpZGVy PiBwcm92aWRlciwgaW50IHN0YXJ0T2Zmc2V0LCBpbnQgZW5kT2Zmc2V0KQogICAgICAgICAgICAg OiBtX3Byb3ZpZGVyKHByb3ZpZGVyKQotICAgICAgICAgICAgLCBtX3N0YXJ0Q2hhcihzdGFydE9m ZnNldCkKLSAgICAgICAgICAgICwgbV9lbmRDaGFyKGVuZE9mZnNldCkKKyAgICAgICAgICAgICwg bV9zdGFydE9mZnNldChzdGFydE9mZnNldCkKKyAgICAgICAgICAgICwgbV9lbmRPZmZzZXQoZW5k T2Zmc2V0KQogICAgICAgICB7CiAgICAgICAgIH0KIAogICAgICAgICBVbmxpbmtlZFNvdXJjZUNv ZGUoY29uc3QgVW5saW5rZWRTb3VyY2VDb2RlJiBvdGhlcikKICAgICAgICAgICAgIDogbV9wcm92 aWRlcihvdGhlci5tX3Byb3ZpZGVyKQotICAgICAgICAgICAgLCBtX3N0YXJ0Q2hhcihvdGhlci5t X3N0YXJ0Q2hhcikKLSAgICAgICAgICAgICwgbV9lbmRDaGFyKG90aGVyLm1fZW5kQ2hhcikKKyAg ICAgICAgICAgICwgbV9zdGFydE9mZnNldChvdGhlci5tX3N0YXJ0T2Zmc2V0KQorICAgICAgICAg ICAgLCBtX2VuZE9mZnNldChvdGhlci5tX2VuZE9mZnNldCkKICAgICAgICAgewogICAgICAgICB9 CiAKQEAgLTgwLDIwICs4MCwyMCBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgewogICAgICAg ICAgICAgaWYgKCFtX3Byb3ZpZGVyKQogICAgICAgICAgICAgICAgIHJldHVybiBTdHJpbmdWaWV3 KCk7Ci0gICAgICAgICAgICByZXR1cm4gbV9wcm92aWRlci0+Z2V0UmFuZ2UobV9zdGFydENoYXIs IG1fZW5kQ2hhcik7CisgICAgICAgICAgICByZXR1cm4gbV9wcm92aWRlci0+Z2V0UmFuZ2UobV9z dGFydE9mZnNldCwgbV9lbmRPZmZzZXQpOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICBD U3RyaW5nIHRvVVRGOCgpIGNvbnN0OwogICAgICAgICAKICAgICAgICAgYm9vbCBpc051bGwoKSBj b25zdCB7IHJldHVybiAhbV9wcm92aWRlcjsgfQotICAgICAgICBpbnQgc3RhcnRPZmZzZXQoKSBj b25zdCB7IHJldHVybiBtX3N0YXJ0Q2hhcjsgfQotICAgICAgICBpbnQgZW5kT2Zmc2V0KCkgY29u c3QgeyByZXR1cm4gbV9lbmRDaGFyOyB9Ci0gICAgICAgIGludCBsZW5ndGgoKSBjb25zdCB7IHJl dHVybiBtX2VuZENoYXIgLSBtX3N0YXJ0Q2hhcjsgfQorICAgICAgICBpbnQgc3RhcnRPZmZzZXQo KSBjb25zdCB7IHJldHVybiBtX3N0YXJ0T2Zmc2V0OyB9CisgICAgICAgIGludCBlbmRPZmZzZXQo KSBjb25zdCB7IHJldHVybiBtX2VuZE9mZnNldDsgfQorICAgICAgICBpbnQgbGVuZ3RoKCkgY29u c3QgeyByZXR1cm4gbV9lbmRPZmZzZXQgLSBtX3N0YXJ0T2Zmc2V0OyB9CiAKICAgICBwcm90ZWN0 ZWQ6CiAgICAgICAgIFJlZlB0cjxTb3VyY2VQcm92aWRlcj4gbV9wcm92aWRlcjsKLSAgICAgICAg aW50IG1fc3RhcnRDaGFyOwotICAgICAgICBpbnQgbV9lbmRDaGFyOworICAgICAgICBpbnQgbV9z dGFydE9mZnNldDsKKyAgICAgICAgaW50IG1fZW5kT2Zmc2V0OwogICAgIH07CiAKIH0gLy8gbmFt ZXNwYWNlIEpTQwo=