165564 2016-12-07 16:27:16 -0800 Add more missing trivial wasm ops. 2016-12-07 17:14:09 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam oldest_to_newest 1257437 0 keith_miller 2016-12-07 16:27:16 -0800 Add more missing trivial wasm ops. 1257458 1 296440 keith_miller 2016-12-07 16:50:58 -0800 Created attachment 296440 Patch 1257460 2 commit-queue 2016-12-07 16:52:59 -0800 Attachment 296440 did not pass style-queue: ERROR: Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:68: [<lambda>] Undefined variable 'isUnary' [pylint/E0602] [5] ERROR: Source/JavaScriptCore/wasm/generateWasmOpsHeader.py:68: [<lambda>] Undefined variable 'isBinary' [pylint/E0602] [5] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1257467 3 296440 ggaren 2016-12-07 17:00:24 -0800 Comment on attachment 296440 Patch r=me Needs a Nop test. 1257479 4 keith_miller 2016-12-07 17:14:09 -0800 Committed r209503: <http://trac.webkit.org/changeset/209503> 296440 2016-12-07 16:50:58 -0800 2016-12-07 17:00:24 -0800 Patch bug-165564-20161207165018.patch text/plain 6748 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5NDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 YjUwZDgzMTg4NjIxMzE1OWExNWM3ZDBjMGQxZWZmZGM0Y2E0YTYxLi5iMGQyOGNmMTlhYThhOTU0 NWUzZWIyM2YyM2U2OGIxZGFlMDUyZGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0xMi0wNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBZGQgbW9yZSBtaXNzaW5nIHRyaXZpYWwgd2FzbSBvcHMuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU1NjQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFk ZHMgdGhlIG5vcCwgZHJvcCwgYW5kIHRlZV9sb2NhbCBvcGNvZGVzLgorICAgICAgICBJdCBhbHNv IGZpeGVzIGFuIGlzc3VlIHdoZXJlIHdlIHdlcmUgbm90IGdlbmVyYXRpbmcKKyAgICAgICAgdGhl IHByb3BlciBlbnVtcyBmb3IgdGhlIGdyb3dfbWVtb3J5IGFuZCBjdXJyZW50X21lbW9yeQorICAg ICAgICBvcGNvZGVzLgorCisgICAgICAgICogd2FzbS9XYXNtRnVuY3Rpb25QYXJzZXIuaDoKKyAg ICAgICAgKEpTQzo6V2FzbTo6RnVuY3Rpb25QYXJzZXI8Q29udGV4dD46OnBhcnNlRXhwcmVzc2lv bik6CisgICAgICAgICogd2FzbS9nZW5lcmF0ZVdhc21PcHNIZWFkZXIucHk6CisKIDIwMTYtMTIt MDYgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IHN1cHBvcnQgZm9yIHRydW5jYXRpb24gb3BlcmF0b3JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd2FzbS9XYXNtRnVuY3Rpb25QYXJzZXIuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93YXNtL1dhc21GdW5jdGlvblBhcnNlci5oCmluZGV4IDg5YjBhYjNjMjk3MDc0NTAyNjhh M2M5NzA3MTRjMWIzYjFlYTkzZDEuLmU2MjExMjUyZjFmOTBkMzUzNWU4NTY2MzYzN2E2MTQwYTJm NGJmNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21GdW5jdGlv blBhcnNlci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21GdW5jdGlvblBh cnNlci5oCkBAIC0zMzYsNiArMzM2LDE1IEBAIGJvb2wgRnVuY3Rpb25QYXJzZXI8Q29udGV4dD46 OnBhcnNlRXhwcmVzc2lvbihPcFR5cGUgb3ApCiAgICAgICAgIHJldHVybiBtX2NvbnRleHQuc2V0 TG9jYWwoaW5kZXgsIHZhbHVlKTsKICAgICB9CiAKKyAgICBjYXNlIE9wVHlwZTo6VGVlTG9jYWw6 IHsKKyAgICAgICAgdWludDMyX3QgaW5kZXg7CisgICAgICAgIGlmICghcGFyc2VWYXJVSW50MzIo aW5kZXgpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICBpZiAoIW1fZXhwcmVz c2lvblN0YWNrLnNpemUoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgcmV0 dXJuIG1fY29udGV4dC5zZXRMb2NhbChpbmRleCwgbV9leHByZXNzaW9uU3RhY2subGFzdCgpKTsK KyAgICB9CisKICAgICBjYXNlIE9wVHlwZTo6Q2FsbDogewogICAgICAgICB1aW50MzJfdCBmdW5j dGlvbkluZGV4OwogICAgICAgICBpZiAoIXBhcnNlVmFyVUludDMyKGZ1bmN0aW9uSW5kZXgpKQpA QCAtNDkyLDcgKzUwMSwyNCBAQCBib29sIEZ1bmN0aW9uUGFyc2VyPENvbnRleHQ+OjpwYXJzZUV4 cHJlc3Npb24oT3BUeXBlIG9wKQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKLSAgICBk ZWZhdWx0OiB7CisgICAgY2FzZSBPcFR5cGU6OkRyb3A6IHsKKyAgICAgICAgaWYgKCFtX2V4cHJl c3Npb25TdGFjay5zaXplKCkpIHsKKyAgICAgICAgICAgIHNldEVycm9yTWVzc2FnZSgiQXR0ZW1w dGVkIHRvIGRyb3AgYW4gZXhwcmVzc2lvbiBmcm9tIGFuIGVtcHR5IHN0YWNrLiIpOworICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9CisgICAgICAgIG1fZXhwcmVzc2lvblN0YWNr LnRha2VMYXN0KCk7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0KKworICAgIGNhc2UgT3BU eXBlOjpOb3A6IHsKKyAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQorCisgICAgY2FzZSBPcFR5 cGU6Okdyb3dNZW1vcnk6CisgICAgY2FzZSBPcFR5cGU6OkN1cnJlbnRNZW1vcnk6CisgICAgY2Fz ZSBPcFR5cGU6OkdldEdsb2JhbDoKKyAgICBjYXNlIE9wVHlwZTo6U2V0R2xvYmFsOgorICAgIGNh c2UgT3BUeXBlOjpDYWxsSW5kaXJlY3Q6IHsKICAgICAgICAgLy8gRklYTUU6IE5vdCB5ZXQgaW1w bGVtZW50ZWQuCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd2FzbS9nZW5lcmF0ZVdhc21PcHNIZWFkZXIucHkgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvd2FzbS9nZW5lcmF0ZVdhc21PcHNIZWFkZXIucHkKaW5kZXggY2U4OTQ4 NGZkNzA2YzRlOTcwZGI0ZjJhNWYwMmRjNWU4NjkxMGQ4ZS4uYTU1M2ZiOWZhMDkxNmFhODlmNzYx NGU4NDk5YWE3MjFlYjEyNDhkOCAxMDA3NTUKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dh c20vZ2VuZXJhdGVXYXNtT3BzSGVhZGVyLnB5CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 YXNtL2dlbmVyYXRlV2FzbU9wc0hlYWRlci5weQpAQCAtNjUsNyArNjUsNyBAQCBkZWYgb3Bjb2Rl TWFjcm9pemVyKGZpbHRlcik6CiAgICAgICAgIGluYyArPSAxCiAKIGRlZmluZXMgPSBbIiNkZWZp bmUgRk9SX0VBQ0hfV0FTTV9TUEVDSUFMX09QKG1hY3JvKSJdCi1kZWZpbmVzLmV4dGVuZChbb3Ag Zm9yIG9wIGluIG9wY29kZU1hY3JvaXplcihsYW1iZGEgb3A6IG9wWyJjYXRlZ29yeSJdID09ICJz cGVjaWFsIiBvciBvcFsiY2F0ZWdvcnkiXSA9PSAiY2FsbCIpXSkKK2RlZmluZXMuZXh0ZW5kKFtv cCBmb3Igb3AgaW4gb3Bjb2RlTWFjcm9pemVyKGxhbWJkYSBvcDogbm90IChpc1VuYXJ5KG9wKSBv ciBpc0JpbmFyeShvcCkgb3Igb3BbImNhdGVnb3J5Il0gPT0gImNvbnRyb2wiIG9yIG9wWyJjYXRl Z29yeSJdID09ICJtZW1vcnkiKSldKQogZGVmaW5lcy5hcHBlbmQoIlxuXG4jZGVmaW5lIEZPUl9F QUNIX1dBU01fQ09OVFJPTF9GTE9XX09QKG1hY3JvKSIpCiBkZWZpbmVzLmV4dGVuZChbb3AgZm9y IG9wIGluIG9wY29kZU1hY3JvaXplcihsYW1iZGEgb3A6IG9wWyJjYXRlZ29yeSJdID09ICJjb250 cm9sIildKQogZGVmaW5lcy5hcHBlbmQoIlxuXG4jZGVmaW5lIEZPUl9FQUNIX1dBU01fU0lNUExF X1VOQVJZX09QKG1hY3JvKSIpCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVz dHMvQ2hhbmdlTG9nCmluZGV4IGEwNjEwYWQ5NTVhMTgwODg1YzM0YWMwNGNiMmE4MTNjZjZkOWVi NzIuLmY3OGQ2YzU2ODRiZGJiMDU1MDE0MzQzMWZmYmNkOWIxMDhiYjlhMzQgMTAwNjQ0Ci0tLSBh L0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTYtMTItMDcgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CisK KyAgICAgICAgQWRkIG1vcmUgbWlzc2luZyB0cml2aWFsIHdhc20gb3BzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NTY0CisKKyAgICAgICAgQWRk IHRlc3RzIGZvciBkcm9wIGFuZCB0ZWVfbG9jYWwuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3YXNtL2Z1bmN0aW9uLXRlc3RzL2Ryb3AuanM6IEFk ZGVkLgorICAgICAgICAqIHdhc20vZnVuY3Rpb24tdGVzdHMvdGVlLWxvY2FsLmpzOiBBZGRlZC4K KwogMjAxNi0xMi0wNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAog ICAgICAgICBBZGQgc3VwcG9ydCBmb3IgdHJ1bmNhdGlvbiBvcGVyYXRvcnMKZGlmZiAtLWdpdCBh L0pTVGVzdHMvd2FzbS9mdW5jdGlvbi10ZXN0cy9kcm9wLmpzIGIvSlNUZXN0cy93YXNtL2Z1bmN0 aW9uLXRlc3RzL2Ryb3AuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjk4ZWYyZDUxMGQ1MTUxMTZkMWRmMjcyNWNi MjczNGYwZWNmM2NkZAotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvd2FzbS9mdW5jdGlvbi10 ZXN0cy9kcm9wLmpzCkBAIC0wLDAgKzEsMzkgQEAKK2ltcG9ydCBCdWlsZGVyIGZyb20gJy4uL0J1 aWxkZXIuanMnCisKK2NvbnN0IGIgPSBuZXcgQnVpbGRlcigpOworYi5UeXBlKCkuRW5kKCkKKyAg ICAuRnVuY3Rpb24oKS5FbmQoKQorICAgIC5Db2RlKCkKKworICAgIC8vIFRoaXMgZnVuY3Rpb24g YWRkcyBvbmUgdG8gdGhlIGFyZ3VtZW50LgorICAgIC5GdW5jdGlvbih7IHBhcmFtczogWyJpMzIi XSwgcmV0OiAiaTMyIiB9LCBbXSkKKyAgICAuR2V0TG9jYWwoMCkKKyAgICAuSTMyQ29uc3QoMSkK KyAgICAuVGVlTG9jYWwoMCkKKyAgICAuR2V0TG9jYWwoMCkKKyAgICAuRHJvcCgpCisgICAgLkkz MkFkZCgpCisgICAgLkVuZCgpCisKKyAgICAvLyBUaGlzIGlzIHRoZSBpZCBmdW5jdGlvbi4KKyAg ICAuRnVuY3Rpb24oeyBwYXJhbXM6IFsiaTMyIl0sIHJldDogImkzMiIgfSwgW10pCisgICAgLkdl dExvY2FsKDApCisgICAgLkkzMkNvbnN0KDEpCisgICAgLkRyb3AoKQorICAgIC5FbmQoKQorCitj b25zdCBiaW4gPSBiLldlYkFzc2VtYmx5KCkKK2Jpbi50cmltKCk7Cit0ZXN0V2FzbU1vZHVsZUZ1 bmN0aW9ucyhiaW4uZ2V0KCksIDIsCisgICAgICAgICAgICAgICAgICAgICAgICBbW3sgdHlwZTog ImkzMiIsIHZhbHVlOiAxIH0sIFt7IHR5cGU6ICJpMzIiLCB2YWx1ZTogMCB9XV0sCisgICAgICAg ICAgICAgICAgICAgICAgICAgW3sgdHlwZTogImkzMiIsIHZhbHVlOiAyIH0sIFt7IHR5cGU6ICJp MzIiLCB2YWx1ZTogMSB9XV0sCisgICAgICAgICAgICAgICAgICAgICAgICAgW3sgdHlwZTogImkz MiIsIHZhbHVlOiAxMDEgfSwgW3sgdHlwZTogImkzMiIsIHZhbHVlOiAxMDAgfV1dLAorICAgICAg ICAgICAgICAgICAgICAgICAgIFt7IHR5cGU6ICJpMzIiLCB2YWx1ZTogLTk5IH0sIFt7IHR5cGU6 ICJpMzIiLCB2YWx1ZTogLTEwMCB9XV0sCisgICAgICAgICAgICAgICAgICAgICAgICBdLAorCisg ICAgICAgICAgICAgICAgICAgICAgICBbW3sgdHlwZTogImkzMiIsIHZhbHVlOiAwIH0sIFt7IHR5 cGU6ICJpMzIiLCB2YWx1ZTogMCB9XV0sCisgICAgICAgICAgICAgICAgICAgICAgICAgW3sgdHlw ZTogImkzMiIsIHZhbHVlOiAxIH0sIFt7IHR5cGU6ICJpMzIiLCB2YWx1ZTogMSB9XV0sCisgICAg ICAgICAgICAgICAgICAgICAgICAgW3sgdHlwZTogImkzMiIsIHZhbHVlOiAxMDAgfSwgW3sgdHlw ZTogImkzMiIsIHZhbHVlOiAxMDAgfV1dLAorICAgICAgICAgICAgICAgICAgICAgICAgIFt7IHR5 cGU6ICJpMzIiLCB2YWx1ZTogLTEwMCB9LCBbeyB0eXBlOiAiaTMyIiwgdmFsdWU6IC0xMDAgfV1d LAorICAgICAgICAgICAgICAgICAgICAgICAgXSwKKyAgICAgICAgICAgICAgICAgICAgICAgKTsK ZGlmZiAtLWdpdCBhL0pTVGVzdHMvd2FzbS9mdW5jdGlvbi10ZXN0cy90ZWUtbG9jYWwuanMgYi9K U1Rlc3RzL3dhc20vZnVuY3Rpb24tdGVzdHMvdGVlLWxvY2FsLmpzCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjg2MGY2 YzQ4YTc1NDM1YjQyNzNiZGY3YjZmYTkwNzc2YTZiODkwNDAKLS0tIC9kZXYvbnVsbAorKysgYi9K U1Rlc3RzL3dhc20vZnVuY3Rpb24tdGVzdHMvdGVlLWxvY2FsLmpzCkBAIC0wLDAgKzEsMjYgQEAK K2ltcG9ydCBCdWlsZGVyIGZyb20gJy4uL0J1aWxkZXIuanMnCisKK2NvbnN0IGIgPSBuZXcgQnVp bGRlcigpOworYi5UeXBlKCkuRW5kKCkKKyAgICAuRnVuY3Rpb24oKS5FbmQoKQorICAgIC5Db2Rl KCkKKworICAgIC8vIFRoaXMgZnVuY3Rpb24gbXVsdGlwbGllcyB0aGUgYXJndW1lbnQgYnkgMgor ICAgIC5GdW5jdGlvbih7IHBhcmFtczogWyJpMzIiXSwgcmV0OiAiaTMyIiB9LCBbXSkKKyAgICAu R2V0TG9jYWwoMCkKKyAgICAuSTMyQ29uc3QoMSkKKyAgICAuVGVlTG9jYWwoMCkKKyAgICAuR2V0 TG9jYWwoMCkKKyAgICAuSTMyQWRkKCkKKyAgICAuSTMyTXVsKCkKKyAgICAuRW5kKCkKKworY29u c3QgYmluID0gYi5XZWJBc3NlbWJseSgpCitiaW4udHJpbSgpOwordGVzdFdhc21Nb2R1bGVGdW5j dGlvbnMoYmluLmdldCgpLCAxLAorICAgICAgICAgICAgICAgICAgICAgICAgW1t7IHR5cGU6ICJp MzIiLCB2YWx1ZTogMCB9LCBbeyB0eXBlOiAiaTMyIiwgdmFsdWU6IDAgfV1dLAorICAgICAgICAg ICAgICAgICAgICAgICAgIFt7IHR5cGU6ICJpMzIiLCB2YWx1ZTogMiB9LCBbeyB0eXBlOiAiaTMy IiwgdmFsdWU6IDEgfV1dLAorICAgICAgICAgICAgICAgICAgICAgICAgIFt7IHR5cGU6ICJpMzIi LCB2YWx1ZTogMjAwIH0sIFt7IHR5cGU6ICJpMzIiLCB2YWx1ZTogMTAwIH1dXSwKKyAgICAgICAg ICAgICAgICAgICAgICAgICBbeyB0eXBlOiAiaTMyIiwgdmFsdWU6IC0yMDAgfSwgW3sgdHlwZTog ImkzMiIsIHZhbHVlOiAtMTAwIH1dXSwKKyAgICAgICAgICAgICAgICAgICAgICAgIF0sCisgICAg ICAgICAgICAgICAgICAgICAgICk7Cg==