165556 2016-12-07 15:57:54 -0800 Web Inspector: Control Flow Profiler's event handlers aren't getting removed when ContentView closes 2016-12-07 17:09:19 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1257409 0 nvasilyev 2016-12-07 15:57:54 -0800 When I decoupled Code Coverage and Type profilers I forgot to do this. 1257411 1 296431 nvasilyev 2016-12-07 16:00:23 -0800 Created attachment 296431 Patch 1257417 2 296431 joepeck 2016-12-07 16:09:14 -0800 Comment on attachment 296431 Patch r=me, nice catch! 1257477 3 296431 commit-queue 2016-12-07 17:09:16 -0800 Comment on attachment 296431 Patch Clearing flags on attachment: 296431 Committed r209502: <http://trac.webkit.org/changeset/209502> 1257478 4 commit-queue 2016-12-07 17:09:19 -0800 All reviewed patches have been landed. Closing bug. 296431 2016-12-07 16:00:23 -0800 2016-12-07 17:09:16 -0800 Patch patch.txt text/plain 2325 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDRmMDViNjIuLjM5Y2VkNjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEyLTA3ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbnRy b2wgRmxvdyBQcm9maWxlcidzIGV2ZW50IGhhbmRsZXJzIGFyZW4ndCBnZXR0aW5nIHJlbW92ZWQg d2hlbiBDb250ZW50VmlldyBjbG9zZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2NTU1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRDb250ZW50Vmlldy5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRDb250ZW50Vmlldy5wcm90b3R5cGUuY2xv c2VkKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRSZXNvdXJjZUNvbnRlbnRW aWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRSZXNvdXJjZUNvbnRlbnRWaWV3LnBy b3RvdHlwZS5jbG9zZWQpOgorCiAyMDE2LTEyLTA3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIHVudXNlZCBhbmQg bW9zdGx5IHVudGVzdGVkIFBhZ2UgZG9tYWluIGNvbW1hbmRzIGFuZCBldmVudHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NjcmlwdENvbnRl bnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2Ny aXB0Q29udGVudFZpZXcuanMKaW5kZXggNDdhMjlhNy4uYTEwNmFlMyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0Q29udGVudFZpZXcu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0 Q29udGVudFZpZXcuanMKQEAgLTEyNCw2ICsxMjQsNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0Q29u dGVudFZpZXcgPSBjbGFzcyBTY3JpcHRDb250ZW50VmlldyBleHRlbmRzIFdlYkluc3BlY3Rvci5D bwogICAgICAgICBzdXBlci5jbG9zZWQoKTsKIAogICAgICAgICBXZWJJbnNwZWN0b3Iuc2hvd0ph dmFTY3JpcHRUeXBlSW5mb3JtYXRpb25TZXR0aW5nLnJlbW92ZUV2ZW50TGlzdGVuZXIobnVsbCwg bnVsbCwgdGhpcyk7CisgICAgICAgIFdlYkluc3BlY3Rvci5lbmFibGVDb250cm9sRmxvd1Byb2Zp bGVyU2V0dGluZy5yZW1vdmVFdmVudExpc3RlbmVyKG51bGwsIG51bGwsIHRoaXMpOwogCiAgICAg ICAgIHRoaXMuX3RleHRFZGl0b3IuY2xvc2UoKTsKICAgICB9CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0UmVzb3VyY2VDb250ZW50Vmll dy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRSZXNv dXJjZUNvbnRlbnRWaWV3LmpzCmluZGV4IDNmNTI5OWMuLmI1ZThhNjcgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRSZXNvdXJjZUNvbnRl bnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1RleHRSZXNvdXJjZUNvbnRlbnRWaWV3LmpzCkBAIC0xMjEsNiArMTIxLDcgQEAgV2ViSW5zcGVj dG9yLlRleHRSZXNvdXJjZUNvbnRlbnRWaWV3ID0gY2xhc3MgVGV4dFJlc291cmNlQ29udGVudFZp ZXcgZXh0ZW5kcyBXZWIKICAgICAgICAgdGhpcy5yZXNvdXJjZS5yZW1vdmVFdmVudExpc3RlbmVy KG51bGwsIG51bGwsIHRoaXMpOwogICAgICAgICBXZWJJbnNwZWN0b3IucHJvYmVNYW5hZ2VyLnJl bW92ZUV2ZW50TGlzdGVuZXIobnVsbCwgbnVsbCwgdGhpcyk7CiAgICAgICAgIFdlYkluc3BlY3Rv ci5zaG93SmF2YVNjcmlwdFR5cGVJbmZvcm1hdGlvblNldHRpbmcucmVtb3ZlRXZlbnRMaXN0ZW5l cihudWxsLCBudWxsLCB0aGlzKTsKKyAgICAgICAgV2ViSW5zcGVjdG9yLmVuYWJsZUNvbnRyb2xG bG93UHJvZmlsZXJTZXR0aW5nLnJlbW92ZUV2ZW50TGlzdGVuZXIobnVsbCwgbnVsbCwgdGhpcyk7 CiAKICAgICAgICAgdGhpcy5fdGV4dEVkaXRvci5jbG9zZSgpOwogICAgIH0K