165548 2016-12-07 13:54:06 -0800 Rename the connection sources to better indicate what data direction they are used for 2016-12-07 14:31:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 1257355 0 andersca 2016-12-07 13:54:06 -0800 Rename the connection sources to better indicate what data direction they are used for 1257357 1 296417 andersca 2016-12-07 13:56:21 -0800 Created attachment 296417 Patch 1257369 2 commit-queue 2016-12-07 14:22:32 -0800 Attachment 296417 did not pass style-queue: ERROR: Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:369: No space between ^ and block definition. [whitespace/brackets] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1257376 3 andersca 2016-12-07 14:31:26 -0800 Committed r209481: <http://trac.webkit.org/changeset/209481> 296417 2016-12-07 13:56:21 -0800 2016-12-07 14:09:54 -0800 Patch bug-165548-20161207135542.patch text/plain 6776 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5NDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjA2YjQzNTFjOTU1NzYx ZjNlOWQwYjk3OTEyMTllYWY2N2E1NjQ4Zi4uMzkxYTc0MDZlZDgwYWYzOTk3YTAyM2QzM2YwZjNk ODU3NTI2Yzg3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTEyLTA3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuYW1lIHRoZSBj b25uZWN0aW9uIHNvdXJjZXMgdG8gYmV0dGVyIGluZGljYXRlIHdoYXQgZGF0YSBkaXJlY3Rpb24g dGhleSBhcmUgdXNlZCBmb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2NTU0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uaDoKKyAgICAgICAgKiBQbGF0Zm9y bS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW06CisgICAgICAgIChJUEM6OkNvbm5lY3Rpb246OnBs YXRmb3JtSW52YWxpZGF0ZSk6CisgICAgICAgIChJUEM6OkNvbm5lY3Rpb246OnBsYXRmb3JtSW5p dGlhbGl6ZSk6CisgICAgICAgIChJUEM6OmNyZWF0ZVJlY2VpdmVTb3VyY2UpOgorICAgICAgICAo SVBDOjpDb25uZWN0aW9uOjppbml0aWFsaXplU2VuZFNvdXJjZSk6CisgICAgICAgIChJUEM6OkNv bm5lY3Rpb246OnJlY2VpdmVTb3VyY2VFdmVudEhhbmRsZXIpOgorICAgICAgICAoSVBDOjpjcmVh dGVEYXRhQXZhaWxhYmxlU291cmNlKTogRGVsZXRlZC4KKyAgICAgICAgKElQQzo6Q29ubmVjdGlv bjo6aW5pdGlhbGl6ZURlYWROYW1lU291cmNlKTogRGVsZXRlZC4KKyAgICAgICAgUmVuYW1lIG1f ZGVhZE5hbWVTb3VyY2UgdG8gbV9zZW5kU291cmNlLCBhbmQgbV9yZWNlaXZlUG9ydERhdGFBdmFp bGFibGVTb3VyY2UgdG8gbV9yZWNlaXZlU291cmNlLgorCisgICAgICAgIChJUEM6OkNvbm5lY3Rp b246Om9wZW4pOgorICAgICAgICBJbml0aWFsaXplIHRoZSBzZW5kIHNvdXJjZSBiZWZvcmUgd2Ug YXR0ZW1wdCB0byBzZW5kIGEgZmlyc3QgbWVzc2FnZS4KKwogMjAxNi0xMi0wNiAgQW5kZXJzIENh cmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIG5ldyBNYWNoTWVz c2FnZSBjbGFzcyBhbmQgdXNlIGl0IGZvciBzZW5kaW5nIG91dGdvaW5nIG1lc3NhZ2VzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQ29ubmVjdGlvbi5oIGIvU291cmNl L1dlYktpdDIvUGxhdGZvcm0vSVBDL0Nvbm5lY3Rpb24uaAppbmRleCBmMDEyYTAxYjU0ZGU3ZDFm Y2UyMTc5N2U2ZjQ1NTA1MGM4M2U2ODg1Li44OTJkOWIwMDE5ZTk3ZjcyMGI3NGM2ZGRmNjJmZDFm OGQ0MjM1MWY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvQ29ubmVj dGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9Db25uZWN0aW9uLmgKQEAg LTMxMiwxMyArMzEyLDEzIEBAIHByaXZhdGU6CiAjZWxpZiBPUyhEQVJXSU4pCiAgICAgLy8gQ2Fs bGVkIG9uIHRoZSBjb25uZWN0aW9uIHF1ZXVlLgogICAgIHZvaWQgcmVjZWl2ZVNvdXJjZUV2ZW50 SGFuZGxlcigpOwotICAgIHZvaWQgaW5pdGlhbGl6ZURlYWROYW1lU291cmNlKCk7CisgICAgdm9p ZCBpbml0aWFsaXplU2VuZFNvdXJjZSgpOwogCiAgICAgbWFjaF9wb3J0X3QgbV9zZW5kUG9ydDsK LSAgICBkaXNwYXRjaF9zb3VyY2VfdCBtX2RlYWROYW1lU291cmNlOworICAgIGRpc3BhdGNoX3Nv dXJjZV90IG1fc2VuZFNvdXJjZTsKIAogICAgIG1hY2hfcG9ydF90IG1fcmVjZWl2ZVBvcnQ7Ci0g ICAgZGlzcGF0Y2hfc291cmNlX3QgbV9yZWNlaXZlUG9ydERhdGFBdmFpbGFibGVTb3VyY2U7Cisg ICAgZGlzcGF0Y2hfc291cmNlX3QgbV9yZWNlaXZlU291cmNlOwogCiAjaWYgUExBVEZPUk0oTUFD KSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEIDw9IDEwMTAwMAogICAgIHZvaWQg ZXhjZXB0aW9uU291cmNlRXZlbnRIYW5kbGVyKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9QbGF0Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0 Zm9ybS9JUEMvbWFjL0Nvbm5lY3Rpb25NYWMubW0KaW5kZXggMGI2NjhiNzFhOWY0OTE1YzBmZTk3 OGQzZmU0ZDQ4Mjk1MTU0YzYzMi4uMTI3NzhhNTY4NDQ4ZDYyYTdhNzU5NjM3ODEzNDRjMDYyNmNk ZjcwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL21hYy9Db25uZWN0 aW9uTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy9tYWMvQ29ubmVjdGlv bk1hYy5tbQpAQCAtMTMyLDE0ICsxMzIsMTQgQEAgdm9pZCBDb25uZWN0aW9uOjpwbGF0Zm9ybUlu dmFsaWRhdGUoKQogICAgIEFTU0VSVChtX3JlY2VpdmVQb3J0KTsKIAogICAgIC8vIFVucmVnaXN0 ZXIgb3VyIHBvcnRzLgotICAgIGRpc3BhdGNoX3NvdXJjZV9jYW5jZWwobV9kZWFkTmFtZVNvdXJj ZSk7Ci0gICAgZGlzcGF0Y2hfcmVsZWFzZShtX2RlYWROYW1lU291cmNlKTsKLSAgICBtX2RlYWRO YW1lU291cmNlID0gMDsKKyAgICBkaXNwYXRjaF9zb3VyY2VfY2FuY2VsKG1fc2VuZFNvdXJjZSk7 CisgICAgZGlzcGF0Y2hfcmVsZWFzZShtX3NlbmRTb3VyY2UpOworICAgIG1fc2VuZFNvdXJjZSA9 IDA7CiAgICAgbV9zZW5kUG9ydCA9IE1BQ0hfUE9SVF9OVUxMOwogCi0gICAgZGlzcGF0Y2hfc291 cmNlX2NhbmNlbChtX3JlY2VpdmVQb3J0RGF0YUF2YWlsYWJsZVNvdXJjZSk7Ci0gICAgZGlzcGF0 Y2hfcmVsZWFzZShtX3JlY2VpdmVQb3J0RGF0YUF2YWlsYWJsZVNvdXJjZSk7Ci0gICAgbV9yZWNl aXZlUG9ydERhdGFBdmFpbGFibGVTb3VyY2UgPSAwOworICAgIGRpc3BhdGNoX3NvdXJjZV9jYW5j ZWwobV9yZWNlaXZlU291cmNlKTsKKyAgICBkaXNwYXRjaF9yZWxlYXNlKG1fcmVjZWl2ZVNvdXJj ZSk7CisgICAgbV9yZWNlaXZlU291cmNlID0gMDsKICAgICBtX3JlY2VpdmVQb3J0ID0gTUFDSF9Q T1JUX05VTEw7CiAKICNpZiBQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPD0gMTAxMDAwCkBAIC0xNzMsMTQgKzE3MywxNCBAQCB2b2lkIENvbm5lY3Rpb246 OnBsYXRmb3JtSW5pdGlhbGl6ZShJZGVudGlmaWVyIGlkZW50aWZpZXIpCiAgICAgICAgIG1fc2Vu ZFBvcnQgPSBpZGVudGlmaWVyLnBvcnQ7CiAgICAgfQogCi0gICAgbV9kZWFkTmFtZVNvdXJjZSA9 IG51bGxwdHI7Ci0gICAgbV9yZWNlaXZlUG9ydERhdGFBdmFpbGFibGVTb3VyY2UgPSBudWxscHRy OworICAgIG1fc2VuZFNvdXJjZSA9IG51bGxwdHI7CisgICAgbV9yZWNlaXZlU291cmNlID0gbnVs bHB0cjsKIAogICAgIG1feHBjQ29ubmVjdGlvbiA9IGlkZW50aWZpZXIueHBjQ29ubmVjdGlvbjsK IH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgRnVuY3Rpb24+Ci1zdGF0aWMgZGlzcGF0Y2hfc291cmNl X3QgY3JlYXRlRGF0YUF2YWlsYWJsZVNvdXJjZShtYWNoX3BvcnRfdCByZWNlaXZlUG9ydCwgV29y a1F1ZXVlJiB3b3JrUXVldWUsIEZ1bmN0aW9uJiYgZnVuY3Rpb24pCitzdGF0aWMgZGlzcGF0Y2hf c291cmNlX3QgY3JlYXRlUmVjZWl2ZVNvdXJjZShtYWNoX3BvcnRfdCByZWNlaXZlUG9ydCwgV29y a1F1ZXVlJiB3b3JrUXVldWUsIEZ1bmN0aW9uJiYgZnVuY3Rpb24pCiB7CiAgICAgZGlzcGF0Y2hf c291cmNlX3Qgc291cmNlID0gZGlzcGF0Y2hfc291cmNlX2NyZWF0ZShESVNQQVRDSF9TT1VSQ0Vf VFlQRV9NQUNIX1JFQ1YsIHJlY2VpdmVQb3J0LCAwLCB3b3JrUXVldWUuZGlzcGF0Y2hRdWV1ZSgp KTsKICAgICBkaXNwYXRjaF9zb3VyY2Vfc2V0X2V2ZW50X2hhbmRsZXIoc291cmNlLCBmdW5jdGlv bik7CkBAIC0yMTUsOSArMjE1LDkgQEAgYm9vbCBDb25uZWN0aW9uOjpvcGVuKCkKICAgICAgICAg YXV0byBlbmNvZGVyID0gc3RkOjptYWtlX3VuaXF1ZTxFbmNvZGVyPigiSVBDIiwgIkluaXRpYWxp emVDb25uZWN0aW9uIiwgMCk7CiAgICAgICAgIGVuY29kZXItPmVuY29kZShNYWNoUG9ydChtX3Jl Y2VpdmVQb3J0LCBNQUNIX01TR19UWVBFX01BS0VfU0VORCkpOwogCi0gICAgICAgIHNlbmRNZXNz YWdlKFdURk1vdmUoZW5jb2RlciksIHsgfSk7CisgICAgICAgIGluaXRpYWxpemVTZW5kU291cmNl KCk7CiAKLSAgICAgICAgaW5pdGlhbGl6ZURlYWROYW1lU291cmNlKCk7CisgICAgICAgIHNlbmRN ZXNzYWdlKFdURk1vdmUoZW5jb2RlciksIHsgfSk7CiAgICAgfQogCiAgICAgLy8gQ2hhbmdlIHRo ZSBtZXNzYWdlIHF1ZXVlIGxlbmd0aCBmb3IgdGhlIHJlY2VpdmUgcG9ydC4KQEAgLTIyNSw3ICsy MjUsNyBAQCBib29sIENvbm5lY3Rpb246Om9wZW4oKQogCiAgICAgLy8gUmVnaXN0ZXIgdGhlIGRh dGEgYXZhaWxhYmxlIGhhbmRsZXIuCiAgICAgUmVmUHRyPENvbm5lY3Rpb24+IGNvbm5lY3Rpb24o dGhpcyk7Ci0gICAgbV9yZWNlaXZlUG9ydERhdGFBdmFpbGFibGVTb3VyY2UgPSBjcmVhdGVEYXRh QXZhaWxhYmxlU291cmNlKG1fcmVjZWl2ZVBvcnQsIG1fY29ubmVjdGlvblF1ZXVlLCBbY29ubmVj dGlvbl0geworICAgIG1fcmVjZWl2ZVNvdXJjZSA9IGNyZWF0ZVJlY2VpdmVTb3VyY2UobV9yZWNl aXZlUG9ydCwgbV9jb25uZWN0aW9uUXVldWUsIFtjb25uZWN0aW9uXSB7CiAgICAgICAgIGNvbm5l Y3Rpb24tPnJlY2VpdmVTb3VyY2VFdmVudEhhbmRsZXIoKTsKICAgICB9KTsKIApAQCAtMjQ0LDEw ICsyNDQsMTAgQEAgYm9vbCBDb25uZWN0aW9uOjpvcGVuKCkKIAogICAgIHJlZigpOwogICAgIGRp c3BhdGNoX2FzeW5jKG1fY29ubmVjdGlvblF1ZXVlLT5kaXNwYXRjaFF1ZXVlKCksIF57Ci0gICAg ICAgIGRpc3BhdGNoX3Jlc3VtZShtX3JlY2VpdmVQb3J0RGF0YUF2YWlsYWJsZVNvdXJjZSk7Cisg ICAgICAgIGRpc3BhdGNoX3Jlc3VtZShtX3JlY2VpdmVTb3VyY2UpOwogCi0gICAgICAgIGlmICht X2RlYWROYW1lU291cmNlKQotICAgICAgICAgICAgZGlzcGF0Y2hfcmVzdW1lKG1fZGVhZE5hbWVT b3VyY2UpOworICAgICAgICBpZiAobV9zZW5kU291cmNlKQorICAgICAgICAgICAgZGlzcGF0Y2hf cmVzdW1lKG1fc2VuZFNvdXJjZSk7CiAjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZF UlNJT05fTUlOX1JFUVVJUkVEIDw9IDEwMTAwMAogICAgICAgICBpZiAobV9leGNlcHRpb25Qb3J0 RGF0YUF2YWlsYWJsZVNvdXJjZSkKICAgICAgICAgICAgIGRpc3BhdGNoX3Jlc3VtZShtX2V4Y2Vw dGlvblBvcnREYXRhQXZhaWxhYmxlU291cmNlKTsKQEAgLTM1NiwxNyArMzU2LDE3IEBAIGJvb2wg Q29ubmVjdGlvbjo6c2VuZE91dGdvaW5nTWVzc2FnZShzdGQ6OnVuaXF1ZV9wdHI8RW5jb2Rlcj4g ZW5jb2RlcikKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotdm9pZCBDb25uZWN0aW9uOjppbml0aWFs aXplRGVhZE5hbWVTb3VyY2UoKQordm9pZCBDb25uZWN0aW9uOjppbml0aWFsaXplU2VuZFNvdXJj ZSgpCiB7Ci0gICAgbV9kZWFkTmFtZVNvdXJjZSA9IGRpc3BhdGNoX3NvdXJjZV9jcmVhdGUoRElT UEFUQ0hfU09VUkNFX1RZUEVfTUFDSF9TRU5ELCBtX3NlbmRQb3J0LCAwLCBtX2Nvbm5lY3Rpb25R dWV1ZS0+ZGlzcGF0Y2hRdWV1ZSgpKTsKKyAgICBtX3NlbmRTb3VyY2UgPSBkaXNwYXRjaF9zb3Vy Y2VfY3JlYXRlKERJU1BBVENIX1NPVVJDRV9UWVBFX01BQ0hfU0VORCwgbV9zZW5kUG9ydCwgMCwg bV9jb25uZWN0aW9uUXVldWUtPmRpc3BhdGNoUXVldWUoKSk7CiAKICAgICBSZWZQdHI8Q29ubmVj dGlvbj4gY29ubmVjdGlvbih0aGlzKTsKLSAgICBkaXNwYXRjaF9zb3VyY2Vfc2V0X2V2ZW50X2hh bmRsZXIobV9kZWFkTmFtZVNvdXJjZSwgW2Nvbm5lY3Rpb25dIHsKKyAgICBkaXNwYXRjaF9zb3Vy Y2Vfc2V0X2V2ZW50X2hhbmRsZXIobV9zZW5kU291cmNlLCBbY29ubmVjdGlvbl0gewogICAgICAg ICBjb25uZWN0aW9uLT5jb25uZWN0aW9uRGlkQ2xvc2UoKTsKICAgICB9KTsKIAogICAgIG1hY2hf cG9ydF90IHNlbmRQb3J0ID0gbV9zZW5kUG9ydDsKLSAgICBkaXNwYXRjaF9zb3VyY2Vfc2V0X2Nh bmNlbF9oYW5kbGVyKG1fZGVhZE5hbWVTb3VyY2UsIF57CisgICAgZGlzcGF0Y2hfc291cmNlX3Nl dF9jYW5jZWxfaGFuZGxlcihtX3NlbmRTb3VyY2UsIF57CiAgICAgICAgIC8vIFJlbGVhc2Ugb3Vy IHNlbmQgcmlnaHQuCiAgICAgICAgIG1hY2hfcG9ydF9kZWFsbG9jYXRlKG1hY2hfdGFza19zZWxm KCksIHNlbmRQb3J0KTsKICAgICB9KTsKQEAgLTUxMCw4ICs1MTAsOCBAQCB2b2lkIENvbm5lY3Rp b246OnJlY2VpdmVTb3VyY2VFdmVudEhhbmRsZXIoKQogICAgICAgICAgICAgaWYgKHByZXZpb3Vz Tm90aWZpY2F0aW9uUG9ydCAhPSBNQUNIX1BPUlRfTlVMTCkKICAgICAgICAgICAgICAgICBtYWNo X3BvcnRfZGVhbGxvY2F0ZShtYWNoX3Rhc2tfc2VsZigpLCBwcmV2aW91c05vdGlmaWNhdGlvblBv cnQpOwogCi0gICAgICAgICAgICBpbml0aWFsaXplRGVhZE5hbWVTb3VyY2UoKTsKLSAgICAgICAg ICAgIGRpc3BhdGNoX3Jlc3VtZShtX2RlYWROYW1lU291cmNlKTsKKyAgICAgICAgICAgIGluaXRp YWxpemVTZW5kU291cmNlKCk7CisgICAgICAgICAgICBkaXNwYXRjaF9yZXN1bWUobV9zZW5kU291 cmNlKTsKICAgICAgICAgfQogCiAgICAgICAgIG1faXNDb25uZWN0ZWQgPSB0cnVlOwo=