165524 2016-12-07 04:16:09 -0800 [Win] Some versions of Cygwin Perl generate incorrect C++ code. 2016-12-08 01:05:02 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham cdumez commit-queue dbates webkit-bug-importer oldest_to_newest 1257222 0 pvollan 2016-12-07 04:16:09 -0800 Perl strings with variables seems to be handled differently, depending on which version of Cygwin Perl you are running. For example, when Cygwin Perl v5.14.2 is processing the string "$domJITClassName::$domJITClassName()\n", it will emit a warning saying the variable '$domJITClassName::' is being used uninitialized. This will generate invalid C++ code. 1257223 1 pvollan 2016-12-07 04:18:49 -0800 <rdar://problem/29508043> 1257226 2 296388 pvollan 2016-12-07 04:47:07 -0800 Created attachment 296388 Patch 1257388 3 296388 dbates 2016-12-07 14:57:29 -0800 Comment on attachment 296388 Patch r=me 1257665 4 pvollan 2016-12-08 00:38:24 -0800 (In reply to comment #3) > Comment on attachment 296388 [details] > Patch > > r=me Thanks for reviewing :) 1257669 5 296388 commit-queue 2016-12-08 01:04:57 -0800 Comment on attachment 296388 Patch Clearing flags on attachment: 296388 Committed r209532: <http://trac.webkit.org/changeset/209532> 1257670 6 commit-queue 2016-12-08 01:05:02 -0800 All reviewed patches have been landed. Closing bug. 296388 2016-12-07 04:47:07 -0800 2016-12-08 01:04:57 -0800 Patch bug-165524-20161207044630.patch text/plain 3221 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTQ1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEyLTA3ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBTb21lIHZlcnNp b25zIG9mIEN5Z3dpbiBQZXJsIGdlbmVyYXRlIGluY29ycmVjdCBDKysgY29kZS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTUyNAorICAgICAgICBy ZGFyOi8vcHJvYmxlbS8yOTUwODA0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFBlcmwgc3RyaW5ncyB3aXRoIHZhcmlhYmxlcyBzZWVtcyB0byBiZSBo YW5kbGVkIGRpZmZlcmVudGx5LCBkZXBlbmRpbmcgb24gd2hpY2ggdmVyc2lvbiBvZgorICAgICAg ICBDeWd3aW4gUGVybCB5b3UgYXJlIHJ1bm5pbmcuIFRvIG1ha2Ugc3VyZSB0aGV5IGFyZSBoYW5k bGVkIGlkZW50aWNhbGx5LCBzcGVjaWZ5IHZhcmlhYmxlcworICAgICAgICBpbiBzdHJpbmdzIGFz ICIke3Zhcn0iIGluc3RlYWQgb2YgIiR2YXIiLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChHZW5lcmF0ZUhlYWRlcik6CisgICAgICAg IChHZW5lcmF0ZUltcGxlbWVudGF0aW9uKToKKwogMjAxNi0xMi0wMiAgTWF0dGhldyBIYW5zb24g IDxtYXR0aGV3X2hhbnNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWVyZ2UgcjIwOTI2NC4gcmRh cjovL3Byb2JsZW0vMjk0ODcxODcKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvckpTLnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCShyZXZpc2lvbiAyMDkzOTApCisrKyBTb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQkod29ya2luZyBj b3B5KQpAQCAtMTg1Nyw5ICsxODU3LDkgQEAgc3ViIEdlbmVyYXRlSGVhZGVyCiAKICAgICAgICAg ICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICJKU0M6OkRPTUpJVDo6R2V0dGVyU2V0dGVyKiBkb21K SVRHZXR0ZXJTZXR0ZXJGb3IkY2xhc3NOYW1lKHZvaWQpO1xuIik7CiAKLSAgICAgICAgICAgIHB1 c2goQGhlYWRlckNvbnRlbnQsICJjbGFzcyAkZG9tSklUQ2xhc3NOYW1lIDogcHVibGljIEpTQzo6 RE9NSklUOjpHZXR0ZXJTZXR0ZXIge1xuIik7CisgICAgICAgICAgICBwdXNoKEBoZWFkZXJDb250 ZW50LCAiY2xhc3MgJHtkb21KSVRDbGFzc05hbWV9IDogcHVibGljIEpTQzo6RE9NSklUOjpHZXR0 ZXJTZXR0ZXIge1xuIik7CiAgICAgICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAicHVibGlj OlxuIik7Ci0gICAgICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiICAgICRkb21KSVRDbGFz c05hbWUoKTtcbiIpOworICAgICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICAke2Rv bUpJVENsYXNzTmFtZX0oKTtcbiIpOwogICAgICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwg IiNpZiBFTkFCTEUoSklUKVxuIik7CiAgICAgICAgICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAi ICAgIFJlZjxKU0M6OkRPTUpJVDo6UGF0Y2hwb2ludD4gY2hlY2tET00oKSBvdmVycmlkZTtcbiIp OwogICAgICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIiAgICBSZWY8SlNDOjpET01KSVQ6 OkNhbGxET01HZXR0ZXJQYXRjaHBvaW50PiBjYWxsRE9NR2V0dGVyKCkgb3ZlcnJpZGU7XG4iKTsK QEAgLTM0MTksMTQgKzM0MTksMTQgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAg ICAgICAgICAgICBteSAkZ2V0dGVyID0gR2V0QXR0cmlidXRlR2V0dGVyTmFtZSgkaW50ZXJmYWNl LCAkZ2VuZXJhdG9yTmFtZSwgJGF0dHJpYnV0ZSk7CiAgICAgICAgICAgICAgICAgbXkgJHNldHRl ciA9IElzUmVhZG9ubHkoJGF0dHJpYnV0ZSkgPyAibnVsbHB0ciIgOiBHZXRBdHRyaWJ1dGVTZXR0 ZXJOYW1lKCRpbnRlcmZhY2UsICRnZW5lcmF0b3JOYW1lLCAkYXR0cmlidXRlKTsKICAgICAgICAg ICAgICAgICBteSAkcmVzdWx0VHlwZSA9IEdldFJlc3VsdFR5cGVGaWx0ZXIoJGludGVyZmFjZSwg JGF0dHJpYnV0ZS0+dHlwZSk7Ci0gICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIk ZG9tSklUQ2xhc3NOYW1lOjokZG9tSklUQ2xhc3NOYW1lKClcbiIpOworICAgICAgICAgICAgICAg IHB1c2goQGltcGxDb250ZW50LCAiJHtkb21KSVRDbGFzc05hbWV9Ojoke2RvbUpJVENsYXNzTmFt ZX0oKVxuIik7CiAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgOiBKU0M6 OkRPTUpJVDo6R2V0dGVyU2V0dGVyKCRnZXR0ZXIsICRzZXR0ZXIsICR7Y2xhc3NOYW1lfTo6aW5m bygpLCAkcmVzdWx0VHlwZSlcbiIpOwogICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50 LCAie1xuIik7CiAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJ9XG5cbiIpOwog CiAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJKU0M6OkRPTUpJVDo6R2V0dGVy U2V0dGVyKiBkb21KSVRHZXR0ZXJTZXR0ZXJGb3IiIC4gJGdlbmVyYXRvck5hbWUgLiAiKClcbiIp OwogICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAie1xuIik7Ci0gICAgICAgICAg ICAgICAgcHVzaChAaW1wbENvbnRlbnQsICIgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPCRkb21K SVRDbGFzc05hbWU+IGNvbXBpbGVyO1xuIik7CisgICAgICAgICAgICAgICAgcHVzaChAaW1wbENv bnRlbnQsICIgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPCR7ZG9tSklUQ2xhc3NOYW1lfT4gY29t cGlsZXI7XG4iKTsKICAgICAgICAgICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIiAgICByZXR1 cm4gJmNvbXBpbGVyLmdldCgpO1xuIik7CiAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRl bnQsICJ9XG5cbiIpOwogICAgICAgICAgICAgfQo=