165501 2016-12-06 16:38:24 -0800 REGRESSION(r209391): requires explicit nullptr checks so missing env vars don't flip AC mode (Requested by mcatanzaro on #webkit). 2016-12-06 16:46:32 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 165300 1 commit-queue commit-queue mcatanzaro tpopela oldest_to_newest 1257077 0 commit-queue 2016-12-06 16:38:24 -0800 http://trac.webkit.org/changeset/209391 broke the build: requires explicit nullptr checks so missing env vars don't flip AC mode (Requested by mcatanzaro on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1257079 1 296350 commit-queue 2016-12-06 16:38:39 -0800 Created attachment 296350 ROLLOUT of r209391 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1257088 2 296350 commit-queue 2016-12-06 16:46:29 -0800 Comment on attachment 296350 ROLLOUT of r209391 Clearing flags on attachment: 296350 Committed r209435: <http://trac.webkit.org/changeset/209435> 1257089 3 commit-queue 2016-12-06 16:46:32 -0800 All reviewed patches have been landed. Closing bug. 296350 2016-12-06 16:38:39 -0800 2016-12-06 16:46:29 -0800 ROLLOUT of r209391 bug-165501-20161206193801.patch text/plain 1737 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5NDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTJhZTQyZjhlMmE0YWI1 MmVjZDcyNDljNjFiNTdlZmY4MjBhNzUyNi4uMDkzODE2ZGQzNmEyODU3ODg5MjdiN2RjMTM0Nzdj ZjU5ZjA3MTlmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTEyLTA2ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMjA5MzkxLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY1NTAxCisKKyAgICAgICAgcmVxdWlyZXMgZXhwbGljaXQgbnVsbHB0 ciBjaGVja3Mgc28gbWlzc2luZyBlbnYgdmFycyBkb24ndAorICAgICAgICBmbGlwIEFDIG1vZGUg KFJlcXVlc3RlZCBieSBtY2F0YW56YXJvIG9uICN3ZWJraXQpLgorCisgICAgICAgIFJldmVydGVk IGNoYW5nZXNldDoKKworICAgICAgICAiW0dUS10gUHJvY2VzcyBhY2NlbGVyYXRlZCBjb21wb3Np dGluZyBlbnYgdmFyaWFibGVzIG9ubHkgaWYKKyAgICAgICAgdGhleSBhcmUgcmVhbGx5IGVuYWJs ZWQiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUz MDAKKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjA5MzkxCisKIDIw MTYtMTItMDYgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAg Q29ycmVjdCBTREtST09UIHZhbHVlcyBpbiB4Y2NvbmZpZyBmaWxlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJQcmVmZXJlbmNlc0d0ay5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcAppbmRleCBhMjdlYTNh OGNkMDI2NDA1YzFiNDFlOTA4NzliZWU5NzdmY2IzMzA3Li5jYjQ5YmQ2YTI0YzU3ZjlmY2FlNzQz NDZmNzQ2NWI3NjUxNDNkMDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Z3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv Z3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcApAQCAtNDcsMTEgKzQ3LDExIEBAIHZvaWQgV2ViUHJl ZmVyZW5jZXM6OnBsYXRmb3JtSW5pdGlhbGl6ZVN0b3JlKCkKICNpZiBVU0UoQ09PUkRJTkFURURf R1JBUEhJQ1NfVEhSRUFERUQpCiAgICAgc2V0Rm9yY2VDb21wb3NpdGluZ01vZGUodHJ1ZSk7CiAj ZWxzZQotICAgIGlmIChnX3N0cmNtcDAoZ2V0ZW52KCJXRUJLSVRfRk9SQ0VfQ09NUE9TSVRJTkdf TU9ERSIpLCAiMCIpKQorICAgIGlmIChnZXRlbnYoIldFQktJVF9GT1JDRV9DT01QT1NJVElOR19N T0RFIikpCiAgICAgICAgIHNldEZvcmNlQ29tcG9zaXRpbmdNb2RlKHRydWUpOwogI2VuZGlmCiAK LSAgICBpZiAoZ19zdHJjbXAwKGdldGVudigiV0VCS0lUX0RJU0FCTEVfQ09NUE9TSVRJTkdfTU9E RSIpLCAiMCIpKSB7CisgICAgaWYgKGdldGVudigiV0VCS0lUX0RJU0FCTEVfQ09NUE9TSVRJTkdf TU9ERSIpKSB7CiAgICAgICAgIHNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkKGZhbHNl KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K