165497 2016-12-06 15:55:27 -0800 DumpRenderTree ASSERT in JSC::ExecutableBase::isHostFunction seen on bots 2016-12-07 13:35:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue fpizlo joepeck keith_miller mark.lam msaboff saam oldest_to_newest 1257042 0 joepeck 2016-12-06 15:55:27 -0800 Summary: While running LayoutTests/inspector/timeline/setInstruments-programmatic-capture.html there was an ASSERT seen on the bots: Crash: > Crashed Thread: 0 Dispatch queue: com.apple.main-thread > Exception Type: EXC_BAD_ACCESS (SIGSEGV) > Exception Codes: KERN_INVALID_ADDRESS at 0x00000000bbadbeef > Exception Note: EXC_CORPSE_NOTIFY > > Application Specific Information: > CRASHING TEST: inspector/timeline/setInstruments-programmatic-capture.html > This process is running with libgmalloc.dylib (GuardMalloc) which may have forced the crash due to a memory access error. > > Thread 0 Crashed:: Dispatch queue: com.apple.main-thread > 0 com.apple.JavaScriptCore 0x000000010244c7a7 WTFCrash + 39 > 1 com.apple.JavaScriptCore 0x00000001015a5c34 JSC::ExecutableBase::isHostFunction() const + 100 > 2 com.apple.JavaScriptCore 0x0000000101d63f8a JSC::SamplingProfiler::StackFrame::sourceID() + 74 > 3 com.apple.JavaScriptCore 0x0000000101bdb0e1 Inspector::buildSamples(JSC::VM&, WTF::Vector<JSC::SamplingProfiler::StackTrace, 0ul, WTF::CrashOnOverflow, 16ul>&&) + 193 > 4 com.apple.JavaScriptCore 0x0000000101bdab30 Inspector::InspectorScriptProfilerAgent::trackingComplete() + 288 > 5 com.apple.JavaScriptCore 0x0000000101bdaa03 Inspector::InspectorScriptProfilerAgent::stopTracking(WTF::String&) + 83 > 6 com.apple.WebCore 0x000000010d0a02fa WebCore::InspectorTimelineAgent::toggleScriptProfilerInstrument(WebCore::InspectorTimelineAgent::InstrumentState) + 106 > 7 com.apple.WebCore 0x000000010d0a01d0 WebCore::InspectorTimelineAgent::toggleInstruments(WebCore::InspectorTimelineAgent::InstrumentState) + 144 > 8 com.apple.WebCore 0x000000010d09f16b WebCore::InspectorTimelineAgent::stopProgrammaticCapture() + 155 > 9 com.apple.WebCore 0x000000010d09ebb2 WebCore::InspectorTimelineAgent::stopFromConsole(JSC::ExecState*, WTF::String const&) + 434 > 10 com.apple.WebCore 0x000000010d029640 WebCore::InspectorInstrumentation::stopProfilingImpl(WebCore::InstrumentingAgents&, JSC::ExecState*, WTF::String const&) + 64 > 11 com.apple.WebCore 0x000000010def22ad WebCore::InspectorInstrumentation::stopProfiling(WebCore::Page&, JSC::ExecState*, WTF::String const&) + 45 > 12 com.apple.WebCore 0x000000010def1ce9 WebCore::PageConsoleClient::profileEnd(JSC::ExecState*, WTF::String const&) + 41 > 13 com.apple.JavaScriptCore 0x00000001013fa02e JSC::consoleProtoFuncProfileEnd(JSC::ExecState*) + 286 > ... Notes: - ScriptProfilerAgent::trackingComplete extracts a bunch of SamplingProfiler StackTraces (which hold ExecutableBase pointers) and then processes them - It seems this ASSERT may be possible if we garbage collect one of those ExecutableBase pointers while processing those samples. After talking this over with Saam we think deferring GC while processing the samples would be enough. 1257043 1 joepeck 2016-12-06 15:55:45 -0800 <rdar://problem/29538973> 1257047 2 296342 joepeck 2016-12-06 16:00:04 -0800 Created attachment 296342 [PATCH] Proposed Fix I was unable to reproduce locally to confirm that this solves the issue. However reasoning about this code it would seem appropriate anyways. 1257056 3 296342 saam 2016-12-06 16:13:56 -0800 Comment on attachment 296342 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=296342&action=review > Source/JavaScriptCore/ChangeLog:12 > + Defer collection when extracting and processing the samples to avoid > + any objects held by the samples from getting collected while processing. Maybe it's worth adding why the could be collected: we're calling into functions that can allocate. We must prevent those functions that can allocate from syncing w/ the GC thread. 1257057 4 saam 2016-12-06 16:14:21 -0800 (In reply to comment #3) > Comment on attachment 296342 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=296342&action=review > > > Source/JavaScriptCore/ChangeLog:12 > > + Defer collection when extracting and processing the samples to avoid > > + any objects held by the samples from getting collected while processing. > > Maybe it's worth adding why the could be collected: > we're calling into functions that can allocate. We must prevent those > functions that can allocate from syncing w/ the GC thread. they* 1257061 5 296345 joepeck 2016-12-06 16:25:29 -0800 Created attachment 296345 [PATCH] For Landing 1257063 6 296345 mark.lam 2016-12-06 16:26:17 -0800 Comment on attachment 296345 [PATCH] For Landing View in context: https://bugs.webkit.org/attachment.cgi?id=296345&action=review > Source/JavaScriptCore/ChangeLog:15 > + GC thread which may collecting other sample data yet to be processed. /collecting/collect/. 1257074 7 296348 joepeck 2016-12-06 16:35:53 -0800 Created attachment 296348 [PATCH] For Landing Heh thanks =) 1257124 8 296348 commit-queue 2016-12-06 18:53:01 -0800 Comment on attachment 296348 [PATCH] For Landing Clearing flags on attachment: 296348 Committed r209440: <http://trac.webkit.org/changeset/209440> 296342 2016-12-06 16:00:04 -0800 2016-12-06 16:25:52 -0800 [PATCH] Proposed Fix defer-gc-1.patch text/plain 3250 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDg5MmZjMzguLmFjNTYwNGMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTEyLTA2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgRHVtcFJlbmRlclRyZWUgQVNTRVJU IGluIEpTQzo6RXhlY3V0YWJsZUJhc2U6OmlzSG9zdEZ1bmN0aW9uIHNlZW4gb24gYm90cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NDk3CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yOTUzODk3Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yU2NyaXB0 UHJvZmlsZXJBZ2VudC5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6Okluc3BlY3RvclNjcmlwdFBy b2ZpbGVyQWdlbnQ6OnRyYWNraW5nQ29tcGxldGUpOgorICAgICAgICBEZWZlciBjb2xsZWN0aW9u IHdoZW4gZXh0cmFjdGluZyBhbmQgcHJvY2Vzc2luZyB0aGUgc2FtcGxlcyB0byBhdm9pZAorICAg ICAgICBhbnkgb2JqZWN0cyBoZWxkIGJ5IHRoZSBzYW1wbGVzIGZyb20gZ2V0dGluZyBjb2xsZWN0 ZWQgd2hpbGUgcHJvY2Vzc2luZy4KKworMjAxNi0xMi0wNiAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNvbWUgcmVzb3VyY2Vz IGZldGNoZWQgdmlhIEZldGNoIEFQSSBkbyBub3QgaGF2ZSBkYXRhCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUyMzAKICAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzI5NDQ5MjIwPgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9hZ2VudHMvSW5zcGVjdG9yU2NyaXB0UHJvZmlsZXJBZ2VudC5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JTY3JpcHRQcm9maWxlckFnZW50 LmNwcAppbmRleCA5ODY2YjJjLi5mZmMyOTliMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yU2NyaXB0UHJvZmlsZXJBZ2VudC5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yU2Ny aXB0UHJvZmlsZXJBZ2VudC5jcHAKQEAgLTI2LDYgKzI2LDggQEAKICNpbmNsdWRlICJjb25maWcu aCIKICNpbmNsdWRlICJJbnNwZWN0b3JTY3JpcHRQcm9maWxlckFnZW50LmgiCiAKKyNpbmNsdWRl ICJEZWZlckdDLmgiCisjaW5jbHVkZSAiSGVhcElubGluZXMuaCIKICNpbmNsdWRlICJJbnNwZWN0 b3JFbnZpcm9ubWVudC5oIgogI2luY2x1ZGUgIlNhbXBsaW5nUHJvZmlsZXIuaCIKICNpbmNsdWRl IDx3dGYvUnVuTG9vcC5oPgpAQCAtMjAzLDggKzIwNSwxMCBAQCB2b2lkIEluc3BlY3RvclNjcmlw dFByb2ZpbGVyQWdlbnQ6OnRyYWNraW5nQ29tcGxldGUoKQogewogI2lmIEVOQUJMRShTQU1QTElO R19QUk9GSUxFUikKICAgICBpZiAobV9lbmFibGVkU2FtcGxpbmdQcm9maWxlcikgewotICAgICAg ICBKU0xvY2tIb2xkZXIgbG9jayhtX2Vudmlyb25tZW50LnNjcmlwdERlYnVnU2VydmVyKCkudm0o KSk7Ci0gICAgICAgIFNhbXBsaW5nUHJvZmlsZXIqIHNhbXBsaW5nUHJvZmlsZXIgPSBtX2Vudmly b25tZW50LnNjcmlwdERlYnVnU2VydmVyKCkudm0oKS5zYW1wbGluZ1Byb2ZpbGVyKCk7CisgICAg ICAgIFZNJiB2bSA9IG1fZW52aXJvbm1lbnQuc2NyaXB0RGVidWdTZXJ2ZXIoKS52bSgpOworICAg ICAgICBKU0xvY2tIb2xkZXIgbG9jayh2bSk7CisgICAgICAgIERlZmVyR0MgZGVmZXJHQyh2bS5o ZWFwKTsKKyAgICAgICAgU2FtcGxpbmdQcm9maWxlciogc2FtcGxpbmdQcm9maWxlciA9IHZtLnNh bXBsaW5nUHJvZmlsZXIoKTsKICAgICAgICAgUkVMRUFTRV9BU1NFUlQoc2FtcGxpbmdQcm9maWxl cik7CiAKICAgICAgICAgTG9ja0hvbGRlciBsb2NrZXIoc2FtcGxpbmdQcm9maWxlci0+Z2V0TG9j aygpKTsKQEAgLTIxMiw3ICsyMTYsNyBAQCB2b2lkIEluc3BlY3RvclNjcmlwdFByb2ZpbGVyQWdl bnQ6OnRyYWNraW5nQ29tcGxldGUoKQogICAgICAgICBWZWN0b3I8U2FtcGxpbmdQcm9maWxlcjo6 U3RhY2tUcmFjZT4gc3RhY2tUcmFjZXMgPSBzYW1wbGluZ1Byb2ZpbGVyLT5yZWxlYXNlU3RhY2tU cmFjZXMobG9ja2VyKTsKICAgICAgICAgbG9ja2VyLnVubG9ja0Vhcmx5KCk7CiAKLSAgICAgICAg UmVmPFByb3RvY29sOjpTY3JpcHRQcm9maWxlcjo6U2FtcGxlcz4gc2FtcGxlcyA9IGJ1aWxkU2Ft cGxlcyhtX2Vudmlyb25tZW50LnNjcmlwdERlYnVnU2VydmVyKCkudm0oKSwgV1RGTW92ZShzdGFj a1RyYWNlcykpOworICAgICAgICBSZWY8UHJvdG9jb2w6OlNjcmlwdFByb2ZpbGVyOjpTYW1wbGVz PiBzYW1wbGVzID0gYnVpbGRTYW1wbGVzKHZtLCBXVEZNb3ZlKHN0YWNrVHJhY2VzKSk7CiAKICAg ICAgICAgbV9lbmFibGVkU2FtcGxpbmdQcm9maWxlciA9IGZhbHNlOwogCkBAIC0yMzAsOCArMjM0 LDkgQEAgdm9pZCBJbnNwZWN0b3JTY3JpcHRQcm9maWxlckFnZW50OjpzdG9wU2FtcGxpbmdXaGVu RGlzY29ubmVjdGluZygpCiAgICAgaWYgKCFtX2VuYWJsZWRTYW1wbGluZ1Byb2ZpbGVyKQogICAg ICAgICByZXR1cm47CiAKLSAgICBKU0xvY2tIb2xkZXIgbG9jayhtX2Vudmlyb25tZW50LnNjcmlw dERlYnVnU2VydmVyKCkudm0oKSk7Ci0gICAgU2FtcGxpbmdQcm9maWxlciogc2FtcGxpbmdQcm9m aWxlciA9IG1fZW52aXJvbm1lbnQuc2NyaXB0RGVidWdTZXJ2ZXIoKS52bSgpLnNhbXBsaW5nUHJv ZmlsZXIoKTsKKyAgICBWTSYgdm0gPSBtX2Vudmlyb25tZW50LnNjcmlwdERlYnVnU2VydmVyKCku dm0oKTsKKyAgICBKU0xvY2tIb2xkZXIgbG9jayh2bSk7CisgICAgU2FtcGxpbmdQcm9maWxlciog c2FtcGxpbmdQcm9maWxlciA9IHZtLnNhbXBsaW5nUHJvZmlsZXIoKTsKICAgICBSRUxFQVNFX0FT U0VSVChzYW1wbGluZ1Byb2ZpbGVyKTsKICAgICBMb2NrSG9sZGVyIGxvY2tlcihzYW1wbGluZ1By b2ZpbGVyLT5nZXRMb2NrKCkpOwogICAgIHNhbXBsaW5nUHJvZmlsZXItPnBhdXNlKGxvY2tlcik7 Cg== 296345 2016-12-06 16:25:29 -0800 2016-12-06 16:35:53 -0800 [PATCH] For Landing for-landing-9.patch text/plain 3476 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDg5MmZjMzguLmZjMGUxMTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTEyLTA2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgRHVtcFJlbmRlclRyZWUgQVNTRVJU IGluIEpTQzo6RXhlY3V0YWJsZUJhc2U6OmlzSG9zdEZ1bmN0aW9uIHNlZW4gb24gYm90cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NDk3CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yOTUzODk3Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBTYWFt IEJhcmF0aS4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yU2NyaXB0UHJv ZmlsZXJBZ2VudC5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6Okluc3BlY3RvclNjcmlwdFByb2Zp bGVyQWdlbnQ6OnRyYWNraW5nQ29tcGxldGUpOgorICAgICAgICBEZWZlciBjb2xsZWN0aW9uIHdo ZW4gZXh0cmFjdGluZyBhbmQgcHJvY2Vzc2luZyB0aGUgc2FtcGxlcyB0byBhdm9pZAorICAgICAg ICBhbnkgb2JqZWN0cyBoZWxkIGJ5IHRoZSBzYW1wbGVzIGZyb20gZ2V0dGluZyBjb2xsZWN0ZWQg d2hpbGUgcHJvY2Vzc2luZy4KKyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIHdoaWxlIHByb2Nlc3Np bmcgd2UgY2FsbCBpbnRvIGZ1bmN0aW9ucyB0aGF0IGNhbgorICAgICAgICBhbGxvY2F0ZSBhbmQg d2UgbXVzdCBwcmV2ZW50IHRob3NlIGZ1bmN0aW9ucyBmcm9tIHN5bmNpbmcgd2l0aCB0aGUKKyAg ICAgICAgR0MgdGhyZWFkIHdoaWNoIG1heSBjb2xsZWN0aW5nIG90aGVyIHNhbXBsZSBkYXRhIHll dCB0byBiZSBwcm9jZXNzZWQuCisKKzIwMTYtMTItMDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTb21lIHJlc291cmNlcyBm ZXRjaGVkIHZpYSBGZXRjaCBBUEkgZG8gbm90IGhhdmUgZGF0YQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MjMwCiAgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8yOTQ0OTIyMD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvYWdlbnRzL0luc3BlY3RvclNjcmlwdFByb2ZpbGVyQWdlbnQuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yU2NyaXB0UHJvZmlsZXJBZ2VudC5j cHAKaW5kZXggOTg2NmIyYy4uZmZjMjk5YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclNjcmlwdFByb2ZpbGVyQWdlbnQuY3BwCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclNjcmlw dFByb2ZpbGVyQWdlbnQuY3BwCkBAIC0yNiw2ICsyNiw4IEBACiAjaW5jbHVkZSAiY29uZmlnLmgi CiAjaW5jbHVkZSAiSW5zcGVjdG9yU2NyaXB0UHJvZmlsZXJBZ2VudC5oIgogCisjaW5jbHVkZSAi RGVmZXJHQy5oIgorI2luY2x1ZGUgIkhlYXBJbmxpbmVzLmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9y RW52aXJvbm1lbnQuaCIKICNpbmNsdWRlICJTYW1wbGluZ1Byb2ZpbGVyLmgiCiAjaW5jbHVkZSA8 d3RmL1J1bkxvb3AuaD4KQEAgLTIwMyw4ICsyMDUsMTAgQEAgdm9pZCBJbnNwZWN0b3JTY3JpcHRQ cm9maWxlckFnZW50Ojp0cmFja2luZ0NvbXBsZXRlKCkKIHsKICNpZiBFTkFCTEUoU0FNUExJTkdf UFJPRklMRVIpCiAgICAgaWYgKG1fZW5hYmxlZFNhbXBsaW5nUHJvZmlsZXIpIHsKLSAgICAgICAg SlNMb2NrSG9sZGVyIGxvY2sobV9lbnZpcm9ubWVudC5zY3JpcHREZWJ1Z1NlcnZlcigpLnZtKCkp OwotICAgICAgICBTYW1wbGluZ1Byb2ZpbGVyKiBzYW1wbGluZ1Byb2ZpbGVyID0gbV9lbnZpcm9u bWVudC5zY3JpcHREZWJ1Z1NlcnZlcigpLnZtKCkuc2FtcGxpbmdQcm9maWxlcigpOworICAgICAg ICBWTSYgdm0gPSBtX2Vudmlyb25tZW50LnNjcmlwdERlYnVnU2VydmVyKCkudm0oKTsKKyAgICAg ICAgSlNMb2NrSG9sZGVyIGxvY2sodm0pOworICAgICAgICBEZWZlckdDIGRlZmVyR0Modm0uaGVh cCk7CisgICAgICAgIFNhbXBsaW5nUHJvZmlsZXIqIHNhbXBsaW5nUHJvZmlsZXIgPSB2bS5zYW1w bGluZ1Byb2ZpbGVyKCk7CiAgICAgICAgIFJFTEVBU0VfQVNTRVJUKHNhbXBsaW5nUHJvZmlsZXIp OwogCiAgICAgICAgIExvY2tIb2xkZXIgbG9ja2VyKHNhbXBsaW5nUHJvZmlsZXItPmdldExvY2so KSk7CkBAIC0yMTIsNyArMjE2LDcgQEAgdm9pZCBJbnNwZWN0b3JTY3JpcHRQcm9maWxlckFnZW50 Ojp0cmFja2luZ0NvbXBsZXRlKCkKICAgICAgICAgVmVjdG9yPFNhbXBsaW5nUHJvZmlsZXI6OlN0 YWNrVHJhY2U+IHN0YWNrVHJhY2VzID0gc2FtcGxpbmdQcm9maWxlci0+cmVsZWFzZVN0YWNrVHJh Y2VzKGxvY2tlcik7CiAgICAgICAgIGxvY2tlci51bmxvY2tFYXJseSgpOwogCi0gICAgICAgIFJl ZjxQcm90b2NvbDo6U2NyaXB0UHJvZmlsZXI6OlNhbXBsZXM+IHNhbXBsZXMgPSBidWlsZFNhbXBs ZXMobV9lbnZpcm9ubWVudC5zY3JpcHREZWJ1Z1NlcnZlcigpLnZtKCksIFdURk1vdmUoc3RhY2tU cmFjZXMpKTsKKyAgICAgICAgUmVmPFByb3RvY29sOjpTY3JpcHRQcm9maWxlcjo6U2FtcGxlcz4g c2FtcGxlcyA9IGJ1aWxkU2FtcGxlcyh2bSwgV1RGTW92ZShzdGFja1RyYWNlcykpOwogCiAgICAg ICAgIG1fZW5hYmxlZFNhbXBsaW5nUHJvZmlsZXIgPSBmYWxzZTsKIApAQCAtMjMwLDggKzIzNCw5 IEBAIHZvaWQgSW5zcGVjdG9yU2NyaXB0UHJvZmlsZXJBZ2VudDo6c3RvcFNhbXBsaW5nV2hlbkRp c2Nvbm5lY3RpbmcoKQogICAgIGlmICghbV9lbmFibGVkU2FtcGxpbmdQcm9maWxlcikKICAgICAg ICAgcmV0dXJuOwogCi0gICAgSlNMb2NrSG9sZGVyIGxvY2sobV9lbnZpcm9ubWVudC5zY3JpcHRE ZWJ1Z1NlcnZlcigpLnZtKCkpOwotICAgIFNhbXBsaW5nUHJvZmlsZXIqIHNhbXBsaW5nUHJvZmls ZXIgPSBtX2Vudmlyb25tZW50LnNjcmlwdERlYnVnU2VydmVyKCkudm0oKS5zYW1wbGluZ1Byb2Zp bGVyKCk7CisgICAgVk0mIHZtID0gbV9lbnZpcm9ubWVudC5zY3JpcHREZWJ1Z1NlcnZlcigpLnZt KCk7CisgICAgSlNMb2NrSG9sZGVyIGxvY2sodm0pOworICAgIFNhbXBsaW5nUHJvZmlsZXIqIHNh bXBsaW5nUHJvZmlsZXIgPSB2bS5zYW1wbGluZ1Byb2ZpbGVyKCk7CiAgICAgUkVMRUFTRV9BU1NF UlQoc2FtcGxpbmdQcm9maWxlcik7CiAgICAgTG9ja0hvbGRlciBsb2NrZXIoc2FtcGxpbmdQcm9m aWxlci0+Z2V0TG9jaygpKTsKICAgICBzYW1wbGluZ1Byb2ZpbGVyLT5wYXVzZShsb2NrZXIpOwo= 296348 2016-12-06 16:35:53 -0800 2016-12-06 18:53:01 -0800 [PATCH] For Landing for-landing-10.patch text/plain 3473 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDg5MmZjMzguLjg4MDljODMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTEyLTA2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgRHVtcFJlbmRlclRyZWUgQVNTRVJU IGluIEpTQzo6RXhlY3V0YWJsZUJhc2U6OmlzSG9zdEZ1bmN0aW9uIHNlZW4gb24gYm90cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NDk3CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8yOTUzODk3Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBTYWFt IEJhcmF0aS4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yU2NyaXB0UHJv ZmlsZXJBZ2VudC5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6Okluc3BlY3RvclNjcmlwdFByb2Zp bGVyQWdlbnQ6OnRyYWNraW5nQ29tcGxldGUpOgorICAgICAgICBEZWZlciBjb2xsZWN0aW9uIHdo ZW4gZXh0cmFjdGluZyBhbmQgcHJvY2Vzc2luZyB0aGUgc2FtcGxlcyB0byBhdm9pZAorICAgICAg ICBhbnkgb2JqZWN0cyBoZWxkIGJ5IHRoZSBzYW1wbGVzIGZyb20gZ2V0dGluZyBjb2xsZWN0ZWQg d2hpbGUgcHJvY2Vzc2luZy4KKyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIHdoaWxlIHByb2Nlc3Np bmcgd2UgY2FsbCBpbnRvIGZ1bmN0aW9ucyB0aGF0IGNhbgorICAgICAgICBhbGxvY2F0ZSBhbmQg d2UgbXVzdCBwcmV2ZW50IHRob3NlIGZ1bmN0aW9ucyBmcm9tIHN5bmNpbmcgd2l0aCB0aGUKKyAg ICAgICAgR0MgdGhyZWFkIHdoaWNoIG1heSBjb2xsZWN0IG90aGVyIHNhbXBsZSBkYXRhIHlldCB0 byBiZSBwcm9jZXNzZWQuCisKKzIwMTYtMTItMDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTb21lIHJlc291cmNlcyBmZXRj aGVkIHZpYSBGZXRjaCBBUEkgZG8gbm90IGhhdmUgZGF0YQogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MjMwCiAgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8yOTQ0OTIyMD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv YWdlbnRzL0luc3BlY3RvclNjcmlwdFByb2ZpbGVyQWdlbnQuY3BwIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yU2NyaXB0UHJvZmlsZXJBZ2VudC5jcHAK aW5kZXggOTg2NmIyYy4uZmZjMjk5YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclNjcmlwdFByb2ZpbGVyQWdlbnQuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclNjcmlwdFBy b2ZpbGVyQWdlbnQuY3BwCkBAIC0yNiw2ICsyNiw4IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAj aW5jbHVkZSAiSW5zcGVjdG9yU2NyaXB0UHJvZmlsZXJBZ2VudC5oIgogCisjaW5jbHVkZSAiRGVm ZXJHQy5oIgorI2luY2x1ZGUgIkhlYXBJbmxpbmVzLmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9yRW52 aXJvbm1lbnQuaCIKICNpbmNsdWRlICJTYW1wbGluZ1Byb2ZpbGVyLmgiCiAjaW5jbHVkZSA8d3Rm L1J1bkxvb3AuaD4KQEAgLTIwMyw4ICsyMDUsMTAgQEAgdm9pZCBJbnNwZWN0b3JTY3JpcHRQcm9m aWxlckFnZW50Ojp0cmFja2luZ0NvbXBsZXRlKCkKIHsKICNpZiBFTkFCTEUoU0FNUExJTkdfUFJP RklMRVIpCiAgICAgaWYgKG1fZW5hYmxlZFNhbXBsaW5nUHJvZmlsZXIpIHsKLSAgICAgICAgSlNM b2NrSG9sZGVyIGxvY2sobV9lbnZpcm9ubWVudC5zY3JpcHREZWJ1Z1NlcnZlcigpLnZtKCkpOwot ICAgICAgICBTYW1wbGluZ1Byb2ZpbGVyKiBzYW1wbGluZ1Byb2ZpbGVyID0gbV9lbnZpcm9ubWVu dC5zY3JpcHREZWJ1Z1NlcnZlcigpLnZtKCkuc2FtcGxpbmdQcm9maWxlcigpOworICAgICAgICBW TSYgdm0gPSBtX2Vudmlyb25tZW50LnNjcmlwdERlYnVnU2VydmVyKCkudm0oKTsKKyAgICAgICAg SlNMb2NrSG9sZGVyIGxvY2sodm0pOworICAgICAgICBEZWZlckdDIGRlZmVyR0Modm0uaGVhcCk7 CisgICAgICAgIFNhbXBsaW5nUHJvZmlsZXIqIHNhbXBsaW5nUHJvZmlsZXIgPSB2bS5zYW1wbGlu Z1Byb2ZpbGVyKCk7CiAgICAgICAgIFJFTEVBU0VfQVNTRVJUKHNhbXBsaW5nUHJvZmlsZXIpOwog CiAgICAgICAgIExvY2tIb2xkZXIgbG9ja2VyKHNhbXBsaW5nUHJvZmlsZXItPmdldExvY2soKSk7 CkBAIC0yMTIsNyArMjE2LDcgQEAgdm9pZCBJbnNwZWN0b3JTY3JpcHRQcm9maWxlckFnZW50Ojp0 cmFja2luZ0NvbXBsZXRlKCkKICAgICAgICAgVmVjdG9yPFNhbXBsaW5nUHJvZmlsZXI6OlN0YWNr VHJhY2U+IHN0YWNrVHJhY2VzID0gc2FtcGxpbmdQcm9maWxlci0+cmVsZWFzZVN0YWNrVHJhY2Vz KGxvY2tlcik7CiAgICAgICAgIGxvY2tlci51bmxvY2tFYXJseSgpOwogCi0gICAgICAgIFJlZjxQ cm90b2NvbDo6U2NyaXB0UHJvZmlsZXI6OlNhbXBsZXM+IHNhbXBsZXMgPSBidWlsZFNhbXBsZXMo bV9lbnZpcm9ubWVudC5zY3JpcHREZWJ1Z1NlcnZlcigpLnZtKCksIFdURk1vdmUoc3RhY2tUcmFj ZXMpKTsKKyAgICAgICAgUmVmPFByb3RvY29sOjpTY3JpcHRQcm9maWxlcjo6U2FtcGxlcz4gc2Ft cGxlcyA9IGJ1aWxkU2FtcGxlcyh2bSwgV1RGTW92ZShzdGFja1RyYWNlcykpOwogCiAgICAgICAg IG1fZW5hYmxlZFNhbXBsaW5nUHJvZmlsZXIgPSBmYWxzZTsKIApAQCAtMjMwLDggKzIzNCw5IEBA IHZvaWQgSW5zcGVjdG9yU2NyaXB0UHJvZmlsZXJBZ2VudDo6c3RvcFNhbXBsaW5nV2hlbkRpc2Nv bm5lY3RpbmcoKQogICAgIGlmICghbV9lbmFibGVkU2FtcGxpbmdQcm9maWxlcikKICAgICAgICAg cmV0dXJuOwogCi0gICAgSlNMb2NrSG9sZGVyIGxvY2sobV9lbnZpcm9ubWVudC5zY3JpcHREZWJ1 Z1NlcnZlcigpLnZtKCkpOwotICAgIFNhbXBsaW5nUHJvZmlsZXIqIHNhbXBsaW5nUHJvZmlsZXIg PSBtX2Vudmlyb25tZW50LnNjcmlwdERlYnVnU2VydmVyKCkudm0oKS5zYW1wbGluZ1Byb2ZpbGVy KCk7CisgICAgVk0mIHZtID0gbV9lbnZpcm9ubWVudC5zY3JpcHREZWJ1Z1NlcnZlcigpLnZtKCk7 CisgICAgSlNMb2NrSG9sZGVyIGxvY2sodm0pOworICAgIFNhbXBsaW5nUHJvZmlsZXIqIHNhbXBs aW5nUHJvZmlsZXIgPSB2bS5zYW1wbGluZ1Byb2ZpbGVyKCk7CiAgICAgUkVMRUFTRV9BU1NFUlQo c2FtcGxpbmdQcm9maWxlcik7CiAgICAgTG9ja0hvbGRlciBsb2NrZXIoc2FtcGxpbmdQcm9maWxl ci0+Z2V0TG9jaygpKTsKICAgICBzYW1wbGluZ1Byb2ZpbGVyLT5wYXVzZShsb2NrZXIpOwo=