165493 2016-12-06 14:49:52 -0800 PureNaN: fix typo 2016-12-06 21:18:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jfbastien jfbastien commit-queue fpizlo ggaren keith_miller mark.lam msaboff saam simon.fraser oldest_to_newest 1256988 0 jfbastien 2016-12-06 14:49:52 -0800 I doubt IEEE 854 was the intent. 1256989 1 296326 jfbastien 2016-12-06 14:51:02 -0800 Created attachment 296326 patch 1256990 2 296326 mark.lam 2016-12-06 14:51:36 -0800 Comment on attachment 296326 patch r=me 1256991 3 commit-queue 2016-12-06 14:53:26 -0800 Attachment 296326 did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/PureNaN.h:35: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1257020 4 296326 commit-queue 2016-12-06 15:29:55 -0800 Comment on attachment 296326 patch Clearing flags on attachment: 296326 Committed r209429: <http://trac.webkit.org/changeset/209429> 1257021 5 commit-queue 2016-12-06 15:29:59 -0800 All reviewed patches have been landed. Closing bug. 1257162 6 simon.fraser 2016-12-06 20:26:28 -0800 Can't believe you fixed the typo and not the two spaces after periods in the comment. 1257164 7 jfbastien 2016-12-06 20:34:12 -0800 (In reply to comment #6) > Can't believe you fixed the typo and not the two spaces after periods in the > comment. That's the style throughout the file. I assume that was intentional on Fil's part, but IEEE-854 is actively misleading because it *almost* means something (it's an abandoned standard which IEEE-754 replaced). 1257177 8 fpizlo 2016-12-06 21:18:47 -0800 (In reply to comment #7) > (In reply to comment #6) > > Can't believe you fixed the typo and not the two spaces after periods in the > > comment. > > That's the style throughout the file. I assume that was intentional on Fil's > part, but IEEE-854 is actively misleading because it *almost* means > something (it's an abandoned standard which IEEE-754 replaced). I know I'm not supposed to use two spaces but I'm a terrible person. 296326 2016-12-06 14:51:02 -0800 2016-12-06 15:29:55 -0800 patch 0001-IEEE-754-typo.patch text/plain 1773 jfbastien RnJvbSA0Yzk2MjRiMmMwZmZjODhmMzc1OGU2ODIxYzVlZDgzZTU1M2Y0ODZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKRiBCYXN0aWVuIDxqZmJhc3RpZW5AYXBwbGUuY29tPgpEYXRl OiBUdWUsIDYgRGVjIDIwMTYgMTQ6NDk6NTggLTA4MDAKU3ViamVjdDogW1BBVENIXSBJRUVFLTc1 NCB0eXBvCgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICB8IDkg KysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9QdXJlTmFOLmggfCAyICst CiAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwppbmRleCBiM2I5MGE3Li5hNmQ3YTNjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNi0xMi0wNiAgSkYgQmFzdGllbiAgPGpmYmFz dGllbkBhcHBsZS5jb20+CisKKyAgICAgICAgUHVyZU5hTjogZml4IHR5cG8KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTQ5MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9QdXJlTmFOLmg6 CisKIDIwMTYtMTItMDYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAg IEludHJvZHVjZSB0aGUgY29uY2VwdCBvZiBJbW11dGFibGUgUHJvdG90eXBlIEV4b3RpYyBPYmpl Y3RzIHRvIGNvbXBseSB3aXRoIHRoZSBzcGVjLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvUHVyZU5hTi5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv UHVyZU5hTi5oCmluZGV4IDYyN2JlNjAuLjg1YWRjMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1B1cmVOYU4uaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9QdXJlTmFOLmgKQEAgLTMyLDcgKzMyLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKIC8v IE5hTiAobm90LWEtbnVtYmVyKSBkb3VibGUgdmFsdWVzIGFyZSBjZW50cmFsIHRvIGhvdyBKYXZh U2NyaXB0Q29yZSBlbmNvZGVzIEphdmFTY3JpcHQKIC8vIHZhbHVlcyAoSlNWYWx1ZXMpLiAgQWxs IHZhbHVlcywgaW5jbHVkaW5nIGludGVnZXJzIGFuZCBub24tbnVtZXJpYyB2YWx1ZXMsIGFyZSBh bHdheXMKLS8vIGVuY29kZWQgdXNpbmcgdGhlIElFRUUgODU0IGJpbmFyeSBkb3VibGUgZm9ybWF0 LiAgTm9uLWRvdWJsZSB2YWx1ZXMgYXJlIGVuY29kZWQgdXNpbmcKKy8vIGVuY29kZWQgdXNpbmcg dGhlIElFRUUgNzU0IGJpbmFyeSBkb3VibGUgZm9ybWF0LiAgTm9uLWRvdWJsZSB2YWx1ZXMgYXJl IGVuY29kZWQgdXNpbmcKIC8vIGEgTmFOIHdpdGggdGhlIHNpZ24gYml0IHNldC4gIFRoZSA1MS1i aXQgcGF5bG9hZCBpcyB0aGVuIHVzZWQgZm9yIGVuY29kaW5nIHRoZSBhY3R1YWwKIC8vIHZhbHVl IC0gYmUgaXQgYW4gaW50ZWdlciBvciBhIHBvaW50ZXIgdG8gYW4gb2JqZWN0LCBvciBzb21ldGhp bmcgZWxzZS4gQnV0IHdlIG9ubHkKIC8vIG1ha2UgdXNlIG9mIHRoZSBsb3cgNDkgYml0cyBhbmQg dGhlIHRvcCAxNSBiaXRzIGJlaW5nIGFsbCBzZXQgdG8gMSBpcyB0aGUgaW5kaWNhdG9yCi0tIAoy LjkuMwoK