165489 2016-12-06 14:00:36 -0800 Two tiled drawing tests failing with visual viewports enabled. 2016-12-06 21:15:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser ap simon.fraser zalan oldest_to_newest 1256949 0 simon.fraser 2016-12-06 14:00:36 -0800 [29/132] tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html failed unexpectedly (text diff) [49/132] tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html failed unexpectedly (text diff) Problem is that we update the layout viewport when the visual viewport is empty, for subframes: FrameView 0x121bf0b80 updateLayoutViewport() layoutViewport: (0,0) width=0 height=0 visualViewport: (0,0) width=500 height=300 scroll positions: min: (0,0) max: (0,0) layoutViewport changed to (500,300) width=0 height=0 1257011 1 simon.fraser 2016-12-06 15:18:22 -0800 Marked as flakey in https://trac.webkit.org/changeset/209419 1257169 2 296370 simon.fraser 2016-12-06 21:03:21 -0800 Created attachment 296370 Patch 1257172 3 296370 dino 2016-12-06 21:10:53 -0800 Comment on attachment 296370 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296370&action=review > Source/WebCore/page/FrameView.cpp:1800 > + Get rid of these spaces. 1257174 4 simon.fraser 2016-12-06 21:15:13 -0800 https://trac.webkit.org/r209447 296370 2016-12-06 21:03:21 -0800 2016-12-06 21:10:53 -0800 Patch bug-165489-20161206210243.patch text/plain 7118 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5NDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWVlNGZjYTZiNDJmZTAw ZWUzODE5NjgxZmQ0NjM2ZWJlMzA2MTQ5My4uMjNkYzBiZTM3MzBkMDVjNjZiNzY5Zjk4YjkwYjYz ZmUzOGM2MjhhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTEyLTA2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFR3byB0aWxlZCBk cmF3aW5nIHRlc3RzIGZhaWxpbmcgd2l0aCB2aXN1YWwgdmlld3BvcnRzIGVuYWJsZWQuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU0ODkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjb21wdXRlTGF5b3V0 Vmlld3BvcnRPcmlnaW4oKSBnZXRzIGNhbGxlZCBmb3IgaWZyYW1lcyB3aGVuIHRoZSBsYXlvdXQg dmlld3BvcnQKKyAgICAgICAgaXMgemVyby1zaXplZCwgYnV0IHRoZSB2aXN1YWwgdmlld3BvcnQg aXMgbm9uLXplcm8uIEl0IGRvZXNuJ3QgcmVhbGx5IG1ha2Ugc2Vuc2UKKyAgICAgICAgdG8gY29t cHV0ZSBhIGxheW91dCB2aWV3cG9ydCB3aGVuIHRoZSB2aXN1YWwgdmlld3BvcnQgaXMgbGFyZ2Vy IHRoYW4gdGhlIGxheW91dAorICAgICAgICB2aWV3cG9ydCwgYnV0IGlmIHRoaXMgaGFwcGVucyBq dXN0IGFuY2hvciB0aGUgbGF5b3V0IHZpZXdwb3J0IGF0IHRoZSBvcmlnaW4KKyAgICAgICAgb2Yg dGhlIHZpc3VhbCB2aWV3cG9ydC4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6Y29tcHV0ZUxheW91dFZpZXdwb3J0T3JpZ2luKToK KwogMjAxNi0xMi0wNiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAg ICAgIFtNb2Rlcm4gTWVkaWEgQ29udHJvbHNdIEluc3RhbnRpYXRlIGlPUyBtZWRpYSBjb250cm9s cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDk3Y2RkZTkzNmIzZmYwZjZlNWQzMWM1 YzkzNzU4NTA1ZmYxYTdkZTIuLmNjMjEwMTdhYWJhOWQ0NTRlM2VjYTVjYjVmODZlYjM0OWYyZjYx ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTE3OTcsMTggKzE3OTcsMjYgQEAg dm9pZCBGcmFtZVZpZXc6OnJlbW92ZVZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3QoUmVuZGVyRWxl bWVudCogb2JqZWN0KQogTGF5b3V0UG9pbnQgRnJhbWVWaWV3Ojpjb21wdXRlTGF5b3V0Vmlld3Bv cnRPcmlnaW4oY29uc3QgTGF5b3V0UmVjdCYgdmlzdWFsVmlld3BvcnQsIGNvbnN0IExheW91dFBv aW50JiBzdGFibGVMYXlvdXRWaWV3cG9ydE9yaWdpbk1pbiwgY29uc3QgTGF5b3V0UG9pbnQmIHN0 YWJsZUxheW91dFZpZXdwb3J0T3JpZ2luTWF4LCBjb25zdCBMYXlvdXRSZWN0JiBsYXlvdXRWaWV3 cG9ydCkKIHsKICAgICBMYXlvdXRQb2ludCBsYXlvdXRWaWV3cG9ydE9yaWdpbiA9IGxheW91dFZp ZXdwb3J0LmxvY2F0aW9uKCk7Ci0KLSAgICBpZiAodmlzdWFsVmlld3BvcnQueCgpIDwgbGF5b3V0 Vmlld3BvcnQueCgpIHx8IHZpc3VhbFZpZXdwb3J0LngoKSA8IHN0YWJsZUxheW91dFZpZXdwb3J0 T3JpZ2luTWluLngoKSkKKyAgICAKKyAgICBpZiAodmlzdWFsVmlld3BvcnQud2lkdGgoKSA+IGxh eW91dFZpZXdwb3J0LndpZHRoKCkpCiAgICAgICAgIGxheW91dFZpZXdwb3J0T3JpZ2luLnNldFgo dmlzdWFsVmlld3BvcnQueCgpKTsKKyAgICBlbHNlIHsKKyAgICAgICAgaWYgKHZpc3VhbFZpZXdw b3J0LngoKSA8IGxheW91dFZpZXdwb3J0LngoKSB8fCB2aXN1YWxWaWV3cG9ydC54KCkgPCBzdGFi bGVMYXlvdXRWaWV3cG9ydE9yaWdpbk1pbi54KCkpCisgICAgICAgICAgICBsYXlvdXRWaWV3cG9y dE9yaWdpbi5zZXRYKHZpc3VhbFZpZXdwb3J0LngoKSk7CiAKLSAgICBpZiAodmlzdWFsVmlld3Bv cnQueSgpIDwgbGF5b3V0Vmlld3BvcnQueSgpIHx8IHZpc3VhbFZpZXdwb3J0LnkoKSA8IHN0YWJs ZUxheW91dFZpZXdwb3J0T3JpZ2luTWluLnkoKSkKLSAgICAgICAgbGF5b3V0Vmlld3BvcnRPcmln aW4uc2V0WSh2aXN1YWxWaWV3cG9ydC55KCkpOworICAgICAgICBpZiAodmlzdWFsVmlld3BvcnQu bWF4WCgpID4gbGF5b3V0Vmlld3BvcnQubWF4WCgpIHx8ICh2aXN1YWxWaWV3cG9ydC5tYXhYKCkg LSBsYXlvdXRWaWV3cG9ydC53aWR0aCgpKSA+IHN0YWJsZUxheW91dFZpZXdwb3J0T3JpZ2luTWF4 LngoKSkKKyAgICAgICAgICAgIGxheW91dFZpZXdwb3J0T3JpZ2luLnNldFgodmlzdWFsVmlld3Bv cnQubWF4WCgpIC0gbGF5b3V0Vmlld3BvcnQud2lkdGgoKSk7CisgICAgfQogCi0gICAgaWYgKHZp c3VhbFZpZXdwb3J0Lm1heFgoKSA+IGxheW91dFZpZXdwb3J0Lm1heFgoKSB8fCAodmlzdWFsVmll d3BvcnQubWF4WCgpIC0gbGF5b3V0Vmlld3BvcnQud2lkdGgoKSkgPiBzdGFibGVMYXlvdXRWaWV3 cG9ydE9yaWdpbk1heC54KCkpCi0gICAgICAgIGxheW91dFZpZXdwb3J0T3JpZ2luLnNldFgodmlz dWFsVmlld3BvcnQubWF4WCgpIC0gbGF5b3V0Vmlld3BvcnQud2lkdGgoKSk7CisgICAgaWYgKHZp c3VhbFZpZXdwb3J0LmhlaWdodCgpID4gbGF5b3V0Vmlld3BvcnQuaGVpZ2h0KCkpCisgICAgICAg IGxheW91dFZpZXdwb3J0T3JpZ2luLnNldFkodmlzdWFsVmlld3BvcnQueSgpKTsKKyAgICBlbHNl IHsKKyAgICAgICAgaWYgKHZpc3VhbFZpZXdwb3J0LnkoKSA8IGxheW91dFZpZXdwb3J0LnkoKSB8 fCB2aXN1YWxWaWV3cG9ydC55KCkgPCBzdGFibGVMYXlvdXRWaWV3cG9ydE9yaWdpbk1pbi55KCkp CisgICAgICAgICAgICBsYXlvdXRWaWV3cG9ydE9yaWdpbi5zZXRZKHZpc3VhbFZpZXdwb3J0Lnko KSk7CiAKLSAgICBpZiAodmlzdWFsVmlld3BvcnQubWF4WSgpID4gbGF5b3V0Vmlld3BvcnQubWF4 WSgpIHx8ICh2aXN1YWxWaWV3cG9ydC5tYXhZKCkgLSBsYXlvdXRWaWV3cG9ydC5oZWlnaHQoKSkg PiBzdGFibGVMYXlvdXRWaWV3cG9ydE9yaWdpbk1heC55KCkpCi0gICAgICAgIGxheW91dFZpZXdw b3J0T3JpZ2luLnNldFkodmlzdWFsVmlld3BvcnQubWF4WSgpIC0gbGF5b3V0Vmlld3BvcnQuaGVp Z2h0KCkpOworICAgICAgICBpZiAodmlzdWFsVmlld3BvcnQubWF4WSgpID4gbGF5b3V0Vmlld3Bv cnQubWF4WSgpIHx8ICh2aXN1YWxWaWV3cG9ydC5tYXhZKCkgLSBsYXlvdXRWaWV3cG9ydC5oZWln aHQoKSkgPiBzdGFibGVMYXlvdXRWaWV3cG9ydE9yaWdpbk1heC55KCkpCisgICAgICAgICAgICBs YXlvdXRWaWV3cG9ydE9yaWdpbi5zZXRZKHZpc3VhbFZpZXdwb3J0Lm1heFkoKSAtIGxheW91dFZp ZXdwb3J0LmhlaWdodCgpKTsKKyAgICB9CiAKICAgICByZXR1cm4gbGF5b3V0Vmlld3BvcnRPcmln aW47CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKaW5kZXggOTJmMzk1MmY2NTIxNmJhMDFkYWQzZGVhZTdjMmJkNjRlOTZiYTY2NS4u ZjVhNWJhMDY0ZWYxMWFjNjE5ZTgwYjZhZDkzYzVjOTg2OWFmOTVjYyAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDE4IEBACiAyMDE2LTEyLTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29t PgogCisgICAgICAgIFR3byB0aWxlZCBkcmF3aW5nIHRlc3RzIGZhaWxpbmcgd2l0aCB2aXN1YWwg dmlld3BvcnRzIGVuYWJsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjU0ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KyAgICAgICAgCisgICAgICAgIFJlYmFzZWxpbmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMt d2syL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogdGlsZWQtZHJhd2luZy9zY3JvbGxpbmcv ZnJhbWVzL2Nvb3JkaW5hdGVkLWZyYW1lLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiB0aWxlZC1k cmF3aW5nL3Njcm9sbGluZy9mcmFtZXMvY29vcmRpbmF0ZWQtZnJhbWUtaW4tZml4ZWQtZXhwZWN0 ZWQudHh0OgorCisyMDE2LTEyLTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgorCiAgICAgICAgIEZpeCBiZWhhdmlvciBvZiBiYWNrZ3JvdW5kLWF0dGFjaG1lbnQ6Zml4 ZWQgd2l0aCB2aXN1YWwgdmlld3BvcnRzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjU0NjUKICAgICAgICAgCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggODE2ZGE5ZTU0NTU1MzAyMDQ3OTM5MDVh ZTcyYjMxMGRkZjNmMTlmZC4uNWE1Y2IzZWU0MTI0MjBjYmQ3ZDU5ZDM3ZTc2ZDY5MWE3ZjgxYmI0 NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRp b25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucwpA QCAtMjY3LDggKzI2Nyw2IEBAIHdlYmtpdC5vcmcvYi8xNjI1MDUgdGlsZWQtZHJhd2luZy9zY3Jv bGxpbmcvbGF0Y2hlZC1kaXYtd2l0aC1zY3JvbGwtc25hcC5odG1sIFsKIHdlYmtpdC5vcmcvYi8x NDg0MDcgdGlsZWQtZHJhd2luZy9zY3JvbGxpbmcvc2Nyb2xsLXNuYXAvc2Nyb2xsLXNuYXAtbWFu ZGF0b3J5LW1haW5mcmFtZS1zbG93LWhvcml6b250YWwuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3 ZWJraXQub3JnL2IvMTQ4NDA3IHRpbGVkLWRyYXdpbmcvc2Nyb2xsaW5nL3Njcm9sbC1zbmFwL3Nj cm9sbC1zbmFwLW1hbmRhdG9yeS1tYWluZnJhbWUtc2xvdy12ZXJ0aWNhbC5odG1sIFsgUGFzcyBG YWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xNjUxOTYgdGlsZWQtZHJhd2luZy9zY3JvbGxpbmcvc2Ny b2xsLXNuYXAvc2Nyb2xsLXNuYXAtaWZyYW1lLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotd2Via2l0 Lm9yZy9iLzE2NTQ4OSB0aWxlZC1kcmF3aW5nL3Njcm9sbGluZy9mcmFtZXMvY29vcmRpbmF0ZWQt ZnJhbWUtZ2Fpbi1zY3JvbGxpbmctYW5jZXN0b3IuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCi13ZWJr aXQub3JnL2IvMTY1NDg5IHRpbGVkLWRyYXdpbmcvc2Nyb2xsaW5nL2ZyYW1lcy9jb29yZGluYXRl ZC1mcmFtZS1sb3NlLXNjcm9sbGluZy1hbmNlc3Rvci5odG1sIFsgUGFzcyBGYWlsdXJlIF0KIAog d2Via2l0Lm9yZy9iLzE0ODQwOCB0aWxlZC1kcmF3aW5nL3Njcm9sbGluZy9yb290LW92ZXJmbG93 LXdpdGgtbW91c2V3aGVlbC5odG1sIFsgUGFzcyBGYWlsdXJlIFRpbWVvdXQgXQogCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy90aWxlZC1kcmF3aW5nL3Njcm9sbGluZy9mcmFtZXMvY29vcmRpbmF0 ZWQtZnJhbWUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvdGlsZWQtZHJhd2luZy9zY3JvbGxp bmcvZnJhbWVzL2Nvb3JkaW5hdGVkLWZyYW1lLWV4cGVjdGVkLnR4dAppbmRleCA4MmUyOTUwMGNm OTgyZmRjMjdjMmI5ODE5ZTIyMzBkZTBlMzE0ODZiLi5jNWRhZTE4MTA5NDQ4OWMxYjNjNWI1MmY1 NjA3Y2RjMWVjNjNjMmNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy90aWxlZC1kcmF3aW5nL3Nj cm9sbGluZy9mcmFtZXMvY29vcmRpbmF0ZWQtZnJhbWUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91 dFRlc3RzL3RpbGVkLWRyYXdpbmcvc2Nyb2xsaW5nL2ZyYW1lcy9jb29yZGluYXRlZC1mcmFtZS1l eHBlY3RlZC50eHQKQEAgLTEwLDcgKzEwLDcgQEAKICAgICAoRnJhbWUgc2Nyb2xsaW5nIG5vZGUK ICAgICAgIChzY3JvbGxhYmxlIGFyZWEgc2l6ZSA0ODUgMzAwKQogICAgICAgKGNvbnRlbnRzIHNp emUgNDg1IDQyMCkKLSAgICAgIChsYXlvdXQgdmlld3BvcnQgYXQgKDUwMCwzMDApIHNpemUgNDg1 eDMwMCkKKyAgICAgIChsYXlvdXQgdmlld3BvcnQgYXQgKDAsMCkgc2l6ZSA0ODV4MzAwKQogICAg ICAgKG1pbiBsYXlvdXQgdmlld3BvcnQgb3JpZ2luICgwLDApKQogICAgICAgKG1heCBsYXlvdXQg dmlld3BvcnQgb3JpZ2luICgwLDEyMCkpCiAgICAgICAoY2hpbGRyZW4gMQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvdGlsZWQtZHJhd2luZy9zY3JvbGxpbmcvZnJhbWVzL2Nvb3JkaW5hdGVkLWZy YW1lLWluLWZpeGVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3RpbGVkLWRyYXdpbmcvc2Ny b2xsaW5nL2ZyYW1lcy9jb29yZGluYXRlZC1mcmFtZS1pbi1maXhlZC1leHBlY3RlZC50eHQKaW5k ZXggYWVkMTc4NjRiMTAyZWMwMWMwMGVhODRlZjVhYTc4OWUzMTJhYTMwMC4uZWI3NGQ4ODNmMjM0 OTQ5MmMxYWMzZDQyODU4YWYyOGEzZTQ0Mjk2ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvdGls ZWQtZHJhd2luZy9zY3JvbGxpbmcvZnJhbWVzL2Nvb3JkaW5hdGVkLWZyYW1lLWluLWZpeGVkLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy90aWxlZC1kcmF3aW5nL3Njcm9sbGluZy9mcmFt ZXMvY29vcmRpbmF0ZWQtZnJhbWUtaW4tZml4ZWQtZXhwZWN0ZWQudHh0CkBAIC0xNSw3ICsxNSw3 IEBACiAgICAgICAgIChGcmFtZSBzY3JvbGxpbmcgbm9kZQogICAgICAgICAgIChzY3JvbGxhYmxl IGFyZWEgc2l6ZSA0ODUgMzAwKQogICAgICAgICAgIChjb250ZW50cyBzaXplIDQ4NSA0MjApCi0g ICAgICAgICAgKGxheW91dCB2aWV3cG9ydCBhdCAoNTAwLDMwMCkgc2l6ZSA0ODV4MzAwKQorICAg ICAgICAgIChsYXlvdXQgdmlld3BvcnQgYXQgKDAsMCkgc2l6ZSA0ODV4MzAwKQogICAgICAgICAg IChtaW4gbGF5b3V0IHZpZXdwb3J0IG9yaWdpbiAoMCwwKSkKICAgICAgICAgICAobWF4IGxheW91 dCB2aWV3cG9ydCBvcmlnaW4gKDAsMTIwKSkKICAgICAgICAgICAoY2hpbGRyZW4gMQo=