165453 2016-12-05 20:01:33 -0800 check-webkit-style: false positive caused by regex literal matching in SingleQuoteChecker 2017-07-20 15:59:07 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 mattbaker webkit-unassigned joepeck lforschler ross.kirsling webkit-bug-importer oldest_to_newest 1256690 0 mattbaker 2016-12-05 20:01:33 -0800 SingleQuoteChecker strips out regex literals before checking for single quotes, which is a good thing. Unfortunately, the regex that does this matches the wrong thing when a regex contains a forward slash: Tools/Scripts/webkitpy/style/checkers/js.py: 88: line = re.sub('/.+?/', '//', line) Input: /[/'"]/ Expect: ^-----^ Actual: ^-^ Output: //'"]/ 1256692 1 mattbaker 2016-12-05 20:07:46 -0800 Forward slash should be escaped: Input: /[\/'"]/ Expect: ^------^ Actual: ^--^ 1307021 2 ross.kirsling 2017-05-10 14:44:06 -0700 This checker has many other problems too -- it doesn't support template strings, it doesn't allow multiline strings to share a line with actual code, and it doesn't allow you to start a line with (whitespace and) a multiplication operator. Given that ESLint does this properly with an actual parser, it would seem advisable to drop this checker altogether. 1307027 3 ross.kirsling 2017-05-10 14:56:17 -0700 To be clearer: > return `'${foo}'`; is viewed as an error, while > return 'foo'; /* bar */ is not. 1330812 4 webkit-bug-importer 2017-07-20 15:59:07 -0700 <rdar://problem/33440119>