165451 2016-12-05 18:42:54 -0800 Cleanup: Rename some HTTP 0.9-specific functions to conform to WebKit Code Style Guidelines 2016-12-06 09:47:19 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates cdumez commit-queue esprehn+autocc kangil.han oldest_to_newest 1256668 0 dbates 2016-12-05 18:42:54 -0800 The functions Document::shouldEnforceHTTP0_9Sandbox() and ResourceResponseBase::isHttpVersion0_9() do not conform the naming conventions in the WebKit Code Style Guidelines. We should rename them so that they conform to the guidelines and are more consistent with the rest of the codebase. 1256671 1 296244 dbates 2016-12-05 18:49:26 -0800 Created attachment 296244 Patch I chose to standardize on the substring "HTTP09" in the names of these functions. Would "HTTPVersion09" be more understandable? I am open to naming suggestions. 1256844 2 296244 dbates 2016-12-06 09:47:15 -0800 Comment on attachment 296244 Patch Clearing flags on attachment: 296244 Committed r209403: <http://trac.webkit.org/changeset/209403> 1256845 3 dbates 2016-12-06 09:47:19 -0800 All reviewed patches have been landed. Closing bug. 296244 2016-12-05 18:49:26 -0800 2016-12-06 09:47:15 -0800 Patch bug-165451-20161205184850.patch text/plain 6617 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MzczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzQ0ZjA5NmU5MDg1Y2Qy MTFhOWQ2ZmFiN2RkMTFjYjE2MGUyZTliYi4uYzVlNjQ2YTc4ZDdjNjI3NWNmNDRiNjgxZmFmNjkx OTAzMTg4ZDg4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTEyLTA1ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbnVwOiBSZW5hbWUg c29tZSBIVFRQIDAuOS1zcGVjaWZpYyBmdW5jdGlvbnMgdG8gY29uZm9ybSB0byBXZWJLaXQgQ29k ZSBTdHlsZSBHdWlkZWxpbmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjU0NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW5hbWUgRG9jdW1lbnQ6OnNob3VsZEVuZm9yY2VIVFRQMF85U2FuZGJveCgp IGFuZCBSZXNvdXJjZVJlc3BvbnNlQmFzZTo6aXNIdHRwVmVyc2lvbjBfOSgpCisgICAgICAgIHRv IERvY3VtZW50OjpzaG91bGRFbmZvcmNlSFRUUDA5U2FuZGJveCgpIGFuZCBSZXNvdXJjZVJlc3Bv bnNlQmFzZTo6aXNIVFRQMDksIHJlc3BlY3RpdmVseSwKKyAgICAgICAgdG8gY29uZm9ybSB0byB0 aGUgV2ViS2l0IENvZGUgU3R5bGUgR3VpZGVsaW5lcy4KKworICAgICAgICAqIGRvbS9Eb2N1bWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6aW5pdFNlY3VyaXR5Q29udGV4dCk6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6c2hvdWxkRW5mb3JjZUhUVFAwOVNhbmRib3gp OiBSZW5hbWVkOyBmb3JtZXJseSBuYW1lZCBzaG91bGRFbmZvcmNlSFRUUDBfOVNhbmRib3gKKyAg ICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291 cmNlSGFuZGxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFuZGxlOjpkaWRSZWNl aXZlUmVzcG9uc2UpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNwb25z ZUJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZUJhc2U6OmlzSFRU UDA5KTogUmVuYW1lZDsgZm9ybWVybHkgbmFtZWQgaXNIdHRwVmVyc2lvbjBfOS4KKyAgICAgICAg KiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmg6CisKIDIwMTYtMTEtMjkg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBWZWN0b3I6 OnVuY2hlY2tlZEFwcGVuZCgpIGluIG1vcmUgcGxhY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTk5ZjY2MDI1 ZWE3Yzk4NTljYmZjNDU1YWIwNDY4ZDIxY2FlMjczYy4uMGQ4YzZkMzk4ODA2ZGQ4NjJlOTIyZTg0 MDEzMTBjNTQyZWY1OTg5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTEyLTA1 ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbnVwOiBS ZW5hbWUgc29tZSBIVFRQIDAuOS1zcGVjaWZpYyBmdW5jdGlvbnMgdG8gY29uZm9ybSB0byBXZWJL aXQgQ29kZSBTdHlsZSBHdWlkZWxpbmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjU0NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtEYXRhVGFzay5jcHA6Cisg ICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFzazo6ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKwog MjAxNi0xMi0wNSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAg ICAgICBBZG9wdCBDQU1hY2hQb3J0LWFzLWxheWVyLWNvbnRlbnRzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmNwcAppbmRleCBmZWU1NzkyNWExNjg5N2YwZWE1MjlhM2Q4ODI5ZDgwZGVkZjcxODU3Li5mZDRj NmVkM2E0ODdlMWI4MTEwZGZhY2ZlY2RkMTVkYjMxMDA3NTJiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKQEAgLTUxMjksNyArNTEyOSw3IEBAIHZvaWQgRG9jdW1lbnQ6OmluaXRTZWN1cml0eUNv bnRleHQoKQogICAgICAgICBhcHBseVF1aWNrTG9va1NhbmRib3goKTsKICNlbmRpZgogCi0gICAg aWYgKHNob3VsZEVuZm9yY2VIVFRQMF85U2FuZGJveCgpKSB7CisgICAgaWYgKHNob3VsZEVuZm9y Y2VIVFRQMDlTYW5kYm94KCkpIHsKICAgICAgICAgU3RyaW5nIG1lc3NhZ2UgPSBtYWtlU3RyaW5n KCJTYW5kYm94aW5nICciLCBtX3VybC5zdHJpbmdDZW50ZXJFbGxpcHNpemVkVG9MZW5ndGgoKSwg IicgYmVjYXVzZSBpdCBpcyB1c2luZyBIVFRQLzAuOS4iKTsKICAgICAgICAgYWRkQ29uc29sZU1l c3NhZ2UoTWVzc2FnZVNvdXJjZTo6U2VjdXJpdHksIE1lc3NhZ2VMZXZlbDo6RXJyb3IsIG1lc3Nh Z2UpOwogICAgICAgICBlbmZvcmNlU2FuZGJveEZsYWdzKFNhbmRib3hTY3JpcHRzIHwgU2FuZGJv eFBsdWdpbnMpOwpAQCAtNjkxOSwxMiArNjkxOSwxMiBAQCBTaG91bGRPcGVuRXh0ZXJuYWxVUkxz UG9saWN5IERvY3VtZW50OjpzaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5VG9Qcm9wYWdhdGUo KQogICAgIHJldHVybiBTaG91bGRPcGVuRXh0ZXJuYWxVUkxzUG9saWN5OjpTaG91bGROb3RBbGxv dzsKIH0KIAotYm9vbCBEb2N1bWVudDo6c2hvdWxkRW5mb3JjZUhUVFAwXzlTYW5kYm94KCkgY29u c3QKK2Jvb2wgRG9jdW1lbnQ6OnNob3VsZEVuZm9yY2VIVFRQMDlTYW5kYm94KCkgY29uc3QKIHsK ICAgICBpZiAobV9pc1N5bnRoZXNpemVkIHx8ICFtX2ZyYW1lKQogICAgICAgICByZXR1cm4gZmFs c2U7CiAgICAgRG9jdW1lbnRMb2FkZXIqIGRvY3VtZW50TG9hZGVyID0gbV9mcmFtZS0+bG9hZGVy KCkuYWN0aXZlRG9jdW1lbnRMb2FkZXIoKTsKLSAgICByZXR1cm4gZG9jdW1lbnRMb2FkZXIgJiYg ZG9jdW1lbnRMb2FkZXItPnJlc3BvbnNlKCkuaXNIdHRwVmVyc2lvbjBfOSgpOworICAgIHJldHVy biBkb2N1bWVudExvYWRlciAmJiBkb2N1bWVudExvYWRlci0+cmVzcG9uc2UoKS5pc0hUVFAwOSgp OwogfQogCiAjaWYgVVNFKFFVSUNLX0xPT0spCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IDUwZTJi ODM5MjJjYTlhMWVhMTM1MjI4NGQ2MzAxN2Y3OTgxMzAyNDAuLjgyMjVkYTdhNGUxMTI5M2Y0OGNi M2JmYWIzMTQyODBiMWZmMGI0MzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC0xMzk0LDcgKzEz OTQsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgYXBwbHlRdWlja0xvb2tTYW5kYm94KCk7CiAjZW5k aWYKIAotICAgIGJvb2wgc2hvdWxkRW5mb3JjZUhUVFAwXzlTYW5kYm94KCkgY29uc3Q7CisgICAg Ym9vbCBzaG91bGRFbmZvcmNlSFRUUDA5U2FuZGJveCgpIGNvbnN0OwogCiAgICAgdW5zaWduZWQg bV9yZWZlcmVuY2luZ05vZGVDb3VudDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9SZXNvdXJjZUhhbmRsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL1Jlc291cmNlSGFuZGxlLmNwcAppbmRleCA2NDdmNjA0MTliZmNkMGZlZTYzNzVk OWQxODgwNzY1OTJhMWY5MjBjLi4wZTU2OTZhNjg5ZDk4MTg4NDI0NzM0MDE2ZWE5OGQyNTcxNDEx MjEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNl SGFuZGxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNl SGFuZGxlLmNwcApAQCAtMTUyLDcgKzE1Miw3IEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6OmNsZWFy Q2xpZW50KCkKIAogdm9pZCBSZXNvdXJjZUhhbmRsZTo6ZGlkUmVjZWl2ZVJlc3BvbnNlKFJlc291 cmNlUmVzcG9uc2UmJiByZXNwb25zZSkKIHsKLSAgICBpZiAocmVzcG9uc2UuaXNIdHRwVmVyc2lv bjBfOSgpKSB7CisgICAgaWYgKHJlc3BvbnNlLmlzSFRUUDA5KCkpIHsKICAgICAgICAgYXV0byB1 cmwgPSByZXNwb25zZS51cmwoKTsKICAgICAgICAgc3RkOjpvcHRpb25hbDx1aW50MTZfdD4gcG9y dCA9IHVybC5wb3J0KCk7CiAgICAgICAgIGlmIChwb3J0ICYmICFpc0RlZmF1bHRQb3J0Rm9yUHJv dG9jb2wocG9ydC52YWx1ZSgpLCB1cmwucHJvdG9jb2woKSkpIHsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5jcHAKaW5k ZXggZmE0NThhMjRkZmMwZWEyNjA5MGM5MDNkNWY3YWQwN2NjZmRlMmQ5NS4uODRiMmM1MDQwYzk4 MmNkNjFkMDRjODQxOWY0OTMwNTEwMjJjNWY5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlc3BvbnNlQmFzZS5jcHAKQEAgLTI3OCw3 ICsyNzgsNyBAQCB2b2lkIFJlc291cmNlUmVzcG9uc2VCYXNlOjpzZXRIVFRQVmVyc2lvbihjb25z dCBTdHJpbmcmIHZlcnNpb25UZXh0KQogICAgIC8vIEZJWE1FOiBTaG91bGQgaW52YWxpZGF0ZSBv ciB1cGRhdGUgcGxhdGZvcm0gcmVzcG9uc2UgaWYgcHJlc2VudC4KIH0KIAotYm9vbCBSZXNvdXJj ZVJlc3BvbnNlQmFzZTo6aXNIdHRwVmVyc2lvbjBfOSgpIGNvbnN0Citib29sIFJlc291cmNlUmVz cG9uc2VCYXNlOjppc0hUVFAwOSgpIGNvbnN0CiB7CiAgICAgbGF6eUluaXQoQWxsRmllbGRzKTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJl c3BvbnNlQmFzZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJl c3BvbnNlQmFzZS5oCmluZGV4IDlkMjJmNGZmMTEyMmFiOGIzM2EwMGRkN2RjOWNmYTQ2ZWM4NjRi NjMuLmYzNWVkYzY5Mzk4N2VmZjQ5YjVhY2U5ZTZjZThhOTQzZjA2ZWE1MzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXNwb25zZUJhc2UuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNl LmgKQEAgLTkyLDcgKzkyLDcgQEAgcHVibGljOgogCiAgICAgV0VCQ09SRV9FWFBPUlQgY29uc3Qg U3RyaW5nJiBodHRwVmVyc2lvbigpIGNvbnN0OwogICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgc2V0 SFRUUFZlcnNpb24oY29uc3QgU3RyaW5nJik7Ci0gICAgV0VCQ09SRV9FWFBPUlQgYm9vbCBpc0h0 dHBWZXJzaW9uMF85KCkgY29uc3Q7CisgICAgV0VCQ09SRV9FWFBPUlQgYm9vbCBpc0hUVFAwOSgp IGNvbnN0OwogCiAgICAgV0VCQ09SRV9FWFBPUlQgY29uc3QgSFRUUEhlYWRlck1hcCYgaHR0cEhl YWRlckZpZWxkcygpIGNvbnN0OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrRGF0YVRhc2suY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvTmV0d29ya0RhdGFUYXNrLmNwcAppbmRleCA5YmZhNGVjNjRjODQ3MGM3ZGJlYmNlNGZmZTNi ZmMwNGM4NTYzYjkwLi40M2YyYmE0NWY5NTkxNzJiMzNhY2IwM2I2Mzk4M2Q0YjEyNzU1ZTUyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrRGF0YVRhc2su Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtEYXRhVGFzay5j cHAKQEAgLTk3LDcgKzk3LDcgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2s6OnNjaGVkdWxlRmFpbHVy ZShGYWlsdXJlVHlwZSB0eXBlKQogdm9pZCBOZXR3b3JrRGF0YVRhc2s6OmRpZFJlY2VpdmVSZXNw b25zZShSZXNvdXJjZVJlc3BvbnNlJiYgcmVzcG9uc2UsIFJlc3BvbnNlQ29tcGxldGlvbkhhbmRs ZXImJiBjb21wbGV0aW9uSGFuZGxlcikKIHsKICAgICBBU1NFUlQobV9jbGllbnQpOwotICAgIGlm IChyZXNwb25zZS5pc0h0dHBWZXJzaW9uMF85KCkpIHsKKyAgICBpZiAocmVzcG9uc2UuaXNIVFRQ MDkoKSkgewogICAgICAgICBhdXRvIHVybCA9IHJlc3BvbnNlLnVybCgpOwogICAgICAgICBzdGQ6 Om9wdGlvbmFsPHVpbnQxNl90PiBwb3J0ID0gdXJsLnBvcnQoKTsKICAgICAgICAgaWYgKHBvcnQg JiYgIWlzRGVmYXVsdFBvcnRGb3JQcm90b2NvbChwb3J0LnZhbHVlKCksIHVybC5wcm90b2NvbCgp KSkgewo=