165435 2016-12-05 16:41:00 -0800 After preventing a beforeinput event, an input event is fired when formatting rich text 2016-12-06 20:37:26 -0800 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue enrica rniwa webkit-bug-importer oldest_to_newest 1256591 0 wenson_hsieh 2016-12-05 16:41:00 -0800 To reproduce: 1. Go to whsieh.github.io/examples/input-events 2. Type some text 3. Check 'formatBold' on the side 4. Select the text and use the context menu to bold it Expected: beforeinput event fired, but no input event Observed: both events are fired 1256594 1 wenson_hsieh 2016-12-05 16:45:15 -0800 <rdar://problem/29522314> 1256607 2 296222 wenson_hsieh 2016-12-05 17:00:20 -0800 Created attachment 296222 Patch 1257165 3 296222 commit-queue 2016-12-06 20:37:22 -0800 Comment on attachment 296222 Patch Clearing flags on attachment: 296222 Committed r209445: <http://trac.webkit.org/changeset/209445> 1257166 4 commit-queue 2016-12-06 20:37:26 -0800 All reviewed patches have been landed. Closing bug. 296222 2016-12-05 17:00:20 -0800 2016-12-06 20:37:22 -0800 Patch bug-165435-20161205165944.patch text/plain 5850 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTNkNTJlM2JiNzQyODA2 ODUyYzUyNWIwYTJiMDI5OTY2NWJlODFmMi4uYzU1NzJmYjg0NmYwNzAzYWVkOWI3ZWYyNzg4OTli NDVlNTZiZjY4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTEyLTA1ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEFmdGVyIHByZXZl bnRpbmcgYSBiZWZvcmVpbnB1dCBldmVudCwgYW4gaW5wdXQgZXZlbnQgaXMgZmlyZWQgd2hlbiBm b3JtYXR0aW5nIHJpY2ggdGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY1NDM1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTUyMjMxND4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHJlZ3Jl c3NlZCBhZnRlciBJIHJlZmFjdG9yZWQgc29tZSBpbnB1dCBldmVudCBldmVudCBkaXNwYXRjaCBs b2dpYyB3aGVuIGZvcm1hdHRpbmcgdGV4dCBpbiByMjA4NDYxLgorICAgICAgICBJIG1vdmVkIHRo ZSBsb2dpYyBmb3IgZGlzcGF0Y2hpbmcgaW5wdXQgZXZlbnRzIHdoZW4gYXBwbHlpbmcgc3R5bGVz IGludG8gRWRpdG9yOjphcHBseVN0eWxlLCBidXQgbGVmdCBvdXQgYW4KKyAgICAgICAgZWFybHkg cmV0dXJuIGFmdGVyIGZpcmluZyB0aGUgYmVmb3JlaW5wdXQgZXZlbnQgaWYgdGhlIGRlZmF1bHQg YmVoYXZpb3Igd2FzIHByZXZlbnRlZCwgd2hpY2ggY2F1c2VkIHVzIHRvCisgICAgICAgIGNvbnRp bnVlIG9uIGFuZCBkaXNwYXRjaCBhbiBpbnB1dCBldmVudC4gVGhlIGZpeCBpcyB0byBiYWlsIGZy b20gYXBwbHlTdHlsZSBpZiBkZWZhdWx0IHdhcyBwcmV2ZW50ZWQuCisKKyAgICAgICAgQXVnbWVu dGVkIGFuIGV4aXN0aW5nIGxheW91dCB0ZXN0IHRvIGNvdmVyIHRoaXMgY2FzZS4KKworICAgICAg ICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRvcjo6YXBwbHlT dHlsZSk6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6OmFwcGx5UGFyYWdyYXBoU3R5bGUpOgor CiAyMDE2LTExLTMwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCBzcGVjdWxhdGl2ZSBjbWFrZSBidWlsZGZpeCBhZnRlciByMjA5MDcw LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCmluZGV4IDIwZTZiMGMyYjc0Y2FmY2VlYTIyOGY4 MmNjZTIyMmJjNWZjMTdhMzcuLmE5ZWY2ZmVjNDk2NjU2N2JiNjllYTgzOGY2NDdlOGY4YThlOWE3 NDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKQEAgLTc5MiwxNyArNzkyLDE4IEBAIHZv aWQgRWRpdG9yOjphcHBseVN0eWxlKFJlZlB0cjxFZGl0aW5nU3R5bGU+JiYgc3R5bGUsIEVkaXRB Y3Rpb24gZWRpdGluZ0FjdGlvbikKICAgICBTdHJpbmcgaW5wdXRUeXBlTmFtZSA9IGlucHV0VHlw ZU5hbWVGb3JFZGl0aW5nQWN0aW9uKGVkaXRpbmdBY3Rpb24pOwogICAgIFN0cmluZyBpbnB1dEV2 ZW50RGF0YSA9IGlucHV0RXZlbnREYXRhRm9yRWRpdGluZ1N0eWxlQW5kQWN0aW9uKCpzdHlsZSwg ZWRpdGluZ0FjdGlvbik7CiAgICAgUmVmUHRyPEVsZW1lbnQ+IGVsZW1lbnQgPSBtX2ZyYW1lLnNl bGVjdGlvbigpLnNlbGVjdGlvbigpLnJvb3RFZGl0YWJsZUVsZW1lbnQoKTsKLSAgICBpZiAoIWVs ZW1lbnQgfHwgZGlzcGF0Y2hCZWZvcmVJbnB1dEV2ZW50KCplbGVtZW50LCBpbnB1dFR5cGVOYW1l LCBpbnB1dEV2ZW50RGF0YSkpIHsKLSAgICAgICAgc3dpdGNoKHNlbGVjdGlvblR5cGUpIHsKLSAg ICAgICAgY2FzZSBWaXNpYmxlU2VsZWN0aW9uOjpDYXJldFNlbGVjdGlvbjoKLSAgICAgICAgICAg IGNvbXB1dGVBbmRTZXRUeXBpbmdTdHlsZSgqc3R5bGUsIGVkaXRpbmdBY3Rpb24pOwotICAgICAg ICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgVmlzaWJsZVNlbGVjdGlvbjo6UmFuZ2VTZWxlY3Rp b246Ci0gICAgICAgICAgICBhcHBseUNvbW1hbmQoQXBwbHlTdHlsZUNvbW1hbmQ6OmNyZWF0ZShk b2N1bWVudCgpLCBzdHlsZS5nZXQoKSwgZWRpdGluZ0FjdGlvbikpOwotICAgICAgICAgICAgYnJl YWs7Ci0gICAgICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQorICAg IGlmIChlbGVtZW50ICYmICFkaXNwYXRjaEJlZm9yZUlucHV0RXZlbnQoKmVsZW1lbnQsIGlucHV0 VHlwZU5hbWUsIGlucHV0RXZlbnREYXRhKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgc3dpdGNo IChzZWxlY3Rpb25UeXBlKSB7CisgICAgY2FzZSBWaXNpYmxlU2VsZWN0aW9uOjpDYXJldFNlbGVj dGlvbjoKKyAgICAgICAgY29tcHV0ZUFuZFNldFR5cGluZ1N0eWxlKCpzdHlsZSwgZWRpdGluZ0Fj dGlvbik7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgVmlzaWJsZVNlbGVjdGlvbjo6UmFuZ2VT ZWxlY3Rpb246CisgICAgICAgIGFwcGx5Q29tbWFuZChBcHBseVN0eWxlQ29tbWFuZDo6Y3JlYXRl KGRvY3VtZW50KCksIHN0eWxlLmdldCgpLCBlZGl0aW5nQWN0aW9uKSk7CisgICAgICAgIGJyZWFr OworICAgIGRlZmF1bHQ6CisgICAgICAgIGJyZWFrOwogICAgIH0KIAogICAgIGNsaWVudCgpLT5k aWRBcHBseVN0eWxlKCk7CkBAIC04MjYsOSArODI3LDEwIEBAIHZvaWQgRWRpdG9yOjphcHBseVBh cmFncmFwaFN0eWxlKFN0eWxlUHJvcGVydGllcyogc3R5bGUsIEVkaXRBY3Rpb24gZWRpdGluZ0Fj dGlvCiAKICAgICBTdHJpbmcgaW5wdXRUeXBlTmFtZSA9IGlucHV0VHlwZU5hbWVGb3JFZGl0aW5n QWN0aW9uKGVkaXRpbmdBY3Rpb24pOwogICAgIFJlZlB0cjxFbGVtZW50PiBlbGVtZW50ID0gbV9m cmFtZS5zZWxlY3Rpb24oKS5zZWxlY3Rpb24oKS5yb290RWRpdGFibGVFbGVtZW50KCk7Ci0gICAg aWYgKCFlbGVtZW50IHx8IGRpc3BhdGNoQmVmb3JlSW5wdXRFdmVudCgqZWxlbWVudCwgaW5wdXRU eXBlTmFtZSkpCi0gICAgICAgIGFwcGx5Q29tbWFuZChBcHBseVN0eWxlQ29tbWFuZDo6Y3JlYXRl KGRvY3VtZW50KCksIEVkaXRpbmdTdHlsZTo6Y3JlYXRlKHN0eWxlKS5wdHIoKSwgZWRpdGluZ0Fj dGlvbiwgQXBwbHlTdHlsZUNvbW1hbmQ6OkZvcmNlQmxvY2tQcm9wZXJ0aWVzKSk7CisgICAgaWYg KGVsZW1lbnQgJiYgIWRpc3BhdGNoQmVmb3JlSW5wdXRFdmVudCgqZWxlbWVudCwgaW5wdXRUeXBl TmFtZSkpCisgICAgICAgIHJldHVybjsKIAorICAgIGFwcGx5Q29tbWFuZChBcHBseVN0eWxlQ29t bWFuZDo6Y3JlYXRlKGRvY3VtZW50KCksIEVkaXRpbmdTdHlsZTo6Y3JlYXRlKHN0eWxlKS5wdHIo KSwgZWRpdGluZ0FjdGlvbiwgQXBwbHlTdHlsZUNvbW1hbmQ6OkZvcmNlQmxvY2tQcm9wZXJ0aWVz KSk7CiAgICAgY2xpZW50KCktPmRpZEFwcGx5U3R5bGUoKTsKICAgICBpZiAoZWxlbWVudCkKICAg ICAgICAgZGlzcGF0Y2hJbnB1dEV2ZW50KCplbGVtZW50LCBpbnB1dFR5cGVOYW1lKTsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCA4ZTQ0MzY0NzA5NzFhMzliZTQyZjk1NDAyMmQ5YzZkZmVhNGU5OTI5Li4zYTI3NWNkMTFiOTVk ZDQxYmE4YzY1MGM3OWUzZmU4YzdlMmMwNDM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYt MTItMDUgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAg QWZ0ZXIgcHJldmVudGluZyBhIGJlZm9yZWlucHV0IGV2ZW50LCBhbiBpbnB1dCBldmVudCBpcyBm aXJlZCB3aGVuIGZvcm1hdHRpbmcgcmljaCB0ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjU0MzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI5 NTIyMzE0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEF1Z21lbnRlZCBhIGxheW91dCB0ZXN0IHRvIHZlcmlmeSB0aGF0IHdoZW4gcHJldmVudGluZyBi ZWZvcmVpbnB1dCBldmVudHMsIGEgY29ycmVzcG9uZGluZyBpbnB1dCBldmVudCBpcyBub3QKKyAg ICAgICAgZmlyZWQgaW4gYWRkaXRpb24gdG8gdGhlIHN0eWxlIG5vdCBiZWluZyBhcHBsaWVkIHRv IHRoZSB0ZXh0LgorCisgICAgICAgICogZmFzdC9ldmVudHMvYmVmb3JlLWlucHV0LXByZXZlbnQt Yml1Lmh0bWw6CisKIDIwMTYtMTEtMzAgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgbWFyayB0aWxlZC1kcmF3aW5nL3Njcm9sbGlu Zy9zY3JvbGwtc25hcC9zY3JvbGwtc25hcC1pZnJhbWUuaHRtbCBhcyBmbGFreQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvYmVmb3JlLWlucHV0LXByZXZlbnQtYml1Lmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9iZWZvcmUtaW5wdXQtcHJldmVudC1iaXUuaHRtbApp bmRleCA5ZjU5MzcyY2Q2YzhmNGJjOWJhNzU3NDk5MjVmZDk1YWY5NmNjMDUxLi4xNTk0ZDZhZTNm OTc4MTVkMjhiMTA5MDg3YmFiMGFiZTI2NjUyZGUzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9iZWZvcmUtaW5wdXQtcHJldmVudC1iaXUuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9iZWZvcmUtaW5wdXQtcHJldmVudC1iaXUuaHRtbApAQCAtMSw3ICsxLDcg QEAKIDwhRE9DVFlQRSBodG1sPgogPGh0bWw+CiA8Ym9keT4KLSAgICA8ZGl2IGlkPSJlZGl0YWJs ZSIgY29udGVudGVkaXRhYmxlIG9uYmVmb3JlaW5wdXQ9aGFuZGxlQmVmb3JlSW5wdXQoZXZlbnQp PjwvZGl2PgorICAgIDxkaXYgaWQ9ImVkaXRhYmxlIiBjb250ZW50ZWRpdGFibGUgb25iZWZvcmVp bnB1dD1oYW5kbGVCZWZvcmVJbnB1dChldmVudCkgb25pbnB1dD1oYW5kbGVJbnB1dChldmVudCk+ PC9kaXY+CiAgICAgPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9kdW1wLWFzLW1hcmt1cC5q cyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgogICAgICAg ICBNYXJrdXAuZGVzY3JpcHRpb24oYFRvIG1hbnVhbGx5IHRlc3QgdGhpcywgdHVybiBvbiBib2xk LCBpdGFsaWMgYW5kIHVuZGVybGluZSB2aWEgdGhlIGNvbnRleHQgbWVudSwgYW5kIHRoZW4gdHlw ZSBzb21lIHRleHQgaW50byB0aGUgY29udGVudGVkaXRhYmxlLiBUaGUgdGV4dCBzaG91bGQgYmUg aXRhbGljaXplZCBhbmQgdW5kZXJsaW5lZCwgYnV0IG5vdCBib2xkLmApOwpAQCAtMzMsNiArMzMs MTIgQEAKICAgICAgICAgICAgIGlmIChldmVudC5pbnB1dFR5cGUgPT09ICJmb3JtYXRCb2xkIikK ICAgICAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwogICAgICAgICB9CisKKyAg ICAgICAgZnVuY3Rpb24gaGFuZGxlSW5wdXQoZXZlbnQpCisgICAgICAgIHsKKyAgICAgICAgICAg IGlmIChldmVudC5pbnB1dFR5cGUgPT09ICJmb3JtYXRCb2xkIikKKyAgICAgICAgICAgICAgICBN YXJrdXAuZHVtcCgiZWRpdGFibGUiLCAiRkFJTEVEOiByZWNlaXZlZCBpbnB1dCBldmVudCIpOwor ICAgICAgICB9CiAgICAgPC9zY3JpcHQ+CiA8L2JvZHk+CiAK