165422 2016-12-05 15:08:14 -0800 Moved start and end column linking into helper functions 2016-12-13 09:45:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren commit-queue keith_miller mark.lam msaboff ryanhaddad saam oldest_to_newest 1256527 0 ggaren 2016-12-05 15:08:14 -0800 Moved start and end column linking into helper functions 1256531 1 296198 ggaren 2016-12-05 15:10:46 -0800 Created attachment 296198 Patch 1256547 2 ggaren 2016-12-05 15:28:24 -0800 Committed r209361: <http://trac.webkit.org/changeset/209361> 1256550 3 296198 mark.lam 2016-12-05 15:33:41 -0800 Comment on attachment 296198 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296198&action=review > Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:93 > + unsigned linkedEndColumn(unsigned startColumn) const { return m_lineCount ? m_unlinkedBodyEndColumn : startColumn + m_unlinkedBodyEndColumn; } This is wrong. The original code adds 1 to m_unlinkedBodyEndColumn if m_lineCount is non-zero. You didn't add 1 here. 1256620 4 ryanhaddad 2016-12-05 17:21:52 -0800 (In reply to comment #2) > Committed r209361: <http://trac.webkit.org/changeset/209361> LayoutTest js/dom/script-start-end-locations.html is failing after this change: https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r209361%20(11509)/results.html 1259287 5 saam 2016-12-12 17:33:16 -0800 (In reply to comment #4) > (In reply to comment #2) > > Committed r209361: <http://trac.webkit.org/changeset/209361> > > LayoutTest js/dom/script-start-end-locations.html is failing after this > change: > https://build.webkit.org/results/ > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r209361%20(11509)/results.html Has this been fixed? 1259408 6 ggaren 2016-12-13 09:23:44 -0800 I'll check today. 1259409 7 ryanhaddad 2016-12-13 09:26:07 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > Committed r209361: <http://trac.webkit.org/changeset/209361> > > > > LayoutTest js/dom/script-start-end-locations.html is failing after this > > change: > > https://build.webkit.org/results/ > > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r209361%20(11509)/results.html > > Has this been fixed? The test is passing now according to the flakiness dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fscript-start-end-locations.html 1259412 8 ggaren 2016-12-13 09:45:20 -0800 Nice! 296198 2016-12-05 15:10:46 -0800 2016-12-05 15:16:29 -0800 Patch bug-165422-20161205151014.patch text/plain 2998 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5MzU4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE2LTEyLTA1ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgTW92ZWQgc3RhcnQgYW5kIGVuZCBjb2x1bW4gbGlua2luZyBpbnRvIGhlbHBlciBmdW5jdGlv bnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTQy MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYnl0 ZWNvZGUvVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUuY3BwOgorICAgICAgICAoSlNDOjpVbmxp bmtlZEZ1bmN0aW9uRXhlY3V0YWJsZTo6bGluayk6CisgICAgICAgICogYnl0ZWNvZGUvVW5saW5r ZWRGdW5jdGlvbkV4ZWN1dGFibGUuaDoKKwogMjAxNi0xMi0wNSAgTWFyayBMYW0gIDxtYXJrLmxh bUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IEpTQyBmaWxlcyBzbyB0aGF0IHdlIGNhbiBidWls ZCBhIHJlbGVhc2UgYnVpbGQgd2l0aCBOREVCVUcgI3VuZGVmJ2VkLgpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2J5dGVjb2RlL1VubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5saW5rZWRGdW5jdGlv bkV4ZWN1dGFibGUuY3BwCShyZXZpc2lvbiAyMDkzNTcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvZGUvVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMzgsMTEgKzEzOCw4IEBAIEZ1bmN0aW9uRXhlY3V0YWJsZSogVW5saW5rZWRGdW5jdGlv bkV4ZWMKICAgICB1bnNpZ25lZCBzdGFydE9mZnNldCA9IHBhcmVudFNvdXJjZS5zdGFydE9mZnNl dCgpICsgbV9zdGFydE9mZnNldDsKICAgICB1bnNpZ25lZCBsaW5lQ291bnQgPSBtX2xpbmVDb3Vu dDsKIAotICAgIC8vIEFkanVzdCB0byBvbmUtYmFzZWQgaW5kZXhpbmcuCi0gICAgYm9vbCBzdGFy dENvbHVtbklzT25GaXJzdFNvdXJjZUxpbmUgPSAhbV9maXJzdExpbmVPZmZzZXQ7Ci0gICAgdW5z aWduZWQgc3RhcnRDb2x1bW4gPSBtX3VubGlua2VkQm9keVN0YXJ0Q29sdW1uICsgKHN0YXJ0Q29s dW1uSXNPbkZpcnN0U291cmNlTGluZSA/IHBhcmVudFNvdXJjZS5zdGFydENvbHVtbigpIDogMSk7 Ci0gICAgYm9vbCBlbmRDb2x1bW5Jc09uU3RhcnRMaW5lID0gIWxpbmVDb3VudDsKLSAgICB1bnNp Z25lZCBlbmRDb2x1bW4gPSBtX3VubGlua2VkQm9keUVuZENvbHVtbiArIChlbmRDb2x1bW5Jc09u U3RhcnRMaW5lID8gc3RhcnRDb2x1bW4gOiAxKTsKKyAgICB1bnNpZ25lZCBzdGFydENvbHVtbiA9 IGxpbmtlZFN0YXJ0Q29sdW1uKHBhcmVudFNvdXJjZS5zdGFydENvbHVtbigpKTsKKyAgICB1bnNp Z25lZCBlbmRDb2x1bW4gPSBsaW5rZWRFbmRDb2x1bW4oc3RhcnRDb2x1bW4pOwogCiAgICAgU291 cmNlQ29kZSBzb3VyY2UocGFyZW50U291cmNlLnByb3ZpZGVyKCksIHN0YXJ0T2Zmc2V0LCBzdGFy dE9mZnNldCArIG1fc291cmNlTGVuZ3RoLCBmaXJzdExpbmUsIHN0YXJ0Q29sdW1uKTsKICAgICBG dW5jdGlvbk92ZXJyaWRlczo6T3ZlcnJpZGVJbmZvIG92ZXJyaWRlSW5mbzsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZEZ1bmN0 aW9uRXhlY3V0YWJsZS5oCShyZXZpc2lvbiAyMDkzNTcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYnl0ZWNvZGUvVW5saW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUuaAkod29ya2luZyBjb3B5KQpA QCAtODgsNiArODgsOSBAQCBwdWJsaWM6CiAgICAgQ29uc3RydWN0b3JLaW5kIGNvbnN0cnVjdG9y S2luZCgpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0PENvbnN0cnVjdG9yS2luZD4obV9jb25z dHJ1Y3RvcktpbmQpOyB9CiAgICAgU3VwZXJCaW5kaW5nIHN1cGVyQmluZGluZygpIGNvbnN0IHsg cmV0dXJuIHN0YXRpY19jYXN0PFN1cGVyQmluZGluZz4obV9zdXBlckJpbmRpbmcpOyB9CiAKKyAg ICB1bnNpZ25lZCBsaW5lQ291bnQoKSBjb25zdCB7IHJldHVybiBtX2xpbmVDb3VudDsgfQorICAg IHVuc2lnbmVkIGxpbmtlZFN0YXJ0Q29sdW1uKHVuc2lnbmVkIHBhcmVudFN0YXJ0Q29sdW1uKSBj b25zdCB7IHJldHVybiBtX3VubGlua2VkQm9keVN0YXJ0Q29sdW1uICsgKCFtX2ZpcnN0TGluZU9m ZnNldCA/IHBhcmVudFN0YXJ0Q29sdW1uIDogMSk7IH0KKyAgICB1bnNpZ25lZCBsaW5rZWRFbmRD b2x1bW4odW5zaWduZWQgc3RhcnRDb2x1bW4pIGNvbnN0IHsgcmV0dXJuIG1fbGluZUNvdW50ID8g bV91bmxpbmtlZEJvZHlFbmRDb2x1bW4gOiBzdGFydENvbHVtbiArIG1fdW5saW5rZWRCb2R5RW5k Q29sdW1uOyB9CiAgICAgdW5zaWduZWQgdW5saW5rZWRGdW5jdGlvbk5hbWVTdGFydCgpIGNvbnN0 IHsgcmV0dXJuIG1fdW5saW5rZWRGdW5jdGlvbk5hbWVTdGFydDsgfQogICAgIHVuc2lnbmVkIHVu bGlua2VkQm9keVN0YXJ0Q29sdW1uKCkgY29uc3QgeyByZXR1cm4gbV91bmxpbmtlZEJvZHlTdGFy dENvbHVtbjsgfQogICAgIHVuc2lnbmVkIHVubGlua2VkQm9keUVuZENvbHVtbigpIGNvbnN0IHsg cmV0dXJuIG1fdW5saW5rZWRCb2R5RW5kQ29sdW1uOyB9Cg==