165413 2016-12-05 14:20:45 -0800 Web Inspector: remove ASSERT from InspectorDebuggerAgent::derefAsyncCallData 2016-12-07 16:44:02 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1256489 0 mattbaker 2016-12-05 14:20:45 -0800 An async call can be cleared without having been recorded. For example: - Breakpoints becoming enabled between setTimeout/clearTimeout - Inspector opening between setTimeout/clearTimeout - clearTimeout(999) will always go through InspectorInstrumentation 1256490 1 mattbaker 2016-12-05 14:21:05 -0800 <rdar://problem/29517587> 1256496 2 296189 mattbaker 2016-12-05 14:35:23 -0800 Created attachment 296189 Patch 1256499 3 296189 bburg 2016-12-05 14:36:43 -0800 Comment on attachment 296189 Patch rs=me 1256522 4 296189 joepeck 2016-12-05 15:00:05 -0800 Comment on attachment 296189 Patch We could have a test for this right? Did the clearTimeout(999) on about:blank reproduce this? Either way I'm fine with the test. 1256609 5 296189 commit-queue 2016-12-05 17:02:16 -0800 Comment on attachment 296189 Patch Clearing flags on attachment: 296189 Committed r209367: <http://trac.webkit.org/changeset/209367> 1256610 6 commit-queue 2016-12-05 17:02:20 -0800 All reviewed patches have been landed. Closing bug. 1256876 7 joepeck 2016-12-06 11:21:12 -0800 (In reply to comment #4) > Comment on attachment 296189 [details] > Patch > > We could have a test for this right? Did the clearTimeout(999) on > about:blank reproduce this? Either way I'm fine with the test. To answer my own question, yes the clearTimeout(999) did reproduce this. 1257453 8 bburg 2016-12-07 16:44:02 -0800 Still needs a test. It should be pretty basic. 296189 2016-12-05 14:35:23 -0800 2016-12-05 17:02:16 -0800 Patch bug-165413-20161205143447.patch text/plain 1718 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MzQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk NDE0N2UwMGIzNDYzNGE1NzdiNDNhYzU3NGFkNTI1OWQ0NzIxMTY4Li41NGMwMDU3YTM3ZjNiZjNi NjIzMzg1OGEyNGQyZWQ1ZmVlOTdiMjdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNi0xMi0wNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogcmVtb3ZlIEFTU0VSVCBmcm9tIEluc3BlY3RvckRl YnVnZ2VyQWdlbnQ6OmRlcmVmQXN5bmNDYWxsRGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1NDEzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y OTUxNzU4Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBET01UaW1lcjo6cmVtb3ZlQnlJZCBjYW4gY2FsbCBpbnRvIEluc3BlY3Rvckluc3RydW1lbnRh dGlvbiB3aXRoIGFuCisgICAgICAgIGludmFsaWQgaWRlbnRpZmllciwgc28gZG9uJ3QgYXNzZXJ0 IHRoYXQgYXN5bmMgY2FsbCBkYXRhIGV4aXN0cy4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2Vu dHMvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6Okluc3Bl Y3RvckRlYnVnZ2VyQWdlbnQ6OmRlcmVmQXN5bmNDYWxsRGF0YSk6CisKIDIwMTYtMTItMDUgIEtl aXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFdhc20g aTY0IHRvIGkzMiBjb252ZXJzaW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcApp bmRleCBiNDI5NWUzOGNlZTFkNzk2MzA3ODBjODhmOTY5NGQxN2JmNmJkNmVhLi4wZTYwYjgzOWNk ZGZkYmM0ZGRjNDkzNjc1ZWUyOGU5ZWIxN2FhYjQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JEZWJ1Z2dl ckFnZW50LmNwcApAQCAtMTE1MSw3ICsxMTUxLDYgQEAgdm9pZCBJbnNwZWN0b3JEZWJ1Z2dlckFn ZW50OjpyZWZBc3luY0NhbGxEYXRhKGNvbnN0IEFzeW5jQ2FsbElkZW50aWZpZXImIGlkZW50aWYK IHZvaWQgSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6ZGVyZWZBc3luY0NhbGxEYXRhKGNvbnN0IEFz eW5jQ2FsbElkZW50aWZpZXImIGlkZW50aWZpZXIpCiB7CiAgICAgYXV0byBpdGVyYXRvciA9IG1f YXN5bmNDYWxsSWRlbnRpZmllclRvRGF0YS5maW5kKGlkZW50aWZpZXIpOwotICAgIEFTU0VSVChp dGVyYXRvciAhPSBtX2FzeW5jQ2FsbElkZW50aWZpZXJUb0RhdGEuZW5kKCkpOwogICAgIGlmIChp dGVyYXRvciA9PSBtX2FzeW5jQ2FsbElkZW50aWZpZXJUb0RhdGEuZW5kKCkpCiAgICAgICAgIHJl dHVybjsKIAo=