165388 2016-12-05 11:13:42 -0800 STP 19 fails to launch on 16B255 2016-12-10 09:38:55 -0800 1 1 1 Unclassified WebKit WebCore Misc. Safari Technology Preview Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin rmondello bdakin beidson commit-queue rmondello thorton oldest_to_newest 1256394 0 bdakin 2016-12-05 11:13:42 -0800 STP 19 fails to launch on 16B255 Crash on launch: Dyld Error Message: Symbol not found: _NSTouchBarDidExitCustomization Referenced from: /Applications/Safari Technology Preview.app/Contents/MacOS/../Frameworks/WebKitLegacy.framework/Versions/A/WebKitLegacy Expected in: /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit in /Applications/Safari Technology Preview.app/Contents/MacOS/../Frameworks/WebKitLegacy.framework/Versions/A/WebKitLegacy rdar://problem/29514476 1256398 1 296164 bdakin 2016-12-05 11:17:15 -0800 Created attachment 296164 Patch 1256401 2 bdakin 2016-12-05 11:22:21 -0800 https://trac.webkit.org/changeset/209330 1256402 3 bdakin 2016-12-05 11:26:39 -0800 Follow-up: https://trac.webkit.org/changeset/209332 1256672 4 thorton 2016-12-05 18:58:38 -0800 Reopening for new patch 1256673 5 296245 rmondello 2016-12-05 19:04:24 -0800 Created attachment 296245 Re-declare the symbols as weak 1256683 6 296245 commit-queue 2016-12-05 19:30:33 -0800 Comment on attachment 296245 Re-declare the symbols as weak Clearing flags on attachment: 296245 Committed r209379: <http://trac.webkit.org/changeset/209379> 1256728 7 beidson 2016-12-05 21:36:04 -0800 I'm on 10.12.1 (non TouchBar machine) with the standard dev tools, and I saw a build failure after this patch related to nullability. I fixed in https://trac.webkit.org/changeset/209385 1258627 8 thorton 2016-12-10 00:34:51 -0800 My understanding is that this is fixed. 1258697 9 beidson 2016-12-10 09:38:55 -0800 (In reply to comment #8) > My understanding is that this is fixed. Correct - I'm using STP 19 on that OS build with no problems. 296164 2016-12-05 11:17:15 -0800 2016-12-05 11:19:48 -0800 Patch for-review.txt text/plain 1396 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTMyOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTEyLTA1ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBTVFAgMTkgZmFpbHMgdG8gbGF1bmNo IG9uIDE2QjI1NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTY1Mzg4CisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAgICAgcmRhcjovL3By b2JsZW0vMjk1MTQ0NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBTcGVjdWxhdGl2ZSBmaXguCisgICAgICAgICogcGxhdGZvcm0vc3BpL2NvY29hL05T VG91Y2hCYXJTUEkuaDoKKwogMjAxNi0xMi0wNSAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNv bT4KIAogICAgICAgICBbQ1NTIFBhcnNlcl0gRml4IGFzc2VydCB3aGVuIHVua25vd24gcHJvcGVy dGllcyBhcmUgZW5jb3VudGVyZWQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkv Y29jb2EvTlNUb3VjaEJhclNQSS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3NwaS9jb2NvYS9OU1RvdWNoQmFyU1BJLmgJKHJldmlzaW9uIDIwOTMyNSkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS9jb2NvYS9OU1RvdWNoQmFyU1BJLmgJKHdvcmtpbmcgY29w eSkKQEAgLTUxLDggKzUxLDEzIEBAIE5TX0FTU1VNRV9OT05OVUxMX0JFR0lOCiAKIEBlbmQKIAot QVBQS0lUX0VYVEVSTiBOU05vdGlmaWNhdGlvbk5hbWUgY29uc3QgTlNUb3VjaEJhcldpbGxFbnRl ckN1c3RvbWl6YXRpb247Ci1BUFBLSVRfRVhURVJOIE5TTm90aWZpY2F0aW9uTmFtZSBjb25zdCBO U1RvdWNoQmFyRGlkRXhpdEN1c3RvbWl6YXRpb247CisjaWZuZGVmIE5TVG91Y2hCYXJXaWxsRW50 ZXJDdXN0b21pemF0aW9uCisjZGVmaW5lIE5TVG91Y2hCYXJXaWxsRW50ZXJDdXN0b21pemF0aW9u IEAiTlNUb3VjaEJhcldpbGxFbnRlckN1c3RvbWl6YXRpb24iCisjZW5kaWYKKworI2lmbmRlZiBO U1RvdWNoQmFyV2lsbEV4aXRDdXN0b21pemF0aW9uCisjZGVmaW5lIE5TVG91Y2hCYXJXaWxsRXhp dEN1c3RvbWl6YXRpb24gQCJOU1RvdWNoQmFyV2lsbEV4aXRDdXN0b21pemF0aW9uIgorI2VuZGlm CiAKIE5TX0FTU1VNRV9OT05OVUxMX0VORAogCg== 296245 2016-12-05 19:04:24 -0800 2016-12-05 19:30:33 -0800 Re-declare the symbols as weak 0001-STP-19-fails-to-launch-on-16B255.patch text/plain 2571 rmondello RnJvbSAyYjMxZjU1ZTBjYzA5MjU4YWYyNjgyMjZmYzAyODZkMzZkN2E3MzdiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNreSBNb25kZWxsbyA8cm1vbmRlbGxvQGFwcGxlLmNvbT4K RGF0ZTogTW9uLCA1IERlYyAyMDE2IDE5OjAzOjAyIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gU1RQ IDE5IGZhaWxzIHRvIGxhdW5jaCBvbiAxNkIyNTUKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNjUzODggLWFuZCBjb3JyZXNwb25kaW5nLQogcmRhcjovL3Byb2JsZW0v Mjk1MTQ0NzYKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKKiBwbGF0Zm9ybS9zcGkvY29j b2EvTlNUb3VjaEJhclNQSS5oOiBSZS1kZWNsYXJlIHRoZSBTUEkgc3ltYm9scyBhcyB3ZWFrLiBU aGUgY2l0ZWQgY3Jhc2ggaXRzZWxmIGlzIGZvciBhCiAgICBzeW1ib2wgd2Ugd2VyZW4ndCBoYW5k bGluZyBoZXJlLCBidXQgaXMgcGFydCBvZiB0aGUgc2FtZSBncm91cC4gUmUtZGVjbGFyZSBhbGwg Zm91ciBvZiB0aGVzZSBzeW1ib2xzIHRvCiAgICBiZSBzYWZlLgotLS0KIFNvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxMyArKysrKysrKysrKysrCiBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29jb2EvTlNUb3VjaEJhclNQSS5oIHwgIDkgKysr KysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IGM0ZTZhZjguLmQ2ZjViNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NiBAQAorMjAxNi0xMi0wNSAgUmlja3kgTW9uZGVsbG8gIDxybW9uZGVsbG9AYXBwbGUuY29tPgor CisgICAgICAgIFNUUCAxOSBmYWlscyB0byBsYXVuY2ggb24gMTZCMjU1CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUzODgKKyAgICAgICAgLWFuZCBj b3JyZXNwb25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yOTUxNDQ3NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vc3BpL2Nv Y29hL05TVG91Y2hCYXJTUEkuaDogUmUtZGVjbGFyZSB0aGUgU1BJIHN5bWJvbHMgYXMgd2Vhay4g VGhlIGNpdGVkIGNyYXNoIGl0c2VsZiBpcyBmb3IgYQorICAgICAgICAgICAgc3ltYm9sIHdlIHdl cmVuJ3QgaGFuZGxpbmcgaGVyZSwgYnV0IGlzIHBhcnQgb2YgdGhlIHNhbWUgZ3JvdXAuIFJlLWRl Y2xhcmUgYWxsIGZvdXIgb2YgdGhlc2Ugc3ltYm9scyB0bworICAgICAgICAgICAgYmUgc2FmZS4K KwogMjAxNi0xMi0wNSAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBb Q1NTIFBhcnNlcl0gc2hhcGUtcmVuZGVyaW5nIHN1cHBvcnRzIGNyaXNwRWRnZXMgcmF0aGVyIHRo YW4gY3Jpc3AtZWRnZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS9j b2NvYS9OU1RvdWNoQmFyU1BJLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29jb2Ev TlNUb3VjaEJhclNQSS5oCmluZGV4IGFmZGY4ZmEuLjBhZTExYjAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS9jb2NvYS9OU1RvdWNoQmFyU1BJLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vc3BpL2NvY29hL05TVG91Y2hCYXJTUEkuaApAQCAtNTEsMTAgKzUx LDEzIEBAIE5TX0FTU1VNRV9OT05OVUxMX0JFR0lOCiAKIEBlbmQKIAotI2RlZmluZSBOU1RvdWNo QmFyV2lsbEVudGVyQ3VzdG9taXphdGlvbiBAIk5TVG91Y2hCYXJXaWxsRW50ZXJDdXN0b21pemF0 aW9uIgotI2RlZmluZSBOU1RvdWNoQmFyV2lsbEV4aXRDdXN0b21pemF0aW9uIEAiTlNUb3VjaEJh cldpbGxFeGl0Q3VzdG9taXphdGlvbiIKLQogTlNfQVNTVU1FX05PTk5VTExfRU5ECiAKICNlbmRp ZiAvLyBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQorCitBUFBLSVRfRVhURVJOIE5TTm90aWZpY2F0 aW9uTmFtZSBjb25zdCBOU1RvdWNoQmFyV2lsbEVudGVyQ3VzdG9taXphdGlvbiBBUElfQVZBSUxB QkxFKG1hY29zeCgxMC4xMi4yKSk7CitBUFBLSVRfRVhURVJOIE5TTm90aWZpY2F0aW9uTmFtZSBj b25zdCBOU1RvdWNoQmFyRGlkRW50ZXJDdXN0b21pemF0aW9uIEFQSV9BVkFJTEFCTEUobWFjb3N4 KDEwLjEyLjIpKTsKK0FQUEtJVF9FWFRFUk4gTlNOb3RpZmljYXRpb25OYW1lIGNvbnN0IE5TVG91 Y2hCYXJXaWxsRXhpdEN1c3RvbWl6YXRpb24gQVBJX0FWQUlMQUJMRShtYWNvc3goMTAuMTIuMikp OworQVBQS0lUX0VYVEVSTiBOU05vdGlmaWNhdGlvbk5hbWUgY29uc3QgTlNUb3VjaEJhckRpZEV4 aXRDdXN0b21pemF0aW9uIEFQSV9BVkFJTEFCTEUobWFjb3N4KDEwLjEyLjIpKTsKKwogI2VuZGlm IC8vIFBMQVRGT1JNKE1BQykgJiYgSEFWRShUT1VDSF9CQVIpCi0tIAoyLjguNCAoQXBwbGUgR2l0 LTczKQoK