165374 2016-12-05 08:30:40 -0800 Add __STDC_FORMAT_MACROS before inttypes.h is included 2016-12-05 09:48:05 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen annulen benjamin cdumez cmarcelo commit-queue dbates keith_miller mark.lam mcatanzaro msaboff ossy saam oldest_to_newest 1256305 0 annulen 2016-12-05 08:30:40 -0800 We need formatting macros like PRIu64 to be available in all places where inttypes.h header is used. All these usages get inttypes.h definitions via wtf/Assertions.h header, except SQLiteFileSystem.cpp where formatting macros are not used anymore since r185129. This patch fixes multiple build errors with MinGW and reduces number of independent __STDC_FORMAT_MACROS uses in the code base. 1256306 1 296140 annulen 2016-12-05 08:35:50 -0800 Created attachment 296140 Patch 1256307 2 commit-queue 2016-12-05 08:37:39 -0800 Attachment 296140 did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.h:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1256316 3 296140 darin 2016-12-05 09:10:23 -0800 Comment on attachment 296140 Patch OK 1256353 4 296140 commit-queue 2016-12-05 09:48:00 -0800 Comment on attachment 296140 Patch Clearing flags on attachment: 296140 Committed r209322: <http://trac.webkit.org/changeset/209322> 1256354 5 commit-queue 2016-12-05 09:48:05 -0800 All reviewed patches have been landed. Closing bug. 296140 2016-12-05 08:35:50 -0800 2016-12-05 09:48:00 -0800 Patch bug-165374-20161205193514.patch text/plain 6287 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx ZThlNTQyZjhiY2IxNzdmMjQ1NWEyOTczNzllNzg4NGQ5YTg1OGVmLi5mODVmYzk5NDM1NzkzZDg2 ODBjMGFhNzVhNmI2NjYwMmI4ZGFhODc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNi0xMi0wNSAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgQWRkIF9fU1REQ19GT1JNQVRfTUFDUk9TIGJlZm9yZSBpbnR0eXBl cy5oIGlzIGluY2x1ZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjUzNzQKKworICAgICAgICBXZSBuZWVkIGZvcm1hdHRpbmcgbWFjcm9zIGxpa2Ug UFJJdTY0IHRvIGJlIGF2YWlsYWJsZSBpbiBhbGwgcGxhY2VzIHdoZXJlCisgICAgICAgIGludHR5 cGVzLmggaGVhZGVyIGlzIHVzZWQuIEFsbCB0aGVzZSB1c2FnZXMgZ2V0IGludHR5cGVzLmggZGVm aW5pdGlvbnMKKyAgICAgICAgdmlhIHd0Zi9Bc3NlcnRpb25zLmggaGVhZGVyLCBleGNlcHQgU1FM aXRlRmlsZVN5c3RlbS5jcHAgd2hlcmUgZm9ybWF0dGluZworICAgICAgICBtYWNyb3MgYXJlIG5v dCB1c2VkIGFueW1vcmUgc2luY2UgcjE4NTEyOS4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVz IG11bHRpcGxlIGJ1aWxkIGVycm9ycyB3aXRoIE1pbkdXIGFuZCByZWR1Y2VzIG51bWJlciBvZgor ICAgICAgICBpbmRlcGVuZGVudCBfX1NURENfRk9STUFUX01BQ1JPUyB1c2VzIGluIHRoZSBjb2Rl IGJhc2UuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBkaXNhc3NlbWJsZXIvQVJNNjQvQTY0RE9wY29kZS5jcHA6IFJlbW92ZWQgX19TVERDX0ZPUk1B VF9NQUNST1MKKyAgICAgICAgYmVjYXVzZSBpdCBpcyBvYnRhaW5lZCB2aWEgQXNzZXJ0aW9ucy5o IG5vdworICAgICAgICAqIGRpc2Fzc2VtYmxlci9BUk02NERpc2Fzc2VtYmxlci5jcHA6IERpdHRv LgorCiAyMDE2LTEyLTA0ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgog CiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBXYXNtIGN0eiBhbmQgcG9wY250CmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDRmMTJl ZDM0ZDg0ZTczODIyNWIwNTBjOTdiYTJiZjFlMzU2NGY0ZDQuLjYzYWFmMzJkZDVkNzFhYzhlYmNk MDc5NzNjMGRmOTY3MzU4ZTQ4YjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTYtMTItMDUgIEtv bnN0YW50aW4gVG9rYXJldiAgPGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIEFkZCBfX1NU RENfRk9STUFUX01BQ1JPUyBiZWZvcmUgaW50dHlwZXMuaCBpcyBpbmNsdWRlZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1Mzc0CisKKyAgICAgICAg V2UgbmVlZCBmb3JtYXR0aW5nIG1hY3JvcyBsaWtlIFBSSXU2NCB0byBiZSBhdmFpbGFibGUgaW4g YWxsIHBsYWNlcyB3aGVyZQorICAgICAgICBpbnR0eXBlcy5oIGhlYWRlciBpcyB1c2VkLiBBbGwg dGhlc2UgdXNhZ2VzIGdldCBpbnR0eXBlcy5oIGRlZmluaXRpb25zCisgICAgICAgIHZpYSB3dGYv QXNzZXJ0aW9ucy5oIGhlYWRlciwgZXhjZXB0IFNRTGl0ZUZpbGVTeXN0ZW0uY3BwIHdoZXJlIGZv cm1hdHRpbmcKKyAgICAgICAgbWFjcm9zIGFyZSBub3QgdXNlZCBhbnltb3JlIHNpbmNlIHIxODUx MjkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyBtdWx0aXBsZSBidWlsZCBlcnJvcnMgd2l0 aCBNaW5HVyBhbmQgcmVkdWNlcyBudW1iZXIgb2YKKyAgICAgICAgaW5kZXBlbmRlbnQgX19TVERD X0ZPUk1BVF9NQUNST1MgdXNlcyBpbiB0aGUgY29kZSBiYXNlLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0Fzc2VydGlvbnMuaDogRGVmaW5l IF9fU1REQ19GT1JNQVRfTUFDUk9TLgorICAgICAgICAqIHd0Zi9TdGRMaWJFeHRyYXMuaDogUmVt b3ZlIGRlZmluaXRpb24gb2YgUFJJZDY0IGZvciBXaW5kb3dzLCBhcyB3ZQorICAgICAgICBoYXZl IF9fU1REQ19GT1JNQVRfTUFDUk9TIGRlZmluZWQgbm93LgorCiAyMDE2LTEyLTAzICBZdXN1a2Ug U3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFJlZmFjdG9yIFN5bWJv bEltcGwgbGF5b3V0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmFmYzg3YzQ3ZmM3NTJkNmMyMGI5ODkwNTU3ZTdm M2E2NTZmMDJmZC4uNTlkYzUwNWRjMTlkZmZkZmJjMWNjMjNmMDhhNmUyZDIwNTc0YTgwYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTEyLTA1ICBLb25zdGFudGluIFRva2FyZXYg IDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBBZGQgX19TVERDX0ZPUk1BVF9NQUNST1Mg YmVmb3JlIGludHR5cGVzLmggaXMgaW5jbHVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTM3NAorCisgICAgICAgIFdlIG5lZWQgZm9ybWF0dGlu ZyBtYWNyb3MgbGlrZSBQUkl1NjQgdG8gYmUgYXZhaWxhYmxlIGluIGFsbCBwbGFjZXMgd2hlcmUK KyAgICAgICAgaW50dHlwZXMuaCBoZWFkZXIgaXMgdXNlZC4gQWxsIHRoZXNlIHVzYWdlcyBnZXQg aW50dHlwZXMuaCBkZWZpbml0aW9ucworICAgICAgICB2aWEgd3RmL0Fzc2VydGlvbnMuaCBoZWFk ZXIsIGV4Y2VwdCBTUUxpdGVGaWxlU3lzdGVtLmNwcCB3aGVyZSBmb3JtYXR0aW5nCisgICAgICAg IG1hY3JvcyBhcmUgbm90IHVzZWQgYW55bW9yZSBzaW5jZSByMTg1MTI5LgorCisgICAgICAgIFRo aXMgcGF0Y2ggZml4ZXMgbXVsdGlwbGUgYnVpbGQgZXJyb3JzIHdpdGggTWluR1cgYW5kIHJlZHVj ZXMgbnVtYmVyIG9mCisgICAgICAgIGluZGVwZW5kZW50IF9fU1REQ19GT1JNQVRfTUFDUk9TIHVz ZXMgaW4gdGhlIGNvZGUgYmFzZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICogcGxhdGZvcm0v c3FsL1NRTGl0ZUZpbGVTeXN0ZW0uY3BwOiBSZW1vdmVkIHVudXNlZCBpbnR0eXBlcy5oCisgICAg ICAgIGluY2x1c2lvbi4KKwogMjAxNi0xMi0wNCAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNv bT4KIAogICAgICAgICBbQ1NTIFBhcnNlcl0gRWxpbWluYXRlIGluLXBsYWNlIGxvd2VyY2FzaW5n IGluIHRoZSBwYXJzZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNz ZW1ibGVyL0FSTTY0L0E2NERPcGNvZGUuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fz c2VtYmxlci9BUk02NC9BNjRET3Bjb2RlLmNwcAppbmRleCBhNGJkNjM1NDNkODY0NDA4OWU4MGMz YzUzYTZjMWJlOTdhNDY0MjgyLi45OGUzYmE4ZjRjZDQwYjczYmI4MjlmYmUyMWUzNjZiNDQxYzdm Nzg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL0FSTTY0 L0E2NERPcGNvZGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kaXNhc3NlbWJsZXIv QVJNNjQvQTY0RE9wY29kZS5jcHAKQEAgLTIzLDcgKzIzLDYgQEAKICAqIE9GIFRISVMgU09GVFdB UkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAg Ki8KIAotI2RlZmluZSBfX1NURENfRk9STUFUX01BQ1JPUwogI2luY2x1ZGUgImNvbmZpZy5oIgog CiAjaWYgVVNFKEFSTTY0X0RJU0FTU0VNQkxFUikKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kaXNhc3NlbWJsZXIvQVJNNjREaXNhc3NlbWJsZXIuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci9BUk02NERpc2Fzc2VtYmxlci5jcHAKaW5kZXggYmI4ZmRl NGU0MTdhYTQ5NDM3NjBiM2YxYTIyMDU0OTIwNWUxODEyOC4uYWM1MjIxM2RmODdjMzdiM2JiZjgz NWY3NjNiMThmNDc5YjE4YTNlMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Rp c2Fzc2VtYmxlci9BUk02NERpc2Fzc2VtYmxlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2Rpc2Fzc2VtYmxlci9BUk02NERpc2Fzc2VtYmxlci5jcHAKQEAgLTIzLDcgKzIzLDYgQEAK ICAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkg T0YgU1VDSCBEQU1BR0UuCiAgKi8KIAotI2RlZmluZSBfX1NURENfRk9STUFUX01BQ1JPUwogI2lu Y2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkRpc2Fzc2VtYmxlci5oIgogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25zLmggYi9Tb3VyY2UvV1RGL3d0Zi9Bc3NlcnRpb25z LmgKaW5kZXggODRjNDY5NGQxMTAyOWNmMWI4OTY0NzExZGRkM2I1ODQ2NzIwMzZlMS4uMjg2NDBh ODZmYzg1ZGVkMDI1NjJmZjU4MDRjY2MzNDRmMWMxZTE2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dU Ri93dGYvQXNzZXJ0aW9ucy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Fzc2VydGlvbnMuaApAQCAt MzksNiArMzksOCBAQAogICAgaGF2aW5nIGFueSBlZmZlY3QuCiAqLwogCisjdW5kZWYgX19TVERD X0ZPUk1BVF9NQUNST1MKKyNkZWZpbmUgX19TVERDX0ZPUk1BVF9NQUNST1MKICNpbmNsdWRlIDxp bnR0eXBlcy5oPgogI2luY2x1ZGUgPHN0ZGFyZy5oPgogI2luY2x1ZGUgPHN0ZGJvb2wuaD4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oIGIvU291cmNlL1dURi93dGYv U3RkTGliRXh0cmFzLmgKaW5kZXggNjQ1MjRmZDM1YTEzN2NlZTAwNGVjNjVhZmVhNDFlMjJmNDVh NThhMi4uYjI2YjQ2MTc4Y2VlMzg5M2ExY2Q0Nzc5NTJiNGE2YjM4OTJhNjc0MiAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvU3RkTGliRXh0cmFzLmgKKysrIGIvU291cmNlL1dURi93dGYvU3Rk TGliRXh0cmFzLmgKQEAgLTc5LDExICs3OSw2IEBACiAjZGVmaW5lIFdURl9DT05DQVQoYSwgYikg V1RGX0NPTkNBVF9JTlRFUk5BTF9ET05UX1VTRShhLCBiKQogCiAKLS8vIE1ha2UgIlBSSWQ2NCIg Zm9ybWF0IHNwZWNpZmllciB3b3JrIGZvciBWaXN1YWwgQysrIG9uIFdpbmRvd3MuCi0jaWYgT1Mo V0lORE9XUykgJiYgIWRlZmluZWQoUFJJZDY0KQotI2RlZmluZSBQUklkNjQgImxsZCIKLSNlbmRp ZgotCiAvKgogICogVGhlIHJlaW50ZXJwcmV0X2Nhc3Q8VHlwZTEqPihbcG9pbnRlciB0byBUeXBl Ml0pIGV4cHJlc3Npb25zIC0gd2hlcmUKICAqIHNpemVvZihUeXBlMSkgPiBzaXplb2YoVHlwZTIp IC0gY2F1c2UgdGhlIGZvbGxvd2luZyB3YXJuaW5nIG9uIEFSTSB3aXRoIEdDQzoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVGaWxlU3lzdGVtLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NxbC9TUUxpdGVGaWxlU3lzdGVtLmNwcAppbmRleCBiMDNj NDU1MDM4ZjQ1OWU5NDJjMjYxNWI3ZTc5MTI2YzczNWQxNWRmLi5kNGM5NjhjY2U5NjRkZTk3OWEz OTgxNWEyYWYwNjkzMGMwYjc4MWUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9zcWwvU1FMaXRlRmlsZVN5c3RlbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v c3FsL1NRTGl0ZUZpbGVTeXN0ZW0uY3BwCkBAIC0yOCwxNCArMjgsMTIgQEAKICAqIE9GIFRISVMg U09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1B R0UuCiAgKi8KIAotI2RlZmluZSBfX1NURENfRk9STUFUX01BQ1JPUwogI2luY2x1ZGUgImNvbmZp Zy5oIgogI2luY2x1ZGUgIlNRTGl0ZUZpbGVTeXN0ZW0uaCIKIAogI2luY2x1ZGUgIkZpbGVTeXN0 ZW0uaCIKICNpbmNsdWRlICJTUUxpdGVEYXRhYmFzZS5oIgogI2luY2x1ZGUgIlNRTGl0ZVN0YXRl bWVudC5oIgotI2luY2x1ZGUgPGludHR5cGVzLmg+CiAjaW5jbHVkZSA8c3FsaXRlMy5oPgogCiAj aWYgUExBVEZPUk0oSU9TKQo=