165338 2016-12-02 14:32:37 -0800 Remove redundant LayoutUnit conversions. 2016-12-02 15:06:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1255900 0 zalan 2016-12-02 14:32:37 -0800 in RenderBlockFlow::computeColumnCountAndWidth 1255902 1 296001 zalan 2016-12-02 14:34:52 -0800 Created attachment 296001 Patch 1255922 2 296001 commit-queue 2016-12-02 15:06:10 -0800 Comment on attachment 296001 Patch Clearing flags on attachment: 296001 Committed r209277: <http://trac.webkit.org/changeset/209277> 1255923 3 commit-queue 2016-12-02 15:06:13 -0800 All reviewed patches have been landed. Closing bug. 296001 2016-12-02 14:34:52 -0800 2016-12-02 15:06:10 -0800 Patch bug-165338-20161202143422.patch text/plain 3314 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU4NTdlZWQxYmM4Nzk0 MzUwMTg2MzA1ZDZiOWU4YTRjNDdjYWFkYi4uZDgzYTZiNzhiOTZjYTRmOGM5MjZmOTYwMjY4MGM3 ZjI3MDEwNTRmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEyLTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHJlZHVuZGFudCBM YXlvdXRVbml0IGNvbnZlcnNpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTY1MzM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVuZGVyQmxvY2tGbG93Ojpjb21wdXRlQ29sdW1uQ291bnRBbmRXaWR0 aCBoYXMgc29tZSByZWR1bmRhbnQgTGF5b3V0VW50aSA8LT4gdW5zaWduZWQgY29udmVyc2lvbnMu CisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2Nr Rmxvdzo6Y29tcHV0ZUNvbHVtbkNvdW50QW5kV2lkdGgpOgorCiAyMDE2LTExLTI4ICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVXNlIFVJS2l0IFNQSSB0 byBmb3JjZSBwb3BvdmVyIHByZXNlbnRhdGlvbiBzdHlsZSBvbiBpUGhvbmUgZm9yIGh0bWwgdmFs aWRhdGlvbiBwb3BvdmVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJsb2NrRmxvdy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tG bG93LmNwcAppbmRleCA2Nzg0OTUxMmUzYmNlZWJiNDRjZGM5OWM4MjBiNmJiOGJmZmJlMDU1Li40 NDI4ZWUwMDhiZmVmYzFjMGE1YmJjNDNjZWJjNTM1NWM3ZmU5ZDI0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcApAQCAtNDAzLDI2ICs0MDMsMjYgQEAg dm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmNvbXB1dGVDb2x1bW5Db3VudEFuZFdpZHRoKCkKICAgICAv LyBGSVhNRTogQ2FuIG92ZXJmbG93IG9uIGZhc3QvYmxvY2svZmxvYXQvZmxvYXQtbm90LXJlbW92 ZWQtZnJvbS1uZXh0LXNpYmxpbmc0Lmh0bWwsIHNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9Njg3NDQKICAgICB1bnNpZ25lZCBkZXNpcmVkQ29sdW1uQ291bnQgPSAx OwogICAgIExheW91dFVuaXQgZGVzaXJlZENvbHVtbldpZHRoID0gY29udGVudExvZ2ljYWxXaWR0 aCgpOwotICAgIAorCiAgICAgLy8gRm9yIG5vdywgd2UgZG9uJ3Qgc3VwcG9ydCBtdWx0aS1jb2x1 bW4gbGF5b3V0cyB3aGVuIHByaW50aW5nLCBzaW5jZSB3ZSBoYXZlIHRvIGRvIGEgbG90IG9mIHdv cmsgZm9yIHByb3BlciBwYWdpbmF0aW9uLgogICAgIGlmIChkb2N1bWVudCgpLnBhZ2luYXRlZCgp IHx8IChzdHlsZSgpLmhhc0F1dG9Db2x1bW5Db3VudCgpICYmIHN0eWxlKCkuaGFzQXV0b0NvbHVt bldpZHRoKCkpIHx8ICFzdHlsZSgpLmhhc0lubGluZUNvbHVtbkF4aXMoKSkgewogICAgICAgICBz ZXRDb21wdXRlZENvbHVtbkNvdW50QW5kV2lkdGgoZGVzaXJlZENvbHVtbkNvdW50LCBkZXNpcmVk Q29sdW1uV2lkdGgpOwogICAgICAgICByZXR1cm47CiAgICAgfQotICAgICAgICAKKwogICAgIExh eW91dFVuaXQgYXZhaWxXaWR0aCA9IGRlc2lyZWRDb2x1bW5XaWR0aDsKICAgICBMYXlvdXRVbml0 IGNvbEdhcCA9IGNvbHVtbkdhcCgpOwotICAgIExheW91dFVuaXQgY29sV2lkdGggPSBzdGQ6Om1h eDxMYXlvdXRVbml0PihMYXlvdXRVbml0Ojpmcm9tUGl4ZWwoMSksIExheW91dFVuaXQoc3R5bGUo KS5jb2x1bW5XaWR0aCgpKSk7CisgICAgTGF5b3V0VW5pdCBjb2xXaWR0aCA9IHN0ZDo6bWF4PExh eW91dFVuaXQ+KDEsIHN0eWxlKCkuY29sdW1uV2lkdGgoKSk7CiAgICAgdW5zaWduZWQgY29sQ291 bnQgPSBzdGQ6Om1heDx1bnNpZ25lZD4oMSwgc3R5bGUoKS5jb2x1bW5Db3VudCgpKTsKIAogICAg IGlmIChzdHlsZSgpLmhhc0F1dG9Db2x1bW5XaWR0aCgpICYmICFzdHlsZSgpLmhhc0F1dG9Db2x1 bW5Db3VudCgpKSB7CiAgICAgICAgIGRlc2lyZWRDb2x1bW5Db3VudCA9IGNvbENvdW50OwogICAg ICAgICBkZXNpcmVkQ29sdW1uV2lkdGggPSBzdGQ6Om1heDxMYXlvdXRVbml0PigwLCAoYXZhaWxX aWR0aCAtICgoZGVzaXJlZENvbHVtbkNvdW50IC0gMSkgKiBjb2xHYXApKSAvIGRlc2lyZWRDb2x1 bW5Db3VudCk7CiAgICAgfSBlbHNlIGlmICghc3R5bGUoKS5oYXNBdXRvQ29sdW1uV2lkdGgoKSAm JiBzdHlsZSgpLmhhc0F1dG9Db2x1bW5Db3VudCgpKSB7Ci0gICAgICAgIGRlc2lyZWRDb2x1bW5D b3VudCA9IHN0ZDo6bWF4PExheW91dFVuaXQ+KDEsIChhdmFpbFdpZHRoICsgY29sR2FwKSAvIChj b2xXaWR0aCArIGNvbEdhcCkpLnRvVW5zaWduZWQoKTsKKyAgICAgICAgZGVzaXJlZENvbHVtbkNv dW50ID0gc3RkOjptYXg8dW5zaWduZWQ+KDEsICgoYXZhaWxXaWR0aCArIGNvbEdhcCkgLyAoY29s V2lkdGggKyBjb2xHYXApKS50b1Vuc2lnbmVkKCkpOwogICAgICAgICBkZXNpcmVkQ29sdW1uV2lk dGggPSAoKGF2YWlsV2lkdGggKyBjb2xHYXApIC8gZGVzaXJlZENvbHVtbkNvdW50KSAtIGNvbEdh cDsKICAgICB9IGVsc2UgewotICAgICAgICBkZXNpcmVkQ29sdW1uQ291bnQgPSBzdGQ6Om1heDxM YXlvdXRVbml0PihzdGQ6Om1pbjxMYXlvdXRVbml0Pihjb2xDb3VudCwgKGF2YWlsV2lkdGggKyBj b2xHYXApIC8gKGNvbFdpZHRoICsgY29sR2FwKSksIDEpLnRvVW5zaWduZWQoKTsKKyAgICAgICAg ZGVzaXJlZENvbHVtbkNvdW50ID0gc3RkOjptYXg8dW5zaWduZWQ+KHN0ZDo6bWluKGNvbENvdW50 LCAoKGF2YWlsV2lkdGggKyBjb2xHYXApIC8gKGNvbFdpZHRoICsgY29sR2FwKSkudG9VbnNpZ25l ZCgpKSwgMSk7CiAgICAgICAgIGRlc2lyZWRDb2x1bW5XaWR0aCA9ICgoYXZhaWxXaWR0aCArIGNv bEdhcCkgLyBkZXNpcmVkQ29sdW1uQ291bnQpIC0gY29sR2FwOwogICAgIH0KICAgICBzZXRDb21w dXRlZENvbHVtbkNvdW50QW5kV2lkdGgoZGVzaXJlZENvbHVtbkNvdW50LCBkZXNpcmVkQ29sdW1u V2lkdGgpOwo=