165333 2016-12-02 13:55:39 -0800 REGRESSION (r208802): TouchBar pause button doesn't work 2016-12-02 14:01:55 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin eric.carlson jer.noble wenson_hsieh oldest_to_newest 1255864 0 bdakin 2016-12-02 13:55:39 -0800 REGRESSION (r208802): TouchBar pause button doesn't work rdar://problem/29487187 1255872 1 295996 bdakin 2016-12-02 13:58:12 -0800 Created attachment 295996 Patch 1255873 2 295996 wenson_hsieh 2016-12-02 13:59:28 -0800 Comment on attachment 295996 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295996&action=review > Source/WebCore/ChangeLog:11 > + used, so this patch just removes it. Nit - newline after the description 1255876 3 bdakin 2016-12-02 14:01:55 -0800 Thanks Wenson! https://trac.webkit.org/changeset/209264 295996 2016-12-02 13:58:12 -0800 2016-12-02 13:59:28 -0800 Patch for-review.txt text/plain 2298 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTI2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTEyLTAyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjA4ODAyKTog VG91Y2hCYXIgcGF1c2UgYnV0dG9uIGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MzMzCisgICAgICAgIC1hbmQgY29ycmVzcG9u ZGluZy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjk0ODcxODcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcHJldmlvdXMgY29kZSBnb3QgdGhp cyByaWdodCBieSB1c2luZyBzZWxmLnBsYXlpbmcuIF9wbGF5aW5nIHdhcyB0b3RhbGx5IHVuLQor ICAgICAgICB1c2VkLCBzbyB0aGlzIHBhdGNoIGp1c3QgcmVtb3ZlcyBpdC4KKyAgICAgICAgKiBw bGF0Zm9ybS9tYWMvV2ViUGxheWJhY2tDb250cm9sc01hbmFnZXIuaDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9tYWMvV2ViUGxheWJhY2tDb250cm9sc01hbmFnZXIubW06CisgICAgICAgICgtW1dlYlBs YXliYWNrQ29udHJvbHNNYW5hZ2VyIHNldFBsYXlpbmc6XSk6CisKIDIwMTYtMTItMDIgIEpvaG4g V2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVxdWlyZSBwcmVmbGln aHQgZm9yIG5vbi1zdGFuZGFyZCBDT1JTLXNhZmVsaXN0ZWQgcmVxdWVzdCBoZWFkZXJzIEFjY2Vw dCwgQWNjZXB0LUxhbmd1YWdlLCBhbmQgQ29udGVudC1MYW5ndWFnZQpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWFjL1dlYlBsYXliYWNrQ29udHJvbHNNYW5hZ2VyLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYlBsYXliYWNrQ29udHJvbHNNYW5h Z2VyLmgJKHJldmlzaW9uIDIwOTE4NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9X ZWJQbGF5YmFja0NvbnRyb2xzTWFuYWdlci5oCSh3b3JraW5nIGNvcHkpCkBAIC01MSw3ICs1MSw2 IEBAIEBpbnRlcmZhY2UgV2ViUGxheWJhY2tDb250cm9sc01hbmFnZXIgOiAKICAgICBSZXRhaW5Q dHI8TlNBcnJheTxBVkZ1bmN0aW9uQmFyTWVkaWFTZWxlY3Rpb25PcHRpb24gKj4+IF9sZWdpYmxl RnVuY3Rpb25CYXJNZWRpYVNlbGVjdGlvbk9wdGlvbnM7CiAgICAgUmV0YWluUHRyPEFWRnVuY3Rp b25CYXJNZWRpYVNlbGVjdGlvbk9wdGlvbj4gX2N1cnJlbnRMZWdpYmxlRnVuY3Rpb25CYXJNZWRp YVNlbGVjdGlvbk9wdGlvbjsKICAgICBmbG9hdCBfcmF0ZTsKLSAgICBCT09MIF9wbGF5aW5nOwog ICAgIEJPT0wgX2NhblRvZ2dsZVBsYXliYWNrOwogCiBAcHJpdmF0ZQpJbmRleDogU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWFjL1dlYlBsYXliYWNrQ29udHJvbHNNYW5hZ2VyLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJQbGF5YmFja0NvbnRyb2xzTWFu YWdlci5tbQkocmV2aXNpb24gMjA5MTg0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1dlYlBsYXliYWNrQ29udHJvbHNNYW5hZ2VyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMzcsNyAr MjM3LDcgQEAgLSAodm9pZClzZXRQbGF5aW5nOihCT09MKXBsYXlpbmcKICAgICBpZiAoIV93ZWJQ bGF5YmFja1Nlc3Npb25JbnRlcmZhY2VNYWMgfHwgIV93ZWJQbGF5YmFja1Nlc3Npb25JbnRlcmZh Y2VNYWMtPndlYlBsYXliYWNrU2Vzc2lvbk1vZGVsKCkpCiAgICAgICAgIHJldHVybjsKIAotICAg IEJPT0wgaXNDdXJyZW50bHlQbGF5aW5nID0gX3BsYXlpbmc7CisgICAgQk9PTCBpc0N1cnJlbnRs eVBsYXlpbmcgPSBzZWxmLnBsYXlpbmc7CiAgICAgaWYgKCFpc0N1cnJlbnRseVBsYXlpbmcgJiYg cGxheWluZykKICAgICAgICAgX3dlYlBsYXliYWNrU2Vzc2lvbkludGVyZmFjZU1hYy0+d2ViUGxh eWJhY2tTZXNzaW9uTW9kZWwoKS0+cGxheSgpOwogICAgIGVsc2UgaWYgKGlzQ3VycmVudGx5UGxh eWluZyAmJiAhcGxheWluZykK