165331 2016-12-02 13:44:58 -0800 Make a public facing page to check for WebKit features 2016-12-02 17:21:20 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino webkit-bug-importer oldest_to_newest 1255848 0 dino 2016-12-02 13:44:58 -0800 Make a public facing page to check for WebKit features 1255855 1 webkit-bug-importer 2016-12-02 13:49:59 -0800 <rdar://problem/29488535> 1255856 2 295990 dino 2016-12-02 13:51:18 -0800 Created attachment 295990 Patch 1255897 3 295990 graouts 2016-12-02 14:24:47 -0800 Comment on attachment 295990 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295990&action=review > Websites/webkit.org/experimental-features.html:79 > + return canvas.getContext("webgl2"); Either make this a one-liner or use `const`. > Websites/webkit.org/experimental-features.html:111 > + Array.from(document.querySelectorAll(".test")).forEach(element => { you can just use `for … of` to iterate these items. > Websites/webkit.org/experimental-features.html:114 > + element.classList.add(testFunction() ? "enabled" : "disabled"); If you used a single class, and assume the absence of it is the inverse, then you could just do `element.classList.toggle("enabled", testFunction())`. 1255960 4 295990 dino 2016-12-02 16:32:22 -0800 Comment on attachment 295990 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295990&action=review >> Websites/webkit.org/experimental-features.html:79 >> + return canvas.getContext("webgl2"); > > Either make this a one-liner or use `const`. ok >> Websites/webkit.org/experimental-features.html:111 >> + Array.from(document.querySelectorAll(".test")).forEach(element => { > > you can just use `for … of` to iterate these items. cool >> Websites/webkit.org/experimental-features.html:114 >> + element.classList.add(testFunction() ? "enabled" : "disabled"); > > If you used a single class, and assume the absence of it is the inverse, then you could just do `element.classList.toggle("enabled", testFunction())`. There are three states: enabled, disabled and unknown. 1255983 5 dino 2016-12-02 17:21:20 -0800 Committed r209287: <http://trac.webkit.org/changeset/209287> 295990 2016-12-02 13:51:18 -0800 2016-12-02 14:24:47 -0800 Patch bug-165331-20161202135047.patch text/plain 6508 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MDI4CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IGFmOGVk YWVkNzZkMjliNTg2NmMyZWY2MmFhNWZkNzVjNTViNGQ4YTMuLjM0N2Q3ZmY3MDBkM2NhNTU5NTU2 MzM2MGZlNDE3YzMxZjA3YTY3ZDYgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTYtMTItMDIgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAg IE1ha2UgYSBwdWJsaWMgZmFjaW5nIHBhZ2UgdG8gY2hlY2sgZm9yIFdlYktpdCBmZWF0dXJlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MzMxCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTQ4ODUzNT4KKworICAgICAgICBBZGQgYSB3ZWIgcGFn ZSB0byB3ZWJraXQub3JnIHRoYXQgYWxsb3dzIHVzIHRvIGxpdmUKKyAgICAgICAgZGV0ZWN0IG91 ciBleHBlcmltZW50YWwgZmVhdHVyZXMuIFRoaXMgaXMgbW9zdGx5IGZvcgorICAgICAgICBpbnRl cm5hbCBkZWJ1Z2dpbmcsIGJ1dCBhbHNvIHByb3ZpZGVzIHNpbXBsZSBleGFtcGxlcworICAgICAg ICBvZiBob3cgcmVhbCBjb250ZW50IHdvdWxkIGRvIHN1Y2ggZGV0ZWN0aW9uLgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZXhwZXJpbWVudGFsLWZl YXR1cmVzLmh0bWw6IEFkZGVkLgorCiAyMDE2LTExLTE3ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9t aWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCByb3RhdGUgdG8gV2FzbQpkaWZmIC0tZ2l0 IGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9leHBlcmltZW50YWwtZmVhdHVyZXMuaHRtbCBiL1dlYnNp dGVzL3dlYmtpdC5vcmcvZXhwZXJpbWVudGFsLWZlYXR1cmVzLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjE4 NTgxOWQ1MjBkMzJmMDJjNTgyZjlhODY4YzU2YjQ0ZThlZTA0MgotLS0gL2Rldi9udWxsCisrKyBi L1dlYnNpdGVzL3dlYmtpdC5vcmcvZXhwZXJpbWVudGFsLWZlYXR1cmVzLmh0bWwKQEAgLTAsMCAr MSwxMzggQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5FeHBlcmlt ZW50YWwgZmVhdHVyZXM8L3RpdGxlPgorPG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9Indp ZHRoPTYwMCI+Cis8c3R5bGU+Citib2R5IHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiAjQUVCREI0 OworICAgIG1hcmdpbjogMDsKKyAgICBmb250LWZhbWlseTogLWFwcGxlLXN5c3RlbSwgc2Fucy1z ZXJpZjsKKyAgICBmb250LXNpemU6IDIycHg7Cit9CisKKy5jb250ZW50IHsKKyAgICB3aWR0aDog NDgwcHg7CisgICAgbWFyZ2luOiAzMHB4IGF1dG87CisgICAgYmFja2dyb3VuZC1jb2xvcjogI0Qy RDJEMjsKKyAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsKKyAgICBib3JkZXItdG9wLXdpZHRo OiA1cHg7CisgICAgdGV4dC1hbGlnbjogY2VudGVyOworfQorCisuY29udGVudCBoMSB7CisgICAg Zm9udC1zaXplOiAzNHB4OworICAgIG1hcmdpbjogMjBweCAwOworfQorCisuY29udGVudCBwIHsK KyAgICBtYXJnaW46IDEwcHggNDBweDsKK30KKworLmNvbnRlbnQgLnRlc3QgeworICAgIGRpc3Bs YXk6IGZsZXg7CisgICAganVzdGlmeS1jb250ZW50OiBjZW50ZXI7CisgICAgYWxpZ24taXRlbXM6 IGNlbnRlcjsKKyAgICBmb250LXNpemU6IDIycHg7CisgICAgd2lkdGg6IDMyMHB4OworICAgIG1h cmdpbjogMjVweCBhdXRvOworICAgIGhlaWdodDogNzBweDsKKyAgICBwYWRkaW5nOiAwIDU1cHg7 CisgICAgYmFja2dyb3VuZC1jb2xvcjogI2U3ZGQwZTsKKyAgICBib3JkZXI6IDJweCBzb2xpZCAj OTk5MzA5OworICAgIGJvcmRlci1yYWRpdXM6IDM1cHg7CisgICAgYmFja2dyb3VuZC1zaXplOiA0 MHB4IDQwcHg7CisgICAgYmFja2dyb3VuZC1wb3NpdGlvbjogMTVweCAxNXB4OworICAgIGJhY2tn cm91bmQtcmVwZWF0OiBuby1yZXBlYXQ7CisgICAgYmFja2dyb3VuZC1pbWFnZTogdXJsKCdkYXRh OmltYWdlL3N2Zyt4bWwsPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZp ZXdCb3g9IjAgMCA0NSA0NSI+PGNpcmNsZSBjeD0iMjIuNSIgY3k9IjIyLjUiIHI9IjIyLjUiIGZp bGw9IiM5OTkzMDkiLz48cGF0aCBmaWxsPSIjZTdkZDBlIiBkPSJNMTQuNTgsMTcuOTNhNy41NCw3 LjU0LDAsMCwxLDEuMjctNCw5Ljc5LDkuNzksMCwwLDEsMy43MS0zLjM3LDExLjY3LDExLjY3LDAs MCwxLDUuNjktMS4zMywxMi4xNSwxMi4xNSwwLDAsMSw1LjM0LDEuMTIsOC42NSw4LjY1LDAsMCwx LDMuNTgsMyw3LjQ0LDcuNDQsMCwwLDEsMS4yNiw0LjE3LDYuNDUsNi40NSwwLDAsMS0uNzIsMy4x MUE5LjUxLDkuNTEsMCwwLDEsMzMsMjIuOTVxLTEsMS0zLjU1LDMuMjZhMTQuNDcsMTQuNDcsMCww LDAtMS4xNCwxLjE0LDQuNjIsNC42MiwwLDAsMC0uNjQuOSw0LjQsNC40LDAsMCwwLS4zMi44MXEt LjExLjQxLS4zNCwxLjQzYTIuMzIsMi4zMiwwLDAsMS0yLjQ4LDIuMTcsMi41NCwyLjU0LDAsMCwx LTEuODItLjcxQTIuNzgsMi43OCwwLDAsMSwyMiwyOS44NGE3LjM5LDcuMzksMCwwLDEsMi01LjI4 LDMzLDMzLDAsMCwxLDIuNDItMi4zcTEuMzMtMS4xNywxLjkzLTEuNzZhNiw2LDAsMCwwLDEtMS4z MiwzLjIsMy4yLDAsMCwwLC40MS0xLjU4LDMuNjgsMy42OCwwLDAsMC0xLjI0LTIuODEsNC41Myw0 LjUzLDAsMCwwLTMuMi0xLjE1LDQuNDMsNC40MywwLDAsMC0zLjM4LDEuMTZBOS4yMyw5LjIzLDAs MCwwLDIwLDE4LjE4cS0uNzEsMi4zNi0yLjY5LDIuMzZhMi42NCwyLjY0LDAsMCwxLTItLjgyQTIu NTIsMi41MiwwLDAsMSwxNC41OCwxNy45M1pNMjQuNzUsNDAuNzhBMy4yOCwzLjI4LDAsMCwxLDIy LjUzLDQwYTIuODksMi44OSwwLDAsMS0uOTUtMi4zLDMsMywwLDAsMSwuOTItMi4yMSwzLjEsMy4x LDAsMCwxLDIuMjUtLjksMy4wNiwzLjA2LDAsMCwxLDMuMTEsMy4xMSwyLjkxLDIuOTEsMCwwLDEt Ljk0LDIuMjlBMy4xNywzLjE3LDAsMCwxLDI0Ljc1LDQwLjc4WiIgdHJhbnNmb3JtPSJ0cmFuc2xh dGUoLTIuNSAtMi41KSIvPjwvc3ZnPicpOworfQorCisuY29udGVudCAudGVzdCBwIHsKKyAgICBt YXJnaW46IDA7CisgICAgcGFkZGluZzogMDsKK30KKworLmNvbnRlbnQgLnRlc3QuZW5hYmxlZCB7 CisgICAgYmFja2dyb3VuZC1jb2xvcjogIzFmZWUwNjsKKyAgICBib3JkZXItY29sb3I6ICMwMGFh MDQ7CisgICAgYmFja2dyb3VuZC1pbWFnZTogdXJsKCdkYXRhOmltYWdlL3N2Zyt4bWwsPHN2ZyB4 bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCA0NSA0NSI+PGNp cmNsZSBjeD0iMjIuNSIgY3k9IjIyLjUiIHI9IjIyLjUiIGZpbGw9IiMwMGFhMDQiLz48cG9seWxp bmUgcG9pbnRzPSIzNi4xMyAxMS45MyAxNi45OSAzMS4wNyA4Ljg3IDIyLjk1IiBzdHlsZT0iZmls bDpub25lO3N0cm9rZTojMWZlZTA2O3N0cm9rZS13aWR0aDo3cHgiLz48L3N2Zz4nKTsKK30KKwor LmNvbnRlbnQgLnRlc3QuZGlzYWJsZWQgeworICAgIGJhY2tncm91bmQtY29sb3I6ICNmYjUyMDc7 CisgICAgYm9yZGVyLWNvbG9yOiAjYWIzOTAzOworICAgIGJhY2tncm91bmQtaW1hZ2U6IHVybCgn ZGF0YTppbWFnZS9zdmcreG1sLDxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3Zn IiB2aWV3Qm94PSIwIDAgNDUgNDUiPjxjaXJjbGUgY3g9IjIyLjUiIGN5PSIyMi41IiByPSIyMi41 IiBmaWxsPSIjYWIzOTAzIi8+PHBhdGggZD0iTTM0LjU3LDE1LjQzLDE1LjQzLDM0LjU3IiB0cmFu c2Zvcm09InRyYW5zbGF0ZSgtMi41IC0yLjUpIiBzdHlsZT0iZmlsbDpub25lO3N0cm9rZTojZmI1 MjA3O3N0cm9rZS13aWR0aDo3cHgiLz48cGF0aCBkPSJNMTUuNDMsMTUuNDMsMzQuNTcsMzQuNTci IHRyYW5zZm9ybT0idHJhbnNsYXRlKC0yLjUgLTIuNSkiIHN0eWxlPSJmaWxsOm5vbmU7c3Ryb2tl OiNmYjUyMDc7c3Ryb2tlLXdpZHRoOjdweCIvPjwvc3ZnPicpOworfQorCis8L3N0eWxlPgorPHNj cmlwdCB0eXBlPSJtb2R1bGUiPgord2luZG93LmVzNm1vZHVsZXMgPSB0cnVlOworPC9zY3JpcHQ+ Cis8c2NyaXB0PgorCitmdW5jdGlvbiB0ZXN0Q1NTR3JpZCgpIHsKKyAgICByZXR1cm4gQ1NTLnN1 cHBvcnRzKCJkaXNwbGF5IiwgImdyaWQiKTsKK30KKworZnVuY3Rpb24gdGVzdFdlYkdMMigpIHsK KyAgICBsZXQgY2FudmFzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiY2FudmFzIik7CisgICAg cmV0dXJuIGNhbnZhcy5nZXRDb250ZXh0KCJ3ZWJnbDIiKTsKK30KKworZnVuY3Rpb24gdGVzdEdh bWVwYWQoKSB7CisgICAgcmV0dXJuIG5hdmlnYXRvci5nZXRHYW1lcGFkczsKK30KKworZnVuY3Rp b24gdGVzdFNwcmluZ0FuaW1hdGlvbigpIHsKKyAgICByZXR1cm4gQ1NTLnN1cHBvcnRzKCJ0cmFu c2l0aW9uLXRpbWluZy1mdW5jdGlvbiIsICJzcHJpbmcoMSAxMDAgMTAgMCkiKTsKK30KKworZnVu Y3Rpb24gdGVzdFZhcmlhdGlvbkZvbnRzKCkgeworICAgIHJldHVybiBDU1Muc3VwcG9ydHMoImZv bnQtdmFyaWF0aW9uLXNldHRpbmdzIiwgJyJYSEdUIiAwLjcnKTsKK30KKworZnVuY3Rpb24gdGVz dEZvcm1WYWxpZGF0aW9uKCkgeworICAgIHJldHVybiAicmVwb3J0VmFsaWRpdHkiIGluIEhUTUxJ bnB1dEVsZW1lbnQucHJvdG90eXBlOworfQorCitmdW5jdGlvbiB0ZXN0SW5wdXRFdmVudHMoKSB7 CisgICAgcmV0dXJuIHdpbmRvdy5JbnB1dEV2ZW50OworfQorCitmdW5jdGlvbiB0ZXN0UG9pbnRl ckxvY2soKSB7CisgICAgcmV0dXJuICJleGl0UG9pbnRlckxvY2siIGluIERvY3VtZW50LnByb3Rv dHlwZTsKK30KKworZnVuY3Rpb24gdGVzdEVTNk1vZHVsZXMoKSB7CisgICAgcmV0dXJuIHdpbmRv dy5lczZtb2R1bGVzOworfQorCit3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigibG9hZCIsIGZ1bmN0 aW9uICgpIHsKKyAgICBBcnJheS5mcm9tKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwoIi50ZXN0 IikpLmZvckVhY2goZWxlbWVudCA9PiB7CisgICAgICAgIHZhciB0ZXN0RnVuY3Rpb24gPSB3aW5k b3dbYHRlc3Qke2VsZW1lbnQuaWR9YF07CisgICAgICAgIGlmICh0eXBlb2YgdGVzdEZ1bmN0aW9u ID09PSAiZnVuY3Rpb24iKQorICAgICAgICAgICAgZWxlbWVudC5jbGFzc0xpc3QuYWRkKHRlc3RG dW5jdGlvbigpID8gImVuYWJsZWQiIDogImRpc2FibGVkIik7CisgICAgfSk7Cit9LCBmYWxzZSk7 CisKKyAgPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKyAgICA8ZGl2IGNsYXNzPSJjb250ZW50 Ij4KKyAgICAgICAgPGgxPkV4cGVyaW1lbnRhbCBGZWF0dXJlIEF2YWlsYWJpbGl0eTwvaDE+Cisg ICAgICAgIDxwPlRvZ2dsZSBleHBlcmltZW50YWwgZmVhdHVyZXMgdmlhIHRoZSBEZXZlbG9wIG1l bnUgKHJlcXVpcmVzIHJlbG9hZCB0byB0YWtlIGVmZmVjdCkuPC9wPgorICAgICAgICA8cD5UaGVz ZSB0ZXN0cyBkbyBub3QgZXhlcmNpc2UgYWN0dWFsIGZ1bmN0aW9uYWxpdHkuIFRoZXkgYXJlIGp1 c3QgdGhlIG1vc3QgYmFzaWMgY2hlY2sgdG8gc2VlIGlmIHRoZSBmZWF0dXJlIGNsYWltcyB0byBi ZSBhdmFpbGFibGUuPC9wPgorCisgICAgICAgIDxkaXYgY2xhc3M9InRlc3QiIGlkPSJDU1NHcmlk Ij48cD5DU1MgR3JpZDwvcD48L2Rpdj4KKyAgICAgICAgPGRpdiBjbGFzcz0idGVzdCIgaWQ9Ikdh bWVwYWQiPjxwPkdhbWVwYWQgQVBJPC9wPjwvZGl2PgorICAgICAgICA8ZGl2IGNsYXNzPSJ0ZXN0 IiBpZD0iVmFyaWF0aW9uRm9udHMiPjxwPlZhcmlhdGlvbiBGb250czwvcD48L2Rpdj4KKyAgICAg ICAgPCEtLSBSZW1vdmUgIi11bmtub3duIiB3aGVuIFdlYktpdCBjYW4gZG8gbGl2ZSBmZWF0dXJl IGRldGVjdGlvbiBmb3IgcG9pbnRlciBsb2NrIC0tPgorICAgICAgICA8ZGl2IGNsYXNzPSJ0ZXN0 IiBpZD0iUG9pbnRlckxvY2stdW5rbm93biI+PHA+TW91c2UgUG9pbnRlciBMb2NrPC9wPjwvZGl2 PgorICAgICAgICA8ZGl2IGNsYXNzPSJ0ZXN0IiBpZD0iV2ViR0wyIj48cD5XZWJHTCAyLjA8L3A+ PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9InRlc3QiIGlkPSJGb3JtVmFsaWRhdGlvbiI+PHA+ SFRNTCBGb3JtIFZhbGlkYXRpb248L3A+PC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9InRlc3Qi IGlkPSJJbnB1dEV2ZW50cyI+PHA+SFRNTCBJbnB1dCBFdmVudHM8L3A+PC9kaXY+CisgICAgICAg IDxkaXYgY2xhc3M9InRlc3QiIGlkPSJTcHJpbmdBbmltYXRpb24iPjxwPkNTUyBTcHJpbmcgQW5p bWF0aW9uczwvcD48L2Rpdj4KKyAgICAgICAgPGRpdiBjbGFzcz0idGVzdCIgaWQ9IkVTNk1vZHVs ZXMiPjxwPkVTNiBNb2R1bGVzIGluIEhUTUw8L3A+PC9kaXY+CisgICAgPC9kaXY+Cis8L2JvZHk+ Cis8L2h0bWw+Cg==