165330 2016-12-02 13:43:03 -0800 Make IndexedDB.WebProcessKillIDBCleanup even more reliable 2016-12-02 14:29:43 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 160306 1 beidson beidson commit-queue lforschler oldest_to_newest 1255847 0 beidson 2016-12-02 13:43:03 -0800 Make IndexedDB.WebProcessKillIDBCleanup even more reliable Just null'ing out the RetainPtr doesn't necessarily destroy the WKWebView, so it doesn't necessarily kill the web content process. We should explicitly kill it. Also, by relocating *when* we kill it, we better test that IDB is working as expected. 1255849 1 295988 beidson 2016-12-02 13:46:06 -0800 Created attachment 295988 Patch 1255898 2 295988 commit-queue 2016-12-02 14:29:40 -0800 Comment on attachment 295988 Patch Clearing flags on attachment: 295988 Committed r209269: <http://trac.webkit.org/changeset/209269> 1255899 3 commit-queue 2016-12-02 14:29:43 -0800 All reviewed patches have been landed. Closing bug. 295988 2016-12-02 13:46:06 -0800 2016-12-02 14:29:40 -0800 Patch bug-165330-20161202134535.patch text/plain 2892 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MjUxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGRjNTM0NjVhOTQ3MTg0MWJiYzZlODdhMzY0MzNjNjFi YjNlOWJlMC4uNzI5MTJmOGFhZGVlZjIwMDJjN2I4MTM0Yzk2YWQ2OGM2MGNiMDMwMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIz IEBACiAyMDE2LTEyLTAyICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAorICAg ICAgICBNYWtlIEluZGV4ZWREQi5XZWJQcm9jZXNzS2lsbElEQkNsZWFudXAgZXZlbiBtb3JlIHJl bGlhYmxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY1MzMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIHRlc3QgY3VycmVudGx5IG51bGxzIG91dCBhIFJldGFpblB0cjxXS1dlYlZpZXc+IHRvIHRy eSB0byBkZXN0cm95IHRoZSB2aWV3IGFuZCBraWxsIHRoZSBwcm9jZXNzLgorCisgICAgICAgIFBy b2JsZW0gaXMgdGhhdCBkb2Vzbid0IHJlbGlhYmx5IGRlc3Ryb3kgdGhlIHZpZXcuCisgICAgICAg IFdlIHNob3VsZCBleHBsaWNpdGx5IGtpbGwgdGhlIHByb2Nlc3MgaW5zdGVhZC4KKworICAgICAg ICBBbHNvLCBieSByZWxvY2F0aW5nIHdoZW4gd2Uga2lsbCB0aGUgcHJvY2Vzcywgd2UgY2FuIGJl dHRlciB0ZXN0IGJlaGF2aW9yIG9mIHRoZSBJbmRleGVkREIgbWVjaGFuaXNtLgorICAgICAgICBl LmcuIFdlIGV4cGxpY2l0bHkgY29uZmlybSB0aGF0IGEgc2Vjb25kIFdlYlByb2Nlc3MgY2FuIHNp bXVsdGFuZW91c2x5IGF0dGFjaCB0byB0aGUgc2FtZSB1bmlxdWUgZGF0YWJhc2UgYXMgdGhlIGZp cnN0LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvV2ViUHJv Y2Vzc0tpbGxJREJDbGVhbnVwLm1tOgorICAgICAgICAoVEVTVCk6CisKKzIwMTYtMTItMDIgIEJy YWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCiAgICAgICAgIEluZGV4ZWREQi5JbmRl eGVkREJNdWx0aVByb2Nlc3MgYW5kIEluZGV4ZWREQi5XZWJQcm9jZXNzS2lsbElEQkNsZWFudXAg c29tZXRpbWVzIHRpbWVvdXQuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjA3ODAgYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjEwMDEKIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQyQ29jb2EvV2ViUHJvY2Vzc0tpbGxJREJDbGVhbnVwLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQyQ29jb2EvV2ViUHJvY2Vzc0tpbGxJREJDbGVhbnVwLm1tCmluZGV4IDE0 YTcxYTAyNTQ5YjkzNzA4M2Q0ODc0YmZhZjcxMjUwZmI4NTBhM2QuLmViNDA5N2YzNWZjYjgyNDg1 Y2FkNzc5N2I2ODY1YTg2MTljYWU3YTUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0MkNvY29hL1dlYlByb2Nlc3NLaWxsSURCQ2xlYW51cC5tbQorKysgYi9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9XZWJQcm9jZXNzS2lsbElEQkNsZWFu dXAubW0KQEAgLTMyLDYgKzMyLDcgQEAKICNpbXBvcnQgPFdlYktpdC9XS1Byb2Nlc3NQb29sUHJp dmF0ZS5oPgogI2ltcG9ydCA8V2ViS2l0L1dLVXNlckNvbnRlbnRDb250cm9sbGVyUHJpdmF0ZS5o PgogI2ltcG9ydCA8V2ViS2l0L1dLV2ViVmlld0NvbmZpZ3VyYXRpb25Qcml2YXRlLmg+CisjaW1w b3J0IDxXZWJLaXQvV0tXZWJWaWV3UHJpdmF0ZS5oPgogI2ltcG9ydCA8V2ViS2l0L19XS1Byb2Nl c3NQb29sQ29uZmlndXJhdGlvbi5oPgogI2ltcG9ydCA8V2ViS2l0L19XS1VzZXJTdHlsZVNoZWV0 Lmg+CiAjaW1wb3J0IDx3dGYvRGVxdWUuaD4KQEAgLTgzLDkgKzg0LDYgQEAgVEVTVChJbmRleGVk REIsIFdlYlByb2Nlc3NLaWxsSURCQ2xlYW51cCkKICAgICBSZXRhaW5QdHI8TlNTdHJpbmc+IHN0 cmluZzMgPSAoTlNTdHJpbmcgKilbZ2V0TmV4dE1lc3NhZ2UoKSBib2R5XTsKICAgICBSZXRhaW5Q dHI8TlNTdHJpbmc+IHN0cmluZzQgPSAoTlNTdHJpbmcgKilbZ2V0TmV4dE1lc3NhZ2UoKSBib2R5 XTsKIAotICAgIC8vIEtpbGwgdGhhdCB3ZWIgcHJvY2VzcwotICAgIHdlYlZpZXcgPSBuaWw7Ci0K ICAgICAvLyBNYWtlIGEgbmV3IHdlYiB2aWV3IHdpdGggYSBuZXcgd2ViIHByb2Nlc3MgdG8gZmlu aXNoIHRoZSB0ZXN0CiAgICAgUmV0YWluUHRyPFdLV2ViVmlldz4gd2ViVmlldzIgPSBhZG9wdE5T KFtbV0tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2 MDApIGNvbmZpZ3VyYXRpb246Y29uZmlndXJhdGlvbi5nZXQoKV0pOwogCkBAIC05Myw2ICs5MSwx MCBAQCBURVNUKEluZGV4ZWREQiwgV2ViUHJvY2Vzc0tpbGxJREJDbGVhbnVwKQogICAgIFt3ZWJW aWV3MiBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKIAogICAgIFJldGFpblB0cjxOU1N0cmluZz4gc3Ry aW5nNSA9IChOU1N0cmluZyAqKVtnZXROZXh0TWVzc2FnZSgpIGJvZHldOworCisgICAgLy8gS2ls bCB0aGUgZmlyc3Qgd2ViIHByb2Nlc3MgdG8gdW5ibG9jayB0aGUgc2Vjb25kIHdlYiBwcm9jZXNz ZXMgdHJhbnNhY3Rpb24gZnJvbSBzdGFydGluZy4KKyAgICBbd2ViVmlldyBfa2lsbFdlYkNvbnRl bnRQcm9jZXNzQW5kUmVzZXRTdGF0ZV07CisKICAgICBSZXRhaW5QdHI8TlNTdHJpbmc+IHN0cmlu ZzYgPSAoTlNTdHJpbmcgKilbZ2V0TmV4dE1lc3NhZ2UoKSBib2R5XTsKIAogICAgIEVYUEVDVF9X S19TVFJFUShAIlVwZ3JhZGVOZWVkZWQiLCBzdHJpbmcxLmdldCgpKTsK