165306 2016-12-02 08:40:11 -0800 [CSS Parser] Make sure margin and font set the implicit flag properly 2016-12-02 09:14:32 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt ap zalan oldest_to_newest 1255686 0 hyatt 2016-12-02 08:40:11 -0800 [CSS Parser] Make sure margin and font set the implicit flag properly 1255687 1 295946 hyatt 2016-12-02 08:41:17 -0800 Created attachment 295946 Patch 1255688 2 hyatt 2016-12-02 08:44:53 -0800 Fixed in r209239. 1255701 3 295946 ap 2016-12-02 09:14:32 -0800 Comment on attachment 295946 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295946&action=review > LayoutTests/TestExpectations:1012 > +webkit.org/b/165195 fast/inspector-support/style.html [ Pass Failure ] Why did this change make a test flaky? 295946 2016-12-02 08:41:17 -0800 2016-12-02 08:42:37 -0800 Patch bug-165306-20161202104047.patch text/plain 5674 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTIzOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE2LTEyLTAyICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFtDU1MgUGFyc2VyXSBNYWtlIHN1cmUg bWFyZ2luIGFuZCBmb250IHNldCB0aGUgaW1wbGljaXQgZmxhZyBwcm9wZXJseQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MzA2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjc3MvcGFyc2VyL0NTU1By b3BlcnR5UGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1Byb3BlcnR5UGFyc2VyOjpj b25zdW1lRm9udCk6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcm9wZXJ0eVBhcnNlcjo6Y29uc3Vt ZTRWYWx1ZXMpOgorCiAyMDE2LTEyLTAyICBEYXZlIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgog CiAgICAgICAgIFtDU1MgUGFyc2VyXSBNYWtlIHN1cmUgdGhlIHRlbXBsYXRpemVkIGNvbnN1bWVJ ZGVudCB1c2VzIENTU1ZhbHVlUG9vbApJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9D U1NQcm9wZXJ0eVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL3Bh cnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHAJKHJldmlzaW9uIDIwOTIzNykKKysrIFNvdXJjZS9X ZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00MjMzLDE1ICs0MjMzLDE1IEBAIGJvb2wgQ1NTUHJvcGVydHlQYXJzZXI6OmNvbnN1bWVGb250 KGJvb2wKICAgICBpZiAobV9yYW5nZS5hdEVuZCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAK LSAgICBhZGRQcm9wZXJ0eShDU1NQcm9wZXJ0eUZvbnRTdHlsZSwgQ1NTUHJvcGVydHlGb250LCBm b250U3R5bGUgPyBmb250U3R5bGUucmVsZWFzZU5vbk51bGwoKSA6IENTU1ZhbHVlUG9vbDo6c2lu Z2xldG9uKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1ZhbHVlTm9ybWFsKSwgaW1wb3J0YW50 KTsKLSAgICBhZGRQcm9wZXJ0eShDU1NQcm9wZXJ0eUZvbnRWYXJpYW50Q2FwcywgQ1NTUHJvcGVy dHlGb250LCBmb250VmFyaWFudENhcHMgPyBmb250VmFyaWFudENhcHMucmVsZWFzZU5vbk51bGwo KSA6IENTU1ZhbHVlUG9vbDo6c2luZ2xldG9uKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1Zh bHVlTm9ybWFsKSwgaW1wb3J0YW50KTsKKyAgICBhZGRQcm9wZXJ0eShDU1NQcm9wZXJ0eUZvbnRT dHlsZSwgQ1NTUHJvcGVydHlGb250LCBmb250U3R5bGUgPyBmb250U3R5bGUucmVsZWFzZU5vbk51 bGwoKSA6IENTU1ZhbHVlUG9vbDo6c2luZ2xldG9uKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENT U1ZhbHVlTm9ybWFsKSwgaW1wb3J0YW50LCAhZm9udFN0eWxlKTsKKyAgICBhZGRQcm9wZXJ0eShD U1NQcm9wZXJ0eUZvbnRWYXJpYW50Q2FwcywgQ1NTUHJvcGVydHlGb250LCBmb250VmFyaWFudENh cHMgPyBmb250VmFyaWFudENhcHMucmVsZWFzZU5vbk51bGwoKSA6IENTU1ZhbHVlUG9vbDo6c2lu Z2xldG9uKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1ZhbHVlTm9ybWFsKSwgaW1wb3J0YW50 LCAhZm9udFZhcmlhbnRDYXBzKTsKIC8qICAKICAgICAvLyBGSVhNRS1ORVdQQVJTRVI6IFdoYXQg ZG8gd2UgZG8gd2l0aCB0aGVzZT8gVGhleSBhcmVuJ3QgcGFydCBvZiBvdXIgZm9udFNob3J0aGFu ZCgpLgogICAgIGFkZFByb3BlcnR5KENTU1Byb3BlcnR5Rm9udFZhcmlhbnRMaWdhdHVyZXMsIENT U1Byb3BlcnR5Rm9udCwgQ1NTVmFsdWVQb29sOjpzaW5nbGV0b24oKS5jcmVhdGVJZGVudGlmaWVy VmFsdWUoQ1NTVmFsdWVOb3JtYWwpLCBpbXBvcnRhbnQpOwogICAgIGFkZFByb3BlcnR5KENTU1By b3BlcnR5Rm9udFZhcmlhbnROdW1lcmljLCBDU1NQcm9wZXJ0eUZvbnQsIENTU1ZhbHVlUG9vbDo6 c2luZ2xldG9uKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1ZhbHVlTm9ybWFsKSwgaW1wb3J0 YW50KTsKICovCiAgICAgCi0gICAgYWRkUHJvcGVydHkoQ1NTUHJvcGVydHlGb250V2VpZ2h0LCBD U1NQcm9wZXJ0eUZvbnQsIGZvbnRXZWlnaHQgPyBmb250V2VpZ2h0LnJlbGVhc2VOb25OdWxsKCkg OiBDU1NWYWx1ZVBvb2w6OnNpbmdsZXRvbigpLmNyZWF0ZUlkZW50aWZpZXJWYWx1ZShDU1NWYWx1 ZU5vcm1hbCksIGltcG9ydGFudCk7CisgICAgYWRkUHJvcGVydHkoQ1NTUHJvcGVydHlGb250V2Vp Z2h0LCBDU1NQcm9wZXJ0eUZvbnQsIGZvbnRXZWlnaHQgPyBmb250V2VpZ2h0LnJlbGVhc2VOb25O dWxsKCkgOiBDU1NWYWx1ZVBvb2w6OnNpbmdsZXRvbigpLmNyZWF0ZUlkZW50aWZpZXJWYWx1ZShD U1NWYWx1ZU5vcm1hbCksIGltcG9ydGFudCwgIWZvbnRXZWlnaHQpOwogICAgIC8qIEZJWE1FLU5F V1BBUlNFUjogSW1wbGVtZW50LgogICAgIGFkZFByb3BlcnR5KENTU1Byb3BlcnR5Rm9udFN0cmV0 Y2gsIENTU1Byb3BlcnR5Rm9udCwgZm9udFN0cmV0Y2ggPyBmb250U3RyZXRjaC5yZWxlYXNlTm9u TnVsbCgpIDogQ1NTVmFsdWVQb29sOjpzaW5nbGV0b24oKS5jcmVhdGVJZGVudGlmaWVyVmFsdWUo Q1NTVmFsdWVOb3JtYWwpLCBpbXBvcnRhbnQpOwogICAgICovCkBAIC00MjU5LDcgKzQyNTksNyBA QCBib29sIENTU1Byb3BlcnR5UGFyc2VyOjpjb25zdW1lRm9udChib29sCiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CiAgICAgICAgIGFkZFByb3BlcnR5KENTU1Byb3BlcnR5TGluZUhlaWdodCwg Q1NTUHJvcGVydHlGb250LCBsaW5lSGVpZ2h0LnJlbGVhc2VOb25OdWxsKCksIGltcG9ydGFudCk7 CiAgICAgfSBlbHNlIHsKLSAgICAgICAgYWRkUHJvcGVydHkoQ1NTUHJvcGVydHlMaW5lSGVpZ2h0 LCBDU1NQcm9wZXJ0eUZvbnQsIENTU1ZhbHVlUG9vbDo6c2luZ2xldG9uKCkuY3JlYXRlSWRlbnRp ZmllclZhbHVlKENTU1ZhbHVlTm9ybWFsKSwgaW1wb3J0YW50KTsKKyAgICAgICAgYWRkUHJvcGVy dHkoQ1NTUHJvcGVydHlMaW5lSGVpZ2h0LCBDU1NQcm9wZXJ0eUZvbnQsIENTU1ZhbHVlUG9vbDo6 c2luZ2xldG9uKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKENTU1ZhbHVlTm9ybWFsKSwgaW1wb3J0 YW50LCB0cnVlKTsKICAgICB9CiAKICAgICAvLyBGb250IGZhbWlseSBtdXN0IGNvbWUgbm93LgpA QCAtNDYzMyw2ICs0NjMzLDEwIEBAIGJvb2wgQ1NTUHJvcGVydHlQYXJzZXI6OmNvbnN1bWU0VmFs dWVzKGMKICAgICAgICAgICAgIGxlZnQgPSBwYXJzZVNpbmdsZVZhbHVlKGxvbmdoYW5kc1szXSwg c2hvcnRoYW5kLmlkKCkpOwogICAgIH0KIAorICAgIGJvb2wgcmlnaHRJbXBsaWNpdCA9ICFyaWdo dDsKKyAgICBib29sIGJvdHRvbUltcGxpY2l0ID0gIWJvdHRvbTsKKyAgICBib29sIGxlZnRJbXBs aWNpdCA9ICFsZWZ0OworCiAgICAgaWYgKCFyaWdodCkKICAgICAgICAgcmlnaHQgPSB0b3A7CiAg ICAgaWYgKCFib3R0b20pCkBAIC00NjQxLDkgKzQ2NDUsOSBAQCBib29sIENTU1Byb3BlcnR5UGFy c2VyOjpjb25zdW1lNFZhbHVlcyhjCiAgICAgICAgIGxlZnQgPSByaWdodDsKIAogICAgIGFkZFBy b3BlcnR5KGxvbmdoYW5kc1swXSwgc2hvcnRoYW5kLmlkKCksIHRvcC5yZWxlYXNlTm9uTnVsbCgp LCBpbXBvcnRhbnQpOwotICAgIGFkZFByb3BlcnR5KGxvbmdoYW5kc1sxXSwgc2hvcnRoYW5kLmlk KCksIHJpZ2h0LnJlbGVhc2VOb25OdWxsKCksIGltcG9ydGFudCk7Ci0gICAgYWRkUHJvcGVydHko bG9uZ2hhbmRzWzJdLCBzaG9ydGhhbmQuaWQoKSwgYm90dG9tLnJlbGVhc2VOb25OdWxsKCksIGlt cG9ydGFudCk7Ci0gICAgYWRkUHJvcGVydHkobG9uZ2hhbmRzWzNdLCBzaG9ydGhhbmQuaWQoKSwg bGVmdC5yZWxlYXNlTm9uTnVsbCgpLCBpbXBvcnRhbnQpOworICAgIGFkZFByb3BlcnR5KGxvbmdo YW5kc1sxXSwgc2hvcnRoYW5kLmlkKCksIHJpZ2h0LnJlbGVhc2VOb25OdWxsKCksIGltcG9ydGFu dCwgcmlnaHRJbXBsaWNpdCk7CisgICAgYWRkUHJvcGVydHkobG9uZ2hhbmRzWzJdLCBzaG9ydGhh bmQuaWQoKSwgYm90dG9tLnJlbGVhc2VOb25OdWxsKCksIGltcG9ydGFudCwgYm90dG9tSW1wbGlj aXQpOworICAgIGFkZFByb3BlcnR5KGxvbmdoYW5kc1szXSwgc2hvcnRoYW5kLmlkKCksIGxlZnQu cmVsZWFzZU5vbk51bGwoKSwgaW1wb3J0YW50LCBsZWZ0SW1wbGljaXQpOwogCiAgICAgcmV0dXJu IG1fcmFuZ2UuYXRFbmQoKTsKIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTIwMikKKysrIExheW91 dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE2LTEy LTAyICBEYXZlIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIFtDU1MgUGFyc2Vy XSBNYWtlIHN1cmUgbWFyZ2luIGFuZCBmb250IHNldCB0aGUgaW1wbGljaXQgZmxhZyBwcm9wZXJs eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MzA2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0 RXhwZWN0YXRpb25zOgorCiAyMDE2LTEyLTAxICBEYXZlIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgogCiAgICAgICAgIFtDU1MgUGFyc2VyXSBGaXggYW4gaW52YWxpZCBzaGFkb3cgRE9NIHRlc3QK SW5kZXg6IExheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMjA5MTk5KQorKysgTGF5b3V0VGVzdHMv VGVzdEV4cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtMTAwOSw2ICsxMDA5LDcgQEAgd2Vi a2l0Lm9yZy9iLzE2NTE5NSBmYXN0L2Nzcy92YXJpYWJsZXMvYwogd2Via2l0Lm9yZy9iLzE2NTE5 NSBmYXN0L2V2ZW50cy9tb3VzZS1jdXJzb3IuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJraXQu b3JnL2IvMTY1MTk1IGZhc3QvZm9ybXMvYmFzaWMtc2VsZWN0cy5odG1sIFsgUGFzcyBGYWlsdXJl IF0KIHdlYmtpdC5vcmcvYi8xNjUxOTUgZmFzdC9zaGFkb3ctZG9tL3Nsb3R0ZWQtcHNldWRvLWVs ZW1lbnQtY3NzLXRleHQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMTY1MTk1 IGZhc3QvaW5zcGVjdG9yLXN1cHBvcnQvc3R5bGUuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKICMg VGhlIGZvbGxvd2luZyBsYXlvdXQgdGVzdHMgbmVlZCB0byBiZSBjaGFuZ2VkIHdoZW4gdGhlIG5l dyBDU1MgUGFyc2VyIGlzIHR1cm5lZCBvbiwgc2luY2UgdGhleQogIyBpbmNvcnJlY3RseSBpbmRp Y2F0ZSBmYWlsdXJlcyBvbiB2YWxpZCBzeW50YXguCg==