165300 2016-12-02 04:26:17 -0800 [GTK] Process accelerated compositing env variables only if they are really enabled 2016-12-08 05:40:28 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 165501 1 tpopela tpopela bugs-noreply commit-queue mcatanzaro oldest_to_newest 1255655 0 tpopela 2016-12-02 04:26:17 -0800 Only process WEBKIT_FORCE_COMPOSITING_MODE and WEBKIT_DISABLE_COMPOSITING_MODE env variables if they are really enabled (eg. WEBKIT_DISABLE_COMPOSITING_MODE=1) and ignore others (eg. WEBKIT_DISABLE_COMPOSITING_MODE=0). This will help WebKitGTK+ consumers to be able to not disable AC through the env variable if the user wants the AC to be turned on (he will usually have "export WEBKIT_DISABLE_COMPOSITING_MODE=0" somewhere). 1255657 1 295940 tpopela 2016-12-02 04:30:24 -0800 Created attachment 295940 Patch 1255685 2 295940 mcatanzaro 2016-12-02 08:39:56 -0800 Comment on attachment 295940 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295940&action=review > Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp:50 > - if (getenv("WEBKIT_FORCE_COMPOSITING_MODE")) > + if (!g_strcmp0(getenv("WEBKIT_FORCE_COMPOSITING_MODE"), "1")) How about if (g_strcmp0(getenv("WEBKIT_FORCE_COMPOSITING_MODE"), "0")), that way you can disable it by setting it to 0, but set it to anything else and it'd still be enabled? That seems more familiar to me; what do other popular applications do? > Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp:54 > - if (getenv("WEBKIT_DISABLE_COMPOSITING_MODE")) { > + if (!g_strcmp0(getenv("WEBKIT_DISABLE_COMPOSITING_MODE"), "1")) { Ditto. 1256281 3 tpopela 2016-12-05 02:16:30 -0800 (In reply to comment #2) > Comment on attachment 295940 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295940&action=review > > > Source/WebKit2/UIProcess/gtk/WebPreferencesGtk.cpp:50 > > - if (getenv("WEBKIT_FORCE_COMPOSITING_MODE")) > > + if (!g_strcmp0(getenv("WEBKIT_FORCE_COMPOSITING_MODE"), "1")) > > How about if (g_strcmp0(getenv("WEBKIT_FORCE_COMPOSITING_MODE"), "0")), that > way you can disable it by setting it to 0, but set it to anything else and > it'd still be enabled? That seems more familiar to me; what do other popular > applications do? Could be as I don't have a strong preference on any of them. I don't any env variable apart from gtk's GTK_OVERLAY_SCROLLING: gtk/gtkscrolledwindow.c:4415: if (g_strcmp0 (g_getenv ("GTK_OVERLAY_SCROLLING"), "0") == 0) and that behaves the same way you described.. Let's rework the patch :).. 1256283 4 296135 tpopela 2016-12-05 02:48:23 -0800 Created attachment 296135 Patch 1256286 5 296135 mcatanzaro 2016-12-05 03:48:05 -0800 Comment on attachment 296135 Patch This way also avoids breaking previous instructions. I doubt anybody was dumb enough to define WEBKIT_FORCE_COMPOSITING_MODE=0 and expect to get compositing mode, but it's not hard to imagine someone using WEBKIT_FORCE_COMPOSITING_MODE= or something. 1256788 6 296135 tpopela 2016-12-06 04:16:38 -0800 Comment on attachment 296135 Patch Clearing flags on attachment: 296135 Committed r209391: <http://trac.webkit.org/changeset/209391> 1256789 7 tpopela 2016-12-06 04:16:47 -0800 All reviewed patches have been landed. Closing bug. 1257078 8 commit-queue 2016-12-06 16:38:28 -0800 Re-opened since this is blocked by bug 165501 1257230 9 mcatanzaro 2016-12-07 05:27:00 -0800 Sorry about the bad advice, Tom. :) To do it properly you'll need to check if the env variable is set, and then use plain strcmp instead of g_strcmp0 only if it's set, like Milan suggested. 1257680 10 296508 tpopela 2016-12-08 03:46:19 -0800 Created attachment 296508 Patch 1257684 11 296508 tpopela 2016-12-08 05:40:19 -0800 Comment on attachment 296508 Patch Clearing flags on attachment: 296508 Committed r209534: <http://trac.webkit.org/changeset/209534> 1257685 12 tpopela 2016-12-08 05:40:28 -0800 All reviewed patches have been landed. Closing bug. 295940 2016-12-02 04:30:24 -0800 2016-12-05 02:48:16 -0800 Patch bug-165300-20161202132953.patch text/plain 1838 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWI0NjZmMzRkMTcxZWUz MDdlOTIyNmQ4OTljNTI3NGMxMjlmNTNlNy4uYWIyMTI3NDkxOGMwMTA0ZWQ3ZDc0ZjE0NjQ3MmM2 OTYxYTU4ZWNjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTEyLTAyICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW0dUS10gUHJvY2VzcyBh Y2NlbGVyYXRlZCBjb21wb3NpdGluZyBlbnYgdmFyaWFibGVzIG9ubHkgaWYgdGhleSBhcmUgcmVh bGx5IGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2NTMwMAorCisgICAgICAgIE9ubHkgcHJvY2VzcyB0aGUgV0VCS0lUX0ZPUkNFX0NPTVBP U0lUSU5HX01PREUgYW5kCisgICAgICAgIFdFQktJVF9ESVNBQkxFX0NPTVBPU0lUSU5HX01PREUg ZW52IHZhcmlhYmxlcyBpZiB0aGV5IGFyZSByZWFsbHkKKyAgICAgICAgZW5hYmxlZCAoZWcuIFdF QktJVF9ESVNBQkxFX0NPTVBPU0lUSU5HX01PREU9MSkgYW5kIGlnbm9yZSBvdGhlcnMgKGVnLgor ICAgICAgICBXRUJLSVRfRElTQUJMRV9DT01QT1NJVElOR19NT0RFPTApLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9XZWJQ cmVmZXJlbmNlc0d0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByZWZlcmVuY2VzOjpwbGF0 Zm9ybUluaXRpYWxpemVTdG9yZSk6CisKIDIwMTYtMTEtMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIERhdGFiYXNlIHByb2Nlc3Mg c2hvdWxkIG5vdCBpbml0aWFsaXplIGd0awpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2d0ay9XZWJQcmVmZXJlbmNlc0d0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvZ3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcAppbmRleCBjYjQ5YmQ2YTI0YzU3ZjlmY2FlNzQz NDZmNzQ2NWI3NjUxNDNkMDY1Li4xZTg3YmM2ZTc5NzZjYTlkY2FiY2EwZDk4OGIxNzg3ZWMwOTgy NmI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZlcmVu Y2VzR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZlcmVu Y2VzR3RrLmNwcApAQCAtNDcsMTEgKzQ3LDExIEBAIHZvaWQgV2ViUHJlZmVyZW5jZXM6OnBsYXRm b3JtSW5pdGlhbGl6ZVN0b3JlKCkKICNpZiBVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1NfVEhSRUFE RUQpCiAgICAgc2V0Rm9yY2VDb21wb3NpdGluZ01vZGUodHJ1ZSk7CiAjZWxzZQotICAgIGlmIChn ZXRlbnYoIldFQktJVF9GT1JDRV9DT01QT1NJVElOR19NT0RFIikpCisgICAgaWYgKCFnX3N0cmNt cDAoZ2V0ZW52KCJXRUJLSVRfRk9SQ0VfQ09NUE9TSVRJTkdfTU9ERSIpLCAiMSIpKQogICAgICAg ICBzZXRGb3JjZUNvbXBvc2l0aW5nTW9kZSh0cnVlKTsKICNlbmRpZgogCi0gICAgaWYgKGdldGVu digiV0VCS0lUX0RJU0FCTEVfQ09NUE9TSVRJTkdfTU9ERSIpKSB7CisgICAgaWYgKCFnX3N0cmNt cDAoZ2V0ZW52KCJXRUJLSVRfRElTQUJMRV9DT01QT1NJVElOR19NT0RFIiksICIxIikpIHsKICAg ICAgICAgc2V0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ0VuYWJsZWQoZmFsc2UpOwogICAgICAgICBy ZXR1cm47CiAgICAgfQo= 296135 2016-12-05 02:48:23 -0800 2016-12-08 03:46:12 -0800 Patch bug-165300-20161205114747.patch text/plain 1764 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNWI0NjZmMzRkMTcxZWUz MDdlOTIyNmQ4OTljNTI3NGMxMjlmNTNlNy4uZGY3NDc1Y2ZjYTRjM2Q5NjhhM2IzOWZiNmRjY2Mw NGQ4NTE4NjhjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEyLTAyICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW0dUS10gUHJvY2VzcyBh Y2NlbGVyYXRlZCBjb21wb3NpdGluZyBlbnYgdmFyaWFibGVzIG9ubHkgaWYgdGhleSBhcmUgcmVh bGx5IGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2NTMwMAorCisgICAgICAgIERvbid0IHByb2Nlc3MgdGhlIFdFQktJVF9GT1JDRV9DT01Q T1NJVElOR19NT0RFIGFuZAorICAgICAgICBXRUJLSVRfRElTQUJMRV9DT01QT1NJVElOR19NT0RF IGVudiB2YXJpYWJsZXMgaWYgdGhleSBhcmUgZGlzYWJsZWQKKyAgICAgICAgKGVnLiBXRUJLSVRf RElTQUJMRV9DT01QT1NJVElOR19NT0RFPTApLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9XZWJQcmVmZXJlbmNlc0d0ay5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByZWZlcmVuY2VzOjpwbGF0Zm9ybUluaXRpYWxpemVT dG9yZSk6CisKIDIwMTYtMTEtMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtHVEtdIERhdGFiYXNlIHByb2Nlc3Mgc2hvdWxkIG5vdCBpbml0 aWFsaXplIGd0awpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJQ cmVmZXJlbmNlc0d0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZl cmVuY2VzR3RrLmNwcAppbmRleCBjYjQ5YmQ2YTI0YzU3ZjlmY2FlNzQzNDZmNzQ2NWI3NjUxNDNk MDY1Li5hMjdlYTNhOGNkMDI2NDA1YzFiNDFlOTA4NzliZWU5NzdmY2IzMzA3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcApAQCAt NDcsMTEgKzQ3LDExIEBAIHZvaWQgV2ViUHJlZmVyZW5jZXM6OnBsYXRmb3JtSW5pdGlhbGl6ZVN0 b3JlKCkKICNpZiBVU0UoQ09PUkRJTkFURURfR1JBUEhJQ1NfVEhSRUFERUQpCiAgICAgc2V0Rm9y Y2VDb21wb3NpdGluZ01vZGUodHJ1ZSk7CiAjZWxzZQotICAgIGlmIChnZXRlbnYoIldFQktJVF9G T1JDRV9DT01QT1NJVElOR19NT0RFIikpCisgICAgaWYgKGdfc3RyY21wMChnZXRlbnYoIldFQktJ VF9GT1JDRV9DT01QT1NJVElOR19NT0RFIiksICIwIikpCiAgICAgICAgIHNldEZvcmNlQ29tcG9z aXRpbmdNb2RlKHRydWUpOwogI2VuZGlmCiAKLSAgICBpZiAoZ2V0ZW52KCJXRUJLSVRfRElTQUJM RV9DT01QT1NJVElOR19NT0RFIikpIHsKKyAgICBpZiAoZ19zdHJjbXAwKGdldGVudigiV0VCS0lU X0RJU0FCTEVfQ09NUE9TSVRJTkdfTU9ERSIpLCAiMCIpKSB7CiAgICAgICAgIHNldEFjY2VsZXJh dGVkQ29tcG9zaXRpbmdFbmFibGVkKGZhbHNlKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K 296508 2016-12-08 03:46:19 -0800 2016-12-08 05:40:19 -0800 Patch bug-165300-20161208124538.patch text/plain 1887 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5NTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMjY0NDFjZGY1MGNhZTA3 MmQwYjdmOThlNGIyOGFiYzk1YzBiN2UyNS4uMDUwMzA4NGU4ZDI5N2NmYmUwZjdjNDA1YTRjNTc2 ZmY0NmM3ZjNlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTEyLTAyICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW0dUS10gUHJvY2VzcyBh Y2NlbGVyYXRlZCBjb21wb3NpdGluZyBlbnYgdmFyaWFibGVzIG9ubHkgaWYgdGhleSBhcmUgcmVh bGx5IGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2NTMwMAorCisgICAgICAgIERvbid0IHByb2Nlc3MgdGhlIFdFQktJVF9GT1JDRV9DT01Q T1NJVElOR19NT0RFIGFuZAorICAgICAgICBXRUJLSVRfRElTQUJMRV9DT01QT1NJVElOR19NT0RF IGVudiB2YXJpYWJsZXMgaWYgdGhleSBhcmUgZGlzYWJsZWQKKyAgICAgICAgKGVnLiBXRUJLSVRf RElTQUJMRV9DT01QT1NJVElOR19NT0RFPTApLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9XZWJQcmVmZXJlbmNlc0d0ay5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByZWZlcmVuY2VzOjpwbGF0Zm9ybUluaXRpYWxpemVT dG9yZSk6CisKIDIwMTYtMTItMDggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBGaXggQ01ha2UgYnVpbGQuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9ndGsvV2ViUHJlZmVyZW5jZXNHdGsuY3BwCmluZGV4IGNiNDliZDZhMjRj NTdmOWZjYWU3NDM0NmY3NDY1Yjc2NTE0M2QwNjUuLjgzY2I2MjBkMjQwYjhmMTk5MTZiOGVlOTE1 NzhiOTZlYWY4YmJlZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsv V2ViUHJlZmVyZW5jZXNHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsv V2ViUHJlZmVyZW5jZXNHdGsuY3BwCkBAIC00NywxMSArNDcsMTMgQEAgdm9pZCBXZWJQcmVmZXJl bmNlczo6cGxhdGZvcm1Jbml0aWFsaXplU3RvcmUoKQogI2lmIFVTRShDT09SRElOQVRFRF9HUkFQ SElDU19USFJFQURFRCkKICAgICBzZXRGb3JjZUNvbXBvc2l0aW5nTW9kZSh0cnVlKTsKICNlbHNl Ci0gICAgaWYgKGdldGVudigiV0VCS0lUX0ZPUkNFX0NPTVBPU0lUSU5HX01PREUiKSkKKyAgICBj b25zdCBjaGFyKiBmb3JjZV9jb21wb3NpdGluZyA9IGdldGVudigiV0VCS0lUX0ZPUkNFX0NPTVBP U0lUSU5HX01PREUiKTsKKyAgICBpZiAoZm9yY2VfY29tcG9zaXRpbmcgJiYgc3RyY21wKGZvcmNl X2NvbXBvc2l0aW5nLCAiMCIpKQogICAgICAgICBzZXRGb3JjZUNvbXBvc2l0aW5nTW9kZSh0cnVl KTsKICNlbmRpZgogCi0gICAgaWYgKGdldGVudigiV0VCS0lUX0RJU0FCTEVfQ09NUE9TSVRJTkdf TU9ERSIpKSB7CisgICAgY29uc3QgY2hhciogZGlzYWJsZV9jb21wb3NpdGluZyA9IGdldGVudigi V0VCS0lUX0RJU0FCTEVfQ09NUE9TSVRJTkdfTU9ERSIpOworICAgIGlmIChkaXNhYmxlX2NvbXBv c2l0aW5nICYmIHN0cmNtcChkaXNhYmxlX2NvbXBvc2l0aW5nLCAiMCIpKSB7CiAgICAgICAgIHNl dEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVkKGZhbHNlKTsKICAgICAgICAgcmV0dXJuOwog ICAgIH0K