165298 2016-12-02 02:36:50 -0800 [GTK] Minibrowser: Add printing support 2017-01-05 04:08:42 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tpopela tpopela bugs-noreply mcatanzaro oldest_to_newest 1255644 0 tpopela 2016-12-02 02:36:50 -0800 It would be nice to have a possibility of showing a print dialog when pressing a Ctrl + P shortcut. 1255645 1 295936 tpopela 2016-12-02 02:39:59 -0800 Created attachment 295936 Patch 1255675 2 295936 mcatanzaro 2016-12-02 08:18:09 -0800 Comment on attachment 295936 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295936&action=review Maybe we should add a toolbar button for it...? > Tools/MiniBrowser/gtk/BrowserWindow.c:533 > + if (webkit_print_operation_run_dialog(printOperation, GTK_WINDOW(window)) != WEBKIT_PRINT_OPERATION_RESPONSE_CANCEL) > + g_signal_connect(printOperation, "failed", G_CALLBACK(webKitPrintOperationFailedCallback), window); Does this error path actually work? Did you test it? The "failed" signal is emitted after the dialog is closed, so you don't need to connect in advance? 1255676 3 mcatanzaro 2016-12-02 08:18:52 -0800 I think if that actually works, then we need better documentation for WebKitPrintOperation, because that's not what I'd expect. 1255684 4 295936 cgarcia 2016-12-02 08:34:04 -0800 Comment on attachment 295936 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295936&action=review I've always used javascript:print() in the url bar to test printing with MiniBrowser, but I'm ok with adding CTRL + P too. > Tools/MiniBrowser/gtk/BrowserWindow.c:519 > +static void webKitPrintOperationFailedCallback(WebKitPrintOperation *printOperation, GError *error, BrowserWindow *window) BrowserWindow is unused, you could just pas NULL as user_data > Tools/MiniBrowser/gtk/BrowserWindow.c:524 > + g_warning("Print failed without error set"); Is this really possible? I think this should be a bug, failed callback should always provide a valid GError. 1255707 5 mcatanzaro 2016-12-02 09:19:54 -0800 Ah yeah, if there's no GError set then you should just crash by dereferencing it. :) As a rule, functions that can fail must always set the GError when returning FALSE; that convention should apply to our signal here too. 1256284 6 tpopela 2016-12-05 03:01:43 -0800 (In reply to comment #4) > Is this really possible? I think this should be a bug, failed callback > should always provide a valid GError. I added it there "just to be sure". I will remove it. 1256285 7 tpopela 2016-12-05 03:26:54 -0800 (In reply to comment #3) > I think if that actually works, then we need better documentation for > WebKitPrintOperation, because that's not what I'd expect. No, it does not work. I actually don't know how to make the print to fail. 1256288 8 mcatanzaro 2016-12-05 03:49:51 -0800 (In reply to comment #7) > (In reply to comment #3) > > I think if that actually works, then we need better documentation for > > WebKitPrintOperation, because that's not what I'd expect. > > No, it does not work. I actually don't know how to make the print to fail. To test it, modify GTK+ so that the operation does nothing but fail. 1263740 9 298004 tpopela 2017-01-04 04:45:01 -0800 Created attachment 298004 Patch 1263779 10 298004 mcatanzaro 2017-01-04 09:26:08 -0800 Comment on attachment 298004 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=298004&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:521 > + g_warning("Print failed with: '%s'", error->message); Remove the word "with" 1264082 11 tpopela 2017-01-05 04:08:42 -0800 Committed r210324: <http://trac.webkit.org/changeset/210324> 295936 2016-12-02 02:39:59 -0800 2017-01-04 04:44:54 -0800 Patch bug-165298-20161202113929.patch text/plain 2824 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MTI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzQzZmY5Y2IzMGQyMzZmZGI4MjU5MTM1NDBlYjQzZGQ5 Njk0ZGUzYy4uODI1YmViOTQwNjUzZmU5YjZkNzk3OGQwNWU5MTY4MjYyMjFhOWE1MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTEyLTAyICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAg ICAgICAgW0dUS10gTWluaWJyb3dzZXI6IEFkZCBwcmludGluZyBzdXBwb3J0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUyOTgKKworICAgICAgICBP cGVuIGEgcHJpbnQgZGlhbG9nIHdoZW4gdGhlIEN0cmwgKyBQIHNob3J0Y3V0IGlzIHByZXNzZWQu IElmIHRoZXJlIGlzCisgICAgICAgIGFuIGVycm9yIGR1cmluZyB0aGUgcHJpbnQsIGl0J3MgcHJv cGFnYXRlZCB0byB0aGUgY29uc29sZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAg ICAgICh3ZWJLaXRQcmludE9wZXJhdGlvbkZhaWxlZENhbGxiYWNrKToKKyAgICAgICAgKHByaW50 UGFnZSk6CisgICAgICAgIChicm93c2VyX3dpbmRvd19pbml0KToKKwogMjAxNi0xMS0yOSAgQ2Fy bG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBb TGludXhdIHJ1bi1iZW5jaG1hcmsgc2hvdWxkIGJlIGFibGUgdG8gZXhlY3V0ZSB0aGUgYmVuY2ht YXJrcyB3aXRoIG1vcmUgYnJvd3NlcnMuCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9n dGsvQnJvd3NlcldpbmRvdy5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cu YwppbmRleCBmZTQ0OGIwNjI5MGNiMjJiYWQ2ZDNhZDQwN2I4YzI4ZDM4MDg1ZmY1Li5iODIxNDRj NTU5OTljNGQ4YTgwYTkwNzcwZGJlYzY4ZmIxMjRlMTJkIDEwMDY0NAotLS0gYS9Ub29scy9NaW5p QnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9C cm93c2VyV2luZG93LmMKQEAgLTUxNiw2ICs1MTYsMjUgQEAgc3RhdGljIGdib29sZWFuIHRvZ2ds ZUZ1bGxTY3JlZW4oQnJvd3NlcldpbmRvdyAqd2luZG93LCBncG9pbnRlciB1c2VyX2RhdGEpCiAg ICAgcmV0dXJuIFRSVUU7CiB9CiAKK3N0YXRpYyB2b2lkIHdlYktpdFByaW50T3BlcmF0aW9uRmFp bGVkQ2FsbGJhY2soV2ViS2l0UHJpbnRPcGVyYXRpb24gKnByaW50T3BlcmF0aW9uLCBHRXJyb3Ig KmVycm9yLCBCcm93c2VyV2luZG93ICp3aW5kb3cpCit7CisgICAgaWYgKGVycm9yKQorICAgICAg ICBnX3dhcm5pbmcoIlByaW50IGZhaWxlZCB3aXRoOiAnJXMnIiwgZXJyb3ItPm1lc3NhZ2UpOwor ICAgIGVsc2UKKyAgICAgICAgZ193YXJuaW5nKCJQcmludCBmYWlsZWQgd2l0aG91dCBlcnJvciBz ZXQiKTsKK30KKworc3RhdGljIGdib29sZWFuIHByaW50UGFnZShCcm93c2VyV2luZG93ICp3aW5k b3csIGdwb2ludGVyIHVzZXJfZGF0YSkKK3sKKyAgICBXZWJLaXRXZWJWaWV3ICp3ZWJWaWV3ID0g YnJvd3Nlcl90YWJfZ2V0X3dlYl92aWV3KHdpbmRvdy0+YWN0aXZlVGFiKTsKKyAgICBXZWJLaXRQ cmludE9wZXJhdGlvbiAqcHJpbnRPcGVyYXRpb24gPSB3ZWJraXRfcHJpbnRfb3BlcmF0aW9uX25l dyh3ZWJWaWV3KTsKKworICAgIGlmICh3ZWJraXRfcHJpbnRfb3BlcmF0aW9uX3J1bl9kaWFsb2co cHJpbnRPcGVyYXRpb24sIEdUS19XSU5ET1cod2luZG93KSkgIT0gV0VCS0lUX1BSSU5UX09QRVJB VElPTl9SRVNQT05TRV9DQU5DRUwpCisgICAgICAgIGdfc2lnbmFsX2Nvbm5lY3QocHJpbnRPcGVy YXRpb24sICJmYWlsZWQiLCBHX0NBTExCQUNLKHdlYktpdFByaW50T3BlcmF0aW9uRmFpbGVkQ2Fs bGJhY2spLCB3aW5kb3cpOworCisgICAgZ19vYmplY3RfdW5yZWYocHJpbnRPcGVyYXRpb24pOwor ICAgIHJldHVybiBUUlVFOworfQogc3RhdGljIHZvaWQgZWRpdGluZ0NvbW1hbmRDYWxsYmFjayhH dGtXaWRnZXQqd2lkZ2V0LCBCcm93c2VyV2luZG93ICp3aW5kb3cpCiB7CiAgICAgV2ViS2l0V2Vi VmlldyAqd2ViVmlldyA9IGJyb3dzZXJfdGFiX2dldF93ZWJfdmlldyh3aW5kb3ctPmFjdGl2ZVRh Yik7CkBAIC04NjIsNiArODgxLDEwIEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJfd2luZG93X2luaXQo QnJvd3NlcldpbmRvdyAqd2luZG93KQogICAgIGd0a19hY2NlbF9ncm91cF9jb25uZWN0KHdpbmRv dy0+YWNjZWxHcm91cCwgR0RLX0tFWV9XLCBHREtfQ09OVFJPTF9NQVNLLCBHVEtfQUNDRUxfVklT SUJMRSwKICAgICAgICAgZ19jY2xvc3VyZV9uZXdfc3dhcChHX0NBTExCQUNLKGd0a193aWRnZXRf ZGVzdHJveSksIHdpbmRvdywgTlVMTCkpOwogCisgICAgLyogUHJpbnQgKi8KKyAgICBndGtfYWNj ZWxfZ3JvdXBfY29ubmVjdCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19LRVlfUCwgR0RLX0NPTlRS T0xfTUFTSywgR1RLX0FDQ0VMX1ZJU0lCTEUsCisgICAgICAgIGdfY2Nsb3N1cmVfbmV3X3N3YXAo R19DQUxMQkFDSyhwcmludFBhZ2UpLCB3aW5kb3csIE5VTEwpKTsKKwogICAgIGdfc2lnbmFsX2Nv bm5lY3Qod2Via2l0X3dlYl9jb250ZXh0X2dldF9kZWZhdWx0KCksICJkb3dubG9hZC1zdGFydGVk IiwgR19DQUxMQkFDSyhkb3dubG9hZFN0YXJ0ZWQpLCB3aW5kb3cpOwogCiAgICAgR3RrV2lkZ2V0 ICp0b29sYmFyID0gZ3RrX3Rvb2xiYXJfbmV3KCk7Cg== 298004 2017-01-04 04:45:01 -0800 2017-01-04 09:26:08 -0800 Patch bug-165298-20170104134335.patch text/plain 2633 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjEwMjczCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTJiYmZlNDlkOGI2NjhhOTI0NThlMTdlNWEzYTY0MDJl MjAyMGJkMS4uZDE3MzU2MDZhODMzOTZkMzQ1ODZlNThlMTA1NWViNTYxMDFlYmJjOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE3LTAxLTA0ICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAg ICAgICAgW0dUS10gTWluaWJyb3dzZXI6IEFkZCBwcmludGluZyBzdXBwb3J0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUyOTgKKworICAgICAgICBP cGVuIGEgcHJpbnQgZGlhbG9nIHdoZW4gdGhlIEN0cmwgKyBQIHNob3J0Y3V0IGlzIHByZXNzZWQu IElmIHRoZXJlIGlzCisgICAgICAgIGFuIGVycm9yIGR1cmluZyB0aGUgcHJpbnQsIGl0J3MgcHJp bnRlZCBvbiB0aGUgY29uc29sZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAgICAg ICh3ZWJLaXRQcmludE9wZXJhdGlvbkZhaWxlZENhbGxiYWNrKToKKyAgICAgICAgKHByaW50UGFn ZSk6CisgICAgICAgIChicm93c2VyX3dpbmRvd19pbml0KToKKwogMjAxNy0wMS0wNCAgVGltIEhv cnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm92aWRlIGEgc2V0 dGluZyBmb3IgY2xpZW50cyB0byBhbHdheXMgcHJlZmVyIGxvdy1wb3dlciBXZWJHTApkaWZmIC0t Z2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYyBiL1Rvb2xzL01pbmlC cm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmMKaW5kZXggZmU0NDhiMDYyOTBjYjIyYmFkNmQzYWQ0 MDdiOGMyOGQzODA4NWZmNS4uZGU5MjkxMTlkNWU2MTRlYTY3NDhiYmE4Y2UyZmM2ZGY1NGJhYmZj NSAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYworKysg Yi9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5jCkBAIC01MTYsNiArNTE2LDIy IEBAIHN0YXRpYyBnYm9vbGVhbiB0b2dnbGVGdWxsU2NyZWVuKEJyb3dzZXJXaW5kb3cgKndpbmRv dywgZ3BvaW50ZXIgdXNlcl9kYXRhKQogICAgIHJldHVybiBUUlVFOwogfQogCitzdGF0aWMgdm9p ZCB3ZWJLaXRQcmludE9wZXJhdGlvbkZhaWxlZENhbGxiYWNrKFdlYktpdFByaW50T3BlcmF0aW9u ICpwcmludE9wZXJhdGlvbiwgR0Vycm9yICplcnJvcikKK3sKKyAgICBnX3dhcm5pbmcoIlByaW50 IGZhaWxlZCB3aXRoOiAnJXMnIiwgZXJyb3ItPm1lc3NhZ2UpOworfQorCitzdGF0aWMgZ2Jvb2xl YW4gcHJpbnRQYWdlKEJyb3dzZXJXaW5kb3cgKndpbmRvdywgZ3BvaW50ZXIgdXNlcl9kYXRhKQor eworICAgIFdlYktpdFdlYlZpZXcgKndlYlZpZXcgPSBicm93c2VyX3RhYl9nZXRfd2ViX3ZpZXco d2luZG93LT5hY3RpdmVUYWIpOworICAgIFdlYktpdFByaW50T3BlcmF0aW9uICpwcmludE9wZXJh dGlvbiA9IHdlYmtpdF9wcmludF9vcGVyYXRpb25fbmV3KHdlYlZpZXcpOworCisgICAgZ19zaWdu YWxfY29ubmVjdChwcmludE9wZXJhdGlvbiwgImZhaWxlZCIsIEdfQ0FMTEJBQ0sod2ViS2l0UHJp bnRPcGVyYXRpb25GYWlsZWRDYWxsYmFjayksIE5VTEwpOworICAgIHdlYmtpdF9wcmludF9vcGVy YXRpb25fcnVuX2RpYWxvZyhwcmludE9wZXJhdGlvbiwgR1RLX1dJTkRPVyh3aW5kb3cpKTsKKyAg ICBnX29iamVjdF91bnJlZihwcmludE9wZXJhdGlvbik7CisKKyAgICByZXR1cm4gVFJVRTsKK30K IHN0YXRpYyB2b2lkIGVkaXRpbmdDb21tYW5kQ2FsbGJhY2soR3RrV2lkZ2V0KndpZGdldCwgQnJv d3NlcldpbmRvdyAqd2luZG93KQogewogICAgIFdlYktpdFdlYlZpZXcgKndlYlZpZXcgPSBicm93 c2VyX3RhYl9nZXRfd2ViX3ZpZXcod2luZG93LT5hY3RpdmVUYWIpOwpAQCAtODYyLDYgKzg3OCwx MCBAQCBzdGF0aWMgdm9pZCBicm93c2VyX3dpbmRvd19pbml0KEJyb3dzZXJXaW5kb3cgKndpbmRv dykKICAgICBndGtfYWNjZWxfZ3JvdXBfY29ubmVjdCh3aW5kb3ctPmFjY2VsR3JvdXAsIEdES19L RVlfVywgR0RLX0NPTlRST0xfTUFTSywgR1RLX0FDQ0VMX1ZJU0lCTEUsCiAgICAgICAgIGdfY2Ns b3N1cmVfbmV3X3N3YXAoR19DQUxMQkFDSyhndGtfd2lkZ2V0X2Rlc3Ryb3kpLCB3aW5kb3csIE5V TEwpKTsKIAorICAgIC8qIFByaW50ICovCisgICAgZ3RrX2FjY2VsX2dyb3VwX2Nvbm5lY3Qod2lu ZG93LT5hY2NlbEdyb3VwLCBHREtfS0VZX1AsIEdES19DT05UUk9MX01BU0ssIEdUS19BQ0NFTF9W SVNJQkxFLAorICAgICAgICBnX2NjbG9zdXJlX25ld19zd2FwKEdfQ0FMTEJBQ0socHJpbnRQYWdl KSwgd2luZG93LCBOVUxMKSk7CisKICAgICBnX3NpZ25hbF9jb25uZWN0KHdlYmtpdF93ZWJfY29u dGV4dF9nZXRfZGVmYXVsdCgpLCAiZG93bmxvYWQtc3RhcnRlZCIsIEdfQ0FMTEJBQ0soZG93bmxv YWRTdGFydGVkKSwgd2luZG93KTsKIAogICAgIEd0a1dpZGdldCAqdG9vbGJhciA9IGd0a190b29s YmFyX25ldygpOwo=