165292 2016-12-01 17:27:52 -0800 REGRESSION: LayoutTest inspector/debugger/csp-exceptions.html is a flaky failure 2017-01-11 17:25:53 -0800 1 1 1 Unclassified WebKit Web Inspector Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad joepeck commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1255577 0 ryanhaddad 2016-12-01 17:27:52 -0800 LayoutTest inspector/debugger/csp-exceptions.html is a flaky failure https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r209219%20(9698)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fcsp-exceptions.html --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/inspector/debugger/csp-exceptions-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/inspector/debugger/csp-exceptions-actual.txt @@ -12,4 +12,5 @@ -- Running test case: TriggerCSPExceptionOutsideOfScript PASS: CSP Exception caused outside of script evaluation should not pause. +PASS: CSP Exception caused outside of script evaluation should not pause. 1255578 1 webkit-bug-importer 2016-12-01 17:28:09 -0800 <rdar://problem/29471892> 1255579 2 ryanhaddad 2016-12-01 17:29:38 -0800 Seems to be occurring most frequently on mac-wk2 debug. 1258446 3 ryanhaddad 2016-12-09 16:20:45 -0800 Marked test as flaky on mac-wk2 in http://trac.webkit.org/projects/webkit/changeset/209634 1265938 4 joepeck 2017-01-11 16:01:31 -0800 This looks like a test issue that is easily resolved. 1265939 5 298624 joepeck 2017-01-11 16:04:12 -0800 Created attachment 298624 [PATCH] Proposed Fix 1265940 6 joepeck 2017-01-11 16:05:04 -0800 I was easily able to reproduce this by running the test individually. And occasionally (1/100) with --iterations=100. After updating the test I consistently see successes. 1265973 7 298624 ggaren 2017-01-11 17:01:52 -0800 Comment on attachment 298624 [PATCH] Proposed Fix r=me 1265992 8 298624 commit-queue 2017-01-11 17:25:48 -0800 Comment on attachment 298624 [PATCH] Proposed Fix Clearing flags on attachment: 298624 Committed r210611: <http://trac.webkit.org/changeset/210611> 1265993 9 commit-queue 2017-01-11 17:25:53 -0800 All reviewed patches have been landed. Closing bug. 298624 2017-01-11 16:04:12 -0800 2017-01-11 17:25:48 -0800 [PATCH] Proposed Fix csp-1.patch text/plain 6834 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4OTY1YmEyLi5kMDJiYjdkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTctMDEt MTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdS RVNTSU9OOiBMYXlvdXRUZXN0IGluc3BlY3Rvci9kZWJ1Z2dlci9jc3AtZXhjZXB0aW9ucy5odG1s IGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY1MjkyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTQ3MTg5Mj4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rv ci9kZWJ1Z2dlci9jc3AtZXhjZXB0aW9ucy1leHBlY3RlZC50eHQ6CisgICAgICAgICogaW5zcGVj dG9yL2RlYnVnZ2VyL2NzcC1leGNlcHRpb25zLmh0bWw6CisgICAgICAgICogaW5zcGVjdG9yL2Rl YnVnZ2VyL3Jlc291cmNlcy9jc3AtZXhjZXB0aW9uLWlmcmFtZS5odG1sOgorICAgICAgICBJbXBy b3ZlIHRoZSB0ZXN0IHRvIGhhbmRsZSBhbGwgY29uc29sZSBtZXNzYWdlcyBtb3JlIGNhcmVmdWxs eSwKKyAgICAgICAgaW5jbHVkaW5nIG91dHB1dGluZyB0aGUgY29uc29sZSBtZXNzYWdlcyB0byB0 ZXN0IHRoZW0gYXMgd2VsbC4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVj dGF0aW9uczoKKyAgICAgICAgVW5za2lwIHRoZSB0ZXN0LCBpdCBzaG91bGQgbm8gbG9uZ2VyIGJl IGZsYWtleS4KKwogMjAxNy0wMS0xMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEluc3BlY3RpbmcgYSBNYWluIFJlc291cmNl IHRoYXQgaXMgSlMvSlNPTiBkb2VzIG5vdCBmb3JtYXQgLyBzeW50YXggaGlnaGxpZ2h0IGl0IHBy b3Blcmx5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvY3NwLWV4 Y2VwdGlvbnMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2Nz cC1leGNlcHRpb25zLWV4cGVjdGVkLnR4dAppbmRleCA4MDA4ZjU0Li4zMzA0MzU2IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvY3NwLWV4Y2VwdGlvbnMtZXhwZWN0 ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9jc3AtZXhjZXB0aW9u cy1leHBlY3RlZC50eHQKQEAgLTksNyArOSwxMCBAQCBUZXN0IGZvciB0aGUgQ1NQIGV4Y2VwdGlv biBoYW5kbGluZyB3aGVuIHBhdXNlIG9uIGFsbCBleGNlcHRpb25zIGlzIGVuYWJsZWQuCiBQQVNT OiBDU1AgRXhjZXB0aW9uIGNhdXNlZCBieSBzY3JpcHQgZXZhbHVhdGlvbiBzaG91bGQgcGF1c2Uu CiBVbmNhdWdodCBleGNlcHRpb24gaW4gdGVzdCBwYWdlOiBFdmFsRXJyb3I6IFJlZnVzZWQgdG8g ZXZhbHVhdGUgYSBzdHJpbmcgYXMgSmF2YVNjcmlwdCBiZWNhdXNlICd1bnNhZmUtZXZhbCcgaXMg bm90IGFuIGFsbG93ZWQgc291cmNlIG9mIHNjcmlwdCBpbiB0aGUgZm9sbG93aW5nIENvbnRlbnQg U2VjdXJpdHkgUG9saWN5IGRpcmVjdGl2ZTogInNjcmlwdC1zcmMgJ3NlbGYnICd1bnNhZmUtaW5s aW5lJyIuCiAgW2NzcC1leGNlcHRpb25zLmh0bWw6MTFdCitQQVNTOiBDU1AgRXhjZXB0aW9uIENv bnNvbGUgTWVzc2FnZTogRXZhbEVycm9yOiBSZWZ1c2VkIHRvIGV2YWx1YXRlIGEgc3RyaW5nIGFz IEphdmFTY3JpcHQgYmVjYXVzZSAndW5zYWZlLWV2YWwnIGlzIG5vdCBhbiBhbGxvd2VkIHNvdXJj ZSBvZiBzY3JpcHQgaW4gdGhlIGZvbGxvd2luZyBDb250ZW50IFNlY3VyaXR5IFBvbGljeSBkaXJl Y3RpdmU6ICJzY3JpcHQtc3JjICdzZWxmJyAndW5zYWZlLWlubGluZSciLgorCiAKIC0tIFJ1bm5p bmcgdGVzdCBjYXNlOiBUcmlnZ2VyQ1NQRXhjZXB0aW9uT3V0c2lkZU9mU2NyaXB0CiBQQVNTOiBD U1AgRXhjZXB0aW9uIGNhdXNlZCBvdXRzaWRlIG9mIHNjcmlwdCBldmFsdWF0aW9uIHNob3VsZCBu b3QgcGF1c2UuCitQQVNTOiBDU1AgRXhjZXB0aW9uIENvbnNvbGUgTWVzc2FnZTogUmVmdXNlZCB0 byBleGVjdXRlIGEgc2NyaXB0IGJlY2F1c2UgaXRzIGhhc2gsIGl0cyBub25jZSwgb3IgJ3Vuc2Fm ZS1pbmxpbmUnIGRvZXMgbm90IGFwcGVhciBpbiB0aGUgc2NyaXB0LXNyYyBkaXJlY3RpdmUgb2Yg dGhlIENvbnRlbnQgU2VjdXJpdHkgUG9saWN5LgogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9p bnNwZWN0b3IvZGVidWdnZXIvY3NwLWV4Y2VwdGlvbnMuaHRtbCBiL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9kZWJ1Z2dlci9jc3AtZXhjZXB0aW9ucy5odG1sCmluZGV4IDhjZDU5OTYuLjJlNzU0MzIg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9jc3AtZXhjZXB0aW9u cy5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9jc3AtZXhjZXB0aW9u cy5odG1sCkBAIC04LDcgKzgsNyBAQCBUZXN0UGFnZS5hbGxvd1VuY2F1Z2h0RXhjZXB0aW9ucyA9 IHRydWU7CiBUZXN0UGFnZS5uZWVkVG9TYW5pdGl6ZVVuY2F1Z2h0RXhjZXB0aW9uVVJMcyA9IHRy dWU7CiAKIGZ1bmN0aW9uIHRyaWdnZXJDU1BFeGNlcHRpb25JbnNpZGVTY3JpcHQoKSB7Ci0gICAg ZXZhbCgiY29uc29sZS5sb2coJ0NTUCBzaG91bGQgcHJldmVudCB0aGlzJykiKTsKKyAgICBldmFs KCJjb25zb2xlLmxvZygnSW5zaWRlIFNjcmlwdCAtIENTUCBzaG91bGQgcHJldmVudCB0aGlzJyki KTsKIH0KIAogZnVuY3Rpb24gdHJpZ2dlckNTUEV4Y2VwdGlvbk91dHNpZGVTY3JpcHQoKSB7CkBA IC0yOCw3ICsyOCwxMyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgICAgIEluc3BlY3RvclRl c3QuZXZhbHVhdGVJblBhZ2UoInNldFRpbWVvdXQodHJpZ2dlckNTUEV4Y2VwdGlvbkluc2lkZVNj cmlwdCkiKTsKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIuc2luZ2xl RmlyZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5FdmVudC5QYXVz ZWQsIChldmVudCkgPT4gewogICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QucGFzcygiQ1NQ IEV4Y2VwdGlvbiBjYXVzZWQgYnkgc2NyaXB0IGV2YWx1YXRpb24gc2hvdWxkIHBhdXNlLiIpOwot ICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIucmVzdW1lKCkudGhl bihyZXNvbHZlLCByZWplY3QpOworICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5kZWJ1Z2dl ck1hbmFnZXIucmVzdW1lKCk7CisgICAgICAgICAgICB9KTsKKworICAgICAgICAgICAgV2ViSW5z cGVjdG9yLmxvZ01hbmFnZXIuc2luZ2xlRmlyZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkxv Z01hbmFnZXIuRXZlbnQuTWVzc2FnZUFkZGVkLCAoZXZlbnQpID0+IHsKKyAgICAgICAgICAgICAg ICBJbnNwZWN0b3JUZXN0LmFzc2VydChldmVudC5kYXRhLm1lc3NhZ2UubGV2ZWwgPT09IFdlYklu c3BlY3Rvci5Db25zb2xlTWVzc2FnZS5NZXNzYWdlTGV2ZWwuRXJyb3IpOworICAgICAgICAgICAg ICAgIEluc3BlY3RvclRlc3QucGFzcygiQ1NQIEV4Y2VwdGlvbiBDb25zb2xlIE1lc3NhZ2U6ICIg KyBldmVudC5kYXRhLm1lc3NhZ2UubWVzc2FnZVRleHQpOworICAgICAgICAgICAgICAgIHJlc29s dmUoKTsKICAgICAgICAgICAgIH0pOwogICAgICAgICB9CiAgICAgfSk7CkBAIC0zOCwyMCArNDQs MjUgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgIGRlc2NyaXB0aW9uOiAiVHJpZ2dlciBhIENT UCBFeGNlcHRpb24gb3V0c2lkZSBvZiBzY3JpcHQgc2hvdWxkIG5vdCBwYXVzZSBvciBjcmFzaC4i LAogICAgICAgICB0ZXN0KHJlc29sdmUsIHJlamVjdCkgewogICAgICAgICAgICAgSW5zcGVjdG9y VGVzdC5ldmFsdWF0ZUluUGFnZSgic2V0VGltZW91dCh0cmlnZ2VyQ1NQRXhjZXB0aW9uT3V0c2lk ZVNjcmlwdCkiKTsKKyAgICAgICAgICAgIGxldCBkaWRQYXVzZSA9IGZhbHNlOwogICAgICAgICAg ICAgbGV0IHRlbXBQYXVzZUZhaWxMaXN0ZW5lciA9IFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFn ZXIuc2luZ2xlRmlyZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5F dmVudC5QYXVzZWQsIChldmVudCkgPT4geworICAgICAgICAgICAgICAgIGRpZFBhdXNlID0gdHJ1 ZTsKICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmZhaWwoIkNTUCBFeGNlcHRpb24gY2F1 c2VkIG91dHNpZGUgb2Ygc2NyaXB0IGV2YWx1YXRpb24gc2hvdWxkIG5vdCBwYXVzZSwgYnV0IGRp ZC4iKTsKICAgICAgICAgICAgICAgICBXZWJJbnNwZWN0b3IuZGVidWdnZXJNYW5hZ2VyLnJlc3Vt ZSgpOwogICAgICAgICAgICAgICAgIHJlamVjdCgpOwogICAgICAgICAgICAgfSk7Ci0gICAgICAg ICAgICBXZWJJbnNwZWN0b3IubG9nTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rv ci5Mb2dNYW5hZ2VyLkV2ZW50Lk1lc3NhZ2VBZGRlZCwgKGV2ZW50KSA9PiB7CisgICAgICAgICAg ICBXZWJJbnNwZWN0b3IubG9nTWFuYWdlci5zaW5nbGVGaXJlRXZlbnRMaXN0ZW5lcihXZWJJbnNw ZWN0b3IuTG9nTWFuYWdlci5FdmVudC5NZXNzYWdlQWRkZWQsIChldmVudCkgPT4gewogICAgICAg ICAgICAgICAgIFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIucmVtb3ZlRXZlbnRMaXN0ZW5l cihXZWJJbnNwZWN0b3IuRGVidWdnZXJNYW5hZ2VyLkV2ZW50LlBhdXNlZCwgdGVtcFBhdXNlRmFp bExpc3RlbmVyLCBudWxsKTsKLSAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LnBhc3MoIkNT UCBFeGNlcHRpb24gY2F1c2VkIG91dHNpZGUgb2Ygc2NyaXB0IGV2YWx1YXRpb24gc2hvdWxkIG5v dCBwYXVzZS4iKTsKKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmFzc2VydChldmVudC5k YXRhLm1lc3NhZ2UubGV2ZWwgPT09IFdlYkluc3BlY3Rvci5Db25zb2xlTWVzc2FnZS5NZXNzYWdl TGV2ZWwuRXJyb3IpOworICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0RmFsc2Uo ZGlkUGF1c2UsICJDU1AgRXhjZXB0aW9uIGNhdXNlZCBvdXRzaWRlIG9mIHNjcmlwdCBldmFsdWF0 aW9uIHNob3VsZCBub3QgcGF1c2UuIik7CisgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5w YXNzKCJDU1AgRXhjZXB0aW9uIENvbnNvbGUgTWVzc2FnZTogIiArIGV2ZW50LmRhdGEubWVzc2Fn ZS5tZXNzYWdlVGV4dCk7CiAgICAgICAgICAgICAgICAgcmVzb2x2ZSgpOwogICAgICAgICAgICAg fSk7CiAgICAgICAgIH0KICAgICB9KTsKIAogICAgIERlYnVnZ2VyQWdlbnQuc2V0UGF1c2VPbkV4 Y2VwdGlvbnMoImFsbCIpOworCiAgICAgc3VpdGUucnVuVGVzdENhc2VzQW5kRmluaXNoKCk7CiB9 CiA8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9y ZXNvdXJjZXMvY3NwLWV4Y2VwdGlvbi1pZnJhbWUuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rv ci9kZWJ1Z2dlci9yZXNvdXJjZXMvY3NwLWV4Y2VwdGlvbi1pZnJhbWUuaHRtbAppbmRleCBmNmZh NjNiLi5hMTYzNjc3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIv cmVzb3VyY2VzL2NzcC1leGNlcHRpb24taWZyYW1lLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2RlYnVnZ2VyL3Jlc291cmNlcy9jc3AtZXhjZXB0aW9uLWlmcmFtZS5odG1sCkBAIC00 LDYgKzQsNiBAQAogPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1TZWN1cml0eS1Qb2xpY3kiIGNv bnRlbnQ9InNjcmlwdC1zcmMgJ25vbmUnIj4KIDwvaGVhZD4KIDxib2R5PgotPHNjcmlwdD5jb25z b2xlLmxvZygiQ1NQIHNob3VsZCBwcmV2ZW50IHRoaXMiKTs8L3NjcmlwdD4KKzxzY3JpcHQ+Y29u c29sZS5sb2coIkluc2lkZSBGcmFtZSAtIENTUCBzaG91bGQgcHJldmVudCB0aGlzIik7PC9zY3Jp cHQ+CiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rl c3RFeHBlY3RhdGlvbnMKaW5kZXggMmRhOWRiMS4uYTBiYTk3OCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNTQ1LDcgKzU0NSw2IEBAIHdl YmtpdC5vcmcvYi8xNjM5MzIgaW5zcGVjdG9yL2Nzcy9wc2V1ZG8tZWxlbWVudC1tYXRjaGVzLmh0 bWwgWyBQYXNzIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMTYzNjA0IGluc3BlY3Rvci9kZWJ1 Z2dlci9icmVha3BvaW50LWFjdGlvbi1ldmFsLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogd2Via2l0 Lm9yZy9iLzE2MTc3NCBpbnNwZWN0b3IvZGVidWdnZXIvYnJlYWtwb2ludC1jb2x1bW5zLmh0bWwg WyBQYXNzIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzE2NTI5MiBpbnNwZWN0b3IvZGVidWdnZXIv Y3NwLWV4Y2VwdGlvbnMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTU5NDQ3 IFsgRGVidWcgXSBpbnNwZWN0b3IvZGVidWdnZXIvdGFpbC1kZWxldGVkLWZyYW1lcy1mcm9tLXZt LWVudHJ5Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzE2NTU4MiBpbnNwZWN0 b3Ivd29ya2VyL2RlYnVnZ2VyLXNjcmlwdHMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAK