165277 2016-12-01 14:17:52 -0800 Web Inspector: Assertion Failures breakpoint should respect global Breakpoints enabled setting 2016-12-04 12:23:27 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1255472 0 mattbaker 2016-12-01 14:17:52 -0800 Summary: Assertion Failures breakpoint should respect global Breakpoints enabled setting. The other "special" breakpoints do, and the "Assertion Failures" breakpoint turns gray when breakpoints are disabled. Steps to Reproduce: 1. Inspect <script>console.assert(false)</script> 2. Debugger tab > Enable 'Assertion Failures' breakpoint 3. Disable all breakpoints (⌘Y) 4. Reload page Expected: => Nothing happens Actual: => Debugger pauses on assertion failure 1255473 1 webkit-bug-importer 2016-12-01 14:18:05 -0800 <rdar://problem/29467098> 1255484 2 mattbaker 2016-12-01 14:32:24 -0800 Easy fix, going to add a couple tests though: inspector/debugger/break-on-assertion-failure.html inspector/debugger/breakpoints-enabled.html 1255502 3 joepeck 2016-12-01 14:58:25 -0800 Doh, my bad. Great find! 1255600 4 mattbaker 2016-12-01 18:35:52 -0800 (In reply to comment #2) > Easy fix, going to add a couple tests though: > > inspector/debugger/break-on-assertion-failure.html Looks like inspector/debugger/pause-on-assert.html covers the basics. 1255974 5 296024 mattbaker 2016-12-02 16:59:36 -0800 Created attachment 296024 Patch 1256097 6 296024 mark.lam 2016-12-03 13:18:38 -0800 Comment on attachment 296024 Patch r=me 1256191 7 296024 commit-queue 2016-12-04 12:23:23 -0800 Comment on attachment 296024 Patch Clearing flags on attachment: 296024 Committed r209311: <http://trac.webkit.org/changeset/209311> 1256192 8 commit-queue 2016-12-04 12:23:27 -0800 All reviewed patches have been landed. Closing bug. 296024 2016-12-02 16:59:36 -0800 2016-12-04 12:23:23 -0800 Patch bug-165277-20161202165905.patch text/plain 5859 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5Mjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj MmU3MGI1MmIzMWE4NjE3OGY3ZmE0OTQwMjNkMDk3OGNhMDYzMTMyLi43MzJmNzUyMGQ0NGUwNjky N2NiOWM4MTZjZWE1ZmVmMDkwMGY5NDIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0xMi0wMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQXNzZXJ0aW9uIEZhaWx1cmVzIGJyZWFrcG9pbnQg c2hvdWxkIHJlc3BlY3QgZ2xvYmFsIEJyZWFrcG9pbnRzIGVuYWJsZWQgc2V0dGluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1Mjc3CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8yOTQ2NzA5OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yRGVidWdnZXJB Z2VudC5jcHA6CisgICAgICAgIChJbnNwZWN0b3I6Okluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6Omhh bmRsZUNvbnNvbGVBc3NlcnQpOgorICAgICAgICBDaGVjayB0aGF0IGJyZWFrcG9pbnRzIGFyZSBh Y3RpdmUgYmVmb3JlIHBhdXNpbmcuCisKIDIwMTYtMTItMDIgIEpGIEJhc3RpZW4gIDxqZmJhc3Rp ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkFzc2VtYmx5OiBtYXJrIFdhc21PcHMuaCBhcyBw cml2YXRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL2FnZW50 cy9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNw ZWN0b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwCmluZGV4IDA0MGZlNWY1M2Fi MGZjYjYyMDA3ZTYxZjg4ZGIxYTAzOGVlN2M1YmIuLmI0Mjk1ZTM4Y2VlMWQ3OTYzMDc4MGM4OGY5 Njk0ZDE3YmY2YmQ2ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0 b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckRlYnVnZ2VyQWdlbnQuY3BwCkBAIC0y NDgsNiArMjQ4LDkgQEAgUmVmUHRyPEluc3BlY3Rvcjo6UHJvdG9jb2w6OkNvbnNvbGU6OlN0YWNr VHJhY2U+IEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmJ1aWxkQXMKIAogdm9pZCBJbnNwZWN0b3JE ZWJ1Z2dlckFnZW50OjpoYW5kbGVDb25zb2xlQXNzZXJ0KGNvbnN0IFN0cmluZyYgbWVzc2FnZSkK IHsKKyAgICBpZiAoIW1fc2NyaXB0RGVidWdTZXJ2ZXIuYnJlYWtwb2ludHNBY3RpdmUoKSkKKyAg ICAgICAgcmV0dXJuOworCiAgICAgaWYgKG1fcGF1c2VPbkFzc2VydGlvbkZhaWx1cmVzKQogICAg ICAgICBicmVha1Byb2dyYW0oRGVidWdnZXJGcm9udGVuZERpc3BhdGNoZXI6OlJlYXNvbjo6QXNz ZXJ0LCBidWlsZEFzc2VydFBhdXNlUmVhc29uKG1lc3NhZ2UpKTsKIH0KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjZmU3MDdj NWVkYWI2OTM2MWZiNDhiYTA3ZDBmZTM2NDQ4ZDNkODZlLi5iZWY0OWMyMzZjYzY2MDg2ZjM0ZmY5 ZTQxMDRjZGMyZjUwZDA2MmU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMTItMDIgIE1h dHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6 IEFzc2VydGlvbiBGYWlsdXJlcyBicmVha3BvaW50IHNob3VsZCByZXNwZWN0IGdsb2JhbCBCcmVh a3BvaW50cyBlbmFibGVkIHNldHRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2NTI3NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjk0NjcwOTg+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmV3IHRl c3QgZm9yIERlYnVnZ2VyTWFuYWdlci5wcm90b3R5cGUuYnJlYWtQb2ludHNFbmFibGVkLgorCisg ICAgICAgICogaW5zcGVjdG9yL2RlYnVnZ2VyL2JyZWFrcG9pbnRzLWRpc2FibGVkLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogaW5zcGVjdG9yL2RlYnVnZ2VyL2JyZWFrcG9pbnRzLWRp c2FibGVkLmh0bWw6IEFkZGVkLgorCiAyMDE2LTEyLTAyICBEYXZlIEh5YXR0ICA8aHlhdHRAYXBw bGUuY29tPgogCiAgICAgICAgIFtDU1MgUGFyc2VyXSBGaXggZXJyb3JzIGluIG51bWVyb3VzIGxh eW91dCB0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL2Jy ZWFrcG9pbnRzLWRpc2FibGVkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9k ZWJ1Z2dlci9icmVha3BvaW50cy1kaXNhYmxlZC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMDQ2 ODI3MDMxNzEzYmYyODMwODZmMTM4ZWQwMGYyNzNhZTYzMWFkNQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9icmVha3BvaW50cy1kaXNhYmxlZC1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSwxOCBAQAorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDc6IHRocm93 aW5nIFRlc3RFcnJvcgorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDEyOiB0ZXN0Q2F0Y2gKK0NPTlNP TEUgTUVTU0FHRTogbGluZSA3OiB0aHJvd2luZyBUZXN0RXJyb3IKK0NPTlNPTEUgTUVTU0FHRTog bGluZSAxNjogY2F0Y2ggVGVzdEVycm9yCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTg6IERPTkUK K0NoZWNrIHRoYXQgc3BlY2lhbCBicmVha3BvaW50cyBhcmVuJ3QgaGl0IHdoZW4gYnJlYWtwb2lu dHMgYXJlIGRpc2FibGVkLgorCisKKz09IFJ1bm5pbmcgdGVzdCBzdWl0ZTogQnJlYWtwb2ludHNE aXNhYmxlZAorLS0gUnVubmluZyB0ZXN0IGNhc2U6IEFzc2VydGlvbnNCcmVha3BvaW50CitQQVNT OiBTaG91bGQgbm90IHBhdXNlLgorCistLSBSdW5uaW5nIHRlc3QgY2FzZTogQWxsVW5jYXVnaHRF eGNlcHRpb25zQnJlYWtwb2ludAorUEFTUzogU2hvdWxkIG5vdCBwYXVzZS4KKworLS0gUnVubmlu ZyB0ZXN0IGNhc2U6IEFsbEV4Y2VwdGlvbnNCcmVha3BvaW50CitQQVNTOiBTaG91bGQgbm90IHBh dXNlLgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvYnJlYWtw b2ludHMtZGlzYWJsZWQuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9icmVh a3BvaW50cy1kaXNhYmxlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjkwODljZjNmYWFkZTk2N2VlN2QwODM4 ZjdkMmNmNDQzMzI5YjhjNGEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0 b3IvZGVidWdnZXIvYnJlYWtwb2ludHMtZGlzYWJsZWQuaHRtbApAQCAtMCwwICsxLDUxIEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vaHR0cC90 ZXN0cy9pbnNwZWN0b3IvcmVzb3VyY2VzL2luc3BlY3Rvci10ZXN0LmpzIj48L3NjcmlwdD4KKzxz Y3JpcHQgc3JjPSJyZXNvdXJjZXMvYXNzZXJ0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJy ZXNvdXJjZXMvYnJlYWstb24tZXhjZXB0aW9uLXRlc3RzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+ CitUZXN0UGFnZS5hbGxvd1VuY2F1Z2h0RXhjZXB0aW9ucyA9IHRydWU7CisKK2Z1bmN0aW9uIHRl c3QoKQoreworICAgIGxldCBzdWl0ZSA9IEluc3BlY3RvclRlc3QuY3JlYXRlQXN5bmNTdWl0ZSgi QnJlYWtwb2ludHNEaXNhYmxlZCIpOworCisgICAgZnVuY3Rpb24gYWRkVGVzdENhc2UobmFtZSwg ZGVzY3JpcHRpb24sIGV4cHJlc3Npb24sIGJyZWFrcG9pbnQpIHsKKyAgICAgICAgc3VpdGUuYWRk VGVzdENhc2UoeworICAgICAgICAgICAgbmFtZSwKKyAgICAgICAgICAgIGRlc2NyaXB0aW9uLAor ICAgICAgICAgICAgdGVzdChyZXNvbHZlLCByZWplY3QpIHsKKyAgICAgICAgICAgICAgICBsZXQg ZGlkUGF1c2UgPSBmYWxzZTsKKyAgICAgICAgICAgICAgICBsZXQgbGlzdGVuZXIgPSBXZWJJbnNw ZWN0b3IuZGVidWdnZXJNYW5hZ2VyLnNpbmdsZUZpcmVFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rv ci5EZWJ1Z2dlck1hbmFnZXIuRXZlbnQuUGF1c2VkLCAoZXZlbnQpID0+IHsKKyAgICAgICAgICAg ICAgICAgICAgZGlkUGF1c2UgPSB0cnVlOworICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JU ZXN0LmZhaWwoIlNob3VsZCBub3QgaGF2ZSBwYXVzZWQuIik7CisgICAgICAgICAgICAgICAgICAg IFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIucmVzdW1lKCk7CisgICAgICAgICAgICAgICAg ICAgIHJlamVjdCgpOworICAgICAgICAgICAgICAgIH0pOworCisgICAgICAgICAgICAgICAgYnJl YWtwb2ludC5kaXNhYmxlZCA9IGZhbHNlOworICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5k ZWJ1Z2dlck1hbmFnZXIuYnJlYWtwb2ludHNFbmFibGVkID0gZmFsc2U7CisKKyAgICAgICAgICAg ICAgICBJbnNwZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKGV4cHJlc3Npb24sICgpID0+IHsKKyAg ICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RGYWxzZShkaWRQYXVzZSwgIlNo b3VsZCBub3QgcGF1c2UuIikKKyAgICAgICAgICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmRlYnVn Z2VyTWFuYWdlci5yZW1vdmVFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5EZWJ1Z2dlck1hbmFn ZXIuRXZlbnQuUGF1c2VkLCBsaXN0ZW5lcik7CisgICAgICAgICAgICAgICAgICAgIFdlYkluc3Bl Y3Rvci5kZWJ1Z2dlck1hbmFnZXIucmVzdW1lKCk7CisgICAgICAgICAgICAgICAgICAgIHJlc29s dmUoKTsKKyAgICAgICAgICAgICAgICB9KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSk7Cisg ICAgfQorCisgICAgYWRkVGVzdENhc2UoIkFzc2VydGlvbnNCcmVha3BvaW50IiwgIlNob3VsZCBu b3QgcGF1c2Ugb24gYXNzZXJ0aW9uIGZhaWx1cmUuIiwgImFzc2VydEZhbHNlKCkiLCBXZWJJbnNw ZWN0b3IuZGVidWdnZXJNYW5hZ2VyLmFzc2VydGlvbnNCcmVha3BvaW50KTsKKyAgICBhZGRUZXN0 Q2FzZSgiQWxsVW5jYXVnaHRFeGNlcHRpb25zQnJlYWtwb2ludCIsICJTaG91bGQgbm90IHBhdXNl IG9uIHVuY2F1Z2h0IGV4Y2VwdGlvbi4iLCAiZG9UaHJvdygpIiwgV2ViSW5zcGVjdG9yLmRlYnVn Z2VyTWFuYWdlci5hbGxVbmNhdWdodEV4Y2VwdGlvbnNCcmVha3BvaW50KTsKKyAgICBhZGRUZXN0 Q2FzZSgiQWxsRXhjZXB0aW9uc0JyZWFrcG9pbnQiLCAiU2hvdWxkIG5vdCBwYXVzZSBvbiBjYXVn aHQgZXhjZXB0aW9uLiIsICJ0ZXN0Q2F0Y2goKSIsIFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFn ZXIuYWxsRXhjZXB0aW9uc0JyZWFrcG9pbnQpOworCisgICAgc3VpdGUucnVuVGVzdENhc2VzQW5k RmluaXNoKCk7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgp Ij4KKzxwPkNoZWNrIHRoYXQgc3BlY2lhbCBicmVha3BvaW50cyBhcmVuJ3QgaGl0IHdoZW4gYnJl YWtwb2ludHMgYXJlIGRpc2FibGVkLjwvcD4KKzwvYm9keT4KKzwvaHRtbD4K