165253 2016-12-01 07:21:15 -0800 [GTK] Use an OpenGL < 3.0 compliant way to request the OpenGL version 2016-12-02 08:12:28 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=165283 P2 Normal --- 1 magomez magomez bugs-noreply commit-queue mcatanzaro oldest_to_newest 1255243 0 magomez 2016-12-01 07:21:15 -0800 We are currently using glGetIntegerv() with GL_MAJOR_VERSION and GL_MINOR_VERSION to get the opengl version, but this is not compatible with OpenGL < 3.0. We need to use glGetString(GL_VERSION) instead, which is compatible with all versions (so far). 1255245 1 295849 magomez 2016-12-01 07:32:03 -0800 Created attachment 295849 Patch 1255260 2 295849 mcatanzaro 2016-12-01 08:37:33 -0800 Comment on attachment 295849 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295849&action=review > Source/WebCore/platform/graphics/GLContext.cpp:168 > + // The version number always has the form "mayor.minor.release". mayor -> major. Nit, since I'm leaving other comments on this comment: vendor-specific with a hyphen. Nit: If you want to leave a line break in the middle of the comment then you should leave an extra blank line as well. I'd prefer to write this comment on just two lines. Looks like it fits: // Version string always begins with the version number, then a space and the vendor- // specific info. The version number always has the form "major.minor.release". Alternatively (less-preferred): // Version string always begins with the version number, then a space and the vendor- // specific info. // // The version number always has the form "major.minor.release". > Source/WebCore/platform/graphics/GLContext.cpp:174 > + versionStringComponents.at(0).split('.', versionDigits); > + m_version = versionDigits.at(0).toUInt() * 100 + versionDigits.at(1).toUInt() * 10; Looks like it's going to crash if the version does not have a . character. I guess it will always exist, but is it guaranteed, or should we be robust to that? 1255628 3 295849 cgarcia 2016-12-01 23:50:01 -0800 Comment on attachment 295849 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295849&action=review > Source/WebCore/platform/graphics/GLContext.cpp:167 > + // Version string always begins with the version number, then a space and then vendor > + // specific info. I think this is not always true, in case of OpenGL ES, the version string starts with "OpenGL ES", see https://www.khronos.org/opengles/sdk/1.1/docs/man/glGetString.xml. >> Source/WebCore/platform/graphics/GLContext.cpp:168 >> + // The version number always has the form "mayor.minor.release". > > mayor -> major. > > Nit, since I'm leaving other comments on this comment: vendor-specific with a hyphen. > > Nit: If you want to leave a line break in the middle of the comment then you should leave an extra blank line as well. I'd prefer to write this comment on just two lines. Looks like it fits: > > // Version string always begins with the version number, then a space and the vendor- > // specific info. The version number always has the form "major.minor.release". > > Alternatively (less-preferred): > > // Version string always begins with the version number, then a space and the vendor- > // specific info. > // > // The version number always has the form "major.minor.release". And this is not true either, it could be major.minor.release or just major.minor see https://www.opengl.org/wiki/GLAPI/glGetString 1255641 4 295934 magomez 2016-12-02 02:08:39 -0800 Created attachment 295934 Patch 1255649 5 295937 magomez 2016-12-02 03:06:01 -0800 Created attachment 295937 Patch 1255662 6 295937 commit-queue 2016-12-02 05:23:13 -0800 Comment on attachment 295937 Patch Clearing flags on attachment: 295937 Committed r209234: <http://trac.webkit.org/changeset/209234> 1255663 7 commit-queue 2016-12-02 05:23:16 -0800 All reviewed patches have been landed. Closing bug. 1255674 8 mcatanzaro 2016-12-02 08:12:28 -0800 Is there seriously no forwards-compatible way to check OpenGL version? What we committed looks pretty fragile. 295849 2016-12-01 07:32:03 -0800 2016-12-02 02:08:33 -0800 Patch bug-165253-20161201163134.patch text/plain 2187 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDUwMmMxMGM0MjZjYTBk MmExMGU3NjE2ODgwNGNmZDA2MDg4NzE0Mi4uYTY4NTg3ZThkYmRjMWNkM2M1ODc1ZTJkMmNlNDk1 YjVmZmMxNmE2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTEyLTAxICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVXNlIGFuIE9w ZW5HTCA8IDMuMCBjb21wbGlhbnQgd2F5IHRvIHJlcXVlc3QgdGhlIE9wZW5HTCB2ZXJzaW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUyNTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgZ2xHZXRT dHJpbmcoR0xfVkVSU0lPTikgdG8gZ2V0IHRoZSBPcGVuR0wgdmVyc2lvbiwgYXMgZ2xHZXRJbnRl Z2VydiB3aXRoIEdMX01BSk9SX1ZFUlNJT04KKyAgICAgICAgYW5kIEdMX01JTk9SX1ZFUlNJT04g aXMgb25seSBzdXBwb3J0ZWQgZnJvbSAzLjAgb24uCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlz dGVudCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dMQ29udGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHTENvbnRleHQ6OnZlcnNpb24pOgorCiAyMDE2LTExLTMwICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMjA5MTY4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR0xDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0dMQ29udGV4dC5jcHAKaW5kZXggNTI1OTViOWJjOTA3MzkyNTQwNzVkMDBiNDU0NDMyMGUzNjIy ZjM1OC4uN2FmNTJkMzdiYjA1NmJiZmI4ZGYyNTMyN2RiMDg4NzNiYTA5ZGRlMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR0xDb250ZXh0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HTENvbnRleHQuY3BwCkBAIC0xNjMsMTEg KzE2MywxNSBAQCBib29sIEdMQ29udGV4dDo6aXNFeHRlbnNpb25TdXBwb3J0ZWQoY29uc3QgY2hh ciogZXh0ZW5zaW9uTGlzdCwgY29uc3QgY2hhciogZXh0ZQogdW5zaWduZWQgR0xDb250ZXh0Ojp2 ZXJzaW9uKCkKIHsKICAgICBpZiAoIW1fdmVyc2lvbikgewotICAgICAgICBHQzNEaW50IG1ham9y ID0gMDsKLSAgICAgICAgR0MzRGludCBtaW5vciA9IDA7Ci0gICAgICAgIDo6Z2xHZXRJbnRlZ2Vy dihHTF9NQUpPUl9WRVJTSU9OLCAmbWFqb3IpOwotICAgICAgICA6OmdsR2V0SW50ZWdlcnYoR0xf TUlOT1JfVkVSU0lPTiwgJm1pbm9yKTsKLSAgICAgICAgbV92ZXJzaW9uID0gbWFqb3IgKiAxMDAg KyBtaW5vciAqIDEwOworICAgICAgICAvLyBWZXJzaW9uIHN0cmluZyBhbHdheXMgYmVnaW5zIHdp dGggdGhlIHZlcnNpb24gbnVtYmVyLCB0aGVuIGEgc3BhY2UgYW5kIHRoZW4gdmVuZG9yCisgICAg ICAgIC8vIHNwZWNpZmljIGluZm8uCisgICAgICAgIC8vIFRoZSB2ZXJzaW9uIG51bWJlciBhbHdh eXMgaGFzIHRoZSBmb3JtICJtYXlvci5taW5vci5yZWxlYXNlIi4KKyAgICAgICAgU3RyaW5nIHZl cnNpb25TdHJpbmcgPSBTdHJpbmcocmVpbnRlcnByZXRfY2FzdDxjb25zdCBjaGFyKj4oOjpnbEdl dFN0cmluZyhHTF9WRVJTSU9OKSkpOworICAgICAgICBWZWN0b3I8U3RyaW5nPiB2ZXJzaW9uU3Ry aW5nQ29tcG9uZW50czsKKyAgICAgICAgdmVyc2lvblN0cmluZy5zcGxpdCgnICcsIHZlcnNpb25T dHJpbmdDb21wb25lbnRzKTsKKyAgICAgICAgVmVjdG9yPFN0cmluZz4gdmVyc2lvbkRpZ2l0czsK KyAgICAgICAgdmVyc2lvblN0cmluZ0NvbXBvbmVudHMuYXQoMCkuc3BsaXQoJy4nLCB2ZXJzaW9u RGlnaXRzKTsKKyAgICAgICAgbV92ZXJzaW9uID0gdmVyc2lvbkRpZ2l0cy5hdCgwKS50b1VJbnQo KSAqIDEwMCArIHZlcnNpb25EaWdpdHMuYXQoMSkudG9VSW50KCkgKiAxMDsKICAgICB9CiAgICAg cmV0dXJuIG1fdmVyc2lvbjsKIH0K 295934 2016-12-02 02:08:39 -0800 2016-12-02 03:05:54 -0800 Patch bug-165253-20161202110809.patch text/plain 2783 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDUwMmMxMGM0MjZjYTBk MmExMGU3NjE2ODgwNGNmZDA2MDg4NzE0Mi4uYTY4NTg3ZThkYmRjMWNkM2M1ODc1ZTJkMmNlNDk1 YjVmZmMxNmE2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTEyLTAxICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVXNlIGFuIE9w ZW5HTCA8IDMuMCBjb21wbGlhbnQgd2F5IHRvIHJlcXVlc3QgdGhlIE9wZW5HTCB2ZXJzaW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUyNTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgZ2xHZXRT dHJpbmcoR0xfVkVSU0lPTikgdG8gZ2V0IHRoZSBPcGVuR0wgdmVyc2lvbiwgYXMgZ2xHZXRJbnRl Z2VydiB3aXRoIEdMX01BSk9SX1ZFUlNJT04KKyAgICAgICAgYW5kIEdMX01JTk9SX1ZFUlNJT04g aXMgb25seSBzdXBwb3J0ZWQgZnJvbSAzLjAgb24uCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlz dGVudCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dMQ29udGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHTENvbnRleHQ6OnZlcnNpb24pOgorCiAyMDE2LTExLTMwICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMjA5MTY4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR0xDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0dMQ29udGV4dC5jcHAKaW5kZXggNTI1OTViOWJjOTA3MzkyNTQwNzVkMDBiNDU0NDMyMGUzNjIy ZjM1OC4uZTgzMmFjZjZjNzlhYWRhMjk0ZDA4ZjFiN2FlY2NiMzEwMGUyYWNiZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR0xDb250ZXh0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HTENvbnRleHQuY3BwCkBAIC0xNjMsMTEg KzE2MywyNSBAQCBib29sIEdMQ29udGV4dDo6aXNFeHRlbnNpb25TdXBwb3J0ZWQoY29uc3QgY2hh ciogZXh0ZW5zaW9uTGlzdCwgY29uc3QgY2hhciogZXh0ZQogdW5zaWduZWQgR0xDb250ZXh0Ojp2 ZXJzaW9uKCkKIHsKICAgICBpZiAoIW1fdmVyc2lvbikgewotICAgICAgICBHQzNEaW50IG1ham9y ID0gMDsKLSAgICAgICAgR0MzRGludCBtaW5vciA9IDA7Ci0gICAgICAgIDo6Z2xHZXRJbnRlZ2Vy dihHTF9NQUpPUl9WRVJTSU9OLCAmbWFqb3IpOwotICAgICAgICA6OmdsR2V0SW50ZWdlcnYoR0xf TUlOT1JfVkVSU0lPTiwgJm1pbm9yKTsKLSAgICAgICAgbV92ZXJzaW9uID0gbWFqb3IgKiAxMDAg KyBtaW5vciAqIDEwOworICAgICAgICAvLyBWZXJzaW9uIHN0cmluZyBjYW4gc3RhcnQgd2l0aCB0 aGUgdmVyc2lvbiBudW1iZXIgKGFsbCB2ZXJzaW9ucyBleGNlcHQgR0xFUyAxIGFuZCAyKSBvciB3 aXRoCisgICAgICAgIC8vICJPcGVuR0wiLiBEaWZmZXJlbnQgZmllbGRzIGluc2lkZSB0aGUgdmVy c2lvbiBzdHJpbmcgYXJlIHNlcGFyYXRlZCBieSBzcGFjZXMuCisgICAgICAgIFN0cmluZyB2ZXJz aW9uU3RyaW5nID0gU3RyaW5nKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KDo6Z2xHZXRT dHJpbmcoR0xfVkVSU0lPTikpKTsKKyAgICAgICAgVmVjdG9yPFN0cmluZz4gdmVyc2lvblN0cmlu Z0NvbXBvbmVudHM7CisgICAgICAgIHZlcnNpb25TdHJpbmcuc3BsaXQoJyAnLCB2ZXJzaW9uU3Ry aW5nQ29tcG9uZW50cyk7CisKKyAgICAgICAgVmVjdG9yPFN0cmluZz4gdmVyc2lvbkRpZ2l0czsK KyAgICAgICAgaWYgKHZlcnNpb25TdHJpbmdDb21wb25lbnRzLmF0KDApID09ICJPcGVuR0wiKSB7 CisgICAgICAgICAgICAvLyBJZiB0aGUgdmVyc2lvbiBzdHJpbmcgc3RhcnRzIHdpdGggIk9wZW5H TCIgaXQgY2FuIGJlIEdMRVMgMSBvciAyLiBJbiBHTEVTMSB2ZXJzaW9uIHN0cmluZyBzdGFydHMK KyAgICAgICAgICAgIC8vIHdpdGggIk9wZW5HTCBFUy08cHJvZmlsZT4gbWFqb3IubWlub3IiIGFu ZCBpbiBHTEVTMiB3aXRoICJPcGVuR0wgRVMgbWFqb3IubWlub3IiLiBWZXJzaW9uIGlzIHRoZQor ICAgICAgICAgICAgLy8gdGhpcmQgY29tcG9uZW50IGluIGJvdGggY2FzZXMuCisgICAgICAgICAg ICB2ZXJzaW9uU3RyaW5nQ29tcG9uZW50cy5hdCgyKS5zcGxpdCgnLicsIHZlcnNpb25EaWdpdHMp OworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgLy8gVmVyc2lvbiBpcyB0aGUgZmlyc3Qg Y29tcG9uZW50LiBUaGUgdmVyc2lvbiBudW1iZXIgaXMgYWx3YXlzICJtYWpvci5taW5vciIgb3IK KyAgICAgICAgICAgIC8vICJtYWpvci5taW5vci5yZWxlYXNlIi4gSWdub3JlIHRoZSByZWxlYXNl IG51bWJlci4KKyAgICAgICAgICAgIHZlcnNpb25TdHJpbmdDb21wb25lbnRzLmF0KDApLnNwbGl0 KCcuJywgdmVyc2lvbkRpZ2l0cyk7CisgICAgICAgIH0KKworICAgICAgICBtX3ZlcnNpb24gPSB2 ZXJzaW9uRGlnaXRzLmF0KDApLnRvVUludCgpICogMTAwICsgdmVyc2lvbkRpZ2l0cy5hdCgxKS50 b1VJbnQoKSAqIDEwOwogICAgIH0KICAgICByZXR1cm4gbV92ZXJzaW9uOwogfQo= 295937 2016-12-02 03:06:01 -0800 2016-12-02 05:23:13 -0800 Patch bug-165253-20161202120530.patch text/plain 2768 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDUwMmMxMGM0MjZjYTBk MmExMGU3NjE2ODgwNGNmZDA2MDg4NzE0Mi4uYTY4NTg3ZThkYmRjMWNkM2M1ODc1ZTJkMmNlNDk1 YjVmZmMxNmE2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTEyLTAxICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVXNlIGFuIE9w ZW5HTCA8IDMuMCBjb21wbGlhbnQgd2F5IHRvIHJlcXVlc3QgdGhlIE9wZW5HTCB2ZXJzaW9uCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUyNTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgZ2xHZXRT dHJpbmcoR0xfVkVSU0lPTikgdG8gZ2V0IHRoZSBPcGVuR0wgdmVyc2lvbiwgYXMgZ2xHZXRJbnRl Z2VydiB3aXRoIEdMX01BSk9SX1ZFUlNJT04KKyAgICAgICAgYW5kIEdMX01JTk9SX1ZFUlNJT04g aXMgb25seSBzdXBwb3J0ZWQgZnJvbSAzLjAgb24uCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlz dGVudCB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dMQ29udGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHTENvbnRleHQ6OnZlcnNpb24pOgorCiAyMDE2LTExLTMwICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy b2xsaW5nIG91dCByMjA5MTY4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR0xDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0dMQ29udGV4dC5jcHAKaW5kZXggNTI1OTViOWJjOTA3MzkyNTQwNzVkMDBiNDU0NDMyMGUzNjIy ZjM1OC4uYjM4ZjhiYWVlODMzNDE1YjdjMjc1Njc5ZDNkYWM4ZGM4ODY1OGUwMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR0xDb250ZXh0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HTENvbnRleHQuY3BwCkBAIC0xNjMsMTEg KzE2MywyNSBAQCBib29sIEdMQ29udGV4dDo6aXNFeHRlbnNpb25TdXBwb3J0ZWQoY29uc3QgY2hh ciogZXh0ZW5zaW9uTGlzdCwgY29uc3QgY2hhciogZXh0ZQogdW5zaWduZWQgR0xDb250ZXh0Ojp2 ZXJzaW9uKCkKIHsKICAgICBpZiAoIW1fdmVyc2lvbikgewotICAgICAgICBHQzNEaW50IG1ham9y ID0gMDsKLSAgICAgICAgR0MzRGludCBtaW5vciA9IDA7Ci0gICAgICAgIDo6Z2xHZXRJbnRlZ2Vy dihHTF9NQUpPUl9WRVJTSU9OLCAmbWFqb3IpOwotICAgICAgICA6OmdsR2V0SW50ZWdlcnYoR0xf TUlOT1JfVkVSU0lPTiwgJm1pbm9yKTsKLSAgICAgICAgbV92ZXJzaW9uID0gbWFqb3IgKiAxMDAg KyBtaW5vciAqIDEwOworICAgICAgICAvLyBWZXJzaW9uIHN0cmluZyBjYW4gc3RhcnQgd2l0aCB0 aGUgdmVyc2lvbiBudW1iZXIgKGFsbCB2ZXJzaW9ucyBleGNlcHQgR0xFUyAxIGFuZCAyKSBvciB3 aXRoCisgICAgICAgIC8vICJPcGVuR0wiLiBEaWZmZXJlbnQgZmllbGRzIGluc2lkZSB0aGUgdmVy c2lvbiBzdHJpbmcgYXJlIHNlcGFyYXRlZCBieSBzcGFjZXMuCisgICAgICAgIFN0cmluZyB2ZXJz aW9uU3RyaW5nID0gU3RyaW5nKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgY2hhcio+KDo6Z2xHZXRT dHJpbmcoR0xfVkVSU0lPTikpKTsKKyAgICAgICAgVmVjdG9yPFN0cmluZz4gdmVyc2lvblN0cmlu Z0NvbXBvbmVudHM7CisgICAgICAgIHZlcnNpb25TdHJpbmcuc3BsaXQoJyAnLCB2ZXJzaW9uU3Ry aW5nQ29tcG9uZW50cyk7CisKKyAgICAgICAgVmVjdG9yPFN0cmluZz4gdmVyc2lvbkRpZ2l0czsK KyAgICAgICAgaWYgKHZlcnNpb25TdHJpbmdDb21wb25lbnRzWzBdID09ICJPcGVuR0wiKSB7Cisg ICAgICAgICAgICAvLyBJZiB0aGUgdmVyc2lvbiBzdHJpbmcgc3RhcnRzIHdpdGggIk9wZW5HTCIg aXQgY2FuIGJlIEdMRVMgMSBvciAyLiBJbiBHTEVTMSB2ZXJzaW9uIHN0cmluZyBzdGFydHMKKyAg ICAgICAgICAgIC8vIHdpdGggIk9wZW5HTCBFUy08cHJvZmlsZT4gbWFqb3IubWlub3IiIGFuZCBp biBHTEVTMiB3aXRoICJPcGVuR0wgRVMgbWFqb3IubWlub3IiLiBWZXJzaW9uIGlzIHRoZQorICAg ICAgICAgICAgLy8gdGhpcmQgY29tcG9uZW50IGluIGJvdGggY2FzZXMuCisgICAgICAgICAgICB2 ZXJzaW9uU3RyaW5nQ29tcG9uZW50c1syXS5zcGxpdCgnLicsIHZlcnNpb25EaWdpdHMpOworICAg ICAgICB9IGVsc2UgeworICAgICAgICAgICAgLy8gVmVyc2lvbiBpcyB0aGUgZmlyc3QgY29tcG9u ZW50LiBUaGUgdmVyc2lvbiBudW1iZXIgaXMgYWx3YXlzICJtYWpvci5taW5vciIgb3IKKyAgICAg ICAgICAgIC8vICJtYWpvci5taW5vci5yZWxlYXNlIi4gSWdub3JlIHRoZSByZWxlYXNlIG51bWJl ci4KKyAgICAgICAgICAgIHZlcnNpb25TdHJpbmdDb21wb25lbnRzWzBdLnNwbGl0KCcuJywgdmVy c2lvbkRpZ2l0cyk7CisgICAgICAgIH0KKworICAgICAgICBtX3ZlcnNpb24gPSB2ZXJzaW9uRGln aXRzWzBdLnRvVUludCgpICogMTAwICsgdmVyc2lvbkRpZ2l0c1sxXS50b1VJbnQoKSAqIDEwOwog ICAgIH0KICAgICByZXR1cm4gbV92ZXJzaW9uOwogfQo=