165249 2016-12-01 03:50:54 -0800 [Win] test-webkitpy is failing. 2016-12-02 19:29:07 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=164568 P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue dbates glenn jbedard lforschler mcatanzaro oldest_to_newest 1255202 0 pvollan 2016-12-01 03:50:54 -0800 When running test-webkitpy, I get an exception: [1444/1505] webkitpy.tool.commands.rebaseline_unittest.TestRebaselineTest.test_rebaseline_updates_expectations_file_noop erred: Traceback (most recent call last): File "/cygdrive/c/Projects/WebKit2/OpenSource/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 101, in test_rebaseline_updates_expectations_file_noop self._zero_out_test_expectations() File "/cygdrive/c/Projects/WebKit2/OpenSource/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 70, in _zero_out_test_expectations port = self.tool.port_factory.get(port_name) File "/cygdrive/c/Projects/WebKit2/OpenSource/Tools/Scripts/webkitpy/port/factory.py", line 126, in get return cls(self._host, port_name, options=options, **kwargs) File "/cygdrive/c/Projects/WebKit2/OpenSource/Tools/Scripts/webkitpy/port/ios.py", line 106, in __init__ self._current_device = Simulator().current_device() File "/cygdrive/c/Projects/WebKit2/OpenSource/Tools/Scripts/webkitpy/xcode/simulator.py", line 303, in __init__ self.refresh() File "/cygdrive/c/Projects/WebKit2/OpenSource/Tools/Scripts/webkitpy/xcode/simulator.py", line 403, in refresh device_types_header = next(lines) TypeError: tuple object is not an iterator 1255205 1 295833 pvollan 2016-12-01 03:57:21 -0800 Created attachment 295833 Patch 1255258 2 295833 jbedard 2016-12-01 08:28:40 -0800 Comment on attachment 295833 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295833&action=review > Tools/Scripts/webkitpy/xcode/simulator.py:404 > + return I think we want another assert in here to test that we are not on a mac. Otherwise we could end up suppressing a legitimate error on Macs. Perhaps self._host.platform.is_mac() would do the job? 1255660 3 295941 pvollan 2016-12-02 04:45:54 -0800 Created attachment 295941 Patch 1255661 4 pvollan 2016-12-02 04:47:40 -0800 (In reply to comment #2) > Comment on attachment 295833 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295833&action=review > > > Tools/Scripts/webkitpy/xcode/simulator.py:404 > > + return > > I think we want another assert in here to test that we are not on a mac. > Otherwise we could end up suppressing a legitimate error on Macs. Perhaps > self._host.platform.is_mac() would do the job? Thanks for reviewing :) Updated patch. 1255718 5 295941 achristensen 2016-12-02 09:29:50 -0800 Comment on attachment 295941 Patch what about linux? Why are we even running this Xcode-specific code on Windows? 1255766 6 jbedard 2016-12-02 10:55:17 -0800 (In reply to comment #5) > Comment on attachment 295941 [details] > Patch > > what about linux? Why are we even running this Xcode-specific code on > Windows? I'm not aware of a method of disabling certain unit tests on different platforms in Python (since that is essentially what it going on here). This change may be better suited for the unit test itself. It should also be noted that this is a pretty unique circumstance. Most of the time when we run command line tools in webkitpy we mock them up when testing, meaning that testing platform specific code is platform agnostic. In this case, the test in question is intended to test the command, so the test can't really be platform agnostic. 1255929 7 jbedard 2016-12-02 15:15:59 -0800 I think <http://trac.webkit.org/changeset/209266> should have fixed this. https://bugs.webkit.org/show_bug.cgi?id=164568 should be fixed shortly, the more verbose GTK log revealed a better fix to this problem. 1255961 8 295941 dbates 2016-12-02 16:32:40 -0800 Comment on attachment 295941 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295941&action=review I like the approach of this patch. We already rolled out <https://trac.webkit.org/changeset/209136> in <https://trac.webkit.org/changeset/209266>. > Tools/Scripts/webkitpy/xcode/simulator.py:404 > + assert not self._host.platform.is_mac() This assert is not needed because on a real platform xcode_simctl_list() returns a generator. And an empty generator != None. (For correctness we should fix <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/platforminfo.py?rev=209145#L132> to return an empty generator for a non-Mac port. That being said, this should never happen in practice). 295833 2016-12-01 03:57:21 -0800 2016-12-02 04:45:49 -0800 Patch bug-165249-20161201035706.patch text/plain 1308 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwOTE4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTEyLTAxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSB0ZXN0LXdlYmtpdHB5IGlzIGZhaWxpbmcuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUyNDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgY2hlY2sgZm9yIGVtcHR5 IGl0ZXJhdG9yLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3Iu cHk6CisgICAgICAgIChTaW11bGF0b3IucmVmcmVzaCk6CisKIDIwMTYtMTItMDEgIFl1c3VrZSBT dXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgSW50cm9kdWNlIFN0cmlu Z0ltcGw6OlN0YXRpY1N0cmluZ0ltcGwgd2l0aCBjb25zdGV4cHIgY29uc3RydWN0b3IKSW5kZXg6 IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5CShyZXZpc2lvbiAyMDkx NzkpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weQkod29ya2lu ZyBjb3B5KQpAQCAtNDAwLDYgKzQwMCw4IEBAIGNsYXNzIFNpbXVsYXRvcihvYmplY3QpOgogICAg ICAgICBSZWZyZXNoIHJ1bnRpbWUgYW5kIGRldmljZSB0eXBlIGluZm9ybWF0aW9uIGZyb20gYGBz aW1jdGwgbGlzdGBgLgogICAgICAgICAiIiIKICAgICAgICAgbGluZXMgPSBzZWxmLl9ob3N0LnBs YXRmb3JtLnhjb2RlX3NpbWN0bF9saXN0KCkKKyAgICAgICAgaWYgbm90IGxpbmVzOgorICAgICAg ICAgICAgcmV0dXJuCiAgICAgICAgIGRldmljZV90eXBlc19oZWFkZXIgPSBuZXh0KGxpbmVzKQog ICAgICAgICBpZiBkZXZpY2VfdHlwZXNfaGVhZGVyICE9ICc9PSBEZXZpY2UgVHlwZXMgPT0nOgog ICAgICAgICAgICAgcmFpc2UgUnVudGltZUVycm9yKCdFeHBlY3RlZCA9PSBEZXZpY2UgVHlwZXMg PT0gaGVhZGVyIGJ1dCBnb3Q6ICJ7fSInLmZvcm1hdChkZXZpY2VfdHlwZXNfaGVhZGVyKSkK 295941 2016-12-02 04:45:54 -0800 2016-12-02 16:32:40 -0800 Patch bug-165249-20161202044538.patch text/plain 1361 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwOTE4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTEyLTAxICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSB0ZXN0LXdlYmtpdHB5IGlzIGZhaWxpbmcuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUyNDkKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgY2hlY2sgZm9yIGVtcHR5 IGl0ZXJhdG9yLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS94Y29kZS9zaW11bGF0b3Iu cHk6CisgICAgICAgIChTaW11bGF0b3IucmVmcmVzaCk6CisKIDIwMTYtMTItMDEgIFl1c3VrZSBT dXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgSW50cm9kdWNlIFN0cmlu Z0ltcGw6OlN0YXRpY1N0cmluZ0ltcGwgd2l0aCBjb25zdGV4cHIgY29uc3RydWN0b3IKSW5kZXg6 IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdG9yLnB5CShyZXZpc2lvbiAyMDkx NzkpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRvci5weQkod29ya2lu ZyBjb3B5KQpAQCAtNDAwLDYgKzQwMCw5IEBAIGNsYXNzIFNpbXVsYXRvcihvYmplY3QpOgogICAg ICAgICBSZWZyZXNoIHJ1bnRpbWUgYW5kIGRldmljZSB0eXBlIGluZm9ybWF0aW9uIGZyb20gYGBz aW1jdGwgbGlzdGBgLgogICAgICAgICAiIiIKICAgICAgICAgbGluZXMgPSBzZWxmLl9ob3N0LnBs YXRmb3JtLnhjb2RlX3NpbWN0bF9saXN0KCkKKyAgICAgICAgaWYgbm90IGxpbmVzOgorICAgICAg ICAgICAgYXNzZXJ0IG5vdCBzZWxmLl9ob3N0LnBsYXRmb3JtLmlzX21hYygpCisgICAgICAgICAg ICByZXR1cm4KICAgICAgICAgZGV2aWNlX3R5cGVzX2hlYWRlciA9IG5leHQobGluZXMpCiAgICAg ICAgIGlmIGRldmljZV90eXBlc19oZWFkZXIgIT0gJz09IERldmljZSBUeXBlcyA9PSc6CiAgICAg ICAgICAgICByYWlzZSBSdW50aW1lRXJyb3IoJ0V4cGVjdGVkID09IERldmljZSBUeXBlcyA9PSBo ZWFkZXIgYnV0IGdvdDogInt9IicuZm9ybWF0KGRldmljZV90eXBlc19oZWFkZXIpKQo=