165224 2016-11-30 14:34:51 -0800 TypeInfo::OutOfLineTypeFlags should be 16 bits in size. 2016-11-30 16:12:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren jfbastien keith_miller msaboff saam ysuzuki oldest_to_newest 1254989 0 mark.lam 2016-11-30 14:34:51 -0800 There's no reason for OutOfLineTypeFlags to be constraint to 8 bits since the space is available to us. Making OutOfLineTypeFlags 16 bits brings TypeInfo up to 32 bits in size from 24 bits. 1254997 1 295774 mark.lam 2016-11-30 14:54:56 -0800 Created attachment 295774 proposed patch. 1255009 2 295774 jfbastien 2016-11-30 15:11:15 -0800 Comment on attachment 295774 proposed patch. lgtm 1255013 3 295774 saam 2016-11-30 15:15:44 -0800 Comment on attachment 295774 proposed patch. Do you have a plan for the extra bits? 1255015 4 mark.lam 2016-11-30 15:18:33 -0800 (In reply to comment #3) > Comment on attachment 295774 [details] > proposed patch. > > Do you have a plan for the extra bits? I have plans to use 1 bit (which would use up the last empty bit in the current 8). Since I was looking at this code and already did the legwork to confirm that we have the extra space, I wanted to just make it clear in the code that we do have that space should we need to add more bits in the future. 1255030 5 mark.lam 2016-11-30 16:12:15 -0800 Thanks for the reviews. Landed in r209162: <http://trac.webkit.org/r209162>. 295774 2016-11-30 14:54:56 -0800 2016-11-30 15:15:44 -0800 proposed patch. bug-165224.patch text/plain 1990 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5MTU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE2LTExLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBU eXBlSW5mbzo6T3V0T2ZMaW5lVHlwZUZsYWdzIHNob3VsZCBiZSAxNiBiaXRzIGluIHNpemUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjUyMjQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSdzIG5v IHJlYXNvbiBmb3IgT3V0T2ZMaW5lVHlwZUZsYWdzIHRvIGJlIGNvbnN0cmFpbnQgdG8gOCBiaXRz IHNpbmNlIHRoZQorICAgICAgICBzcGFjZSBpcyBhdmFpbGFibGUgdG8gdXMuICBNYWtpbmcgT3V0 T2ZMaW5lVHlwZUZsYWdzIDE2IGJpdHMgYnJpbmdzIFR5cGVJbmZvIHVwCisgICAgICAgIHRvIDMy IGJpdHMgaW4gc2l6ZSBmcm9tIHRoZSBjdXJyZW50IDI0IGJpdHMuCisKKyAgICAgICAgKiBydW50 aW1lL0pTVHlwZUluZm8uaDoKKyAgICAgICAgKEpTQzo6VHlwZUluZm86OlR5cGVJbmZvKToKKwog MjAxNi0xMS0zMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFJFR1JFU1NJT046IGluc3BlY3Rvci9zYW1wbGluZy1wcm9maWxlci8qIExheW91dFRlc3Rz IGFyZSBmbGFreSB0aW1lb3V0cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNUeXBlSW5mby5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTVHlwZUluZm8uaAkocmV2aXNpb24gMjA5MTUyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNUeXBlSW5mby5oCSh3b3JraW5nIGNvcHkpCkBAIC01NCwxMSArNTQsMTIgQEAg c3RhdGljIGNvbnN0IHVuc2lnbmVkIEludGVyY2VwdHNHZXRPd25QcgogY2xhc3MgVHlwZUluZm8g ewogcHVibGljOgogICAgIHR5cGVkZWYgdWludDhfdCBJbmxpbmVUeXBlRmxhZ3M7Ci0gICAgdHlw ZWRlZiB1aW50OF90IE91dE9mTGluZVR5cGVGbGFnczsKKyAgICB0eXBlZGVmIHVpbnQxNl90IE91 dE9mTGluZVR5cGVGbGFnczsKIAogICAgIFR5cGVJbmZvKEpTVHlwZSB0eXBlLCB1bnNpZ25lZCBm bGFncyA9IDApCiAgICAgICAgIDogVHlwZUluZm8odHlwZSwgZmxhZ3MgJiAweGZmLCBmbGFncyA+ PiA4KQogICAgIHsKKyAgICAgICAgQVNTRVJUKCEoZmxhZ3MgPj4gMjQpKTsKICAgICB9CiAKICAg ICBUeXBlSW5mbyhKU1R5cGUgdHlwZSwgSW5saW5lVHlwZUZsYWdzIGlubGluZVR5cGVGbGFncywg T3V0T2ZMaW5lVHlwZUZsYWdzIG91dE9mTGluZVR5cGVGbGFncykKQEAgLTExMCw5ICsxMTEsOSBA QCBwcml2YXRlOgogICAgIGJvb2wgaXNTZXRPbkZsYWdzMSh1bnNpZ25lZCBmbGFnKSBjb25zdCB7 IEFTU0VSVChmbGFnIDw9ICgxIDw8IDcpKTsgcmV0dXJuIG1fZmxhZ3MgJiBmbGFnOyB9CiAgICAg Ym9vbCBpc1NldE9uRmxhZ3MyKHVuc2lnbmVkIGZsYWcpIGNvbnN0IHsgQVNTRVJUKGZsYWcgPj0g KDEgPDwgOCkpOyByZXR1cm4gbV9mbGFnczIgJiAoZmxhZyA+PiA4KTsgfQogCi0gICAgdW5zaWdu ZWQgY2hhciBtX3R5cGU7Ci0gICAgdW5zaWduZWQgY2hhciBtX2ZsYWdzOwotICAgIHVuc2lnbmVk IGNoYXIgbV9mbGFnczI7CisgICAgdWludDhfdCBtX3R5cGU7CisgICAgdWludDhfdCBtX2ZsYWdz OworICAgIHVpbnQxNl90IG1fZmxhZ3MyOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgSlNDCg==