165205 2016-11-30 11:01:01 -0800 Proxy is not allowed in the global prototype chain. 2016-11-30 13:15:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ggaren keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1254851 0 mark.lam 2016-11-30 11:01:01 -0800 patch coming. <rdar://problem/28654967> 1254856 1 295734 mark.lam 2016-11-30 11:10:57 -0800 Created attachment 295734 proposed patch. 1254885 2 295734 ggaren 2016-11-30 12:13:31 -0800 Comment on attachment 295734 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295734&action=review r=me > LayoutTests/js/dom/proxy-is-not-allowed-in-global-prototype-chain.html:12 > + if (e == "TypeError: Proxy is not allowed in the global prototype chain.") > + log("PASS: onerror saw " + e); > + else > + log("FAIL: onerror saw unexpected exception " + e); > +} In tests like this, I think it's best juts to log the error message, without judging whether it's a pass or a fail. Our test infrastructure will flag it for review if the result ever changes -- but we don't know in advance that any change to error message text is definitely bad. 1254887 3 295734 mark.lam 2016-11-30 12:14:53 -0800 Comment on attachment 295734 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295734&action=review >> LayoutTests/js/dom/proxy-is-not-allowed-in-global-prototype-chain.html:12 >> +} > > In tests like this, I think it's best juts to log the error message, without judging whether it's a pass or a fail. Our test infrastructure will flag it for review if the result ever changes -- but we don't know in advance that any change to error message text is definitely bad. OK, I'll change it accordingly. 1254919 4 mark.lam 2016-11-30 13:15:05 -0800 Thanks for the review. Landed in r209149: <http://trac.webkit.org/r209149>. 295734 2016-11-30 11:10:57 -0800 2016-11-30 12:13:31 -0800 proposed patch. bug-165205.patch text/plain 4446 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5MTM4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE2LTExLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBQ cm94eSBpcyBub3QgYWxsb3dlZCBpbiB0aGUgZ2xvYmFsIHByb3RvdHlwZSBjaGFpbi4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2NTIwNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9Qcm9n cmFtRXhlY3V0YWJsZS5jcHA6CisgICAgICAgIChKU0M6OlByb2dyYW1FeGVjdXRhYmxlOjppbml0 aWFsaXplR2xvYmFsUHJvcGVydGllcyk6CisgICAgICAgIC0gV2UnbGwgbm93IHRocm93IGEgVHlw ZUVycm9yIGlmIHdlIGRldGVjdCBhIFByb3h5IGluIHRoZSBnbG9iYWwgcHJvdG90eXBlIGNoYWlu LgorCiAyMDE2LTExLTMwICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAg ICBTdHJlYW1saW5lIGFuZCBzcGVlZCB1cCB0b2tlbml6ZXIgYW5kIHNlZ21lbnRlZCBzdHJpbmcg Y2xhc3NlcwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUHJvZ3JhbUV4ZWN1 dGFibGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1By b2dyYW1FeGVjdXRhYmxlLmNwcAkocmV2aXNpb24gMjA5MDg4KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvUHJvZ3JhbUV4ZWN1dGFibGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03 OSw2ICs3OSwxNSBAQCBKU09iamVjdCogUHJvZ3JhbUV4ZWN1dGFibGU6OmluaXRpYWxpemVHCiAg ICAgUkVMRUFTRV9BU1NFUlQoZ2xvYmFsT2JqZWN0KTsKICAgICBBU1NFUlQoJmdsb2JhbE9iamVj dC0+dm0oKSA9PSAmdm0pOwogCisgICAgSlNWYWx1ZSBuZXh0UHJvdG90eXBlID0gZ2xvYmFsT2Jq ZWN0LT5nZXRQcm90b3R5cGVEaXJlY3QoKTsKKyAgICB3aGlsZSAobmV4dFByb3RvdHlwZSAmJiBu ZXh0UHJvdG90eXBlLmlzT2JqZWN0KCkpIHsKKyAgICAgICAgaWYgKFVOTElLRUxZKGFzT2JqZWN0 KG5leHRQcm90b3R5cGUpLT50eXBlKCkgPT0gUHJveHlPYmplY3RUeXBlKSkgeworICAgICAgICAg ICAgRXhlY1N0YXRlKiBleGVjID0gZ2xvYmFsT2JqZWN0LT5nbG9iYWxFeGVjKCk7CisgICAgICAg ICAgICByZXR1cm4gY3JlYXRlVHlwZUVycm9yKGV4ZWMsIEFTQ0lJTGl0ZXJhbCgiUHJveHkgaXMg bm90IGFsbG93ZWQgaW4gdGhlIGdsb2JhbCBwcm90b3R5cGUgY2hhaW4uIikpOworICAgICAgICB9 CisgICAgICAgIG5leHRQcm90b3R5cGUgPSBhc09iamVjdChuZXh0UHJvdG90eXBlKS0+Z2V0UHJv dG90eXBlRGlyZWN0KCk7CisgICAgfQorICAgIAogICAgIEpTT2JqZWN0KiBleGNlcHRpb24gPSBu dWxscHRyOwogICAgIFVubGlua2VkUHJvZ3JhbUNvZGVCbG9jayogdW5saW5rZWRDb2RlQmxvY2sg PSBnbG9iYWxPYmplY3QtPmNyZWF0ZVByb2dyYW1Db2RlQmxvY2soY2FsbEZyYW1lLCB0aGlzLCAm ZXhjZXB0aW9uKTsKICAgICBpZiAoVU5MSUtFTFkoZXhjZXB0aW9uKSkKQEAgLTE3Nyw3ICsxODYs NyBAQCBKU09iamVjdCogUHJvZ3JhbUV4ZWN1dGFibGU6OmluaXRpYWxpemVHCiAgICAgICAgICAg ICBSRUxFQVNFX0FTU0VSVChvZmZzZXRGb3JBc3NlcnQgPT0gb2Zmc2V0KTsKICAgICAgICAgfQog ICAgIH0KLSAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAogdm9pZCBQcm9n cmFtRXhlY3V0YWJsZTo6dmlzaXRDaGlsZHJlbihKU0NlbGwqIGNlbGwsIFNsb3RWaXNpdG9yJiB2 aXNpdG9yKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjA5MDg4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMTEtMzAgIE1hcmsgTGFt ICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIFByb3h5IGlzIG5vdCBhbGxvd2VkIGlu IHRoZSBnbG9iYWwgcHJvdG90eXBlIGNoYWluLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MjA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBqcy9kb20vcHJveHktaXMtbm90LWFsbG93ZWQtaW4tZ2xv YmFsLXByb3RvdHlwZS1jaGFpbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGpzL2Rv bS9wcm94eS1pcy1ub3QtYWxsb3dlZC1pbi1nbG9iYWwtcHJvdG90eXBlLWNoYWluLmh0bWw6IEFk ZGVkLgorCiAyMDE2LTExLTI5ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29t PgogCiAgICAgICAgIFtNZWRpYVN0cmVhbV0gRG9uJ3QgcmVxdWVzdCB1c2VyIHBlcm1pc3Npb24g Zm9yIGEgZGV2aWNlIGlmIGl0IGhhcyBhbHJlYWR5IGJlZW4gZ3JhbnRlZCBpbiB0aGUgY3VycmVu dCBicm93c2luZyBjb250ZXh0CkluZGV4OiBMYXlvdXRUZXN0cy9qcy9kb20vcHJveHktaXMtbm90 LWFsbG93ZWQtaW4tZ2xvYmFsLXByb3RvdHlwZS1jaGFpbi1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvanMvZG9tL3Byb3h5LWlzLW5vdC1hbGxvd2VkLWluLWdsb2JhbC1w cm90b3R5cGUtY2hhaW4tZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkKKysrIExheW91dFRlc3Rz L2pzL2RvbS9wcm94eS1pcy1ub3QtYWxsb3dlZC1pbi1nbG9iYWwtcHJvdG90eXBlLWNoYWluLWV4 cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDMgQEAKK0NPTlNPTEUgTUVTU0FH RTogVHlwZUVycm9yOiBQcm94eSBpcyBub3QgYWxsb3dlZCBpbiB0aGUgZ2xvYmFsIHByb3RvdHlw ZSBjaGFpbi4KK1BBU1M6IG9uZXJyb3Igc2F3IFR5cGVFcnJvcjogUHJveHkgaXMgbm90IGFsbG93 ZWQgaW4gdGhlIGdsb2JhbCBwcm90b3R5cGUgY2hhaW4uCisKSW5kZXg6IExheW91dFRlc3RzL2pz L2RvbS9wcm94eS1pcy1ub3QtYWxsb3dlZC1pbi1nbG9iYWwtcHJvdG90eXBlLWNoYWluLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvanMvZG9tL3Byb3h5LWlzLW5vdC1hbGxvd2VkLWlu LWdsb2JhbC1wcm90b3R5cGUtY2hhaW4uaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0 cy9qcy9kb20vcHJveHktaXMtbm90LWFsbG93ZWQtaW4tZ2xvYmFsLXByb3RvdHlwZS1jaGFpbi5o dG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMzMgQEAKKzxwcmUgaWQ9ImNvbnNvbGUiPjwv cHJlPgorCis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIu ZHVtcEFzVGV4dCgpOworCit3aW5kb3cub25lcnJvciA9IGZ1bmN0aW9uKGUpIHsKKyAgICBpZiAo ZSA9PSAiVHlwZUVycm9yOiBQcm94eSBpcyBub3QgYWxsb3dlZCBpbiB0aGUgZ2xvYmFsIHByb3Rv dHlwZSBjaGFpbi4iKQorICAgICAgICBsb2coIlBBU1M6IG9uZXJyb3Igc2F3ICIgKyBlKTsKKyAg ICBlbHNlCisgICAgICAgIGxvZygiRkFJTDogb25lcnJvciBzYXcgdW5leHBlY3RlZCBleGNlcHRp b24gIiArIGUpOworfQorCit0cnkgeworICAgIHZhciBwcm90byA9IHdpbmRvdy5fX3Byb3RvX18u X19wcm90b19fLl9fcHJvdG9fXzsKKyAgICBwcm90by5fX3Byb3RvX18gPSBuZXcgUHJveHkocHJv dG8uX19wcm90b19fLCB7CisgICAgICAgIGhhcyh0YXJnZXQsIHByb3ApIHsKKyAgICAgICAgICAg IGxvZygiRkFJTDogcHJveHkgc2F3ICIgKyBwcm9wKTsKKyAgICAgICAgfQorICAgIH0pOworCit9 IGNhdGNoIChlKSB7CisgICAgbG9nKCJDYXVnaHQ6ICIgKyBlKTsKKyAgICBsb2coZS5zdGFjayk7 Cit9CisKK2Z1bmN0aW9uIGxvZyhzKQoreworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJj b25zb2xlIikuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUocyArICJcbiIpKTsK K30KKzwvc2NyaXB0PgorCis8c2NyaXB0PnZhciB1bmRlZmluZWRfdmFyaWFibGU8L3NjcmlwdD4K