165187 2016-11-29 19:51:11 -0800 Correct plugin sandbox after r208611 2016-11-30 09:53:36 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham aestes ap bfulgham bshafiei commit-queue ddkilzer oldest_to_newest 1254655 0 bfulgham 2016-11-29 19:51:11 -0800 I misread the Scheme conditional clause I changed in <http://trac.webkit.org/changeset/208611> as if it was C++. I should have recognized that Scheme's conditional looks like this: (if (predicate ...) (stuff to do if true) (stuff to do if false)) Therefore, much of what I stripped out is still needed. 1254660 1 bfulgham 2016-11-29 19:58:22 -0800 <rdar://problem/29431165> 1254661 2 295696 bfulgham 2016-11-29 20:01:12 -0800 Created attachment 295696 Patch 1254815 3 295696 commit-queue 2016-11-30 09:53:32 -0800 Comment on attachment 295696 Patch Clearing flags on attachment: 295696 Committed r209133: <http://trac.webkit.org/changeset/209133> 1254816 4 commit-queue 2016-11-30 09:53:36 -0800 All reviewed patches have been landed. Closing bug. 295696 2016-11-29 20:01:12 -0800 2016-11-30 09:53:32 -0800 Patch bug-165187-20161129200048.patch text/plain 2127 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwOTExNCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTExLTI5ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIENvcnJlY3QgcGx1Z2luIHNh bmRib3ggYWZ0ZXIgcjIwODYxMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY1MTg3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTQzMTE2NT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjA4NjEx IEkgcmVtb3ZlZCB0aGUgJ2Vsc2UnIGNsYXVzZSBvZiBhIFNjaGVtZSBjb25kaXRpb25hbAorICAg ICAgICB0aGF0IHdhcyBuZWVkZWQgdG8gcHJvcGVybHkgcnVuIHBsdWdpbnMgKHN1Y2ggYXMgRmxh c2ggUGxheWVyKS4KKworICAgICAgICBUaGlzIGNoYW5nZSByZXRhaW5zIHRoZSByZWxldmFudCBj dXJyZW50IHNhbmRib3ggY29udGVudCwgd2hpbGUKKyAgICAgICAgc3RpbGwgc3RyaXBwaW5nIG91 dCB0aGUgb2xkIGNvZGUgdGhhdCBpcyBubyBsb25nZXIgbmVlZGVkLgorCisgICAgICAgICogUGx1 Z2luUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5wbHVnaW4tY29tbW9uLnNiLmluOgorCiAy MDE2LTExLTI5ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZW1vdmUgV2ViUGFnZTo6U2V0UGFnZVN1cHByZXNzZWQKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1BsdWdpblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQucGx1Z2luLWNvbW1vbi5z Yi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL21hYy9jb20u YXBwbGUuV2ViS2l0LnBsdWdpbi1jb21tb24uc2IuaW4JKHJldmlzaW9uIDIwOTExNCkKKysrIFNv dXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQucGx1Z2luLWNv bW1vbi5zYi5pbgkod29ya2luZyBjb3B5KQpAQCAtMzQ3LDYgKzM0NywyMiBAQAogKGRlZmluZSAo d2Via2l0LW1pY3JvcGhvbmUpCiAgICAgKGFsbG93IGRldmljZS1taWNyb3Bob25lKSkKIAorKGFs bG93IGlwYy1wb3NpeC1zaG0qCisgICAgKGlwYy1wb3NpeC1uYW1lLXJlZ2V4ICMiXkF1ZGlvSU8i KQorICAgIChpcGMtcG9zaXgtbmFtZS1yZWdleCAjIl5DRlBCUzoiKQorICAgIChpcGMtcG9zaXgt bmFtZSAiY29tLmFwcGxlLkNvbG9yU3luYy5HZW4ubG9jayIpCisgICAgKGlwYy1wb3NpeC1uYW1l ICJjb20uYXBwbGUuQ29sb3JTeW5jLkRpc3AubG9jayIpCisgICAgKGlwYy1wb3NpeC1uYW1lICJj b20uYXBwbGUuQ29sb3JTeW5jLkdyYXkyLjIiKQorICAgIChpcGMtcG9zaXgtbmFtZSAiY29tLmFw cGxlLkNvbG9yU3luYy5zUkdCIikKKyAgICAoaXBjLXBvc2l4LW5hbWUgImNvbS5hcHBsZS5Db2xv clN5bmMuR2VuR3JheSIpCisgICAgKGlwYy1wb3NpeC1uYW1lICJjb20uYXBwbGUuQ29sb3JTeW5j LkdlblJHQiIpCisgICAgKGlwYy1wb3NpeC1uYW1lLXJlZ2V4ICMiXmNvbVwuYXBwbGVcLmNzXC4i KQorICAgIChpcGMtcG9zaXgtbmFtZS1yZWdleCAjIl5sc1wuIikpCisoYWxsb3cgaXBjLXBvc2l4 LXNobS1yZWFkKgorICAgIChpcGMtcG9zaXgtbmFtZS1yZWdleCAjIl4vdG1wL2NvbVwuYXBwbGVc LmNzc2VlZFwuIikKKyAgICAoaXBjLXBvc2l4LW5hbWUgIkZOZXR3b3JrLmRlZmF1bHRTdG9yYWdl U2Vzc2lvbiIpCisgICAgKGlwYy1wb3NpeC1uYW1lICJhcHBsZS5zaG0ubm90aWZpY2F0aW9uX2Nl bnRlciIpKQorCiA7OyBTaWxlbnRseSBibG9jayBhY2Nlc3MgdG8gc29tZSByZXNvdXJjZXMKIChk ZW55IGZpbGUtcmVhZCogZmlsZS13cml0ZSogKHdpdGggbm8tbG9nKQogICAgIChzdWJwYXRoICIv TmV0d29yay9MaWJyYXJ5IikK