16516 2007-12-19 11:16:18 -0800 canvas image patterns stop working with some transformations 2008-03-08 22:50:08 -0800 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) PC Windows XP RESOLVED FIXED P2 Normal --- 1 ilmari.heikkinen oliver mitz oldest_to_newest 64747 0 ilmari.heikkinen 2007-12-19 11:16:18 -0800 HTML canvas image patterns created with context.createPattern(image, 'no-repeat') don't work after translating and rotating. E.g. p = ctx.createPattern(myImage, 'no-repeat'); ctx.translate(200, 0); ctx.rotate(Math.PI/8); ctx.fillStyle = p; ctx.fillRect(0,0, 215, 174); Patterns created with 'repeat' work. 64748 1 17993 ilmari.heikkinen 2007-12-19 11:19:24 -0800 Created attachment 17993 Testcase for transformed image patterns 64763 2 mitz 2007-12-19 14:42:02 -0800 This might be a bug in CoreGraphics. 65788 3 mitz 2007-12-30 20:24:32 -0800 The magic values from <http://trac.webkit.org/projects/webkit/changeset/13384> do not work for the test case. Of course, the old values of 0, 0 do not work for other cases (as demonstrated by bug 7830). 73109 4 19614 oliver 2008-03-08 22:24:47 -0800 Created attachment 19614 Fixeration! 73113 5 oliver 2008-03-08 22:50:08 -0800 Landed r30905 17993 2007-12-19 11:19:24 -0800 2007-12-19 11:19:24 -0800 Testcase for transformed image patterns imageTest.html text/html 1189 ilmari.heikkinen PGh0bWw+PGJvZHk+ClRoZXJlIHNob3VsZCBiZSB0d28gaW1hZ2VzIGJlbG93LCB0aGUgcmlnaHQg b25lIHJvdGF0ZWQgYnkgTWF0aC5QSS84Ljxicj4KPGNhbnZhcyBpZD0ibXlDYW52YXMiIHdpZHRo PSI0MDAiIGhlaWdodD0iMjAwIj48L2NhbnZhcz48YnI+ClRoZXJlIHNob3VsZCBiZSB0d28gaW1h Z2VzIGJlbG93LCB0aGUgcmlnaHQgb25lIHJvdGF0ZWQgYnkgTWF0aC5QSS84Ljxicj4KPGNhbnZh cyBpZD0ibXlDYW52YXMxIiB3aWR0aD0iNDAwIiBoZWlnaHQ9IjIwMCI+PC9jYW52YXM+PGJyPgo8 c2NyaXB0Pgp2YXIgaW1nID0gbmV3IEltYWdlKCkKaW1nLm9ubG9hZCA9IGZ1bmN0aW9uKCl7CiAg dmFyIGMgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbXlDYW52YXMnKQogIHZhciBjdHggPSBj LmdldENvbnRleHQoJzJkJykKICBjdHguc2F2ZSgpCiAgICB2YXIgcCA9IGN0eC5jcmVhdGVQYXR0 ZXJuKHRoaXMsICduby1yZXBlYXQnKQogICAgY3R4LmZpbGxTdHlsZSA9IHAKICAgIGN0eC5maWxs UmVjdCgwLCAwLCAyMTUsIDE3NCkKICBjdHgucmVzdG9yZSgpCiAgCiAgY3R4LnNhdmUoKQogICAg cCA9IGN0eC5jcmVhdGVQYXR0ZXJuKHRoaXMsICduby1yZXBlYXQnKQogICAgY3R4LnRyYW5zbGF0 ZSgyMDAsIDApCiAgICBjdHgucm90YXRlKE1hdGguUEkvOCkKICAgIGN0eC5maWxsU3R5bGUgPSBw CiAgICBjdHguZmlsbFJlY3QoMCwwLCAyMTUsIDE3NCkKICBjdHgucmVzdG9yZSgpCgogIGMgPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnbXlDYW52YXMxJykKICBjdHggPSBjLmdldENvbnRleHQo JzJkJykKICBjdHguc2F2ZSgpCiAgICBwID0gY3R4LmNyZWF0ZVBhdHRlcm4odGhpcywgJ3JlcGVh dCcpCiAgICBjdHguZmlsbFN0eWxlID0gcAogICAgY3R4LmZpbGxSZWN0KDAsIDAsIDIxNSwgMTc0 KQogIGN0eC5yZXN0b3JlKCkKICAKICBjdHguc2F2ZSgpCiAgICBwID0gY3R4LmNyZWF0ZVBhdHRl cm4odGhpcywgJ3JlcGVhdCcpCiAgICBjdHgudHJhbnNsYXRlKDIwMCwgMCkKICAgIGN0eC5yb3Rh dGUoTWF0aC5QSS84KQogICAgY3R4LmZpbGxTdHlsZSA9IHAKICAgIGN0eC5maWxsUmVjdCgwLDAs IDIxNSwgMTc0KQogIGN0eC5yZXN0b3JlKCkKfQppbWcuc3JjID0gJ2h0dHA6Ly93ZWJraXQub3Jn L2ltYWdlcy9pY29uLWdvbGQucG5nJwo8L3NjcmlwdD4KPC9ib2R5PjwvaHRtbD4KCg== 19614 2008-03-08 22:24:47 -0800 2008-03-08 22:43:35 -0800 Fixeration! repeat-fix.patch text/plain 4980 oliver ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlMTlmMzA4Li5iZDBmZGM0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMDMt MDggT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgY2FzZSBmb3IgQnVnIDE2NTE2OiBjYW52 YXMgaW1hZ2UgcGF0dGVybnMgc3RvcCB3b3JraW5nIHdpdGggc29tZSB0cmFuc2Zvcm1hdGlvbnMK KworICAgICAgICAqIGZhc3QvY2FudmFzL2NhbnZhcy1wYXR0ZXJuLWJlaGF2aW91ci5qczoKKwog MjAwOC0wMy0wOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IE1pdHouCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52 YXMtcGF0dGVybi1iZWhhdmlvdXItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52 YXMvY2FudmFzLXBhdHRlcm4tYmVoYXZpb3VyLWV4cGVjdGVkLnR4dAppbmRleCA5NjdlYTg4Li44 MTgzZTMyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtcGF0dGVy bi1iZWhhdmlvdXItZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2Nh bnZhcy1wYXR0ZXJuLWJlaGF2aW91ci1leHBlY3RlZC50eHQKQEAgLTIyLDYgKzIyLDEwIEBAIFBB U1MgZ2V0UGl4ZWwoMSwxKSBpcyBbMCwxMjgsMCwyNTVdCiBQQVNTIGdldFBpeGVsKDk4LDEpIGlz IFswLDEyOCwwLDI1NV0KIFBBU1MgZ2V0UGl4ZWwoMSw0OCkgaXMgWzAsMTI4LDAsMjU1XQogUEFT UyBnZXRQaXhlbCg5OCw0OCkgaXMgWzAsMTI4LDAsMjU1XQorUEFTUyBnZXRQaXhlbCgxLDEpIGlz IFswLDEyOCwwLDI1NV0KK1BBU1MgZ2V0UGl4ZWwoOTgsMSkgaXMgWzAsMTI4LDAsMjU1XQorUEFT UyBnZXRQaXhlbCgxLDQ4KSBpcyBbMCwxMjgsMCwyNTVdCitQQVNTIGdldFBpeGVsKDk4LDQ4KSBp cyBbMCwxMjgsMCwyNTVdCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1Qg Q09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1wYXR0 ZXJuLWJlaGF2aW91ci5qcyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL2NhbnZhcy1wYXR0ZXJu LWJlaGF2aW91ci5qcwppbmRleCBhMThlMDA0Li5lZmE2ZGU5IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9mYXN0L2NhbnZhcy9jYW52YXMtcGF0dGVybi1iZWhhdmlvdXIuanMKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9jYW52YXMvY2FudmFzLXBhdHRlcm4tYmVoYXZpb3VyLmpzCkBAIC0xOCwxMiAr MTgsMTkgQEAgZnVuY3Rpb24gcGl4ZWxTaG91bGRCZSh4LCB5LCBjb2xvdXIpIHsKICAgICBzaG91 bGRCZSgiZ2V0UGl4ZWwoIiArIFt4LCB5XSArIikiLCAiWyIrY29sb3VyKyJdIik7CiB9CiAKLXZh ciBncmVlbjF4MSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImNhbnZhcyIpOwotZ3JlZW4xeDEu d2lkdGggPSAxOwotZ3JlZW4xeDEuaGVpZ2h0ID0gMTsKLXZhciBjb250ZXh0ID0gZ3JlZW4xeDEu Z2V0Q29udGV4dCgiMmQiKTsKLWNvbnRleHQuZmlsbFN0eWxlID0gImdyZWVuIjsKLWNvbnRleHQu ZmlsbFJlY3QoMCwwLDEsMSk7CitmdW5jdGlvbiBjcmVhdGVDYW52YXNJbWFnZSh3aWR0aCwgaGVp Z2h0LCBjb2xvdXIpIHsKKyAgICB2YXIgYyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImNhbnZh cyIpOworICAgIGMud2lkdGggPSB3aWR0aDsKKyAgICBjLmhlaWdodCA9IGhlaWdodDsKKyAgICB2 YXIgY29udGV4dCA9IGMuZ2V0Q29udGV4dCgiMmQiKTsKKyAgICBjb250ZXh0LmZpbGxTdHlsZSA9 IGNvbG91cjsKKyAgICBjb250ZXh0LmZpbGxSZWN0KDAsMCx3aWR0aCxoZWlnaHQpOworICAgIHJl dHVybiBjOworfQorCisKK3ZhciBncmVlbjF4MSA9IGNyZWF0ZUNhbnZhc0ltYWdlKDEsIDEsICJn cmVlbiIpOwordmFyIGdyZWVuMTAweDUwID0gY3JlYXRlQ2FudmFzSW1hZ2UoMTAwLCA1MCwgImdy ZWVuIik7CiAKIHZhciBjYW52YXMgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJjYW52YXMiKTsK IGNhbnZhcy53aWR0aCA9IDEwMDsKQEAgLTk2LDYgKzEwMywxOCBAQCB2YXIgdGVzdHMgPSBbCiAg ICAgICAgIHBpeGVsU2hvdWxkQmUoMSwgIDQ4LCBbMCwxMjgsMCwyNTVdKTsKICAgICAgICAgcGl4 ZWxTaG91bGRCZSg5OCwgNDgsIFswLDEyOCwwLDI1NV0pOwogICAgIH0sCisgICAgZnVuY3Rpb24g KCkgeworICAgICAgICBjb250ZXh0LmZpbGxTdHlsZSA9ICJncmVlbiI7CisgICAgICAgIGNvbnRl eHQuZmlsbFJlY3QoMCwgMCwgNTAsIDUwKTsKKyAgICAgICAgdmFyIHBhdHRlcm4gPSBjb250ZXh0 LmNyZWF0ZVBhdHRlcm4oZ3JlZW4xMDB4NTAsICJuby1yZXBlYXQiKTsKKyAgICAgICAgY29udGV4 dC5maWxsU3R5bGUgPSBwYXR0ZXJuOworICAgICAgICBjb250ZXh0LnRyYW5zbGF0ZSg1MCwgMCk7 CisgICAgICAgIGNvbnRleHQuZmlsbFJlY3QoLTUwLCAwLCAxMDAsIDUwKTsKKyAgICAgICAgcGl4 ZWxTaG91bGRCZSgxLCAgIDEsIFswLDEyOCwwLDI1NV0pOworICAgICAgICBwaXhlbFNob3VsZEJl KDk4LCAgMSwgWzAsMTI4LDAsMjU1XSk7CisgICAgICAgIHBpeGVsU2hvdWxkQmUoMSwgIDQ4LCBb MCwxMjgsMCwyNTVdKTsKKyAgICAgICAgcGl4ZWxTaG91bGRCZSg5OCwgNDgsIFswLDEyOCwwLDI1 NV0pOworICAgIH0sCiBdOwogZm9yICh2YXIgaSA9IDA7IGkgPCB0ZXN0cy5sZW5ndGg7IGkrKykg ewogICAgIGNvbnRleHQuZmlsbFN0eWxlPSJyZWQiOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFu Z2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMWQ2MjQ1Li43Mzg5NGVhIDEwMDY0NAot LS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDA4LTAzLTA4IE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMTY1MTY6IGNh bnZhcyBpbWFnZSBwYXR0ZXJucyBzdG9wIHdvcmtpbmcgd2l0aCBzb21lIHRyYW5zZm9ybWF0aW9u cworCisgICAgICAgIFNpbXBsZSBmaXguICBXZSB1c2VkIHgveVN0ZXAgb2YgRkxUX01BWCB0byBm YWtlIGEgbm8tcmVwZWF0LXgveSBwYXR0ZXJuCisgICAgICAgIHdpdGggQ0cuICBIb3dldmVyIGFu eSB0cmFuc2Zvcm1zIGludm9sdmluZyBGTFRfTUFYIGltbWVkaWF0ZWx5IGdldAorICAgICAgICBj b25zdW1lZCBieSB0aGUgaW50cm9kdWNlZCBmbG9hdGluZyBwb2ludCBlcnJvci4gIHlTdGVwIGhh ZCBhbHJlYWR5IGJlZW4KKyAgICAgICAgY2xhbXBlZCB0byBhIG11Y2ggc21hbGxlciBhcmJpdHJh cnkgdmFsdWUsIGFuZCB0aGlzIHBhdGNoIG1ha2VzIHVzIHVzZQorICAgICAgICB0aGF0IGNsYW1w IHZhbHVlIGZvciB4U3RlcCBhcyB3ZWxsLgorCisgICAgICAgICogaHRtbC9DYW52YXNQYXR0ZXJu LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1BhdHRlcm46OmNyZWF0ZVBhdHRlcm4pOgor CiAyMDA4LTAzLTA4ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTWl0ei4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9DYW52YXNQYXR0ZXJu LmNwcCBiL1dlYkNvcmUvaHRtbC9DYW52YXNQYXR0ZXJuLmNwcAppbmRleCAyY2RhOTE3Li5jZDk2 MzNiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvQ2FudmFzUGF0dGVybi5jcHAKKysrIGIvV2Vi Q29yZS9odG1sL0NhbnZhc1BhdHRlcm4uY3BwCkBAIC0xNzEsMTMgKzE3MSwxMyBAQCBDR1BhdHRl cm5SZWYgQ2FudmFzUGF0dGVybjo6Y3JlYXRlUGF0dGVybihjb25zdCBDR0FmZmluZVRyYW5zZm9y bSYgdHJhbnNmb3JtKQogCiAgICAgQ0dBZmZpbmVUcmFuc2Zvcm0gcGF0dGVyblRyYW5zZm9ybSA9 CiAgICAgICAgIENHQWZmaW5lVHJhbnNmb3JtVHJhbnNsYXRlKENHQWZmaW5lVHJhbnNmb3JtU2Nh bGUodHJhbnNmb3JtLCAxLCAtMSksIDAsIC1yZWN0LnNpemUuaGVpZ2h0KTsKLQotICAgIGZsb2F0 IHhTdGVwID0gbV9yZXBlYXRYID8gcmVjdC5zaXplLndpZHRoIDogRkxUX01BWDsKLSAgICAvLyBJ ZiBGTFRfTUFYIHNob3VsZCBhbHNvIGJlIHVzZWQgZm9yIHlTdGVwLCBub3RoaW5nIGlzIHJlbmRl cmVkLiBVc2luZyBmcmFjdGlvbnMgb2YgRkxUX01BWCBhbHNvCi0gICAgLy8gcmVzdWx0IGluIG5v dGhpbmcgYmVpbmcgcmVuZGVyZWQuIFRoaXMgaXMgbm90IGEgcHJvYmxlbSB3aXRoIHhTdGVwLgor ICAgIAorICAgIC8vIElmIEZMVF9NQVggc2hvdWxkIGFsc28gYmUgdXNlZCBmb3IgeFN0ZXAgb3Ig eVN0ZXAsIG5vdGhpbmcgaXMgcmVuZGVyZWQuIFVzaW5nIGZyYWN0aW9ucyBvZiBGTFRfTUFYIGFs c28KKyAgICAvLyByZXN1bHQgaW4gbm90aGluZyBiZWluZyByZW5kZXJlZC4KICAgICAvLyBJTlRf TUFYIGlzIGFsbW9zdCBjb3JyZWN0LCBidXQgdGhlcmUgc2VlbXMgdG8gYmUgc29tZSBudW1iZXIg d3JhcHBpbmcgb2NjdXJpbmcgbWFraW5nIHRoZSBmaWxsCiAgICAgLy8gcGF0dGVybiBpcyBub3Qg ZmlsbGVkIGNvcnJlY3RseS4gCiAgICAgLy8gU28sIGp1c3QgcGljayBhIHJlYWxseSBsYXJnZSBu dW1iZXIgdGhhdCB3b3Jrcy4gCisgICAgZmxvYXQgeFN0ZXAgPSBtX3JlcGVhdFggPyByZWN0LnNp emUud2lkdGggOiAoMTAwMDAwMDAwLjBmKTsKICAgICBmbG9hdCB5U3RlcCA9IG1fcmVwZWF0WSA/ IHJlY3Quc2l6ZS5oZWlnaHQgOiAoMTAwMDAwMDAwLjBmKTsKIAogICAgIGNvbnN0IENHUGF0dGVy bkNhbGxiYWNrcyBwYXR0ZXJuQ2FsbGJhY2tzID0geyAwLCBwYXR0ZXJuQ2FsbGJhY2ssIHBhdHRl cm5SZWxlYXNlQ2FsbGJhY2sgfTsK