165148 2016-11-29 10:53:53 -0800 Can't download move.simple.com direct deposit transition PDF: Non user-triggered activations of anchors that have a download attribute are ignored 2016-11-29 14:38:47 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ap bfulgham cdumez commit-queue darin dbates esprehn+autocc gyuyoung.kim rniwa thorton webkit-bug-importer oldest_to_newest 1254333 0 cdumez 2016-11-29 10:53:53 -0800 Can't download move.simple.com direct deposit transition PDF: [Warning] Non user-triggered activations of anchors that have a download attribute are ignored. (app-7d2adbd6a086ab6b1d3f.js, line 65) We are stricter than other browsers as they allow synthetic clicks and it causes compatibility issues. 1254334 1 cdumez 2016-11-29 10:54:12 -0800 <rdar://problem/29421771> 1254415 2 295625 cdumez 2016-11-29 13:10:10 -0800 Created attachment 295625 Patch 1254453 3 295625 dbates 2016-11-29 13:59:52 -0800 Comment on attachment 295625 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295625&action=review r=me > Source/WebCore/ChangeLog:10 > + We were ignoring non user-triggered activations of anchors that have a > + download attribute which is stricter than Chrome and Firefox and breaks Our current behavior conforms to the HTML spec. Have you filed an issue to change the spec? (I haven't checked yet). Unless the spec will be changed before this patch is landed I suggest that we explicitly mention that we are making this change against the spec (citing the date of the spec) for compatibility to match the behavior in the aforementioned other browsers and provide a URL to the WHATWG issue that we filed (or an existing one) to change the spec to align to the behavior we want to adopt. 1254459 4 cdumez 2016-11-29 14:07:09 -0800 Filed <https://github.com/whatwg/html/issues/2116> against the spec. 1254460 5 cdumez 2016-11-29 14:09:20 -0800 (In reply to comment #4) > Filed <https://github.com/whatwg/html/issues/2116> against the spec. I am uncertain about the benefit of adding a comment especially because it will likely be outdated soon. 1254480 6 cdumez 2016-11-29 14:38:47 -0800 Committed r209091: <http://trac.webkit.org/changeset/209091> 295625 2016-11-29 13:10:10 -0800 2016-11-29 13:59:52 -0800 Patch bug-165148-20161129130945.patch text/plain 5651 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWU3NGYwZGUyZDNmZTI0 ZGUyZGZiZjk4MmQ2MjYxNzYxM2ExZmJjZi4uZjE4MmQ4ZjlmNzlmZWYyMmIyNmRjNWJhNGI3MDhh ZmNlM2E4MjY4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTExLTI5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FuJ3QgZG93bmxvYWQgbW92 ZS5zaW1wbGUuY29tIGRpcmVjdCBkZXBvc2l0IHRyYW5zaXRpb24gUERGOiBOb24gdXNlci10cmln Z2VyZWQgYWN0aXZhdGlvbnMgb2YgYW5jaG9ycyB0aGF0IGhhdmUgYSBkb3dubG9hZCBhdHRyaWJ1 dGUgYXJlIGlnbm9yZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2NTE0OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjk0MjE3NzE+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugd2VyZSBpZ25vcmlu ZyBub24gdXNlci10cmlnZ2VyZWQgYWN0aXZhdGlvbnMgb2YgYW5jaG9ycyB0aGF0IGhhdmUgYQor ICAgICAgICBkb3dubG9hZCBhdHRyaWJ1dGUgd2hpY2ggaXMgc3RyaWN0ZXIgdGhhbiBDaHJvbWUg YW5kIEZpcmVmb3ggYW5kIGJyZWFrcworICAgICAgICBkb3dubG9hZHMgb24gbW92ZS5zaW1wbGUu Y29tLiBUaGlzIHBhdGNoIHJlbGF4ZXMgb3VyIHBvbGljeSB0byBhbGxvdworICAgICAgICBzaW11 bGF0ZWQgY2xpY2tzIG9uIHN1Y2ggbGlua3MsIHNpbWlsYXJseSB0byBvdGhlciBicm93c2Vycy4K KworICAgICAgICBXZWIgYXV0aG9ycyBjYW4gYW55d2F5IGFscmVhZHkgdHJpZ2dlciBkb3dubG9h ZHMgdXNpbmcgc2NyaXB0IGJ5IHNldHRpbmcKKyAgICAgICAgd2luZG93LmxvY2F0aW9uIHRvIGEg c3BlY2lmaWMgVVJMIGFuZCBzZXJ2aW5nIHRvIHJpZ2h0IEhUVFAgaGVhZGVycyB0bworICAgICAg ICB0cmlnZ2VyIGEgZG93bmxvYWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB1cGRhdGVkIGV4 aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBodG1sL0hUTUxBbmNob3JFbGVtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkhUTUxBbmNob3JFbGVtZW50OjpoYW5kbGVDbGljayk6CisKIDIwMTYt MTEtMjkgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgW0NTUyBQYXJz ZXJdIEZpeCBwYXJzaW5nIG9mICJhbGwiIGluIHRyYW5zaXRpb25zCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxBbmNob3JFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTEFuY2hvckVsZW1lbnQuY3BwCmluZGV4IGM0ODUzNjdlMDU0NzAxYzgwMjViY2U2ZGRm MjA1ODlkOWY2ZTUyZTUuLjc0ZmQzY2Q3ZWY0MzE1NmI2MGRkNTQ5YjA3ZDQwODc1NDQxYWZhYzUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuY3BwCkBAIC0zODMsMTQg KzM4Myw2IEBAIHZvaWQgSFRNTEFuY2hvckVsZW1lbnQ6OmhhbmRsZUNsaWNrKEV2ZW50JiBldmVu dCkKICAgICAgICAgICAgIGRvd25sb2FkQXR0cmlidXRlID0gYXR0cmlidXRlV2l0aG91dFN5bmNo cm9uaXphdGlvbihkb3dubG9hZEF0dHIpOwogICAgICAgICBlbHNlIGlmIChoYXNBdHRyaWJ1dGVX aXRob3V0U3luY2hyb25pemF0aW9uKGRvd25sb2FkQXR0cikpCiAgICAgICAgICAgICBkb2N1bWVu dCgpLmFkZENvbnNvbGVNZXNzYWdlKE1lc3NhZ2VTb3VyY2U6OlNlY3VyaXR5LCBNZXNzYWdlTGV2 ZWw6Oldhcm5pbmcsICJUaGUgZG93bmxvYWQgYXR0cmlidXRlIG9uIGFuY2hvciB3YXMgaWdub3Jl ZCBiZWNhdXNlIGl0cyBocmVmIFVSTCBoYXMgYSBkaWZmZXJlbnQgc2VjdXJpdHkgb3JpZ2luLiIp OwotICAgICAgICAvLyBJZiB0aGUgYSBlbGVtZW50IGhhcyBhIGRvd25sb2FkIGF0dHJpYnV0ZSBh bmQgdGhlIGFsZ29yaXRobSBpcyBub3QgdHJpZ2dlcmVkIGJ5IHVzZXIgYWN0aXZhdGlvbgotICAg ICAgICAvLyB0aGVuIGFib3J0IHRoZXNlIHN0ZXBzLgotICAgICAgICAvLyBodHRwczovL2h0bWwu c3BlYy53aGF0d2cub3JnLyN0aGUtYS1lbGVtZW50OnRyaWdnZXJlZC1ieS11c2VyLWFjdGl2YXRp b24KLSAgICAgICAgaWYgKCFkb3dubG9hZEF0dHJpYnV0ZS5pc051bGwoKSAmJiAhZXZlbnQuaXNU cnVzdGVkKCkgJiYgIVNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzdHVyZSgpKSB7 Ci0gICAgICAgICAgICAvLyBUaGUgc3BlY2lmaWNhdGlvbiBzYXlzIHRvIHRocm93IGFuIEludmFs aWRBY2Nlc3NFcnJvciBidXQgb3RoZXIgYnJvd3NlcnMgZG8gbm90LgotICAgICAgICAgICAgZG9j dW1lbnQoKS5hZGRDb25zb2xlTWVzc2FnZShNZXNzYWdlU291cmNlOjpTZWN1cml0eSwgTWVzc2Fn ZUxldmVsOjpXYXJuaW5nLCAiTm9uIHVzZXItdHJpZ2dlcmVkIGFjdGl2YXRpb25zIG9mIGFuY2hv cnMgdGhhdCBoYXZlIGEgZG93bmxvYWQgYXR0cmlidXRlIGFyZSBpZ25vcmVkLiIpOwotICAgICAg ICAgICAgcmV0dXJuOwotICAgICAgICB9CiAgICAgfQogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjODIyYjlj YTg0MzVkYjVhNjY0OGRjN2Y5NTI1Y2I0OWE3YTMwZGQ5Li41N2Q4MzBhY2ZlMmEzNDQ5NTg5ZTdl ZjFkMzBiMjA2YTg3ZDE3NDBkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMTEtMjkgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBDYW4ndCBkb3dubG9hZCBt b3ZlLnNpbXBsZS5jb20gZGlyZWN0IGRlcG9zaXQgdHJhbnNpdGlvbiBQREY6IE5vbiB1c2VyLXRy aWdnZXJlZCBhY3RpdmF0aW9ucyBvZiBhbmNob3JzIHRoYXQgaGF2ZSBhIGRvd25sb2FkIGF0dHJp YnV0ZSBhcmUgaWdub3JlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY1MTQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTQyMTc3MT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgZXhpc3Rp bmcgdGVzdCB0byByZWZsZWN0IGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGZhc3QvZG9t L0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1kb3dubG9hZC1zeW50aGV0aWMtY2xpY2stZXhwZWN0 ZWQudHh0OgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1kb3du bG9hZC1zeW50aGV0aWMtY2xpY2suaHRtbDoKKwogMjAxNi0xMS0yOSAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBTY3JvbGwgc25hcHBpbmcgb24gTWFj IHNob3VsZCB1c2UgQXBwS2l0IGFuaW1hdGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1kb3dubG9hZC1zeW50aGV0aWMtY2xpY2st ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5j aG9yLWRvd25sb2FkLXN5bnRoZXRpYy1jbGljay1leHBlY3RlZC50eHQKaW5kZXggMTJhNjUxMjc4 NTI2OGYxZDQxMzRmNDBjZThjNTljMGM0MzhkMmRmZS4uMzVlNzE3OWY5MDk3MTJkMzk0M2UxNzU3 MTUwM2M4NTQ1M2UxMTFmYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFu Y2hvckVsZW1lbnQvYW5jaG9yLWRvd25sb2FkLXN5bnRoZXRpYy1jbGljay1leHBlY3RlZC50eHQK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWRvd25s b2FkLXN5bnRoZXRpYy1jbGljay1leHBlY3RlZC50eHQKQEAgLTEsNiArMSw4IEBACi1DT05TT0xF IE1FU1NBR0U6IGxpbmUgMjI6IE5vbiB1c2VyLXRyaWdnZXJlZCBhY3RpdmF0aW9ucyBvZiBhbmNo b3JzIHRoYXQgaGF2ZSBhIGRvd25sb2FkIGF0dHJpYnV0ZSBhcmUgaWdub3JlZC4KLVRlc3QgdGhh dCBzeW50aGV0aWMgY2xpY2tzIG9uIGFuIGFuY2hvciB3aXRoIGEgZG93bmxvYWQgYXR0cmlidXRl IGFyZSBpZ25vcmVkLgorRG93bmxvYWQgc3RhcnRlZC4KK0Rvd25sb2FkaW5nIFVSTCB3aXRoIHN1 Z2dlc3RlZCBmaWxlbmFtZSAiZm9vLnBkZiIKK0Rvd25sb2FkIGNvbXBsZXRlZC4KK1Rlc3QgdGhh dCBzeW50aGV0aWMgY2xpY2tzIG9uIGFuIGFuY2hvciB3aXRoIGEgZG93bmxvYWQgYXR0cmlidXRl IGFyZSBub3QgaWdub3JlZC4KIAotVGhpcyB0ZXN0IHBhc3NlcyBpZiB5b3UgZG8gbm90IHNlZSBh bnkgJ0Rvd25sb2FkIHN0YXJ0ZWQnIG1lc3NhZ2UgYWJvdmUuCitUaGlzIHRlc3QgcGFzc2VzIGlm IHlvdSBzZWUgYSAnRG93bmxvYWQgc3RhcnRlZCcgbWVzc2FnZSBhYm92ZSBhbmQgaWYgdGhlIHN1 Z2dlc3RlZCBmaWxlbmFtZSBpcyBmb28ucGRmLgogCiBCbG9iIFVSTApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWRvd25sb2FkLXN5bnRo ZXRpYy1jbGljay5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQv YW5jaG9yLWRvd25sb2FkLXN5bnRoZXRpYy1jbGljay5odG1sCmluZGV4IDQ0NWRiZGJhNmJkZGM3 Y2Q1ODZmMjM2NmYxOTExZTBkOWUyYzEyMDYuLmFjMTA1NmZjY2I1NWMxNzlmOThkNmM0NWQxMWFj NTAxYjgwZTk1MzIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JF bGVtZW50L2FuY2hvci1kb3dubG9hZC1zeW50aGV0aWMtY2xpY2suaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItZG93bmxvYWQtc3ludGhldGlj LWNsaWNrLmh0bWwKQEAgLTksOSArOSw5IEBAIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgewogPC9z Y3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keT4KLTxwPlRlc3QgdGhhdCBzeW50aGV0aWMgY2xpY2tzIG9u IGFuIGFuY2hvciB3aXRoIGEgZG93bmxvYWQgYXR0cmlidXRlIGFyZSBpZ25vcmVkLjwvcD4KLTxw PiBUaGlzIHRlc3QgcGFzc2VzIGlmIHlvdSBkbyBub3Qgc2VlIGFueSAnRG93bmxvYWQgc3RhcnRl ZCcgbWVzc2FnZSBhYm92ZS48L3A+Ci08YSBpZD0iYmxvYi11cmwiIGRvd25sb2FkPkJsb2IgVVJM PC9hPgorPHA+VGVzdCB0aGF0IHN5bnRoZXRpYyBjbGlja3Mgb24gYW4gYW5jaG9yIHdpdGggYSBk b3dubG9hZCBhdHRyaWJ1dGUgYXJlIG5vdCBpZ25vcmVkLjwvcD4KKzxwPiBUaGlzIHRlc3QgcGFz c2VzIGlmIHlvdSBzZWUgYSAnRG93bmxvYWQgc3RhcnRlZCcgbWVzc2FnZSBhYm92ZSBhbmQgaWYg dGhlIHN1Z2dlc3RlZCBmaWxlbmFtZSBpcyBmb28ucGRmLjwvcD4KKzxhIGlkPSJibG9iLXVybCIg ZG93bmxvYWQ9ImZvby5wZGYiPkJsb2IgVVJMPC9hPgogPHNjcmlwdD4KIGZ1bmN0aW9uIHJ1blRl c3QoKQogewo=