165141 2016-11-29 08:35:56 -0800 [WebRTC][OpenWebRTC] Temporary device selection support 2016-11-30 00:37:29 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned alex pnormand oldest_to_newest 1254273 0 pnormand 2016-11-29 08:35:56 -0800 Meanwhile the CaptureDeviceManager isn't implemented yet we can have a temporary solution using env vars. 1254275 1 295598 pnormand 2016-11-29 08:39:31 -0800 Created attachment 295598 patch 1254280 2 295598 alex 2016-11-29 08:46:23 -0800 Comment on attachment 295598 patch LGTM 1254720 3 pnormand 2016-11-30 00:37:29 -0800 Committed r209125: <http://trac.webkit.org/changeset/209125> 295598 2016-11-29 08:39:31 -0800 2016-11-29 08:46:23 -0800 patch patch.patch text/plain 3810 pnormand RnJvbSBjOWQ0NmNlZGQyNTkyNGIzZjY5ZDliMDIxM2FkYjVkNTJjYzgwMTQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDI5IE5vdiAyMDE2IDE3OjM4OjQ1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAxNiArKysrKysrKysrCiAuLi4vZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lck93ci5jcHAgICB8IDM2ICsrKysrKysrKysrKysrKystLS0tLS0KIDIgZmlsZXMgY2hh bmdlZCwgNDIgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGNk YTcxYTIuLjM5N2IwMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNi0xMS0yOSAg UGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dlYlJU Q11bT3BlbldlYlJUQ10gVGVtcG9yYXJ5IGRldmljZSBzZWxlY3Rpb24gc3VwcG9ydAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MTQxCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHRoZSBw bGF5ZXIgaGFuZGxlcyBvbmx5IG9uZSBhdWRpbyBhbmQgdmlkZW8gdHJhY2sgYXQKKyAgICAgICAg bW9zdCBmb3Igbm93LiBUaGUgZGV2aWNlIGNob2ljZSBjYW4gYmUgaW5mbHVlbmNlZCB3aXRoIHRo ZQorICAgICAgICBXRUJLSVRfVklERU9fREVWSUNFIGFuZCBXRUJLSVRfQVVESU9fREVWSUNFIGVu dmlyb25tZW50IHZhcmlhYmxlcy4KKyAgICAgICAgRWFjaCB2YXJpYWJsZSBvcHRpb25hbGx5IGhv bGRzIHRoZSBuYW1lIG9mIHRoZSBkZXZpY2UgdG8gdXNlLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJPd3I6OnBsYXkpOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyOjpsb2FkKToK KwogMjAxNi0xMS0yOSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAog ICAgICAgICBTY3JvbGwgc25hcHBpbmcgb24gTWFjIHNob3VsZCB1c2UgQXBwS2l0IGFuaW1hdGlv bnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJPd3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5j cHAKaW5kZXggYmVmMmEyYi4uM2YwMGU4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5jcHAKQEAgLTczLDE0ICs3MywxMSBAQCB2b2lkIE1l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93cjo6cGxheSgpCiAKICAgICBHU1RfREVCVUcoIkNv bm5lY3RpbmcgdG8gbGl2ZSBzdHJlYW0sIGRlc2NyaXB0b3I6ICVwIiwgbV9zdHJlYW1Qcml2YXRl LmdldCgpKTsKIAotICAgIGZvciAoYXV0byB0cmFjayA6IG1fc3RyZWFtUHJpdmF0ZS0+dHJhY2tz KCkpIHsKLSAgICAgICAgaWYgKCF0cmFjay0+ZW5hYmxlZCgpKSB7Ci0gICAgICAgICAgICBHU1Rf REVCVUcoIlRyYWNrICVzIGRpc2FibGVkIiwgdHJhY2stPmxhYmVsKCkuYXNjaWkoKS5kYXRhKCkp OwotICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIH0KKyAgICBpZiAobV92aWRlb1RyYWNr KQorICAgICAgICBtYXliZUhhbmRsZUNoYW5nZU11dGVkU3RhdGUoKm1fdmlkZW9UcmFjay5nZXQo KSk7CiAKLSAgICAgICAgbWF5YmVIYW5kbGVDaGFuZ2VNdXRlZFN0YXRlKCp0cmFjayk7Ci0gICAg fQorICAgIGlmIChtX2F1ZGlvVHJhY2spCisgICAgICAgIG1heWJlSGFuZGxlQ2hhbmdlTXV0ZWRT dGF0ZSgqbV9hdWRpb1RyYWNrLmdldCgpKTsKIH0KIAogdm9pZCBNZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXJPd3I6OnBhdXNlKCkKQEAgLTE5MiwxOCArMTg5LDM3IEBAIHZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyT3dyOjpsb2FkKE1lZGlhU3RyZWFtUHJpdmF0ZSYgc3RyZWFtUHJp dmF0ZSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICB9CiAKLSAgICAgICAgdHJhY2st PmFkZE9ic2VydmVyKCp0aGlzKTsKKyAgICAgICAgR1NUX0RFQlVHKCJQcm9jZXNzaW5nIHRyYWNr ICVzIiwgdHJhY2stPmxhYmVsKCkuYXNjaWkoKS5kYXRhKCkpOworCisgICAgICAgIGJvb2wgb2Jz ZXJ2ZVRyYWNrID0gZmFsc2U7CisKKyAgICAgICAgLy8gVE9ETzogU3VwcG9ydCBmb3IgbXVsdGlw bGUgdHJhY2tzIG9mIHRoZSBzYW1lIHR5cGUuCiAKICAgICAgICAgc3dpdGNoICh0cmFjay0+dHlw ZSgpKSB7CiAgICAgICAgIGNhc2UgUmVhbHRpbWVNZWRpYVNvdXJjZTo6QXVkaW86Ci0gICAgICAg ICAgICBtX2F1ZGlvVHJhY2sgPSB0cmFjazsKKyAgICAgICAgICAgIGlmICghbV9hdWRpb1RyYWNr KSB7CisgICAgICAgICAgICAgICAgU3RyaW5nIHByZVNlbGVjdGVkRGV2aWNlID0gZ2V0ZW52KCJX RUJLSVRfQVVESU9fREVWSUNFIik7CisgICAgICAgICAgICAgICAgaWYgKCFwcmVTZWxlY3RlZERl dmljZSB8fCAocHJlU2VsZWN0ZWREZXZpY2UgPT0gdHJhY2stPmxhYmVsKCkpKSB7CisgICAgICAg ICAgICAgICAgICAgIG1fYXVkaW9UcmFjayA9IHRyYWNrOworICAgICAgICAgICAgICAgICAgICBv YnNlcnZlVHJhY2sgPSB0cnVlOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIFJlYWx0aW1lTWVkaWFTb3VyY2U6OlZpZGVv OgotICAgICAgICAgICAgbV92aWRlb1RyYWNrID0gdHJhY2s7CisgICAgICAgICAgICBpZiAoIW1f dmlkZW9UcmFjaykgeworICAgICAgICAgICAgICAgIFN0cmluZyBwcmVTZWxlY3RlZERldmljZSA9 IGdldGVudigiV0VCS0lUX1ZJREVPX0RFVklDRSIpOworICAgICAgICAgICAgICAgIGlmICghcHJl U2VsZWN0ZWREZXZpY2UgfHwgKHByZVNlbGVjdGVkRGV2aWNlID09IHRyYWNrLT5sYWJlbCgpKSkg eworICAgICAgICAgICAgICAgICAgICBtX3ZpZGVvVHJhY2sgPSB0cmFjazsKKyAgICAgICAgICAg ICAgICAgICAgb2JzZXJ2ZVRyYWNrID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAg ICAgICB9CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBSZWFsdGltZU1lZGlhU291 cmNlOjpOb25lOgogICAgICAgICAgICAgR1NUX1dBUk5JTkcoIkxvYWRpbmcgYSB0cmFjayB3aXRo IE5vbmUgdHlwZSIpOwogICAgICAgICB9CisKKyAgICAgICAgaWYgKG9ic2VydmVUcmFjaykKKyAg ICAgICAgICAgIHRyYWNrLT5hZGRPYnNlcnZlcigqdGhpcyk7CiAgICAgfQogCiAgICAgbV9yZWFk eVN0YXRlID0gTWVkaWFQbGF5ZXI6OkhhdmVFbm91Z2hEYXRhOwotLSAKMi4xMC4y