165140 2016-11-29 07:40:16 -0800 [Win] Skip failing JSC tests. 2016-12-01 01:39:38 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham lforschler mark.lam oldest_to_newest 1254265 0 pvollan 2016-11-29 07:40:16 -0800 Some JSC stress tests are failing on Windows. 1254266 1 295595 pvollan 2016-11-29 07:43:50 -0800 Created attachment 295595 Patch 1254307 2 achristensen 2016-11-29 09:52:05 -0800 Is there a reason they're failing and cannot be fixed? 1254308 3 mark.lam 2016-11-29 09:52:54 -0800 (In reply to comment #2) > Is there a reason they're failing and cannot be fixed? At minimum, can you add a FIXME with a bug url to fix later / soon? 1254756 4 pvollan 2016-11-30 07:26:05 -0800 (In reply to comment #3) > (In reply to comment #2) > > Is there a reason they're failing and cannot be fixed? I believe the tests toLocaleString.js and toLocaleStringBasics.js will be fixed when we reenable INTL on Windows. The two other failures should be investigated. > > At minimum, can you add a FIXME with a bug url to fix later / soon? I will update the patch. Thanks for reviewing :) 1254757 5 295715 pvollan 2016-11-30 07:27:54 -0800 Created attachment 295715 Patch 1254788 6 295715 mark.lam 2016-11-30 09:20:21 -0800 Comment on attachment 295715 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295715&action=review r=me. Please add bug url for re-enabling INTL on Windows. > JSTests/ChakraCore.yaml:78 > + # FIXME: unskip the following test on Windows when INTL is reenabled. You should have a bug url for re-enabling INTL on Windows too. > JSTests/ChakraCore.yaml:975 > + # FIXME: unskip the following test on Windows when INTL is reenabled. Ditto. 1255192 7 pvollan 2016-12-01 01:39:38 -0800 Committed r209178: <http://trac.webkit.org/changeset/209178> 295595 2016-11-29 07:43:50 -0800 2016-11-30 07:27:48 -0800 Patch bug-165140-20161129074336.patch text/plain 2965 pvollan SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDkwNjcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTExLTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFw cGxlLmNvbT4KKworICAgICAgICBbV2luXSBTa2lwIGZhaWxpbmcgSlNDIHRlc3RzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MTQwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDaGFrcmFDb3JlLnlh bWw6CisgICAgICAgICogbWljcm9iZW5jaG1hcmtzL3Rhbi5qczoKKwogMjAxNi0xMS0yMSAgWXVz dWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWlsLmNvbT4KIAogICAgICAgICBDcmFzaCBpbiBj b20uYXBwbGUuSmF2YVNjcmlwdENvcmU6IFdURjo6VGhyZWFkU3BlY2lmaWM8V1RGOjpXVEZUaHJl YWREYXRhLCArIDE0MgpJbmRleDogSlNUZXN0cy9DaGFrcmFDb3JlLnlhbWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gSlNUZXN0cy9DaGFrcmFDb3JlLnlhbWwJKHJldmlzaW9uIDIwOTA2NikKKysrIEpTVGVzdHMv Q2hha3JhQ29yZS55YW1sCSh3b3JraW5nIGNvcHkpCkBAIC03Niw3ICs3NiwxMiBAQAogLSBwYXRo OiBDaGFrcmFDb3JlL3Rlc3QvQXJyYXkvdG9TdHJpbmcuanMKICAgY21kOiBydW5DaGFrcmEgOmJh c2VsaW5lLCAiTm9FeGNlcHRpb24iLCAidG9TdHJpbmcuYmFzZWxpbmUiLCBbXQogLSBwYXRoOiBD aGFrcmFDb3JlL3Rlc3QvQXJyYXkvdG9Mb2NhbGVTdHJpbmcuanMKLSAgY21kOiBydW5DaGFrcmEg OmJhc2VsaW5lLCAiTm9FeGNlcHRpb24iLCAidG9Mb2NhbGVTdHJpbmcuYmFzZWxpbmUtanNjIiwg W10KKyAgY21kOiB8CisgICAgICBpZiAoJGhvc3RPUyA9PSAid2luZG93cyIpCisgICAgICAgICAg c2tpcAorICAgICAgZWxzZQorICAgICAgICAgIHJ1bkNoYWtyYSA6YmFzZWxpbmUsICJOb0V4Y2Vw dGlvbiIsICJ0b0xvY2FsZVN0cmluZy5iYXNlbGluZS1qc2MiLCBbXQorICAgICAgZW5kCiAtIHBh dGg6IENoYWtyYUNvcmUvdGVzdC9BcnJheS9hcnJheV9zbGljZS5qcwogICBjbWQ6IHJ1bkNoYWty YSA6YmFzZWxpbmUsICJOb0V4Y2VwdGlvbiIsICJhcnJheV9zbGljZS5iYXNlbGluZSIsIFtdCiAt IHBhdGg6IENoYWtyYUNvcmUvdGVzdC9BcnJheS9hcnJheV9zbGljZTIuanMKQEAgLTQ4OCw3ICs0 OTMsMTIgQEAKIC0gcGF0aDogQ2hha3JhQ29yZS90ZXN0L0RhdGUvTWlsbGlzZWNvbmRUcnVuY2F0 aW9uQ2hlY2tBZnRlckNvcHlDb25zdHJ1Y3Rvci5qcwogICBjbWQ6IHJ1bkNoYWtyYSA6YmFzZWxp bmUsICJOb0V4Y2VwdGlvbiIsICJNaWxsaXNlY29uZFRydW5jYXRpb25DaGVja0FmdGVyQ29weUNv bnN0cnVjdG9yLmVzNi5iYXNlbGluZSIsIFtdCiAtIHBhdGg6IENoYWtyYUNvcmUvdGVzdC9EYXRl L2RhdGVfY2FjaGVfYnVnLmpzCi0gIGNtZDogcnVuQ2hha3JhIDpiYXNlbGluZSwgIk5vRXhjZXB0 aW9uIiwgImRhdGVfY2FjaGVfYnVnLmJhc2VsaW5lIiwgW10KKyAgY21kOiB8CisgICAgICBpZiAo JGhvc3RPUyA9PSAid2luZG93cyIpCisgICAgICAgICAgc2tpcAorICAgICAgZWxzZQorICAgICAg ICAgIHJ1bkNoYWtyYSA6YmFzZWxpbmUsICJOb0V4Y2VwdGlvbiIsICJkYXRlX2NhY2hlX2J1Zy5i YXNlbGluZSIsIFtdCisgICAgICBlbmQKIC0gcGF0aDogQ2hha3JhQ29yZS90ZXN0L0VIL2NhcHR1 cmUuanMKICAgY21kOiBydW5DaGFrcmEgOmJhc2VsaW5lLCAiTm9FeGNlcHRpb24iLCAiY2FwdHVy ZS5iYXNlbGluZSIsIFtdCiAtIHBhdGg6IENoYWtyYUNvcmUvdGVzdC9FSC9vb3MyLmpzCkBAIC05 NjEsNyArOTcxLDEyIEBACiAgICMgQmFkIHRlc3QsIGNoZWNrcyBoYXJkIGNvZGVkIGV4Y2VwdGlv bnMuCiAgIGNtZDogcnVuQ2hha3JhIDpza2lwLCAiTm9FeGNlcHRpb24iLCAiIiwgWyIuLi9Vbml0 VGVzdEZyYW1ld29yay9Vbml0VGVzdEZyYW1ld29yay5qcyJdCiAtIHBhdGg6IENoYWtyYUNvcmUv dGVzdC9PYmplY3QvdG9Mb2NhbGVTdHJpbmdCYXNpY3MuanMKLSAgY21kOiBydW5DaGFrcmEgOmJh c2VsaW5lLCAiTm9FeGNlcHRpb24iLCAidG9Mb2NhbGVTdHJpbmdCYXNpY3MuYmFzZWxpbmUiLCBb XQorICBjbWQ6IHwKKyAgICAgIGlmICgkaG9zdE9TID09ICJ3aW5kb3dzIikKKyAgICAgICAgICBz a2lwCisgICAgICBlbHNlCisgICAgICAgICAgcnVuQ2hha3JhIDpiYXNlbGluZSwgIk5vRXhjZXB0 aW9uIiwgInRvTG9jYWxlU3RyaW5nQmFzaWNzLmJhc2VsaW5lIiwgW10KKyAgICAgIGVuZAogLSBw YXRoOiBDaGFrcmFDb3JlL3Rlc3QvT2JqZWN0L3RvU3RyaW5nMS5qcwogICBjbWQ6IHJ1bkNoYWty YSA6YmFzZWxpbmUsICJOb0V4Y2VwdGlvbiIsICJ0b1N0cmluZzMuYmFzZWxpbmUiLCBbXQogLSBw YXRoOiBDaGFrcmFDb3JlL3Rlc3QvT2JqZWN0L3RvU3RyaW5nMi5qcwpJbmRleDogSlNUZXN0cy9t aWNyb2JlbmNobWFya3MvdGFuLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvbWljcm9iZW5jaG1h cmtzL3Rhbi5qcwkocmV2aXNpb24gMjA5MDY2KQorKysgSlNUZXN0cy9taWNyb2JlbmNobWFya3Mv dGFuLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNiBAQAotKGZ1bmN0aW9uKCkgeworLy9A IHNraXAgaWYgJGhvc3RPUyA9PSAid2luZG93cyIKKworKGZ1bmN0aW9uICgpIHsKICAgICBmb3Ig KHZhciBpID0gMDsgaSA8IDMwMDAwMDA7ICsraSkKICAgICAgICAgeCA9IE1hdGgudGFuKGkpOwog Cg== 295715 2016-11-30 07:27:54 -0800 2016-11-30 09:20:21 -0800 Patch bug-165140-20161130072740.patch text/plain 3450 pvollan SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDkxMjYpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE2LTExLTI5ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFw cGxlLmNvbT4KKworICAgICAgICBbV2luXSBTa2lwIGZhaWxpbmcgSlNDIHRlc3RzLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MTQwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDaGFrcmFDb3JlLnlh bWw6CisgICAgICAgICogbWljcm9iZW5jaG1hcmtzL3Rhbi5qczoKKwogMjAxNi0xMS0yOSAgSkYg QmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViQXNzZW1ibHkgSlMg QVBJOiBpbXByb3ZlIEluc3RhbmNlCkluZGV4OiBKU1Rlc3RzL0NoYWtyYUNvcmUueWFtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKU1Rlc3RzL0NoYWtyYUNvcmUueWFtbAkocmV2aXNpb24gMjA5MTI2KQorKysg SlNUZXN0cy9DaGFrcmFDb3JlLnlhbWwJKHdvcmtpbmcgY29weSkKQEAgLTc1LDggKzc1LDE0IEBA CiAgIGNtZDogcnVuQ2hha3JhIDpwYXNzLCAiTm9FeGNlcHRpb24iLCAic2hpZnRfdW5zaGlmdC5i YXNlbGluZSIsIFtdCiAtIHBhdGg6IENoYWtyYUNvcmUvdGVzdC9BcnJheS90b1N0cmluZy5qcwog ICBjbWQ6IHJ1bkNoYWtyYSA6YmFzZWxpbmUsICJOb0V4Y2VwdGlvbiIsICJ0b1N0cmluZy5iYXNl bGluZSIsIFtdCisgICMgRklYTUU6IHVuc2tpcCB0aGUgZm9sbG93aW5nIHRlc3Qgb24gV2luZG93 cyB3aGVuIElOVEwgaXMgcmVlbmFibGVkLgogLSBwYXRoOiBDaGFrcmFDb3JlL3Rlc3QvQXJyYXkv dG9Mb2NhbGVTdHJpbmcuanMKLSAgY21kOiBydW5DaGFrcmEgOmJhc2VsaW5lLCAiTm9FeGNlcHRp b24iLCAidG9Mb2NhbGVTdHJpbmcuYmFzZWxpbmUtanNjIiwgW10KKyAgY21kOiB8CisgICAgICBp ZiAoJGhvc3RPUyA9PSAid2luZG93cyIpCisgICAgICAgICAgc2tpcAorICAgICAgZWxzZQorICAg ICAgICAgIHJ1bkNoYWtyYSA6YmFzZWxpbmUsICJOb0V4Y2VwdGlvbiIsICJ0b0xvY2FsZVN0cmlu Zy5iYXNlbGluZS1qc2MiLCBbXQorICAgICAgZW5kCiAtIHBhdGg6IENoYWtyYUNvcmUvdGVzdC9B cnJheS9hcnJheV9zbGljZS5qcwogICBjbWQ6IHJ1bkNoYWtyYSA6YmFzZWxpbmUsICJOb0V4Y2Vw dGlvbiIsICJhcnJheV9zbGljZS5iYXNlbGluZSIsIFtdCiAtIHBhdGg6IENoYWtyYUNvcmUvdGVz dC9BcnJheS9hcnJheV9zbGljZTIuanMKQEAgLTQ4Nyw4ICs0OTMsMTQgQEAKICAgY21kOiBydW5D aGFrcmEgOmJhc2VsaW5lLCAiTm9FeGNlcHRpb24iLCAiZGF0ZXV0Yy5iYXNlbGluZSIsIFtdCiAt IHBhdGg6IENoYWtyYUNvcmUvdGVzdC9EYXRlL01pbGxpc2Vjb25kVHJ1bmNhdGlvbkNoZWNrQWZ0 ZXJDb3B5Q29uc3RydWN0b3IuanMKICAgY21kOiBydW5DaGFrcmEgOmJhc2VsaW5lLCAiTm9FeGNl cHRpb24iLCAiTWlsbGlzZWNvbmRUcnVuY2F0aW9uQ2hlY2tBZnRlckNvcHlDb25zdHJ1Y3Rvci5l czYuYmFzZWxpbmUiLCBbXQorICAjIEZJWE1FOiB1bnNraXAgdGhlIGZvbGxvd2luZyB0ZXN0IG9u IFdpbmRvd3Mgd2hlbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1 MTkzIGlzIGZpeGVkLgogLSBwYXRoOiBDaGFrcmFDb3JlL3Rlc3QvRGF0ZS9kYXRlX2NhY2hlX2J1 Zy5qcwotICBjbWQ6IHJ1bkNoYWtyYSA6YmFzZWxpbmUsICJOb0V4Y2VwdGlvbiIsICJkYXRlX2Nh Y2hlX2J1Zy5iYXNlbGluZSIsIFtdCisgIGNtZDogfAorICAgICAgaWYgKCRob3N0T1MgPT0gIndp bmRvd3MiKQorICAgICAgICAgIHNraXAKKyAgICAgIGVsc2UKKyAgICAgICAgICBydW5DaGFrcmEg OmJhc2VsaW5lLCAiTm9FeGNlcHRpb24iLCAiZGF0ZV9jYWNoZV9idWcuYmFzZWxpbmUiLCBbXQor ICAgICAgZW5kCiAtIHBhdGg6IENoYWtyYUNvcmUvdGVzdC9FSC9jYXB0dXJlLmpzCiAgIGNtZDog cnVuQ2hha3JhIDpiYXNlbGluZSwgIk5vRXhjZXB0aW9uIiwgImNhcHR1cmUuYmFzZWxpbmUiLCBb XQogLSBwYXRoOiBDaGFrcmFDb3JlL3Rlc3QvRUgvb29zMi5qcwpAQCAtOTYwLDggKzk3MiwxNCBA QAogLSBwYXRoOiBDaGFrcmFDb3JlL3Rlc3QvT2JqZWN0L3RvTG9jYWxlU3RyaW5nMi5qcwogICAj IEJhZCB0ZXN0LCBjaGVja3MgaGFyZCBjb2RlZCBleGNlcHRpb25zLgogICBjbWQ6IHJ1bkNoYWty YSA6c2tpcCwgIk5vRXhjZXB0aW9uIiwgIiIsIFsiLi4vVW5pdFRlc3RGcmFtZXdvcmsvVW5pdFRl c3RGcmFtZXdvcmsuanMiXQorICAjIEZJWE1FOiB1bnNraXAgdGhlIGZvbGxvd2luZyB0ZXN0IG9u IFdpbmRvd3Mgd2hlbiBJTlRMIGlzIHJlZW5hYmxlZC4KIC0gcGF0aDogQ2hha3JhQ29yZS90ZXN0 L09iamVjdC90b0xvY2FsZVN0cmluZ0Jhc2ljcy5qcwotICBjbWQ6IHJ1bkNoYWtyYSA6YmFzZWxp bmUsICJOb0V4Y2VwdGlvbiIsICJ0b0xvY2FsZVN0cmluZ0Jhc2ljcy5iYXNlbGluZSIsIFtdCisg IGNtZDogfAorICAgICAgaWYgKCRob3N0T1MgPT0gIndpbmRvd3MiKQorICAgICAgICAgIHNraXAK KyAgICAgIGVsc2UKKyAgICAgICAgICBydW5DaGFrcmEgOmJhc2VsaW5lLCAiTm9FeGNlcHRpb24i LCAidG9Mb2NhbGVTdHJpbmdCYXNpY3MuYmFzZWxpbmUiLCBbXQorICAgICAgZW5kCiAtIHBhdGg6 IENoYWtyYUNvcmUvdGVzdC9PYmplY3QvdG9TdHJpbmcxLmpzCiAgIGNtZDogcnVuQ2hha3JhIDpi YXNlbGluZSwgIk5vRXhjZXB0aW9uIiwgInRvU3RyaW5nMy5iYXNlbGluZSIsIFtdCiAtIHBhdGg6 IENoYWtyYUNvcmUvdGVzdC9PYmplY3QvdG9TdHJpbmcyLmpzCkluZGV4OiBKU1Rlc3RzL21pY3Jv YmVuY2htYXJrcy90YW4uanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSlNUZXN0cy9taWNyb2JlbmNobWFya3Mv dGFuLmpzCShyZXZpc2lvbiAyMDkxMjYpCisrKyBKU1Rlc3RzL21pY3JvYmVuY2htYXJrcy90YW4u anMJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw3IEBACi0oZnVuY3Rpb24oKSB7CisvL0Agc2tp cCBpZiAkaG9zdE9TID09ICJ3aW5kb3dzIgorLy8gRklYTUU6IHVuc2tpcCB0aGlzIHRlc3Qgd2hl biBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MTk0IGlzIGZpeGVk LgorCisoZnVuY3Rpb24gKCkgewogICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMzAwMDAwMDsgKytp KQogICAgICAgICB4ID0gTWF0aC50YW4oaSk7CiAK