165133 2016-11-28 22:46:55 -0800 intersection-observer-entry-interface.html test fails on the bots 2016-11-29 09:16:31 -0800 1 1 1 Unclassified WebKit Tools / Tests Safari 9 Unspecified Unspecified RESOLVED FIXED https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r209057%20(9622)/intersection-observer/intersection-observer-entry-interface-pretty-diff.html P2 Normal --- 1 simon.fraser simon.fraser commit-queue lforschler ryanhaddad sam simon.fraser oldest_to_newest 1254216 0 simon.fraser 2016-11-28 22:46:55 -0800 intersection-observer-entry-interface.html is failing on the bots, but does not when the test is run locally on its own. 1254218 1 simon.fraser 2016-11-28 22:48:47 -0800 The bug is that TestController::ensureViewSupportsOptionsForTest() early returns if it thinks the current view supports the new test options. However, the code fails to check for a difference in the enableIntersectionObserver option. In general, this code is confused about options that must be set before view creation, and those that can be set as normal preferences. 1254223 2 295585 simon.fraser 2016-11-28 23:10:56 -0800 Created attachment 295585 Patch 1254294 3 295585 commit-queue 2016-11-29 09:16:27 -0800 Comment on attachment 295585 Patch Clearing flags on attachment: 295585 Committed r209073: <http://trac.webkit.org/changeset/209073> 1254295 4 commit-queue 2016-11-29 09:16:31 -0800 All reviewed patches have been landed. Closing bug. 295585 2016-11-28 23:10:56 -0800 2016-11-29 09:16:27 -0800 Patch bug-165133-20161128231031.patch text/plain 4891 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MDU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTg0ZGM5NTFiMDFkZDM4ZjExMmQwNmJjODc4NjQzN2Yz OWEyMGZiNi4uN2Y3NzI4MWEyNTAwOThjM2U4MWY0NTk3NTM5NzRjNTg4OTExMjk1NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5 IEBACisyMDE2LTExLTI4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIGludGVyc2VjdGlvbi1vYnNlcnZlci1lbnRyeS1pbnRlcmZhY2UuaHRtbCB0ZXN0 IGZhaWxzIG9uIHRoZSBib3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjUxMzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KyAgICAgICAgCisgICAgICAgIFRlc3RzIHRoYXQgZW5hYmxlZCBJbnRlcnNlY3Rpb24gT2JzZXJ2 ZXIgdmlhIDwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgZW5hYmxlSW50ZXJzZWN0aW9uT2JzZXJ2 ZXI9dHJ1ZSBdIC0tPgorICAgICAgICB3b3VsZCBmYWlsIHNvbWV0aW1lcywgYmVjYXVzZSBUZXN0 Q29udHJvbGxlcjo6ZW5zdXJlVmlld1N1cHBvcnRzT3B0aW9uc0ZvclRlc3QoKSBmYWlsZWQgdG8g Y2hlY2sKKyAgICAgICAgdG8gc2VlIGlmIHRoaXMgb3B0aW9uIHJlcXVpcmVkIGNyZWF0aW5nIGEg bmV3IHdlYiB2aWV3LCBzbyB3b3VsZCBqdXN0IHVzZSB0aGUgb2xkIHZpZXcgd2l0aG91dAorICAg ICAgICBldmVuIHJlc2V0dGluZyBwcmVmZXJlbmNlcy4KKyAgICAgICAgCisgICAgICAgIEluIGdl bmVyYWwsIFRlc3RDb250cm9sbGVyIGRvZXNuJ3QgZGlzdGluZ3Vpc2ggcHJvcGVybHkgYmV0d2Vl biBvcHRpb25zIHRoYXQgcmVxdWlyZSB0aGUgY3JlYXRpb24KKyAgICAgICAgb2YgYSBuZXcgdmll dyAobGlrZSBtb2NrIHNjcm9sbGJhcnMpLCBhbmQgdGhvc2UgdGhhdCBjYW4gYmUgc2ltcGx5IHJl c2V0IGFzIHJlc2V0UHJlZmVyZW5jZXNUb0NvbnNpc3RlbnRWYWx1ZXMoKQorICAgICAgICBkb2Vz LgorICAgICAgICAKKyAgICAgICAgRG8gdGhlIGVhc3kgZml4IG9mIGhhdmluZyB2aWV3U3VwcG9y dHNPcHRpb25zKCkgY2hlY2sgb3B0aW9ucy5lbmFibGVJbnRlcnNlY3Rpb25PYnNlcnZlci4gV2Ug c2hvdWxkIHByb2JhYmx5CisgICAgICAgIGp1c3QgY2FsbCByZXNldFByZWZlcmVuY2VzVG9Db25z aXN0ZW50VmFsdWVzKCkgZXZlbiB3aGVuIHJlLXVzZSB0aGUgc2FtZSB2aWV3LgorICAgICAgICAK KyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAg KFdUUjo6VGVzdENvbnRyb2xsZXI6OnJlc2V0UHJlZmVyZW5jZXNUb0NvbnNpc3RlbnRWYWx1ZXMp OgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvaW9zL1BsYXRmb3JtV2ViVmlld0lPUy5tbToK KyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3Ojp2aWV3U3VwcG9ydHNPcHRpb25zKToKKyAg ICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW06CisgICAg ICAgIChXVFI6OlBsYXRmb3JtV2ViVmlldzo6dmlld1N1cHBvcnRzT3B0aW9ucyk6CisKIDIwMTYt MTEtMjggIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIwOTAwOC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0 Q29udHJvbGxlci5jcHAKaW5kZXggMGE3YjE1ZDc5Yjk5MDIwYzExN2QyYzllZTY0MmFhYTcxMmNj MDExZC4uYTA2M2E0Y2ExZDI3MTIyMGU4ZjI1MGNlYjNmNmUxOWIwMDE1MWYxNSAxMDA2NDQKLS0t IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTY0Nyw2ICs2NDcsNyBAQCB2 b2lkIFRlc3RDb250cm9sbGVyOjpyZXNldFByZWZlcmVuY2VzVG9Db25zaXN0ZW50VmFsdWVzKGNv bnN0IFRlc3RPcHRpb25zJiBvcHRpbwogICAgIFdLUHJlZmVyZW5jZXNTZXRBcnRpZmljaWFsUGx1 Z2luSW5pdGlhbGl6YXRpb25EZWxheUVuYWJsZWQocHJlZmVyZW5jZXMsIGZhbHNlKTsKICAgICBX S1ByZWZlcmVuY2VzU2V0VGFiVG9MaW5rc0VuYWJsZWQocHJlZmVyZW5jZXMsIGZhbHNlKTsKICAg ICBXS1ByZWZlcmVuY2VzU2V0SW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQocHJlZmVy ZW5jZXMsIHRydWUpOworCiAgICAgV0tQcmVmZXJlbmNlc1NldE1vY2tTY3JvbGxiYXJzRW5hYmxl ZChwcmVmZXJlbmNlcywgb3B0aW9ucy51c2VNb2NrU2Nyb2xsYmFycyk7CiAgICAgV0tQcmVmZXJl bmNlc1NldE5lZWRzU2l0ZVNwZWNpZmljUXVpcmtzKHByZWZlcmVuY2VzLCBvcHRpb25zLm5lZWRz U2l0ZVNwZWNpZmljUXVpcmtzKTsKICAgICBXS1ByZWZlcmVuY2VzU2V0SW50ZXJzZWN0aW9uT2Jz ZXJ2ZXJFbmFibGVkKHByZWZlcmVuY2VzLCBvcHRpb25zLmVuYWJsZUludGVyc2VjdGlvbk9ic2Vy dmVyKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1BsYXRmb3JtV2Vi Vmlld0lPUy5tbSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1BsYXRmb3JtV2ViVmlld0lP Uy5tbQppbmRleCA4Y2NjNWFmMzYwMzQwNWQ3MmY0Yzc3NjFjYTNlNDU5ZDRhYjY3OTZiLi4wZDAw OWM0NGYwYmJlNmU5YTg5MGI0MzIwZTkwODViMTI2ZTdkNmI0IDEwMDY0NAotLS0gYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL2lvcy9QbGF0Zm9ybVdlYlZpZXdJT1MubW0KKysrIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9pb3MvUGxhdGZvcm1XZWJWaWV3SU9TLm1tCkBAIC0yNzgsNyArMjc4LDEw IEBAIFdLUmV0YWluUHRyPFdLSW1hZ2VSZWY+IFBsYXRmb3JtV2ViVmlldzo6d2luZG93U25hcHNo b3RJbWFnZSgpCiAKIGJvb2wgUGxhdGZvcm1XZWJWaWV3Ojp2aWV3U3VwcG9ydHNPcHRpb25zKGNv bnN0IFRlc3RPcHRpb25zJiBvcHRpb25zKSBjb25zdAogewotICAgIGlmIChtX29wdGlvbnMub3Zl cnJpZGVMYW5ndWFnZXMgIT0gb3B0aW9ucy5vdmVycmlkZUxhbmd1YWdlcyB8fCBtX29wdGlvbnMu bmVlZHNTaXRlU3BlY2lmaWNRdWlya3MgIT0gb3B0aW9ucy5uZWVkc1NpdGVTcGVjaWZpY1F1aXJr cyB8fCBtX29wdGlvbnMudXNlQ2hhcmFjdGVyU2VsZWN0aW9uR3JhbnVsYXJpdHkgIT0gb3B0aW9u cy51c2VDaGFyYWN0ZXJTZWxlY3Rpb25HcmFudWxhcml0eSkKKyAgICBpZiAobV9vcHRpb25zLm92 ZXJyaWRlTGFuZ3VhZ2VzICE9IG9wdGlvbnMub3ZlcnJpZGVMYW5ndWFnZXMKKyAgICAgICAgfHwg bV9vcHRpb25zLm5lZWRzU2l0ZVNwZWNpZmljUXVpcmtzICE9IG9wdGlvbnMubmVlZHNTaXRlU3Bl Y2lmaWNRdWlya3MKKyAgICAgICAgfHwgbV9vcHRpb25zLnVzZUNoYXJhY3RlclNlbGVjdGlvbkdy YW51bGFyaXR5ICE9IG9wdGlvbnMudXNlQ2hhcmFjdGVyU2VsZWN0aW9uR3JhbnVsYXJpdHkKKyAg ICAgICAgfHwgbV9vcHRpb25zLmVuYWJsZUludGVyc2VjdGlvbk9ic2VydmVyICE9IG9wdGlvbnMu ZW5hYmxlSW50ZXJzZWN0aW9uT2JzZXJ2ZXIpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAg IHJldHVybiB0cnVlOwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxh dGZvcm1XZWJWaWV3TWFjLm1tIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMvUGxhdGZvcm1X ZWJWaWV3TWFjLm1tCmluZGV4IDgzMzg1MDJkNDhiYzgwYTMyMDc3OGExY2IxMGFkZWJlY2FiZDZm NzkuLjAyNTg3M2E0NTE2YTQyZDk2MGE2YWI3YzAyODQzMzllNzkzZTM0NTUgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbQorKysgYi9U b29scy9XZWJLaXRUZXN0UnVubmVyL21hYy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0KQEAgLTI3Myw3 ICsyNzMsMTEgQEAgV0tSZXRhaW5QdHI8V0tJbWFnZVJlZj4gUGxhdGZvcm1XZWJWaWV3Ojp3aW5k b3dTbmFwc2hvdEltYWdlKCkKIAogYm9vbCBQbGF0Zm9ybVdlYlZpZXc6OnZpZXdTdXBwb3J0c09w dGlvbnMoY29uc3QgVGVzdE9wdGlvbnMmIG9wdGlvbnMpIGNvbnN0CiB7Ci0gICAgaWYgKG1fb3B0 aW9ucy51c2VUaHJlYWRlZFNjcm9sbGluZyAhPSBvcHRpb25zLnVzZVRocmVhZGVkU2Nyb2xsaW5n IHx8IG1fb3B0aW9ucy5vdmVycmlkZUxhbmd1YWdlcyAhPSBvcHRpb25zLm92ZXJyaWRlTGFuZ3Vh Z2VzIHx8IG1fb3B0aW9ucy51c2VNb2NrU2Nyb2xsYmFycyAhPSBvcHRpb25zLnVzZU1vY2tTY3Jv bGxiYXJzIHx8IG1fb3B0aW9ucy5uZWVkc1NpdGVTcGVjaWZpY1F1aXJrcyAhPSBvcHRpb25zLm5l ZWRzU2l0ZVNwZWNpZmljUXVpcmtzKQorICAgIGlmIChtX29wdGlvbnMudXNlVGhyZWFkZWRTY3Jv bGxpbmcgIT0gb3B0aW9ucy51c2VUaHJlYWRlZFNjcm9sbGluZworICAgICAgICB8fCBtX29wdGlv bnMub3ZlcnJpZGVMYW5ndWFnZXMgIT0gb3B0aW9ucy5vdmVycmlkZUxhbmd1YWdlcworICAgICAg ICB8fCBtX29wdGlvbnMudXNlTW9ja1Njcm9sbGJhcnMgIT0gb3B0aW9ucy51c2VNb2NrU2Nyb2xs YmFycworICAgICAgICB8fCBtX29wdGlvbnMubmVlZHNTaXRlU3BlY2lmaWNRdWlya3MgIT0gb3B0 aW9ucy5uZWVkc1NpdGVTcGVjaWZpY1F1aXJrcworICAgICAgICB8fCBtX29wdGlvbnMuZW5hYmxl SW50ZXJzZWN0aW9uT2JzZXJ2ZXIgIT0gb3B0aW9ucy5lbmFibGVJbnRlcnNlY3Rpb25PYnNlcnZl cikKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgcmV0dXJuIHRydWU7Cg==