165127 2016-11-28 17:21:15 -0800 Avoid ref-count churn in CSSParser::ValueWithCalculation::setCalculation() 2016-11-29 10:53:31 -0800 1 1 1 Unclassified WebKit CSS WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates hyatt koivisto simon.fraser oldest_to_newest 1254121 0 dbates 2016-11-28 17:21:15 -0800 In CSSParser::ValueWithCalculation::setCalculation() we copy the passed RefPtr into CSSParser::ValueWithCalculation::m_calculation. Instead we should WTFMove() it. This has the benefit of avoiding unnecessary ref-count churn. 1254123 1 295555 dbates 2016-11-28 17:21:46 -0800 Created attachment 295555 Patch 1254331 2 295555 dbates 2016-11-29 10:53:27 -0800 Comment on attachment 295555 Patch Clearing flags on attachment: 295555 Committed r209078: <http://trac.webkit.org/changeset/209078> 1254332 3 dbates 2016-11-29 10:53:31 -0800 All reviewed patches have been landed. Closing bug. 295555 2016-11-28 17:21:46 -0800 2016-11-29 10:53:27 -0800 Patch bug-165127-20161128172122.patch text/plain 1434 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU4NTdlZWQxYmM4Nzk0 MzUwMTg2MzA1ZDZiOWU4YTRjNDdjYWFkYi4uZGJhMzJjNjJlODhkOGFiZWM2Y2VkMzI3MzYwYjUy MzNkMjEyZmUxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTExLTI4ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCByZWYtY291bnQg Y2h1cm4gaW4gQ1NTUGFyc2VyOjpWYWx1ZVdpdGhDYWxjdWxhdGlvbjo6c2V0Q2FsY3VsYXRpb24o KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MTI3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIFdU Rk1vdmUoKSB0byBtb3ZlIHRoZSBwYXNzZWQgUmVmUHRyIGludG8gQ1NTUGFyc2VyOjpWYWx1ZVdp dGhDYWxjdWxhdGlvbjo6bV9jYWxjdWxhdGlvbgorICAgICAgICBpbnN0ZWFkIG9mIGNvcHlpbmcg aXQuCisKKyAgICAgICAgKiBjc3MvcGFyc2VyL0NTU1BhcnNlci5oOgorICAgICAgICAoV2ViQ29y ZTo6Q1NTUGFyc2VyOjpWYWx1ZVdpdGhDYWxjdWxhdGlvbjo6c2V0Q2FsY3VsYXRpb24pOgorCiAy MDE2LTExLTI4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW2lP U10gVXNlIFVJS2l0IFNQSSB0byBmb3JjZSBwb3BvdmVyIHByZXNlbnRhdGlvbiBzdHlsZSBvbiBp UGhvbmUgZm9yIGh0bWwgdmFsaWRhdGlvbiBwb3BvdmVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIv Q1NTUGFyc2VyLmgKaW5kZXggZDlkMmUxZmZjNTNmNzVjMjUxMDMwZjJiYWMzNDdlYTE4OTQ2YzJh Mi4uN2VjNDEwNWM3OTBlMzAxMTQxODBmOTg5MjJmOGNjMTAyNWFjMzA4NSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQYXJzZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9jc3MvcGFyc2VyL0NTU1BhcnNlci5oCkBAIC0xMTcsNyArMTE3LDcgQEAgcHVibGljOgogICAg ICAgICB2b2lkIHNldENhbGN1bGF0aW9uKFJlZlB0cjxDU1NDYWxjVmFsdWU+JiYgY2FsY3VsYXRp b24pCiAgICAgICAgIHsKICAgICAgICAgICAgIEFTU0VSVChpc0NhbGN1bGF0aW9uKG1fdmFsdWUp KTsKLSAgICAgICAgICAgIG1fY2FsY3VsYXRpb24gPSBjYWxjdWxhdGlvbjsKKyAgICAgICAgICAg IG1fY2FsY3VsYXRpb24gPSBXVEZNb3ZlKGNhbGN1bGF0aW9uKTsKICAgICAgICAgfQogCiAgICAg cHJpdmF0ZToK