<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>165108</bug_id>
          
          <creation_ts>2016-11-28 13:32:07 -0800</creation_ts>
          <short_desc>Teach webkitpy how to read CSSProperties.json r209001</short_desc>
          <delta_ts>2016-11-28 13:37:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>MakingBotsRed</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>164691</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Daniel Bates">dbates</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>glenn</cc>
    
    <cc>lforschler</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1253960</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2016-11-28 13:32:07 -0800</bug_when>
    <thetext>Following the patch for bug #164691 various webkitpy tests are failing. We need to teach webkitpy about CSSProperties.json</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253961</commentid>
    <comment_count>1</comment_count>
      <attachid>295522</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2016-11-28 13:32:50 -0800</bug_when>
    <thetext>Created attachment 295522
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1253964</commentid>
    <comment_count>2</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2016-11-28 13:37:30 -0800</bug_when>
    <thetext>Committed r209012: &lt;http://trac.webkit.org/changeset/209012&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>295522</attachid>
            <date>2016-11-28 13:32:50 -0800</date>
            <delta_ts>2016-11-28 13:34:10 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-165108-20161128133226.patch</filename>
            <type>text/plain</type>
            <size>6371</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjA5MDAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTFiNDBiYjVjYTc3YjBhNDYwNzBlYTMzNjg5ZWM0OWQ4
ZDYzNjQyNi4uODE3NzcwODIwZWEzOGM2YjAwNjFhM2E1ODdlNGFjMDY5YzZkZjQ1OCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2
IEBACisyMDE2LTExLTI4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg
ICAgICBUZWFjaCB3ZWJraXRweSBob3cgdG8gcmVhZCBDU1NQcm9wZXJ0aWVzLmpzb24gcjIwOTAw
MQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY1MTA4
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHdl
YmtpdHB5IGxvZ2ljIHNvIHRoYXQgaXQgY2FuIHJlYWQgQ1NTIHByb3BlcnR5IG5hbWVzIGZyb20g
Q1NTUHJvcGVydGllcy5qc29uIGZvbGxvd2luZyByMjA5MDAxLgorCisgICAgICAgIEZvbGxvd2lu
ZyByMjA5MDAxIENTU1Byb3BlcnR5TmFtZXMuaW4gbm8gbG9uZ2VyIGV4aXN0cyBhcyBpdCB3YXMg
cmVwbGFjZWQgd2l0aCBDU1NQcm9wZXJ0aWVzLmpzb24uCisgICAgICAgIFdlIG5lZWQgdG8gbW9k
aWZ5IHRoZSB3ZWJraXRweSBtYWNoaW5lcnkgdGhhdCBwcm9jZXNzZWQgQ1NTUHJvcGVydHlOYW1l
cy5pbiB0byBwcm9jZXNzIENTU1Byb3BlcnRpZXMuanNvbi4KKworICAgICAgICAqIFNjcmlwdHMv
d2Via2l0cHkvdzNjL3Rlc3RfY29udmVydGVyLnB5OgorICAgICAgICAoX1czQ1Rlc3RDb252ZXJ0
ZXIuX19pbml0X18pOiBNYWtlIHNlbGYuX2Nzc19wcm9wZXJ0eV9maWxlIGFuZCBzZWxmLl9jc3Nf
cHJvcGVydHlfdmFsdWVfZmlsZSBsb2NhbAorICAgICAgICB2YXJpYWJsZXMgYXMgaXQgaXMgdW5u
ZWNlc3NhcnkgZm9yIHRoZW0gdG8gYmUgaW5zdGFuY2UgdmFyaWFibGVzLiBDYWxsIHJlYWRfd2Vi
a2l0X3ByZWZpeGVkX2Nzc19wcm9wZXJ0eV9saXN0KCkKKyAgICAgICAgdG8gcmVhZCB0aGUgcHJv
cGVydHkgbmFtZXMgZnJvbSBmaWxlIENTU1Byb3BlcnRpZXMuanNvbi4gQ2FsbCBsZWdhY3lfcmVh
ZF93ZWJraXRfcHJlZml4ZWRfY3NzX3Byb3BlcnR5X2xpc3QoKSB0bworICAgICAgICByZWFkIENT
UyBrZXl3b3JkIHZhbHVlcyBmcm9tIENTU1ZhbHVlS2V5d29yZHMuaW4uCisgICAgICAgIChfVzND
VGVzdENvbnZlcnRlci5yZWFkX3dlYmtpdF9wcmVmaXhlZF9jc3NfcHJvcGVydHlfbGlzdCk6IEFk
ZGVkLgorICAgICAgICAoX1czQ1Rlc3RDb252ZXJ0ZXIpOgorICAgICAgICAoX1czQ1Rlc3RDb252
ZXJ0ZXIubGVnYWN5X3JlYWRfd2Via2l0X3ByZWZpeGVkX2Nzc19wcm9wZXJ0eV9saXN0KTogUmVu
YW1lZCBmcm9tIHJlYWRfd2Via2l0X3ByZWZpeGVkX2Nzc19wcm9wZXJ0eV9saXN0LgorICAgICAg
ICAqIFNjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0ZXJfdW5pdHRlc3QucHk6CisgICAg
ICAgIChUZXN0SW1wb3J0ZXJUZXN0LnRlc3RfaGFybmVzc2xpbmtzX2NvbnZlcnNpb24pOiBTdWJz
dGl0dXRlIENTU1Byb3BlcnRpZXMuanNvbiBmb3IgQ1NTUHJvcGVydHlOYW1lcy5pbi4KKwogMjAx
Ni0xMS0xOCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQg
c29tZSBwZXJmb3JtYW5jZSB0ZXN0cyBmb3IgdmFyaW91cyBhc3BlY3RzIG9mIG1lZGlhIGxvYWRp
bmcgYW5kIHBsYXliYWNrLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93M2Mv
dGVzdF9jb252ZXJ0ZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZl
cnRlci5weQppbmRleCA2Y2I5Y2U0Y2E2MjQ1OGU5NjJlMzQ3MDM5ZWM4NTg4MWJmYjNjZjgxLi42
ZTI5OTZlOTAxMzY1NWMwODYxNTUwNWQxNjliMDZiMzEyNmI2NWVkIDEwMDY0NAotLS0gYS9Ub29s
cy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZlcnRlci5weQorKysgYi9Ub29scy9TY3Jp
cHRzL3dlYmtpdHB5L3czYy90ZXN0X2NvbnZlcnRlci5weQpAQCAtMjcsNiArMjcsNyBAQAogIyBU
SEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJ
VFkgT0YKICMgU1VDSCBEQU1BR0UuCiAKK2ltcG9ydCBqc29uCiBpbXBvcnQgbG9nZ2luZwogaW1w
b3J0IHJlCiAKQEAgLTczLDE2ICs3NCwxNiBAQCBjbGFzcyBfVzNDVGVzdENvbnZlcnRlcihIVE1M
UGFyc2VyKToKICAgICAgICAgc2VsZi5jb252ZXJ0X3Rlc3RfaGFybmVzc19saW5rcyA9IGNvbnZl
cnRfdGVzdF9oYXJuZXNzX2xpbmtzCiAKICAgICAgICAgIyBUaGVzZSBzZXR0aW5ncyBtaWdodCB2
YXJ5IGJldHdlZW4gV2ViS2l0IGFuZCBCbGluawotICAgICAgICBzZWxmLl9jc3NfcHJvcGVydHlf
ZmlsZSA9IHNlbGYucGF0aF9mcm9tX3dlYmtpdF9yb290KCdTb3VyY2UnLCAnV2ViQ29yZScsICdj
c3MnLCAnQ1NTUHJvcGVydHlOYW1lcy5pbicpCi0gICAgICAgIHNlbGYuX2Nzc19wcm9wZXJ0eV92
YWx1ZV9maWxlID0gc2VsZi5wYXRoX2Zyb21fd2Via2l0X3Jvb3QoJ1NvdXJjZScsICdXZWJDb3Jl
JywgJ2NzcycsICdDU1NWYWx1ZUtleXdvcmRzLmluJykKKyAgICAgICAgY3NzX3Byb3BlcnR5X2Zp
bGUgPSBzZWxmLnBhdGhfZnJvbV93ZWJraXRfcm9vdCgnU291cmNlJywgJ1dlYkNvcmUnLCAnY3Nz
JywgJ0NTU1Byb3BlcnRpZXMuanNvbicpCisgICAgICAgIGNzc19wcm9wZXJ0eV92YWx1ZV9maWxl
ID0gc2VsZi5wYXRoX2Zyb21fd2Via2l0X3Jvb3QoJ1NvdXJjZScsICdXZWJDb3JlJywgJ2Nzcycs
ICdDU1NWYWx1ZUtleXdvcmRzLmluJykKIAogICAgICAgICBzZWxmLnRlc3RfaGFybmVzc19yZSA9
IHJlLmNvbXBpbGUoJy9yZXNvdXJjZXMvdGVzdGhhcm5lc3MnKQogCi0gICAgICAgIHNlbGYucHJl
Zml4ZWRfcHJvcGVydGllcyA9IHNlbGYucmVhZF93ZWJraXRfcHJlZml4ZWRfY3NzX3Byb3BlcnR5
X2xpc3Qoc2VsZi5fY3NzX3Byb3BlcnR5X2ZpbGUpCisgICAgICAgIHNlbGYucHJlZml4ZWRfcHJv
cGVydGllcyA9IHNlbGYucmVhZF93ZWJraXRfcHJlZml4ZWRfY3NzX3Byb3BlcnR5X2xpc3QoY3Nz
X3Byb3BlcnR5X2ZpbGUpCiAgICAgICAgIHByb3BfcmVnZXggPSAnKFtcc3tdfF4pKCcgKyAifCIu
am9pbihwcm9wLnJlcGxhY2UoJy13ZWJraXQtJywgJycpIGZvciBwcm9wIGluIHNlbGYucHJlZml4
ZWRfcHJvcGVydGllcykgKyAnKShccys6fDopJwogICAgICAgICBzZWxmLnByb3BfcmUgPSByZS5j
b21waWxlKHByb3BfcmVnZXgpCiAKLSAgICAgICAgc2VsZi5wcmVmaXhlZF9wcm9wZXJ0eV92YWx1
ZXMgPSBzZWxmLnJlYWRfd2Via2l0X3ByZWZpeGVkX2Nzc19wcm9wZXJ0eV9saXN0KHNlbGYuX2Nz
c19wcm9wZXJ0eV92YWx1ZV9maWxlKQorICAgICAgICBzZWxmLnByZWZpeGVkX3Byb3BlcnR5X3Zh
bHVlcyA9IHNlbGYubGVnYWN5X3JlYWRfd2Via2l0X3ByZWZpeGVkX2Nzc19wcm9wZXJ0eV9saXN0
KGNzc19wcm9wZXJ0eV92YWx1ZV9maWxlKQogICAgICAgICBwcm9wX3ZhbHVlX3JlZ2V4ID0gJyg6
XHMqfF5ccyopKCcgKyAifCIuam9pbih2YWx1ZS5yZXBsYWNlKCctd2Via2l0LScsICcnKSBmb3Ig
dmFsdWUgaW4gc2VsZi5wcmVmaXhlZF9wcm9wZXJ0eV92YWx1ZXMpICsgJykoXHMqO3xccyp9fFxz
KiQpJwogICAgICAgICBzZWxmLnByb3BfdmFsdWVfcmUgPSByZS5jb21waWxlKHByb3BfdmFsdWVf
cmVnZXgpCiAKQEAgLTk0LDYgKzk1LDMyIEBAIGNsYXNzIF9XM0NUZXN0Q29udmVydGVyKEhUTUxQ
YXJzZXIpOgogCiAgICAgZGVmIHJlYWRfd2Via2l0X3ByZWZpeGVkX2Nzc19wcm9wZXJ0eV9saXN0
KHNlbGYsIGZpbGVfbmFtZSk6CiAgICAgICAgIGNvbnRlbnRzID0gc2VsZi5fZmlsZXN5c3RlbS5y
ZWFkX3RleHRfZmlsZShmaWxlX25hbWUpCisgICAgICAgIGlmIG5vdCBjb250ZW50czoKKyAgICAg
ICAgICAgIHJldHVybiBbXQorICAgICAgICBwcm9wZXJ0aWVzID0ganNvbi5sb2Fkcyhjb250ZW50
cylbJ3Byb3BlcnRpZXMnXQorICAgICAgICBwcm9wZXJ0eV9uYW1lcyA9IFtdCisgICAgICAgIGZv
ciBwcm9wZXJ0eV9uYW1lLCBwcm9wZXJ0eV9kaWN0IGluIHByb3BlcnRpZXMuaXRlcml0ZW1zKCk6
CisgICAgICAgICAgICBwcm9wZXJ0eV9uYW1lcy5hcHBlbmQocHJvcGVydHlfbmFtZSkKKyAgICAg
ICAgICAgIGlmICdjb2RlZ2VuLXByb3BlcnRpZXMnIGluIHByb3BlcnR5X2RpY3Q6CisgICAgICAg
ICAgICAgICAgY29kZWdlbl9vcHRpb25zID0gcHJvcGVydHlfZGljdFsnY29kZWdlbi1wcm9wZXJ0
aWVzJ10KKyAgICAgICAgICAgICAgICBpZiAnYWxpYXNlcycgaW4gY29kZWdlbl9vcHRpb25zOgor
ICAgICAgICAgICAgICAgICAgICBwcm9wZXJ0eV9uYW1lcy5leHRlbmQoY29kZWdlbl9vcHRpb25z
WydhbGlhc2VzJ10pCisKKyAgICAgICAgcHJlZml4ZWRfcHJvcGVydGllcyA9IFtdCisgICAgICAg
IHVucHJlZml4ZWRfcHJvcGVydGllcyA9IHNldCgpCisgICAgICAgIGZvciBwcm9wZXJ0eV9uYW1l
IGluIHByb3BlcnR5X25hbWVzOgorICAgICAgICAgICAgIyBGaW5kIHByb3BlcnRpZXMgc3RhcnRp
bmcgd2l0aCB0aGUgLXdlYmtpdC0gcHJlZml4LgorICAgICAgICAgICAgbWF0Y2ggPSByZS5tYXRj
aCgnLXdlYmtpdC0oW1x3fC1dKiknLCBwcm9wZXJ0eV9uYW1lKQorICAgICAgICAgICAgaWYgbWF0
Y2g6CisgICAgICAgICAgICAgICAgcHJlZml4ZWRfcHJvcGVydGllcy5hcHBlbmQobWF0Y2guZ3Jv
dXAoMSkpCisgICAgICAgICAgICBlbHNlOgorICAgICAgICAgICAgICAgIHVucHJlZml4ZWRfcHJv
cGVydGllcy5hZGQocHJvcGVydHlfbmFtZSkKKworICAgICAgICAjIElnbm9yZSBhbnkgcHJlZml4
ZWQgcHJvcGVydGllcyBmb3Igd2hpY2ggYW4gdW5wcmVmaXhlZCB2ZXJzaW9uIGlzIHN1cHBvcnRl
ZAorICAgICAgICByZXR1cm4gW3Byb3AgZm9yIHByb3AgaW4gcHJlZml4ZWRfcHJvcGVydGllcyBp
ZiBwcm9wIG5vdCBpbiB1bnByZWZpeGVkX3Byb3BlcnRpZXNdCisKKyAgICBkZWYgbGVnYWN5X3Jl
YWRfd2Via2l0X3ByZWZpeGVkX2Nzc19wcm9wZXJ0eV9saXN0KHNlbGYsIGZpbGVfbmFtZSk6Cisg
ICAgICAgIGNvbnRlbnRzID0gc2VsZi5fZmlsZXN5c3RlbS5yZWFkX3RleHRfZmlsZShmaWxlX25h
bWUpCiAgICAgICAgIHByZWZpeGVkX3Byb3BlcnRpZXMgPSBbXQogICAgICAgICB1bnByZWZpeGVk
X3Byb3BlcnRpZXMgPSBzZXQoKQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5
L3czYy90ZXN0X2ltcG9ydGVyX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS93
M2MvdGVzdF9pbXBvcnRlcl91bml0dGVzdC5weQppbmRleCBiNjRmMGJkYTMxNGE3MTUxZTNmNjNi
Y2U2ZGRkNWE0OGJkM2U4NDk1Li4yYTEyZjNhZGQ3MGVhOWI0NzA0MzNiZDEyN2FlOWVhMjc4Y2U4
ZTRmIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3czYy90ZXN0X2ltcG9ydGVy
X3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfaW1wb3J0
ZXJfdW5pdHRlc3QucHkKQEAgLTEzOCw3ICsxMzgsNyBAQCBjbGFzcyBUZXN0SW1wb3J0ZXJUZXN0
KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgRkFLRV9GSUxFUyA9IHsKICAgICAgICAgICAg
ICcvbW9jay1jaGVja291dC9XZWJLaXRCdWlsZC93M2MtdGVzdHMvY3Nzd2ctdGVzdHMvdC90ZXN0
Lmh0bWwnOiAnPCFkb2N0eXBlIGh0bWw+PHNjcmlwdCBzcmM9Ii9yZXNvdXJjZXMvdGVzdGhhcm5l
c3MuanMiPjwvc2NyaXB0PjxzY3JpcHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVwb3J0
LmpzIj48L3NjcmlwdD4nLAogICAgICAgICAgICAgJy9tb2NrLWNoZWNrb3V0L1dlYktpdEJ1aWxk
L3czYy10ZXN0cy93ZWItcGxhdGZvcm0tdGVzdHMvdC90ZXN0Lmh0bWwnOiAnPCFkb2N0eXBlIGh0
bWw+PHNjcmlwdCBzcmM9Ii9yZXNvdXJjZXMvdGVzdGhhcm5lc3MuanMiPjwvc2NyaXB0PjxzY3Jp
cHQgc3JjPSIvcmVzb3VyY2VzL3Rlc3RoYXJuZXNzcmVwb3J0LmpzIj48L3NjcmlwdD4nLAotICAg
ICAgICAgICAgJy9tb2NrLWNoZWNrb3V0L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcm9wZXJ0eU5h
bWVzLmluJzogJycsCisgICAgICAgICAgICAnL21vY2stY2hlY2tvdXQvU291cmNlL1dlYkNvcmUv
Y3NzL0NTU1Byb3BlcnRpZXMuanNvbic6ICcnLAogICAgICAgICAgICAgJy9tb2NrLWNoZWNrb3V0
L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUtleXdvcmRzLmluJzogJycsCiAgICAgICAgIH0K
ICAgICAgICAgRkFLRV9GSUxFUy51cGRhdGUoRkFLRV9SRVBPU0lUT1JZKQo=
</data>
<flag name="review"
          id="318085"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
      

    </bug>

</bugzilla>